-stable kernel.
> Please have a way to get them.
>
> Sorry again!
>
> Thanks
> Baoquan
>
>
> On 11/29/16 at 07:57am, Brice Goglin wrote:
>> Hello
>>
>> My Dell PowerEdge R815 doesn't have IPMI anymore when I boot a 4.8
>> kernel, the BMC doesn't even pin
Hello
My Dell PowerEdge R815 doesn't have IPMI anymore when I boot a 4.8
kernel, the BMC doesn't even ping anymore. Its Ethernet devices are 4 of
those:
01:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM5709 Gigabit
Ethernet (rev 20)
DeviceName: Embedded NIC 1
LRO_F_EXTRACT_VLAN_ID.
Please apply for 2.6.24.
Brice
[PATCH][LRO] Fix lro_mgr-features checks
lro_mgr-features contains a bitmask of LRO_F_* values which are
defined as power of two, not as bit indexes.
They must be checked with xLRO_F_FOO, not with test_bit(LRO_F_FOO,x).
Signed-off-by: Brice Goglin
Fix one comment in myri10ge.c and update indendation and white spaces
to match the code generated by indent from upstream CVS.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
Index: linux-git
Hi Jeff,
Now that LRO and the new NAPI have landed in myri10ge for 2.6.24, here's
a couple updates. The big part is support for IPv6 TSO, which requires
the addition of skb_is_gso_v6(). I am CC'ing Dave and Herbert in the
corresponding mails. The other patches are trivial.
1. myri10ge: fix some
Update myri10ge firmware headers to latest upstream version with
TSO6 and RSS support.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge_mcp.h | 90 ++--
1 file changed, 86 insertions(+), 4 deletions(-)
Index: linux-git/drivers/net
The myri10ge driver is now at version 1.3.2-1.287.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
Add skb_is_gso_v6().
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
include/linux/skbuff.h |5 +
1 file changed, 5 insertions(+)
Index: linux-git/include/linux/skbuff.h
===
--- linux-git.orig/include/linux/skbuff.h
Add support for IPv6 TSO to the myri10ge driver.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 87
1 file changed, 79 insertions(+), 8 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
The following patch adds support for a new PCI device id. Please apply
for 2.6.23.
Thanks,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Add support for new Myri-10G boards with PCI device id 9.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |3 +++
1 file changed, 3 insertions(+)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
Now that Greg pushed my fix to expose pcie_get_readrq() prototype in
linux/pci.h, I am resending my rework of Peter Oruba's patch to use
pcie_get/set_readrq() in myri10ge. Please apply for 2.6.23.
1. use pcie_get/set_readrq
2. update driver version to 1.3.2-1.269
Also, we noticed
manually, instead wrapping functions are called to allow quirks for some
PCI bridges.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
Signed-off by: Peter Oruba [EMAIL PROTECTED]
Based on work by Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/net/myri10ge
Update myri10ge driver version to 1.3.2-1.269.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/drivers/net/myri10ge/myri10ge.c
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Peter Oruba [EMAIL PROTECTED]
These driver changes incorporate the proposed PCI-X / PCI-Express
read byte
count interface. Reading and setting those valuse doesn't take place
manually, instead wrapping functions are called to allow quirks
Hi Jeff,
Aside from the LRO patch that DaveM queued for 2.6.24, here's a small
fix for myri10ge in 2.6.23:
1. Use the pause counter to avoid a needless device reset
Please apply, thanks,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Use the pause counter to avoid a needless device reset, and
print a message telling the admin that our link partner is
flow controlling us down to 0 pkts/sec.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 25 ++---
1 file changed, 18
Hi Jeff,
Almost nothing new regarding myri10ge in 2.6.23 for now, just a single
patch to remove some non-sensical code in the tx done routine.
Please apply, thanks,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
Remove nonsensical limit in the tx done routine. Specifically,
the loop will always terminate after processing = 1 rings worth
of frames, as the mcp index is not refetched, so the removed
conditional could never be true.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge
Hi,
I am trying to understand whether I can setup a skb destructor in my
code (which is basically a protocol above dev_queue_xmit() and co). From
what I see in many parts in the current kernel code, the protocol (I
mean, the one who actually creates the skb) may setup a destructor.
However, I
Hi Jeff,
Here are 3 minor updates of myri10ge for 2.6.22. The first one is a
reduced version of the earlier nacked patch, it now limits the number of
recoveries (to detect bad nics) without making the limit tunable.
1. limit the number of recoveries
2. report when the link partner is running in
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default.
It enables detection of defective NICs immediately since these memory parity
errors are expected to happen very rarely (less than once per century*NIC).
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net
Since Myri-10G boards may also run in Myrinet mode instead of Ethernet,
add a message when we detect that the link partner is not running in the
right mode.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 15 ++-
1 file changed, 10 insertions
Update myri10ge driver version to 1.3.1-1.248.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Jeff Garzik wrote:
Brice Goglin wrote:
Limit the number of recoveries from a NIC hw watchdog reset to 1 by
default.
It enables detection of defective NICs immediately since these memory
parity
errors are expected to happen very rarely (less than once per
century*NIC).
However, a defective
Limit the number of recoveries from a NIC hw watchdog reset to 1 by default.
It enables detection of defective NICs immediately since these memory parity
errors are expected to happen very rarely (less than once per century*NIC).
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net
Hi Jeff,
Here's a small patchset for myri10ge in 2.6.22:
1) report link up/down in standard ethtool way
2) limit the number of recoveries
3) update driver version
Please apply.
Thanks!
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Report link up/down in standard ethtool way
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |1 +
1 file changed, 1 insertion(+)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
===
--- linux
, it will still work.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Update driver version to 1.3.1-1.245.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Jeff Garzik wrote:
Brice Goglin wrote:
Limit the number of recoveries from a NIC hw watchdog reset to
1 by default. This is tweakable via the myri10ge_reset_recover
tunable.
NAK. Tunables like this are generally (a) never touched by the vast
majority of users, and (b) have useful values
Hi Jeff,
Here's some updates of myri10ge for 2.6.22. The good news is that the
aligned-completion whitelist is now gone.
1. support new firmware counters
2. update firmware headers
3. fix restoring of multicast list after reset
4. limit the number of recoveries
5. move the DMA test code into its
Add dropped_pause, dropped_bad_phy, dropped_bad_crc32,
dropped_unicast_filtered to the set of ethtool counters.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |9 -
drivers/net/myri10ge/myri10ge_mcp.h |6 +-
2 files changed, 13
Update myri10ge firmware headers to those of 1.4.16.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge_mcp.h | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
Index: linux-git/drivers/net/myri10ge/myri10ge_mcp.h
it belongs.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
===
--- linux-git.orig/drivers
Limit the number of recoveries from a NIC hw watchdog reset to
1 by default. This is tweakable via the myri10ge_reset_recover
tunable.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions
Move the DMA test code into its own function.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 121 ++--
1 file changed, 68 insertions(+), 53 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
old (ie, MXGEFW_CMD_UNALIGNED_TEST is an unknown command).
- The MXGEFW_CMD_UNALIGNED_TEST returns MXGEFW_CMD_ERROR_UNALIGNED, meaning
that it has seen an unaligned completion during the DMA test.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 121
Jeff Garzik wrote:
@@ -2526,6 +2530,18 @@
PCI_DEVICE_ID_SERVERWORKS_HT2100_PCIE_FIRST
bridge-device =
PCI_DEVICE_ID_SERVERWORKS_HT2100_PCIE_LAST)
+/* All Intel E3000/E3010 PCIE ports */
+|| (bridge-vendor ==
Hi Jeff,
In case it is not too late for 2.6.21, here are 3 minor fixes for myri10ge:
1. fix management of the firmware 4KB boundary crossing restriction
2. more Intel chipsets providing aligned PCIe completions
3. update driver version to 1.3.0-1.233
Thanks,
Brice
-
To unsubscribe from this
Simpler way of dealing with the firmware 4KB boundary crossing
restriction for rx buffers. This fixes a variety of memory
corruption issues when using an uncommon MTU with a 16KB
page size.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 19
Add the Intel 5000 southbridge (aka Intel 6310/6311/6321ESB) PCIe ports
and the Intel E30x0 chipsets to the whitelist of aligned PCIe completion.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 17 +
1 file changed, 17 insertions(+)
Index
Update the myri10ge driver version number to 1.3.0-1.233.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
Here's a last minute fix for myri10ge in 2.6.21. Please apply.
Thanks,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Correctly detect when TSO should be used on transmit by looking at the
skb-gso_size rather than seeing if the frame was larger than our MTU.
The old method causes problems when a host with a large (jumbo) MTU is
sending to a host with a small (standard) MTU.
---
drivers/net/myri10ge/myri10ge.c |
Correctly detect when TSO should be used on transmit by looking at the
skb-gso_size rather than seeing if the frame was larger than our MTU.
The old method causes problems when a host with a large (jumbo) MTU is
sending to a host with a small (standard) MTU.
Signed-off-by: Brice Goglin [EMAIL
Brice Goglin wrote:
Hi Jeff,
Here's 3 minor updates for myri10ge in 2.6.21:
1. use regular firmware on Serverworks HT2100
2. update wcfifo and intr_coal_delay default values
3. update driver version to 1.3.0-1.225
Please apply.
Thanks,
Brice
I just got a last minute fix (management
[PATCH 1/4] myri10ge: Serverworks HT2100 provides aligned PCIe completion
Use the regular firmware on Serverworks HT2100 PCIe ports since this
chipset provides aligned PCIe completion.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |8
1 file
Update the default value of 2 module parameters:
* wcfifo disabled
* intr_coal_delay 75us
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Driver version is now 1.3.0-1.226.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
Here's 3 minor updates for myri10ge in 2.6.21:
1. use regular firmware on Serverworks HT2100
2. update wcfifo and intr_coal_delay default values
3. update driver version to 1.3.0-1.225
Please apply.
Thanks,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
[PATCH 1/3] myri10ge: use regular firmware on Serverworks HT2100
Use the regular firmware on Serverworks HT2100 PCIe ports since this
chipset provides aligned PCIe completions.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |8
1 file changed, 8
Update the default value of 2 module parameters:
* wcfifo disabled
* intr_coal_delay 75us
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Driver version is now 1.3.0-1.225.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
4 small updates of myri10ge for 2.6.21 will follow this mail:
1) fix error checking and return value in myri10ge_allocate_rings
2) use pci_map_page to prepare the dmatest buffer
3) prevent 4k rdma on SGI TIOCE chipset
4) add a wc_enabled flag to myri10ge_priv
Thanks,
Brice
-
To
Fix a missing error check in myri10ge_allocate_rings() and set status
to -ENOMEM before all actual allocations so that the error path returns
what it should.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4
1 file changed, 4 insertions(+)
Index
Allocate a specific page and use pci_map_page for dma test instead
of relying on another existing buffer.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
Index: linux-rc/drivers/net
Do not use 4k rdma request on SGI TIOCE chipset since this
bridge does not support it.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |6 ++
1 file changed, 6 insertions(+)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Add a wc_enabled flag in the myri10ge_priv instead of relying
on mtrr = 0.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
I am resending the patch to fix the copyright and license that you acked
in the previous serie. Please apply for 2.6.21.
Thank you,
Brice
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Fix copyright and license (regents should not have ever been used).
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Steve Wise wrote:
You're right. But cxgb3 has it now in the driver (tested and working).
Shouldn't it be pulled in? When the network stack design gets done
(which could take a few releases to finalize), all the drivers can be
updated to use it. It doesn't seem reasonable to allow some
Fix copyright and license (regents should not have ever been used).
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Brice Goglin wrote:
Hi Jeff,
No big change in myri10ge these days, mainly just a workaround for
boards that were shipped with a bug in their firmware (patch #1, for
2.6.21).
Since things are pretty calm here, I am also resending the Large Receive
Offload patch for inclusion (patch #2
Hi Jeff,
No big change in myri10ge these days, mainly just a workaround for
boards that were shipped with a bug in their firmware (patch #1, for
2.6.21).
Since things are pretty calm here, I am also resending the Large Receive
Offload patch for inclusion (patch #2, maybe only for 2.6.22?). I
Work around a bug which occurs when adopting firmware versions
1.4.4 though 1.4.11 where broadcasts are filtered as if they
were multicasts.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 27 +++
1 file changed, 23 insertions(+), 4
Add Large Receive Offload implemented in software.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 422
1 file changed, 422 insertions(+)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Hi Jeff,
These should be the last 3 patches to finalize myri10ge version 1.2.0:
1. myri10ge: make wc_fifo usage load-time tunable
2. myri10ge: check that we can get an irq
3. myri10ge: update driver version to 1.2.0
Please apply to 2.6.20.
thanks,
Brice
-
To unsubscribe from this list: send the
Driver is now at version 1.2.0.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
Under some circumstances, using WC without the WC fifo is faster.
So we make it possible to tune wc_fifo with a module parameter.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Index: linux-rc
Now that IRQ allocation is done in myri10ge_open(), we want to still
check when loading the driver that IRQ allocation could succeed later.
Additionaly, we fix the initialization and printing of netdev-irq.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 15
anymore.
For the future, we are thinking of a better way to recover from parity
error without using pci_save_state().
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-rc/drivers/net
Request IRQ in myri10ge_open() and free in close() instead of probe()
and remove() to eliminate potential race between the watchdog and the
interrupt handler. Additionaly, the interrupt handler won't get called
on shared irq anymore when the interface is down.
Signed-off-by: Brice Goglin [EMAIL
-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-rc/drivers/net/myri10ge/myri10ge.c
===
--- linux-rc.orig/drivers/net/myri10ge/myri10ge.c
On suspend, handle pci_set_power_state errors, and on resume
handle failures in pci_resume_state().
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 12 +++-
1 file changed, 7 insertions(+), 5
Hi Jeff,
While testing Stephen Hemminger's patch to cleanup the save/restore_state
in myri10ge, we discovered some problems in our code. First, since the MSI
and PCIe state is saved on a kind of stack, we leak some memory by saving
the state both for parity recovery and on suspend. Additionaly,
The PCI MSI and express state are already saved and restored by the
current versions of pci_save_state/pci_restore_state.
Therefore it is no longer necessary for the driver to do it.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net
Indentation cleanups to synchronize to our tree which is automatically
indent'ed.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
Add physical page skb allocation routines and page based rx_done,
to be used by upcoming patches.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 190
1 file changed, 190 insertions(+)
Index: linux-git/drivers/net
Hi Jeff,
The following 7 patches update/fix myri10ge:
1. indentation cleanups
2. add page-based skb routines
3. switch to page-based skb
4. drop contiguous skb routines
5. full vlan frame in small_bytes
6. fix big_bytes in case of vlan frames
7. update driver version to 1.1.0
#1 is independent,
Drop the old routines that used the physically contigous skb now
that we use the physical pages. And rename myri10ge_page_rx_done()
to myri10ge_rx_done() as it was previously.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c | 212
for some MTUs.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
===
--- linux-git.orig/drivers
Receive full vlan frames into smalls when running with a jumbo MTU.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
Update driver version to 1.1.0.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-git/drivers/net/myri10ge/myri10ge.c
Jeff Garzik wrote:
Stephen Hemminger wrote:
The PCI MSI and express state are already saved and restored by the
current versions of pci_save_state/pci_restore_state.
Therefore it should no longer be necessary for the driver to do it.
This patch has not been tested on the hardware.
On
It looks ok to me, except that you should also remove devctl and
msi_flags from myri10ge_priv since these fields were only used in the
functions that are dropped by this patch.
However, I won't be able to test the patch on real hardware within the
next days...
Thanks a lot!
Brice
Stephen
Jeff Garzik wrote:
Brice Goglin wrote:
In the myri10ge_submit_8rx() routine, write the 64 byte request block as
2 32-byte blocks so that it is handled by the hardware pio write handler
if write-combining is enabled.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge
In the myri10ge_submit_8rx() routine, write the 64 byte request block as
2 32-byte blocks so that it is handled by the hardware pio write handler
if write-combining is enabled.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 +++-
1 file changed, 3
Hi,
About 2 month ago, I sent a patchset to implement software LRO in
myri10ge. People replied that it might be time to implement something
generic in the net core stack instead since it was the second driver to
do so. We completely agree with this. But, I haven't heard back from
this idea since
Steve Wise wrote:
There is no SW TCP stack in this driver. The HW supports RDMA over
TCP/IP/10GbE in HW and this is required for zero-copy RDMA over Ethernet
(aka iWARP). The device is a 10 GbE device, not Infiniband.
Then, I wonder why the driver goes in drivers/infiniband/ :)
Is there
Hi Jeff,
The following patch is a small fix for myri10ge, please apply it for 2.6.20.
I don't send any other fix/update since they highly depend on the
physical page skb conversion that I sent a couple times in the past
without getting any answer.
Thanks,
Brice
-
To unsubscribe from this list:
In the myri10ge_submit_8rx() routine, write the 64 byte request block as
2 32-byte blocks so that it is handled by the hardware pio write handler
if write-combining is enabled.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |4 +++-
1 file changed, 3
Hi Jeff,
It looks like you didn't apply this patch to #upstream for 2.6.20 so far. We
would really like to get ith in 2.6.20 (we already missed 2.6.19 by a couple
days :)). But, I guess we need some testing in -mm first, so...
thanks,
Brice
Brice Goglin wrote:
Physical pages are used
[PATCH] myri10ge: ServerWorks HT2000 PCI id is already defined in pci_ids.h
No need to keep defining PCI_DEVICE_ID_SERVERWORKS_HT2000_PCIE
in the driver code since it is now defined in pci_ids.h.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
---
drivers/net/myri10ge/myri10ge.c |1 -
1 file
The following patch reworks the myri10ge driver to use physical pages for skb
allocation. A similar patch has been submitted about a month ago within our LRO
patches. The LRO code won't be sent here since we are waiting for the core
stack to implement a generic LRO.
Please consider this single
Physical pages are used instead of 16kB contiguous buffers for the
skb frags. And we also put as much fragments as possible in any page
so that we do not have to allocate a page for every fragments.
Signed-off-by: Brice Goglin [EMAIL PROTECTED]
Signed-off-by: Andrew J. Gallatin [EMAIL PROTECTED
Michael Chan a écrit :
AMD believes this incompatibility is unique to the 5706, and
prefers to locally disable MSI rather than globally disabling it
using pci_msi_quirk.
FYI, pci_msi_quirk is the extreme solution, there is something in the
middle :) It is possible to disable MSI for only
Brice Goglin a écrit :
Could we get patch #1 merged anyway (page-based skb allocation)?
Oops, actually, one hunk has to be dropped (it reverts const'ification
of ethtool_ops by mistake). If it is ok to merge the patch apart from
this hunk, will resend an updated patch.
Brice
Evgeniy Polyakov a écrit :
On Sat, Sep 30, 2006 at 12:16:44AM +0200, Brice Goglin ([EMAIL PROTECTED])
wrote:
Jeff Garzik a écrit :
Brice Goglin wrote:
The complete driver code in our CVS actually also supports high-order
allocations instead of single physical pages since
Jeff Garzik a écrit :
Brice Goglin wrote:
This is a complete rework of the myri10ge receive path. The first
patch converts skb allocation to use physical pages. The second one
adds a software implementation of Large Receive Offload. The third
one updates the driver version to 1.1.0
1 - 100 of 161 matches
Mail list logo
