So, it sounds like Krishna's patch is ok, because the race does not
exist anymore in this driver?
The first part is right indeed, but the second part is breaking the
current usage of txq_stopped and
the logic that stops and restarts the Tx queue.
I can submit a patch fixing it. Plese let me
Jeff Garzik wrote:
Divy Le Ray wrote:
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
master.kernel.org
-Original Message-
From: David Miller [mailto:[EMAIL PROTECTED]
Sent: Wednesday, February 20, 2008 9:47 PM
To: [EMAIL PROTECTED]
Cc: Divy Le Ray; [EMAIL PROTECTED]; [EMAIL PROTECTED];
netdev@vger.kernel.org
Subject: Re: [git patches] net driver updates
From: Krishna Kumar2
From: Divy Le Ray [EMAIL PROTECTED]
Date: Wed, 20 Feb 2008 21:57:08 -0800
The driver is cxgb3 here, it uses LLTX.
That's extremely unfortunate, hopefully you can update it to
use a model like tg3 and others use. LLTX is a lost cause
for hardware device drivers, and in fact we'd like
Jeff Garzik wrote:
Mostly fixes, a few cleanups (generally assisting fixes), and an
exception for PS3 wireless because it had been posted, reviewed and
acked for a while, just not committed.
Please pull from 'upstream-davem' branch of
to use the arp entry can cause RDMA connection failures.
Signed-off-by: Steve Wise [EMAIL PROTECTED]
Acked-by: Divy Le Ray [EMAIL PROTECTED]
Divy
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Krishna Kumar wrote:
Changes:
1. Add common code for stopping queue.
2. No need to call netif_stop_queue followed by netif_wake_queue (and
infact a netif_start_queue could have been used instead), instead
call stop_queue if required, and remove code under
Jeff Garzik wrote:
A couple serious fixes (wireless, e100, sky2) and a bevy of minor ones.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
Hi Jeff,
Should I resend the 2 cxgb3 patches posted on 12/05 and 12/06
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c| 82
drivers/net/cxgb3/cxgb3_offload.c | 15 ++
drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
set_pci_drvdata() stores a pointer to the adapter,
not the net device.
Add missing softirq blocking in t3_mgmt_tx.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 14 --
drivers/net/cxgb3/sge.c|7
http://vger.kernel.org/majordomo-info.html
The last thing I have from you, in netdev#upstream, is
commit 75758e8aa4b7d5c651261ce653dd8d0b716e1eda
Author: Divy Le Ray [EMAIL PROTECTED]
Date: Wed Dec 5 10:15:01 2007 -0800
cxgb3 - T3C support update
Update GPIO mapping for T3C
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net
Jeff Garzik wrote:
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c| 82
drivers/net/cxgb3
Divy Le Ray wrote:
Jeff,
I'm submitting a patch series for inclusion in 2.6.25.
The patches are built against netdev#upstream.
Here is a brief description:
- Update GPIO pinning and MAC support for T3C adapters
- Enable parity error detection.
Jeff,
I posted a third patch to fix the EEH code
From: Divy Le Ray [EMAIL PROTECTED]
set_pci_drvdata() stores a pointer to the adapter,
not the net device.
Add missing softirq blocking in t3_mgmt_tx.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 14 --
drivers/net/cxgb3/sge.c|7
Jeff,
I'm submitting a patch series for inclusion in 2.6.25.
The patches are built against netdev#upstream.
Here is a brief description:
- Update GPIO pinning and MAC support for T3C adapters
- Enable parity error detection.
Cheers,
Divy
--
To unsubscribe from this list: send the line
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c| 82
drivers/net/cxgb3/cxgb3_offload.c | 15 ++
drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Update GPIO mapping for T3C.
Update xgmac for T3C support.
Fix typo in mtu table.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h | 27 ++-
drivers/net/cxgb3/t3_hw.c |6 +++---
drivers/net/cxgb3
Ben Greear wrote:
Divy Le Ray wrote:
Jeff,
I'm submitting a patch series for inclusion in 2.6.24 for the cxgb
driver.
The patches are built against Linus'git tree.
Here is a brief description:
- Ensure that GSO skbs have enough headroom before encapsulating them,
- Fix a crash in NAPI mode
From: Divy Le Ray [EMAIL PROTECTED]
revert inavertant file mode changes
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/chelsio/cxgb2.c |0
drivers/net/chelsio/pm3393.c |0
drivers/net/chelsio/sge.c|0
drivers/net/chelsio/sge.h|0
4 files changed, 0
Jeff Garzik wrote:
Notes:
1) Several of these are resends from the last submission.
2) That chelsio file mode change (644-755) is a bit annoying. Can git
do chmod as a changeset by itself?
Sorry for this. I had not noticed it.
If any help, I just submitted a patch reverting the file mode
Jeff,
I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver.
The patches are built against Linus'git tree.
Here is a brief description:
- Ensure that GSO skbs have enough headroom before encapsulating them,
- Fix a crash in NAPI mode,
- Fix statistics accounting and report.
From: Divy Le Ray [EMAIL PROTECTED]
The patch ensures that a GSO skb has enough headroom
to push an encapsulating cpl_tx_pkt_lso header.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/chelsio/cxgb2.c |3 ++-
drivers/net/chelsio/sge.c | 34
From: Divy Le Ray [EMAIL PROTECTED]
netif_rx_complete() should be called only
when work_done budget.
Signed-off-by: Divy Le ray [EMAIL PROTECTED]
---
drivers/net/chelsio/sge.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/chelsio/sge.c b/drivers
From: Divy Le Ray [EMAIL PROTECTED]
Fix MAC stats accounting.
Fix get_stats.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/chelsio/cxgb2.c | 67 +++--
drivers/net/chelsio/pm3393.c | 112 +-
drivers/net/chelsio
From: Divy Le Ray [EMAIL PROTECTED]
Return error code when msi-x settings fail.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Vendor ID is not necessarily set to 1.
Use Vendor Id wild card for PCI device matching
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff
From: Divy Le Ray [EMAIL PROTECTED]
Remove sysfs entries before unregistering the net devices.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b
From: Divy Le Ray [EMAIL PROTECTED]
Add PCI recovery support
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 107
1 files changed, 107 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b
From: Divy Le Ray [EMAIL PROTECTED]
Bump up FW version to 5.0.
Do not downgrade FW within the same major version range.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/t3_hw.c | 10 +++---
drivers/net/cxgb3/version.h |4 ++--
2 files changed, 9 insertions(+), 5
Jeff, Dave,
I'm submitting a patch series for inclusion in 2.6.25.
The patches are built against netdev#upstream.
Here is a brief description:
- Fix error path when requesting MSI-X resources
- Use wild card for PCI Vendor ID
- Fix sysfs resource release
- Add PCI error recovery support
- FW
From: Divy Le Ray [EMAIL PROTECTED]
Do not use skb-cb to stash unmap info,
save the info to the descriptor state.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/sge.c | 82 +++
1 files changed, 40 insertions(+), 42 deletions
From: Divy Le Ray [EMAIL PROTECTED]
Remove unused argument in sysfs methods
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 19 +--
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Synchronize memory access before ringing
the Tx door bell.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/sge.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Disable PEX errors. The HW generates false positives.
Update RSS hash function to a symmetric algorithm.
Update T3C HW support
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |2 +-
drivers/net/cxgb3/regs.h | 22
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Vendor ID is not necessarily set to 1.
This patch modifies the sub-device id, not the vendor id ...
Use Vendor Id wild card for PCI device matching
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c
From: Divy Le Ray [EMAIL PROTECTED]
Subdevice ID is not necessarily set to 1.
Use wild card for PCI device matching
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git
Ben Greear wrote:
This panic happens (almost?) immediately after starting TCP traffic
between
the cxgb nic on this system and another. We also got at least one crash
on a custom/tainted 2.6.20.12 kernel, but it would run for at least
a few minutes at ~1Gbps first.
I think my serial console
From: Divy Le Ray [EMAIL PROTECTED]
eth_type_trans() now sets skb-dev.
Access skb-def after it gets set.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/chelsio/sge.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/chelsio/sge.c b/drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Embed napi_struct directly into sge_qset.
Use napi_schedule/napi_complete.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h| 20 +++---
drivers/net/cxgb3/cxgb3_main.c | 57 ++
drivers/net
I think 9-14 still need to be incorporated. I don't see them in your
upstream branch, and they aren't in linus' tree either.
I am not the blocker here.
Sorry for the delay - again.
I'm resubmitting these patches against net#upstream.
Cheers,
Divy
-
To unsubscribe from this list: send
From: Divy Le Ray [EMAIL PROTECTED]
Update firmware version.
Allow the driver to be up and running with older FW image
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 +-
drivers/net/cxgb3/cxgb3_main.c |9 +
drivers/net/cxgb3/t3_hw.c
From: Divy Le Ray [EMAIL PROTECTED]
Clear pciE PEX errors late at module load time.
Log details when PEX errors occur.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/t3_hw.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Qualify toggling of xgmac tx enable with not getting pause frames,
we might not make forward progress because the peer is sending
lots of pause frames.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |1 +
drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
add driver recognition for T3C rev board.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |1 +
drivers/net/cxgb3/cxgb3_main.c |3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
The new microcode engine version is set to 1.1.0
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
From: Divy Le Ray [EMAIL PROTECTED]
Currently, the driver only tries up to 5 times (5us) to get the results
of a CQ context operation. Testing has shown the chip can take as much
as 50us to return the response on SG_CONTEXT_CMD operations. So we up
the retry count to 100 to cover high loads
Roland Dreier wrote:
Looks OK to me but I would just roll up the second patch into the
first patch and let Jeff merge it as one commit. There's no point in
creating an intermediate tree that doesn't build -- it just breaks git
bisect for no useful purpose.
Okay, Jeff agrees too, I'll do so.
Jeff,
I'm resubmitting the cxgb3 dev-priv issue.
I'm also submitting a patch fixing the engine microcode loading.
The first patch changes in both cxgb3 and iw_cxgb3 related to
the dev-priv issue.
The second patch allows the driver to load the engine microcode
at the right time - when a port is
From: Divy Le Ray [EMAIL PROTECTED]
cxgb3 used netdev_priv() and dev-priv for different purposes.
In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Without this fix, cxgb3 crashes on 2.6.23.
Signed
From: Divy Le Ray [EMAIL PROTECTED]
Load the engine microcode when an interface
is brought up, instead of of doing it when the module
is loaded.
Loosen up tight binding between the driver and the
engine microcode version.
There is no need for microcode update with T3A boards.
Fix the file
Roland Dreier wrote:
I take that back. Rejected -- it breaks infiniband build.
To be more precise:
drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open':
drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of
function 'T3CDEV'
it seems the
Jeff/Roland,
I'm resubmitting the cxgb3 dev-priv fix for inclusion in 2.6.23.
I also submit a follow-up patch for the iw_cxgb3 driver that fixes
the previous infiniband breakage.
Cheers,
Divy
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
From: Divy Le Ray [EMAIL PROTECTED]
cxgb3 used netdev_priv() and dev-priv for different purposes.
In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Without this fix, cxgb3 crashes on 2.6.23.
Signed
From: Divy Le Ray [EMAIL PROTECTED]
The RDMA driver sitting on top of cxgb3
now uses the exported function dev2t3cdev()
to retrieve the the t3cdev associated with
a net_device.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/infiniband/hw/cxgb3/cxio_hal.c |2 +-
1 files changed
Hi Jeff,
I'm submitting three more patches for inclusion in netdev#upstream.
These patches are built over the series I resent yesterday night.
The patch numbering reflects the stacking.
Here is a brief description:
- avoid false positives in the xgmac hang workaround
- Properly set the
From: Divy Le Ray [EMAIL PROTECTED]
Qualify toggling of xgmac tx enable with not getting pause frames,
we might not make forward progress because the peer is sending
lots of pause frames.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |1 +
drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
The cxgb3 driver is incorrectly configuring the HW CQ context for CQ's
that use overflow-avoidance. Namely the RDMA control CQ. This results
in a bad DMA from the device to bus address 0. The solution is to set
the CQ_ERR bit in the context for these types
From: Divy Le Ray [EMAIL PROTECTED]
Currently, the driver only tries up to 5 times (5us) to get the results
of a CQ context operation. Testing has shown the chip can take as much
as 50us to return the response on SG_CONTEXT_CMD operations. So we up
the retry count to 100 to cover high loads
Hi Al,
Speaking of cxgb3, could you explain what the hell is
static int do_term(struct t3cdev *dev, struct sk_buff *skb)
{
unsigned int hwtid = ntohl(skb-priority) 8 0xf;
doing? AFAIK, skb-priority is not net-endian...
the RDMA connection id is saved in the skb's priority
From: Divy Le Ray [EMAIL PROTECTED]
cxgb3 used netdev_priv() and dev-priv for different purposes.
In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Without this fix, cxgb3 crashes on 2.6.23.
Signed
Jeff,
I'm resubmitting the last cxgb3 patch series against netdev-2.6#upstream,
minus the first patch that you already applied and the last patch.
Here is a brief description:
- Modify max HW Rx coalescing size
- Log SGE doorbell Fifo overflow
- Use Tx immediate data for
From: Divy Le Ray [EMAIL PROTECTED]
Reduce Rx coalescing length to 12288
Large bursts from the adapter to the host create back pressure
on the chip. Reducing the burst size avoids the issue.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 +-
1 files changed
From: Divy Le Ray [EMAIL PROTECTED]
Log doorbell Fifo overflow
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h |8
drivers/net/cxgb3/sge.c |4
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/regs.h b/drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Send small TX_DATA work requests as immediate data even when
there are fragments. this avoids doing multiple DMAs for
small fragmented packets.
The driver already implements this optimization for small
contiguous packets.
Signed-off-by: Divy Le Ray [EMAIL
From: Divy Le Ray [EMAIL PROTECTED]
A HW issue requires limiting the receive window size
to 23 pages of internal memory.
These pages can be configured to different sizes,
thus the RDMA driver needs to know the
page size to enforce the upper limit.
Also assign explicit enum values.
Signed-off
From: Divy Le Ray [EMAIL PROTECTED]
Enforce validity checks on connection ids
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_defs.h| 20 ++--
drivers/net/cxgb3/cxgb3_offload.c | 28 +++-
2 files changed, 41 insertions
From: Divy Le Ray [EMAIL PROTECTED]
Stop the MAC when a fatal error is detected.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Log HW serial number when cxgb3 module is loaded.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 ++
drivers/net/cxgb3/cxgb3_main.c |6 --
drivers/net/cxgb3/t3_hw.c |3 ++-
3 files changed, 8
From: Divy Le Ray [EMAIL PROTECTED]
Set PM1 internal memory to round robin mode
It balances access to this internal memory for multiport adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h |2 ++
drivers/net/cxgb3/t3_hw.c |2 ++
2 files changed, 4
From: Divy Le Ray [EMAIL PROTECTED]
Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Update firmware version
Allow the driver to be up and running with older FW image
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 +-
drivers/net/cxgb3/cxgb3_main.c |9 +
drivers/net/cxgb3/t3_hw.c
From: Divy Le Ray [EMAIL PROTECTED]
Clear pciE PEX errors late at module load time.
Log details when PEX errors occur.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/t3_hw.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Set max Rx coalescing length to 12288
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Send small TX_DATA work requests as immediate data even when
there are fragments.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/sge.c | 17 +++--
1 files changed, 11
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Let the RDMA driver get HW page info to work around HW issues.
Assign explicit enum values.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
HW issues -- you need to go into far more detail, when adding a new
interface
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Set PM1 internal memory to round robin mode
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
why?
For multiport adapters, it balances access to this internal memory.
Divy
-
To unsubscribe from this list: send
From: Divy Le Ray [EMAIL PROTECTED]
cxgb3 used netdev_priv() and dev-priv for different purposes.
In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix.
This patch is a partial backport of Dave Miller's changes in the
net-2.6.24 git branch.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED
From: Divy Le Ray [EMAIL PROTECTED]
Update the MAC workaround to deal with switches that do not
honor pause frames.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |1 +
drivers/net/cxgb3/xgmac.c | 22 +++---
2 files changed, 12 insertions
From: Divy Le Ray [EMAIL PROTECTED]
Set max Rx coalescing length to 12288
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h
index c46c249
From: Divy Le Ray [EMAIL PROTECTED]
Log doorbell Fifo overflow
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h |8
drivers/net/cxgb3/sge.c |4
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/regs.h b/drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Send small TX_DATA work requests as immediate data even when
there are fragments.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/sge.c | 17 +++--
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Let the RDMA driver get HW page info to work around HW issues.
Assign explicit enum values.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_ctl_defs.h | 52 +---
drivers/net/cxgb3/cxgb3_offload.c
From: Divy Le Ray [EMAIL PROTECTED]
Stop the MAC when a fatal error is detected.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3
From: Divy Le Ray [EMAIL PROTECTED]
Log HW serial number when cxgb3 module is loaded.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/common.h |2 ++
drivers/net/cxgb3/cxgb3_main.c |6 --
drivers/net/cxgb3/t3_hw.c |3 ++-
3 files changed, 8
From: Divy Le Ray [EMAIL PROTECTED]
Set PM1 internal memory to round robin mode
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h |2 ++
drivers/net/cxgb3/t3_hw.c |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/regs.h b
From: Divy Le Ray [EMAIL PROTECTED]
Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net
From: Divy Le Ray [EMAIL PROTECTED]
Enforce validity checks on connection ids
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_defs.h| 20 ++--
drivers/net/cxgb3/cxgb3_offload.c | 28 +++-
2 files changed, 41 insertions
From: Divy Le Ray [EMAIL PROTECTED]
Check that the HW in really in MSI/MSI-X mode
when it was succesfully enabled.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c | 42
drivers/net/cxgb3/regs.h |4
2
From: Divy Le Ray [EMAIL PROTECTED]
Clear pciE PEX errors late at module load time.
Log details when PEX errors occur.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/t3_hw.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3
Adrian Bunk wrote:
This patch removes dead code (tx_xcnt can never be != 0 at this place)
spotted by the Coverity checker.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/xgmac.c |5 +
1 file changed, 1 insertion(+), 4
Denis Cheng wrote:
Cc: [EMAIL PROTECTED]
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
Acked-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3
Andi Kleen wrote:
Brice Goglin [EMAIL PROTECTED] writes:
I am trying to understand whether I can setup a skb destructor in my
code (which is basically a protocol above dev_queue_xmit() and co). From
what I see in many parts in the current kernel code, the protocol (I
mean, the one who
Divy Le Ray wrote:
Divy Le Ray wrote:
Hi Jeff,
I'm submitting a set of bug fixes for inclusion in 2.6.22.
The patches are built against Linus'git tree.
The mail title was incomplete. sorry about that.
Cheers,
Divy
Hi Jeff,
Did you get a chance to review the series I posted for driver
Hi Jeff,
I'm submitting a set of bug fixes for inclusion in 2.6.22.
The patches are built against Linus'git tree.
Here is a brief description:
- Fix skb-dev dereference in,
- Fix netpoll handler,
- Fix link status detection for direct XAUI adapters,
- Work around potential hang on MTU change,
-
Divy Le Ray wrote:
Hi Jeff,
I'm submitting a set of bug fixes for inclusion in 2.6.22.
The patches are built against Linus'git tree.
The mail title was incomplete. sorry about that.
Cheers,
Divy
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
[EMAIL PROTECTED] wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Rx traffic needs to be halted when the MTU is changed
to avoid a potential chip hang.
Reset/restore MAC filters around a MTU change.
Also fix the pause frames high materwark setting.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED
From: Divy Le Ray [EMAIL PROTECTED]
Rx traffic needs to be halted when the MTU is changed
to avoid a potential chip hang.
Reset/restore MAC filters around a MTU change.
Also fix the pause frames high materwark setting.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/regs.h
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Streamline page management on RX.
Fix dma mappings.
NAK #2: You should use the page_address(page) accessor rather than
creating a struct member in the same struct as your page, solely to
contain the virtual
1 - 100 of 181 matches
Mail list logo
