Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-03-01 Thread John Holland
> On 02.03.2016, at 00:55, Jeff Kirsher <jeffrey.t.kirs...@intel.com> wrote: > >> On Tue, 2016-03-01 at 07:56 +0100, John Holland wrote: >> On Mar 1, 2016, at 03:52, Brown, Aaron F <aaron.f.br...@intel.com> >> wrote: >> >>> This throws

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-29 Thread John Holland
On Mar 1, 2016, at 03:52, Brown, Aaron F wrote: > This throws a few checkpatch warnings, but I won't withhold my tested by for > these: > > total: 0 errors, 2 warnings, 0 checks, 21 lines checked > > Your patch has style problems, please review. > > NOTE: If any of

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-18 Thread John Holland
> On Feb 18, 2016, at 16:22, David Miller <da...@davemloft.net> wrote: > > From: John Holland <jotih...@gmail.com> > Date: Thu, 18 Feb 2016 08:53:07 +0100 > >> The PCI path in eth_platform_get_mac_address() didn't return a devicetree >&

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-18 Thread John Holland
On 02/18/2016 12:10 PM, John Holland wrote: Hello, The Intel i211 LOM PCIe Ethernet controllers' iNVM operates as an OTP and has no external EEPROM interface [1]. The following allows the driver to pickup the MAC address from a device tree blob when CONFIG_OF has been enabled

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V5

2016-02-18 Thread John Holland
. - Remove now invalid device tree binding documentation specified in V3 und V4. Signed-off-by: John Holland<jotih...@gmail.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_mai

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-17 Thread John Holland
> On Feb 18, 2016, at 03:29, David Miller <da...@davemloft.net> wrote: > > From: John Holland <jotih...@gmail.com> > Date: Thu, 18 Feb 2016 00:49:17 +0100 > >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an OTP >> and has no externel EEP

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

2016-02-17 Thread John Holland
/networking/i211-ethernet-controller-datasheet.html Changes V2 - Restrict searching for compatible devices to current pci device. Changes V3 - Add device tree binding documentation. Changes V4 - Rebase patch. Signed-off-by: John Holland<jotih...@gmail.com> --- Documentation/devicetree/bi

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V3

2016-02-16 Thread John Holland
/networking/i211-ethernet-controller-datasheet.html Changes V2 - Restrict searching for compatible devices to current pci device. Changes V3 - Add device tree binding documentation. Signed-off-by: John Holland<jotih...@gmail.com> --- Documentation/devicetree/bindings/net/intel,i210.tx

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

2016-02-16 Thread John Holland
> On Feb 16, 2016, at 17:58, Andrew Lunn <and...@lunn.ch> wrote: > >> On Sat, Feb 13, 2016 at 11:04:45PM +0100, John Holland wrote: >> Hello, >> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an >> OTP and has no externel

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V2

2016-02-13 Thread John Holland
/products/networking/i211-ethernet-controller-datasheet.html Changes V2 - Restrict searching for compatible devices to current pci device. Signed-off-by: John Holland <jotih...@gmail.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 30 ++ 1 file chang

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-10 Thread John Holland
> On Feb 9, 2016, at 12:02, Jeff Kirsher <jeffrey.t.kirs...@intel.com> wrote: > >> On Fri, 2016-01-29 at 23:11 +0100, John Holland wrote: >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an >> OTP >> and has no externel EEPROM interface [1].

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-10 Thread John Holland
Sent from my iPad On Feb 9, 2016, at 12:54, Andrew Lunn wrote: >>> +static void igb_read_mac_addr_dts(struct e1000_hw *hw) >>> +{ >>> + const u8 *mac; >>> + struct device_node *dn; >>> + >>> + dn = of_find_compatible_node(NULL, NULL, "intel,i211"); > > Hi

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-10 Thread John Holland
On Feb 9, 2016, at 12:59, Andrew Lunn wrote: >>> + dn = of_find_compatible_node(NULL, NULL, "intel,i211"); > > Humm, NULL, NULL. That means find the first node anywhere in the > device tree which matches. This is not going to work too well when you > have multiple i211s.

Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-02-10 Thread John Holland
> On Feb 9, 2016, at 18:42, Shannon Nelson wrote: > > It seem to me this should be using eth_platform_get_mac_address(), a > slightly more generic method to do this. See the i40e driver for an > example, commit d9a84324e6 I believe. > I believe you are referring to

[Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

2016-01-29 Thread John Holland
/networking/i211-ethernet-controller-datasheet.html Signed-off-by: John Holland <jotih...@gmail.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/et