Re: [PATCH][next] ath10k: fix out of bound read on array ath10k_rates

Colin King wrote: > From: Colin Ian King > > An out-of-bounds read on array ath10k_rates is occurring because > the maximum number of elements is currently based on the size of > the array and not the number of elements in the array. Fix this > by using ARRAY_SIZE instead of sizeof. > >

Re: [PATCH] qtnfmac: avoid uninitialized variable access

tool > warning. It looks like the patch from Arnd does not cover both cases. > So we will take a closer look and send a combined fix later. Ok, I'll drop this from my queue. Please resend whatever patch I need to apply. -- Kalle Valo

Re: [PATCH] net: wireless: ath: Convert to using %pOFn instead of device_node.name

Rob Herring writes: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wirel...@vger.kernel.org > Cc: netdev@vger.kernel.o

Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

"H. Nikolaus Schaller" writes: >> Am 25.07.2018 um 08:40 schrieb Kalle Valo : >> >> "H. Nikolaus Schaller" writes: >> >>> wl1271_warning() already appends a \n to the format, >>> so adding one to the warning string gives empty

Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

"H. Nikolaus Schaller" writes: > wl1271_warning() already appends a \n to the format, > so adding one to the warning string gives empty lines in the log. > > Signed-off-by: H. Nikolaus Schaller "drivers: net:" in the title is unnecessary, but I can remove that. -- Kalle Valo

Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode

/testmode.c: C source, UTF-8 Unicode > (with BOM) text > > and after: > > drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text > > Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)") > Signed-off-by: Geert Uytterhoeven I'll queue this for 4.18. -- Kalle Valo

Re: [PATCH] ath6kl: mark expected switch fall-throughs

"Gustavo A. R. Silva" <gust...@embeddedor.com> writes: > On 05/25/2018 08:30 AM, Kalle Valo wrote: >> Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: >> >>> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: >>> >>>> I

Re: [PATCH] ath6kl: mark expected switch fall-throughs

/* fall through */ >> case WMI_11AG_CAP: >> band_2gig = true; >> band_5gig = true; > >Hm, typically such comments are done on a line of their own, have > never seen this style... Yeah, I was wondering the same. Was there a particular reason for this? -- Kalle Valo

Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

$ scripts/get_maintainer.pl --no-rolestats --no-git -f drivers/net/wireless/intel/iwlwifi/dvm/main.c Johannes Berg <johannes.b...@intel.com> Emmanuel Grumbach <emmanuel.grumb...@intel.com> Luca Coelho <luciano.coe...@intel.com> Intel Linux Wireless <linuxw...@intel.com> Kalle Valo <

Re: [v3] wcn36xx: Add support for Factory Test Mode (FTM)

2) > 5) Add generic handling for all PTT_MSG packets > > Signed-off-by: Eyal Ilsar <eil...@codeaurora.org> > Signed-off-by: Ramon Fried <ramon.fr...@linaro.org> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 87f

Re: [net-next] ath10k: Remove useless test before clk_disable_unprepare

YueHaibing <yuehaib...@huawei.com> wrote: > clk_disable_unprepare() already checks that the clock pointer is valid. > No need to test it before calling it. > > Signed-off-by: YueHaibing <yuehaib...@huawei.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org>

pull-request: wireless-drivers 2018-05-22

and b44 drivers * try again fixing a MIPS linker error bcma * fix truncated info log messages Kalle Valo (3): MAINTAINERS: update Kalle's email address MAINTAINERS: change Kalle as ath.ko maintainer MAINTAINERS

Re: [PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM)

/ath/wcn36xx/testmode.c:122:5: warning: 'msg' may be used uninitialized in this function [-Wmaybe-uninitialized] -- Kalle Valo

pull-request: wireless-drivers-next 2018-05-17

iwlwifi: move timestamp functions from debugfs.h to dbg.h Jia-Ju Bai (1): net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment Johannes Berg (3): iwlwifi: mvm: detect U-APSD breaking aggregation iwlwifi: mvm: clean up scan capability checks

Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

ree, not to net-next. So adding net-next to the subject is wrong, but no need to resend just because of that. -- Kalle Valo

Re: rsi: fix spelling mistake: "thead" -> "thread"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in rsi_dbg debug message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. b41c39367669

Re: mwifiex: delete unneeded include

Julia Lawall wrote: > Nothing that is defined in 11ac.h is referenced in cmdevt.c. > > Signed-off-by: Julia Lawall Patch applied to wireless-drivers-next.git, thanks. 4793e5a954fa mwifiex: delete unneeded include --

Re: [PATCH] net: wireless: ath: ath9k: Fix a possible data race in ath_chanctx_set_next

t;next_chan". > > To fix this data race, the read operation to "sc->next_chan" > should be also protected by the lock. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> I need this reviewed by someone else before I'm willing to take it. -- Kalle Valo

Re: [PATCH 09/18] net: mac80211.h: fix a bad comment line

ted a similar patch: https://patchwork.kernel.org/patch/10367275/ But it seems Johannes has not applied that yet. -- Kalle Valo

Re: ipw2200: fix spelling mistake: "functionalitis" -> "functionalities"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in module parameter description text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: rtlwifi: fix spelling mistake: "dismatch" -> "mismatch"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message text. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 070fc356e21a

Re: ipw2100: fix spelling mistake: "decsribed" -> "described"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in comment and in the ord_data text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

Colin Ian King wrote: > From: Colin Ian King > > Rename several macros that contain mispellings of UNKNOWN > > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to

Re: rsi_91x: fix uninitialized variable

"Gustavo A. R. Silva" wrote: > There is a potential execution path in which variable ret is returned > without being properly initialized previously. > > Fix this by storing the value returned by function > rsi_usb_master_reg_write into _ret_. > > Addresses-Coverity-ID:

Re: rsi_91x: fix structurally dead code

"Gustavo A. R. Silva" wrote: > Function rsi_hal_key_config returns before reaching code at line > 922 if (status), hence this code is structurally dead. > > Fix this by storing the value returned by rsi_hal_load_key > into _status_ for its further evaluation and use. >

Re: qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of INIT_WORK() in >

Re: mwifiex: fix spelling mistake: "capabilties" -> "capabilities"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in function names and text strings > > Signed-off-by: Colin Ian King Failed to apply: error: patch failed:

Re: mwifiex: fix mwifiex_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: ath10k: sdio: jump to correct label in error handling path

t;ath10k: sdio: fix memory > leak for probe allocations"). > However, the bug was originally introduced in commit d96db25d2025 > ("ath10k: add initial SDIO support"). > > Fixes: d96db25d2025 ("ath10k: add initial SDIO support") > Signed-off-by: Nik

Re: [next] ath10k: fix spelling mistake: "servive" -> "service"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in ath10k_warn warning message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-

Re: ath6kl: fix ath6kl_data_tx()'s return type

iver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 378b1d65070f ath6kl: fix ath6kl_data_tx()'s return type -- https://p

pull-request: wireless-drivers 2018-04-26

Hi Dave, here's a pull request to net tree, more info below. Please let me know if you have any problems. Kalle The following changes since commit 4608f064532c28c0ea3c03fe26a3a5909852811a: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next (2018-04-03 14:08:58 -0700) are

Re: qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

"Gustavo A. R. Silva" wrote: > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") >

Re: brcmsmac: phy_lcn: remove duplicate code

"Gustavo A. R. Silva" wrote: > Remove and refactor some code in order to avoid having identical code > for different branches. > > Notice that this piece of code hasn't been modified since 2011. > > Addresses-Coverity-ID: 1226756 ("Identical code for different

Re: [1/2] net: wireless: zydas: Replace mdelay with msleep in zd1201_probe

Jia-Ju Bai wrote: > zd1201_probe() is never called in atomic context. > > zd1201_probe() is only set as ".probe" in struct usb_driver. > > Despite never getting called from atomic context, zd1201_probe() > calls mdelay() to busily wait. > This is not necessary and can

Re: [PATCH v3] ath9k: dfs: Remove VLA usage

fine FFT_NUM_SAMPLES (NUM_DIFFS + 1) I have already applied an almost identical patch: ath9k: dfs: remove accidental use of stack VLA https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next=9c27489a34548913baaaf3b2776e05d4a9389e3e -- Kalle Valo

Re: mt7601u: phy: mark expected switch fall-through

"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Jakub Kicinski Patch applied to

Re: cw1200: fix spelling mistake: "Mailformed" -> "Malformed"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in wiphy_warn warning message text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: ath6kl: fix spelling mistake: "chache" -> "cache"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, tha

Re: ath9k: dfs: remove accidental use of stack VLA

t; "const"). This just replaces it with a #define. > > Also, fixed as part of the directive to remove all VLAs from > the kernel: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > Signed-off-by: Kalle Valo <kv...@

Re: ath10k: fix spelling mistake: "tiggers" -> "triggers"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, tha

Re: [next] wil6210: fix potential null dereference of ndev before null check

rityScan, CID#1467010 ("Dereference before null check") > > Fixes: e00243fab84b ("wil6210: infrastructure for multiple virtual > interfaces") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Maya Erez <me...@codeaurora.org> > Sign

Re: ath10k: avoid possible string overflow

low, using strlcat() instead of strncat() avoids the warning and > makes the code more robust. > > Fixes: bc64d05220f3 ("ath10k: debugfs support to get final TPC stats for 10.4 > variants") > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Kalle Valo &l

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Ulf Hansson <ulf.hans...@linaro.org> writes: > On 20 March 2018 at 10:55, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend van Spriel <arend.vanspr...@broadcom.com> writes: >> >>>>> If I get it right, you mean something like this: >>>>

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Kalle Valo <kv...@codeaurora.org> writes: > Joe Perches <j...@perches.com> writes: > >> Use the new ether_broadcast_addr global instead to save some object code. >> >> Signed-off-by: Joe Perches <j...@perches.com> >> --- >> drivers/net/wirel

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

to what tree the patches are meant for. Otherwise I, and other maintainers as well, need to waste time trying to guess what's your plan. I will now drop the four wireless patches from my queue. So if you want to me to take them please resubmit. -- Kalle Valo

pull-request: wireless-drivers-next 2018-03-29

hannes Berg (1): iwlwifi: mvm: fix error checking for multi/broadcast sta Kalle Valo (7): Merge tag 'iwlwifi-for-kalle-2018-03-16' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018-03-19' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merg

Re: ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr

Joe Perches <j...@perches.com> wrote: > Remove the static array and use the generic routine to set the > Ethernet broadcast address. > > Signed-off-by: Joe Perches <j...@perches.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to a

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

(really adding Bjorn) Ramon Fried <rfr...@codeaurora.org> writes: > (adding Bjorn Andersson) > > > On 3/29/2018 10:15 AM, Kalle Valo wrote: >> (adding devicetree list) >> >> Ramon Fried <rfr...@codeaurora.org> writes: >> >>> wcn

Re: [PATCH v2] wcn36xx: Disable 5GHz for wcn3610

quot;)) > + wcn->rf_id = RF_IRIS_WCN3610; > of_node_put(iris_node); > } Should we document qcom,wcn3610 just like wcn3620 is: Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt: "qcom,wcn3620", -- Kalle Valo

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

; Signed-off-by: Colin Ian King <colin.k...@canonical.com> [...] > Reviewed-by: Maya Erez <me...@codeaurora.org> Maya, as you are the wil6210 maintainer you can actually use Acked-by instead of Reviewed-by. Not that it really matters which one you use, both of them indicate me that you have checked and agree the patch, but wanted to point out this anyway :) -- Kalle Valo

Re: rtlwifi: rtl8821ae: fix spelling mistake: "Aboslute" -> "Absolute"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in RT_TRACE message text. > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger

Re: [next] rsi: remove redundant duplicate assignment of buffer_size

Colin Ian King wrote: > From: Colin Ian King > > Variable buffer_size is re-assigned the same value, this duplicated > assignment is redundant and can be removed. > > Cleans up clang warning: > drivers/net/wireless/rsi/rsi_91x_usb.c:140:4:

Re: [v2] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The use of stack Variable Length Arrays needs to be avoided, as they > can be a vector for stack exhaustion, which can be both a runtime bug > (kernel Oops) or a security flaw (overwriting memory beyond the > stack). Also, in general, as code evolves it

Re: [2/4] wireless: Use octal not symbolic permissions

Joe Perches wrote: > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > > Signed-off-by: Joe Perches

Re: [v3] Bluetooth: btrsi: rework dependencies

Arnd Bergmann wrote: > The linkage between the bluetooth driver and the wireless > driver is not defined properly, leading to build problems > such as: > > warning: (BT_HCIRSI) selects RSI_COEX which has unmet direct dependencies > (NETDEVICES && WLAN && WLAN_VENDOR_RSI &&

pull-request: wireless-drivers-next 2018-03-24

Hi Dave, here's the first pull request to net-next for 4.17. What's special here is the addition of a new bluetooth driver, but that's been acked by Marcel. Also we add a new include file to include/net because of that. Please let me know if you have any problems. Kalle The following changes

pull-request: wireless-drivers 2018-03-24

): iwlwifi: mvm: fix error checking for multi/broadcast sta Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2018-03-16' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018-03-19' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Luca Coelho (1

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

ubmitter was proposing to have a bounce buffer in ath10k to workaround that. I don't remember the details anymore, they are on the ath10k mailing list archive if anyone is curious to know, but I would not be surprised if they are similar as here. So there might be a need to solve this in a generic way (but not sure of course as I haven't checked the details). -- Kalle Valo

Re: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings

/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Why net-next? To me it looks like this should go to wireless-drivers-next. -- Kalle Valo

Re: [V2] brcmfmac: drop Inter-Access Point Protocol packets by default

Rafał Miłecki wrote: > From: Rafał Miłecki > > Testing brcmfmac with more recent firmwares resulted in AP interfaces > not working in some specific setups. Debugging resulted in discovering > support for IAPP in Broadcom's firmwares. > > Older firmwares were only generating

Re: [PATCH] [v2] Bluetooth: btrsi: rework dependencies

>> --- >>> drivers/bluetooth/Kconfig| 4 +--- >>> drivers/net/wireless/rsi/Kconfig | 4 +++- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> Acked-by: Marcel Holtmann <mar...@holtmann.org> >> >> Since I think Kalle still has to take it through his tree until the >> btrsi driver makes it into net-next. Yes, I have to take this as I haven't sent the original patch to Dave yet. > Kalle, please wait for v3 though, I just ran into another build > failure caused by a typo in v2. Ok, I saw it. -- Kalle Valo

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

ers/net/wireless/cisco/Kconfig | 2 +- Acked-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > On 3/14/2018 5:10 PM, Kalle Valo wrote: >> Rafał Miłecki <ra...@milecki.pl> writes: >> >>>>> + unsigned char *eth_data = skb_mac_header(skb) + ETH_HLEN; >>>>> +#if !defined(

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" <m...@tobin.cc> writes: > On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote: >> "Tobin C. Harding" <m...@tobin.cc> writes: >> >> > Added Konstantin in case he is in charge of administering >> > patchwo

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

> good exceuse? Could it be there any some good reason for #if defined()? Don't know, maybe just a matter of taste? But it would be nice to know the background behind #ifdef vs #if defined(), never figured it out why two different forms. -- Kalle Valo

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

Arend van Spriel <arend.vanspr...@broadcom.com> writes: > On 3/14/2018 3:24 PM, Kalle Valo wrote: >>> +config BRCMFMAC_IAPP >>> >+ bool "Partial support for obsoleted Inter-Access Point Protocol" >>> >+ depends on BRCMFMAC >>> &

Re: [PATCH] brcmfmac: drop Inter-Access Point Protocol packets by default

data; > + const u16 *b = (const u16 *)iapp_l2_update_packet; > +#endif > + > + if (skb->len - skb->mac_len != 6 || > + !is_multicast_ether_addr(eth_hdr(skb)->h_dest)) > + return false; > + > +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) #ifdef? -- Kalle Valo

Re: [RESEND] rsi: Remove stack VLA usage

.cc> wrote: >> > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <m...@tobin.cc> wrote: >> >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> >> >> tchard

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" <m...@tobin.cc> writes: > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: >> On Tue, Mar 13, 2018 at 10:17 PM, tcharding <m...@tobin.cc> wrote: >> > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >>

Re: [RESEND] rsi: Remove stack VLA usage

tcharding <m...@tobin.cc> writes: > On Mon, Mar 12, 2018 at 09:46:06AM +0000, Kalle Valo wrote: >> tcharding <m...@tobin.cc> wrote: >> >> > The kernel would like to have all stack VLA usage removed[1]. rsi uses >> > a VLA based on 'blksize'.

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to

Re: net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

dropping one of those spaces, it also needs some other word > inserted there. Instead of putting each vendor's name there, I chose > to say "these" cards in all of the Kconfig help text. > > Cc: Kalle Valo <kv...@codeaurora.org> > Signed-off-by: Randy Dunlap <

Re: [RESEND] rsi: Remove stack VLA usage

tcharding wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing -- Kalle Valo

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

rs/net/wireless/ath/ath9k/dfs.c > 626ab67 ath9k: dfs: use swap macro in ath9k_check_chirping > 50c8cd4 ath9k: remove cast to void pointer > 8fc2b61 ath9k: DFS - add pulse chirp detection for FCC > Yeah, just "ath9k:" is enough as the prefix, no need to have full directory path in the title. -- Kalle Valo

Re: [PATCH] rsi: Remove stack VLA usage

nstant and declare the array to maximum size. We add a check before > accessing the array in case of programmer error. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Tobin C. Harding <m...@tobin.cc> Please CC linux-wireless list, otherwise patchwork won't see the patch and I can't apply it. -- Kalle Valo

pull-request: wireless-drivers 2018-03-08

Ilan Peer (2): iwlwifi: mvm: Direct multicast frames to the correct station iwlwifi: mvm: Correctly set the tid for mcast queue Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2018-02-16-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge tag 'iwlwifi-for-kalle-2018

Re: rtl8187: Fix NULL pointer dereference in priv->conf_mutex

Sudhir Sreedharan wrote: > This can be reproduced by bind/unbind the driver multiple times > in AM3517 board. > > Analysis revealed that rtl8187_start() was invoked before probe > finishes(ie. before the mutex is initialized). > > INFO: trying to register non-static

Re: ath5k: remove duplicated re-assignment to pointer 'tq'

ireless/ath/ath5k/qcu.c:326:25: warning: Value stored > to 'tq' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks.

Re: brcmsmac: remove duplicated bit-wise or of IEEE80211_CHAN_NO_IR

Colin Ian King wrote: > From: Colin Ian King > > Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice; > remove the redundant 2nd IEEE80211_CHAN_NO_IR > > Signed-off-by: Colin Ian King Patch applied to

Re: rtlwifi: rtl8192cu: remove pointless memcpy

Arnd Bergmann wrote: > gcc-8 points out that source and destination of the memcpy() are > always the same pointer, so the effect of memcpy() is undefined > here (its arguments must not overlap): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function >

Re: [v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

Matthias Kaehlcke wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned

Re: wireless: zd1211rw: remove redundant assignment of pointer 'q'

Colin Ian King wrote: > From: Colin Ian King > > Pointer q is initialized and then almost immediately afterwards being > re-assigned the same value. Remove the second redundant assignment. > > Cleans up clang warning: >

Re: brcm80211: remove duplicated bit-wise or of IEEE80211_CHAN_NO_IR

Colin Ian King wrote: > From: Colin Ian King > > Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice; > remove the redundant 2nd IEEE80211_CHAN_NO_IR > > Signed-off-by: Colin Ian King The prefix should

Re: [v2,1/6] wl1251: Update wl->nvs_len after wl->nvs is valid

Pali Rohár wrote: > If kmemdup fails, then wl->nvs_len will contain invalid non-zero size. > > Signed-off-by: Pali Rohár > Acked-by: Pavel Machek 4 patches applied to wireless-drivers-next.git, thanks. f63b4c971f5f wl1251: Update wl->nvs_len after wl->nvs

Re: [next] wil6210: fix spelling mistake: "preperation"-> "preparation"

Colin Ian King <colin.k...@canonical.com> wrote: > Trivial fix to spelling mistake in debug error message text. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Kalle Valo <kv...@codeaurora.org> Patch applied to ath-next branch of

Re: [PATCH v2] qrtr: add MODULE_ALIAS macro to smd

a part of a patchset. > --- > net/qrtr/smd.c | 1 + > 1 file changed, 1 insertion(+) The change log should be after "---" line so that git-am can discard it automatically. Now the changelog would be part of git commit log and we don't want that. So please submit v3. -- Kalle Valo

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

i! Are there any comments for first 4 patches? If not, could they be >> > accepted and merged? >> >> Since the first 4 patches do not touch the firmware API they seem fine to me >> so >> long as the maintainer accepts them. Maybe resend and clarify you have >> dropped >> the other ones and amend with the new tags. > > According to get_maintainer.pl, Kalle Valo is maintainer. > > Kalle Valo, if you do not have any other comments, can you accept first > 4 patches? Or do you really need to resent first 4 patches again? The first 4 patches are now in my queue, I should get to them in the next few days. -- Kalle Valo

Re: [PATCH] ath9k: turn on btcoex_enable as default

. And bluetooth peripherals are more than ever now, so it > would be great to use BT out of the box. Sure, but we have to make sure that we don't create regressions on existing systems. For example, did you test this with any system which don't support btcoex? (just asking, haven't tested this myself) -- Kalle Valo

pull-request: wireless-drivers-next 2018-02-08

Felix Fietkau (4): mt76: implement AP_LINK_PS mt76: implement processing of BlockAckReq frames mt76: avoid re-queueing A-MPDU rx reorder work if no frames are pending mt76: do not set status->aggr for NULL data frames Kalle Valo (2): Merge git://git.kernel.org/.../kv

pull-request: wireless-drivers-next 2018-01-26

cid to the core for multicast rx mt76: validate rx CCMP PN Igor Mitsyanko (2): qtnfmac: do not use mutexes in timer context qtnfmac: do not use bus mutex for events processing Kalle Valo (1): Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Lior David

Re: pull-request: wireless-drivers 2018-01-26

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Fri, 26 Jan 2018 18:33:33 +0200 > >> this is a pull request to the net tree for 4.15. I hate to do late pull >> requests like this but today Sven Joachim found a se

pull-request: wireless-drivers 2018-01-26

Hi Dave, this is a pull request to the net tree for 4.15. I hate to do late pull requests like this but today Sven Joachim found a serious regression in one of ssb patches, I hope there's still enough time to get this to 4.15. But if it's too late, just let me know and I'll queue this for 4.16.

Re: [v2] wcn36xx: release resources in case of error

Ramon Fried <rfr...@codeaurora.org> wrote: > wcn36xx_dxe_init() doesn't check for the return value of > wcn36xx_dxe_init_descs(), release the resources in case an error ocurred. > > Signed-off-by: Ramon Fried <rfr...@codeaurora.org> > Signed-off-by: Kalle Valo &l

Re: rtl8xxxu: Fix trailing semicolon

Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > Removing it since it doesn't do anything. > > Signed-off-by: Luis de Bethencourt > Acked-by: Jes Sorensen Patch applied to

Re: [PATCH v2] wcn36xx: release resources in case of error

y are called from. It's easier to manage the labels that way. But as this is a style issue I didn't change it. -- Kalle Valo

Re: wcn36xx: release resources in case of error

Ramon Fried wrote: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Signed-off-by: Ramon Fried This is a duplicate. Patch set to Superseded.

Re: wcn36xx: release resources in case of error

Ramon Fried wrote: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Signed-off-by: Ramon Fried This is a duplicate. Patch set to Superseded.

  1   2   3   4   5   6   7   8   9   10   >