about the data loss. Restructure the code to minimise
rollback effort if it happens.
This fix kernel bug #86091
Thanks to Insu Yun <wuni...@gmail.com> to remind me on this issue.
Signed-off-by: Karsten Keil <k...@b1-systems.de>
---
drivers/isdn/mISDN/l
Insu Yun did brinup the issue with not checking the skb_clone() return
value in the layer2 I-frame ull functions.
This series fix the issue in a way which avoid protocol violations/data loss
on a temporary memory shortage.
Karsten Keil (2):
ISDN: fix OOM condition for sending queued I-Frames
queue.
We need to requeue the original skb if the call failed, since the upper
layer cannot be informed about memory shortage.
Thanks to Insu Yun <wuni...@gmail.com> to remind me on this issue.
Signed-off-by: Karsten Keil <k...@b1-systems.de>
---
drivers/isdn/hisax/i
Hi,
On Wed, Jan 09, 2008 at 09:26:53PM +0100, Karsten Keil wrote:
Reading the section you reference, we do follow all the MUST requirements,
and
we log an error. Given that the disable section is a SHOULD, I think we
can at
least be somewhat more restrictive in our implementation
On Wed, Jan 09, 2008 at 03:32:12PM -0800, David Miller wrote:
From: Karsten Keil [EMAIL PROTECTED]
Date: Wed, 9 Jan 2008 16:36:56 +0100
If the address is a link-local address formed from an interface
identifier based on the hardware address, which is supposed to be
uniquely
to be uniquely assigned, IP operation on the interface MAY
be continued.
So I think we should disable the interface now, if DAD fails on a
hardware based LLA.
--
Karsten Keil
SuSE Labs
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
On Wed, Jan 09, 2008 at 11:17:48AM -0500, Neil Horman wrote:
On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote:
Hi,
I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel.
It fails in the Stateless Address Autoconfiguration section with
6 tests.
These tests
IPv6
0: ignore (as we do now)
Argh, 0, 0 and 0, maybe.
I would like this solution, I had something similar to this in mind after I
discovered the issue.
--
Karsten Keil
SuSE Labs
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB
16746 (AG Nuernberg
| | | | | | Address = fe80::2
So how we should handle this issue, claim that the test is wrong, the test
should not use LLA for this ?
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB
16746 (AG
do we have this check in ip6_datagram_connect() ?
The posix manpage for connect says about EINVAL:
EINVAL - The address_len argument is not a valid length for the address
family; or
invalid address family in the sockaddr structure.
Which is not the case here.
--
Karsten Keil
SuSE Labs
ISDN
On Mon, Oct 15, 2007 at 06:44:56PM +0400, Denis V. Lunev wrote:
Compilation fix. The problem appears after
7c076d1de869256848dacb8de0050a3a390f95df by Karsten Keil [EMAIL PROTECTED]
Acked-by: Karsten Keil [EMAIL PROTECTED]
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]
--- ./drivers/isdn/i4l
Hi Dave,
a follow up to the previous patch for net-2.6.24.
On Mon, Oct 08, 2007 at 08:37:33PM -0700, David Miller wrote:
You could try following patch with 2.6.23-rc8-mm2, it change I4L to use
alloc_netdev().
Signed-off-by: Karsten Keil [EMAIL PROTECTED]
I've added this patch
);
check which caused the BUG message.
The regression comes from the net namespace patches.
Up to now in ISDN the struct netdevice is contained in struct isdn_net_dev and
so
it's not allocated using alloc_netdev(), which would set the missing dev-nd_net
pointer.
--
Karsten Keil
SuSE Labs
ISDN
risk for me since I (personally) won't have physical
access to it for a couple days and some people will kill me if the main
internet gateway happened to go down unfixably. ;)
You could try following patch with 2.6.23-rc8-mm2, it change I4L to use
alloc_netdev().
Signed-off-by: Karsten Keil
Hello Steven,
On Mon, Aug 27, 2007 at 09:16:55AM -0700, Stephen Hemminger wrote:
On Mon, 27 Aug 2007 13:02:26 +0200
Karsten Keil [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen Hemminger wrote:
The following driver API is broken on any architecture with 64 bit
On Fri, Aug 24, 2007 at 11:08:11AM -0700, Stephen Hemminger wrote:
The following driver API is broken on any architecture with 64 bit addresses.
because of cast that loses high bits.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/isdn/capi/capidrv.c 2007-06-25
: if (Read_hfc(cs, HFCSX_INT_S1)) ;
--
These are workaround to not get compiler warnings about ignored return
values I got some time ago under some architecture.
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF
+++---
drivers/isdn/hisax/avma1_cs.c | 14 +++---
Acked-by: Karsten Keil [EMAIL PROTECTED]
for ISDN.
drivers/net/pcmcia/3c574_cs.c |9 +++--
drivers/net/pcmcia/smc91c92_cs.c | 27 ---
drivers/net/pcmcia/xirc2ps_cs.c| 19
/teles_cs.c | 17 -
Acked-by: Karsten Keil [EMAIL PROTECTED]
for ISDN.
...
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
of bond-curr_slave_lock - deadlock.
This issue was found by a test lab during network stress tests, this patch
disable the softirq handler for this case and solved the issue.
Signed-off-by: Karsten Keil [EMAIL PROTECTED]
---
drivers/net/bonding/bond_alb.c |4 ++--
1 files changed, 2
of bond-curr_slave_lock - deadlock.
This issue was found by a test lab during network stress tests, this patch
disable the softirq handler for this case and solved the issue.
Signed-off-by: Karsten Keil [EMAIL PROTECTED]
---
drivers/net/bonding/bond_alb.c |4 ++--
1 files changed, 2
)) {
cmd-speed = tp-link_config.active_speed;
cmd-duplex = tp-link_config.active_duplex;
}
- cmd-port = 0;
cmd-phy_address = PHY_ADDR;
cmd-transceiver = 0;
cmd-autoneg = tp-link_config.autoneg;
--
Karsten Keil
SuSE Labs
ISDN development
On Fri, May 12, 2006 at 07:59:54AM -0700, Michael Chan wrote:
ACK. Thanks. Please add sign-off line and send to DaveM.
This time with Signed-off line.
Even with fiber cards ethtool reports that the connected port is TP,
the patch fix this.
Signed-off-by: Karsten Keil [EMAIL PROTECTED
, 0, 0, DM910X },
{ 0x1113, 0x1216, PCI_ANY_ID, PCI_ANY_ID, 0, 0, COMET },
{ 0x1113, 0x1217, PCI_ANY_ID, PCI_ANY_ID, 0, 0, MX98715 },
{ 0x1113, 0x9511, PCI_ANY_ID, PCI_ANY_ID, 0, 0, COMET },
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send
24 matches
Mail list logo
