Re: Races in net_rx_action vs netpoll?

, should I submit an updated patch for 2.6.23, or do you prefer to yank the patch now and try again for 2.6.24? Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send

Re: Races in net_rx_action vs netpoll?

in net_rx_action? I think one reason is that you want to get the kernel oops out even when the machine is so hosed that it doesn't even service softirqs anymore. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax

Re: Races in net_rx_action vs netpoll?

from via softirq, but never from an interrupt handler directly. I also don't think the test_bit() needs to lock out interrupts. The only reason we do it for the RX_SCHED bit is that the RX_SCHED bit and the poll_list change must happen atomically wrt interrupts from the NIC, right? Olaf -- Olaf

Re: Races in net_rx_action vs netpoll?

. Understood. How about the patch below? It takes a similar approach, but it puts the onus on the netpoll code path rather than the general NAPI case. Olaf -- From: Olaf Kirch [EMAIL PROTECTED] Keep netpoll/poll_napi from messing with the poll_list. Only net_rx_action is allowed

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

autoconfiguration daemon capable of doing DHCP, DHCP6, RDNSS, mDNS, you-name-it would be a nice thing. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line

[PATCH] net: Make skb_seq_read unmap the last fragment

From: Olaf Kirch [EMAIL PROTECTED] Make skb_seq_read unmap the last fragment Having walked through the entire skbuff, skb_seq_read would leave the last fragment mapped. As a consequence, the unwary caller would leak kmaps, and proceed with preempt_count off by one. The only (kind of non

Re: very strange inet_sock corruption with rpc

by an inet_timewait_sock, which is a kind of truncated inet_sock. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 1/2] avoid OPEN_MAX in SCM_MAX_FD

that still uses it, it's most likely something that hasn't seen a compiler in years - and will likely continue to do so. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from

Fix for ipv6_setsockopt NULL dereference

I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 Here's a potential fix. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax -- Fix NULL pointer derefence in ipv6_setsockopt

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

to be on the safe side, you should check that you're really looking at a PKTINFO cmsg rather than something else. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

easier to just store the raw control message in the svc_rqst, without looking at its contents, and send it out along with the reply, unchanged. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax

Question on IOAT

expected there to be some kind of interrupt handler that kicks the upper layers when a DMA operation completes. But the interrupt handler seems to be for error reporting exclusively... Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED

[RFC] natsemi cable length woes

Here's a proposed patch that addresses a problem with natsemi NICs and long cables we've been chasing (*sigh*). I'm interested in feedback on how to fix this sanely. Olaf -- From: Olaf Kirch [EMAIL PROTECTED] Subject: natsemi: make

Re: 2.6.19-rc1: Volanomark slowdown

On Wed, Nov 08, 2006 at 02:07:32PM -0800, Tim Chen wrote: In my testing, the CPU utilization is at 100%. So increase in ACKs will cost CPU to devote more time to process those ACKs and reduce throughput. Oh, I see. I would test on a real network with real clients. I doubt you would observe a

Re: 2.6.19-rc1: Volanomark slowdown

On Wed, Nov 08, 2006 at 04:55:18PM +0100, Arjan van de Ven wrote: I wonder if it's an option to use low priority QoS fields for these acks (heck I don't even know if ACKs have such fields in their packet) so that they can get dropped if there are more packets then there is bandwidth Is

Re: 2.6.19-rc1: Volanomark slowdown

On Wed, Nov 08, 2006 at 10:38:52AM -0800, Tim Chen wrote: The patch in question affects purely TCP and not the scheduler. I don't I know. think the scheduler has anything to do with the slowdown seen after the patch is applied. In fixing performance issues, the most obvious explanation

[PATCH] Fix order in inet_init failure path.

This is just a minor buglet I came across by accident - when inet_init fails to register raw_prot, it jumps to out_unregister_udp_proto which should unregister UDP _and_ TCP. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] net/ipv4/af_inet.c |4 ++-- 1 files changed, 2 insertions(+), 2

[RFC IPv6] Disabling IPv6 autoconf

the device first (and thereby triggering DAD). The attached tentative patch makes IPv6 autoconf depend on the availability of IFF_MULTICAST. This is admittedly a bit of a hack, but it makes sense, since DAD and router solicitation do rely on multicast. Any comments? Thanks, Olaf -- Olaf Kirch

[PATCH IPv6] Fix race condition in ipv6_add_addr

. Thanks, Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax From: Keir Fraser [EMAIL PROTECTED] Subject: ipv6_add_addr should install dstentry earlier ipv6_add_addr allocates a struct inet6_ifaddr

Re: [RFC IPv6] Disabling IPv6 autoconf

case they won't have to disable multicasting on the bridge device anymore. I agree, this would be the right long-term fix. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from

Re: [RFC IPv6] Disabling IPv6 autoconf

to submit an updated patch? Thanks, Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: [RFC IPv6] Disabling IPv6 autoconf

address. I tend to agree that it's incorrect to assign an address at all in this case. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev

Re: [RFC IPv6] Disabling IPv6 autoconf

them to use that instead. Thanks for the feedback, Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH netdev-2.6 00/19] e1000: driver update (fixes for 2.6.16)

. Major driver updates at this point would invalidate the QA that has happened on these already. I'll push it into netdev-2.6.git#upstream (and into meta-branch #ALL), which means it is queued for 2.6.17 [2.6.16-git1, really]. Once that Fine with me. Thanks Olaf -- Olaf Kirch | --- o

Re: Strange IPsec freeze/partial fix

the retry again. Yes, that is simpler, and should work as well. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Acked-by: Olaf Kirch [EMAIL PROTECTED] Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax

Strange IPsec freeze/partial fix

It seems that the route xfrm_lookup is given on input can go away when we sleep. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] net/ipv4/route.c | 25 - net/xfrm/xfrm_policy.c | 16 2 files changed, 32 insertions(+), 9 deletions(-) diff -r df2df438c970

Re: e100 oops on resume

On Thu, Jan 26, 2006 at 08:02:37PM +0100, Stefan Seyfried wrote: Will be in the next SUSE betas, so if anything breaks, we'll notice it. I doubt it. As Jesse mentioned, e100_hw_init is called from e100_up, so the call from e100_resume was really superfluous. Olaf -- Olaf Kirch | --- o

Re: e100 oops on resume

to call e100_alloc_cbs early on, while e100_up should avoid calling it a second time if nic-cbs_avail != 0. A tentative patch for testing is attached. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah

Re: e100 oops on resume

On Wed, Jan 25, 2006 at 10:02:40AM +0100, Olaf Kirch wrote: I'm not sure what the right fix would be. e100_resume would probably have to call e100_alloc_cbs early on, while e100_up should avoid calling it a second time if nic-cbs_avail != 0. A tentative patch for testing is attached

Re: e100 oops on resume

taking me a while to set up a system with the ability to resume. I'll ask the folks here to give it a try tomorrow. But I suspect at least some of it will be needed. For instance I assume you'll have to reload to ucode when bringing the NIC back from sleep. Olaf -- Olaf Kirch | --- o --- Nous

[PATCH] rt2x00core: fix mismatched rwsem calls

with an up_write call. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] rt2x00core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: rt2x00-2.0.0-b3/rt2x00core.c === --- rt2x00-2.0.0-b3.orig/rt2x00core.c +++ rt2x00-2.0.0-b3

[PATCH] ipw2200 - do not sleep in ipw_request_direct_scan

wpa_supplicant handle the problem. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] drivers/net/wireless/ipw2200.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6.15/drivers/net/wireless/ipw2200.c

Re: Fw: [Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

into 2.6.11-rc1. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

, and succeeds (maybe). Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Small af_inet6 fix

the ipv6 module. So I'll leave this alone for now. So putting your patch and the sock_register() check together we end up with the following. Looks good to me. Thanks, Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah

Small af_inet6 fix

: inet6_init: cleanup after failed initialization When initialization fails in inet6_init(), we should unregister the PF_INET6 socket ops. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] Index: linux-2.6.14/net/ipv6/af_inet6.c

[PATCH] Prevent oops when printing martian source

. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax From: Olaf Kirch [EMAIL PROTECTED] Subject: [IPv4] Prevent oops when printing martian source In some cases, we may be generating packets