other states we have to dump the same socket
> properties, so lets allow to enable repair mode for these sockets.
>
> The repair mode reveals nothing more for sockets in other states.
>
> Signed-off-by: Andrei Vagin <ava...@openvz.org>
Acked-by: Pavel Emelyanov <xe...@o
On 06/10/2016 02:22 PM, Eggert, Lars wrote:
> Hi,
>
> I see an issue with TCP_REPAIR on kernel 4.6.0, where a migrated connection
> is only sending minimum-sized
> segments (~500 bytes), although the interfaces and path support
> Ethernet-sized MTUs. A connection that
> doesn't use TCP_REPAIR
g bytes in i->addr[].
>
> Fixes: eea68e2f1a00 ("packet: Report socket mclist info via diag module")
> Signed-off-by: Mathias Krause <mini...@googlemail.com>
> Cc: Eric W. Biederman <ebied...@xmission.com>
> Cc: Pavel Emelyanov <xe...@parallels.com>
Acked-by: Pavel Emelyanov <xe...@virtuozzo.com>
not add more memory to socket.
Nonetheless,
Acked-by: Pavel Emelyanov <xe...@parallels.com>
> - In case of fault during the copy we do not return correct errno.
>
> Lets use alloc_skb_with_frags() to cook optimal skbs.
>
> Fixes: 292e8d8c8538 ("tcp: Move rcvq sendi
the rule is added and appears in the ebtables -L output.
Originally developed by Evgeny Kravtsunov.
Prepared against net-2.6 tree.
Signed-off-by: Evgeny Kravtsunov [EMAIL PROTECTED]
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge
David Miller wrote:
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Thu, 21 Feb 2008 15:38:16 +0300
Changelog:
Use the added dev_alloc_name() call to create tunnel device name,
rather than iterate in a hand-made loop with an artificial limit.
Thanks Patrick for noticing this.
Signed-off
the calls to -hash
under this lock read-locked closes this gap.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 4062b88..2328acb 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -358,11 +358,12 @@ struct neighbour
with a '%' in its
name, but all the other places either use the register_netdev(),
or explicitly call dev_alloc_name() before registering, i.e.
do not allow for such names.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 63f6917..6b9744f
Patrick McHardy wrote:
Pavel Emelyanov wrote:
Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can
receive a pre-defined name for a device from the userspace.
Since these drivers call the register_netdevice() after this
(rtnl_lock is held), the device's name may contain
Patrick McHardy wrote:
Pavel Emelyanov wrote:
Patrick McHardy wrote:
It would be nicer to replace the entire hand-made name
allocation to remove the 100 device limit.
Actually, I thought the same, but fixing % in names looks like a
BUG-fix for 2.6.25, while removing the hand-made name
-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index 1d3e5fc..303f105 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -175,7 +175,7 @@ static int svc_sendto(struct svc_rqst *rqstp, struct
xdr_buf *xdr)
size_t base
Joe Perches wrote:
On Wed, 2008-02-20 at 17:02 +0300, Pavel Emelyanov wrote:
There are tree places, which declare the char buf[...] on the stack
to push it later into dprintk(). Since the dprintk sometimes (if the
CONFIG_SYSCTL=n) becomes an empty do { } while (0) stub, these buffers
cause
Patrick McHardy wrote:
Joe Perches wrote:
On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote:
fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN];
Perhaps there should be a DECLARE_RPC_BUF(buf) macro?
#define DECLARE_RPC_BUF(var) char var[MAC_BUF_SIZE] __maybe_unused
as __maybe_unused.
More candidates for patching are found by Joe Perches.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 0822646..b7e179e 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -153,7 +153,7 @@ lockd(struct svc_rqst *rqstp
The -read and -write callbacks act in a very similar way, so
merge these paths to reduce the number of places to patch later.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
fs/proc/proc_sysctl.c | 50 ++--
1 files changed, 11 insertions(+), 39
The do_sysctl_strategy can be static since it's used in
kernel/sysctl.c only.
Besides, move it and parse_table above their callers and
drop the forward declarations.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/linux/sysctl.h |5 --
kernel/sysctl.c| 144
This root keeps ctl tables in one global list, but doesn't allow
for non-init namespaces to write into tables, stored in it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/net_namespace.h |2 ++
net/sysctl_net.c| 33 +
2 files
some memory in run time and
removes the... ugly code, that prepared the tables.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/core/sysctl_net_core.c | 35 +--
1 files changed, 17 insertions(+), 18 deletions(-)
diff --git a/net/core/sysctl_net_core.c b
Hi, David.
Some time ago, when I made the net.core.somaxconn ctl per-namespace,
you told that the approach I used to make some ctl tables read-only
in namespace was not very good and said to improve it. After looking
at other code, I decided, that many ctl variables will have to be
read-only in
?) used in the net sysctls.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
fs/proc/proc_sysctl.c |4 ++--
include/linux/sysctl.h |7 ++-
kernel/sysctl.c| 25 ++---
3 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/fs/proc/proc_sysctl.c b
Daniel Lezcano wrote:
Subject: veth fix dev refcount race
From: Daniel Lezcano [EMAIL PROTECTED]
When deleting the veth driver, veth_close calls netif_carrier_off
for the two extremities of the network device. netif_carrier_off on
the peer device will fire an event and hold a reference on
This counter is currently write-only.
Drawing an analogy with the similar tcp counter, I think
that this one should be pointed by the sockets_allocated
members of sctp_prot and sctpv6_prot.
Or should it be instead removed at all?
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git
The code opening proc entry for each device makes the
same thing, as the single_open does, so remove the
unneeded code.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 57772be..bb31e09 100644
--- a/drivers/net/ibmveth.c
+++ b
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index f93407c..bab72b6 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1151,7 +1151,7 @@ static void fib6_del_route(struct fib6_node *fn, struct
rt6_info **rtp
Everything that is called from netlbl_init() can be marked with
__init. This moves 620 bytes from .text section to .text.init one.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/netlabel/netlabel_cipso_v4.c |2 +-
net/netlabel/netlabel_domainhash.c |2 +-
net/netlabel
Turning them to array and registration in a loop saves
80 lines of code and ~300 bytes from text section.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/netlabel/netlabel_cipso_v4.c | 43 +++
net/netlabel/netlabel_mgmt.c | 79
this is 2.6.25 material, but the patch looks
pretty simple. Should I hold it till 2.6.26?
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index 150579a..d16929c 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
Currently, if the call to netlbl_domhsh_search succeeds the
return result will still be NULL.
Fix that, by returning the found entry (if any).
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/netlabel/netlabel_domainhash.c
b/net/netlabel/netlabel_domainhash.c
index
SCPT already depends in INET, so this doesn't create additional
dependencies.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/sctp/proc.c | 23 ++-
1 files changed, 2 insertions(+), 21 deletions(-)
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index 2499732
This makes the code use a good proc API and the text ~50 bytes shorter.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/sctp/objcnt.c | 85 +++-
1 files changed, 44 insertions(+), 41 deletions(-)
diff --git a/net/sctp/objcnt.c b/net
The seq files API disposes the caller of the difficulty of
checking file position, the length of data to produce and
the size of provided buffer.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/key/af_key.c | 94 +
1 files changed
Mainly this removes ifdef-s from inside the ipsec_pfkey_init.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/key/af_key.c | 35 +++
1 files changed, 27 insertions(+), 8 deletions(-)
diff --git a/net/key/af_key.c b/net/key/af_key.c
index 45c3c27
such style and rework the patch?
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/netlabel/netlabel_unlabeled.c | 28 ++--
1 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/net/netlabel/netlabel_unlabeled.c
b/net/netlabel/netlabel_unlabeled.c
index
The audit_log_start() will expand into an empty do { } while (0)
construction and the audit_ctx becomes unused.
The solution: push current-audit_context into audit_log_start()
directly, since it is not required in any other place in the
calling function.
Signed-off-by: Pavel Emelyanov [EMAIL
This one is called from under this config only, so move
it in the same place.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/netlabel/netlabel_unlabeled.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/netlabel/netlabel_unlabeled.c
b/net/netlabel
Yinghai Lu wrote:
On Tuesday 05 February 2008 11:10:24 pm Pavel Emelyanov wrote:
[snip]
What other info from me is required?
boot log please. with the patch and reverting the patch.
Here they are (attached).
BTW, I found, that the sky2 adapter is broken by this patch as well.
To simplify
Yinghai Lu wrote:
On Wednesday 06 February 2008 12:41:15 am Pavel Emelyanov wrote:
Yinghai Lu wrote:
On Tuesday 05 February 2008 11:10:24 pm Pavel Emelyanov wrote:
[snip]
What other info from me is required?
boot log please. with the patch and reverting the patch.
Here they are (attached
The commit
093af8d7f0ba3c6be1485973508584ef081e9f93
x86_32: trim memory by updating e820
broke my e1000 card: on loading driver says that
e1000: probe of :04:03.0 failed with error -5
and the interface doesn't appear.
With this commit reset everything is OK.
lspci
[snip]
What other info from me is required?
boot log please. with the patch and reverting the patch.
Here they are (attached).
BTW, I found, that the sky2 adapter is broken by this patch as well.
To simplify the analysis, here's their diff:
--- bad-log 2008-02-06 10:06:40.0
Yinghai Lu wrote:
On Tuesday 05 February 2008 09:24:17 am Kok, Auke wrote:
[Added Ingo, Thomas, Justin who signed off on the patch/tested it]
Pavel Emelyanov wrote:
The commit
093af8d7f0ba3c6be1485973508584ef081e9f93
x86_32: trim memory by updating e820
broke my e1000 card
into
the consolidated function.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Noticed-by: Adrian Bunk [EMAIL PROTECTED]
---
diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
index 48ac620..97dc35a 100644
--- a/include/net/inet_hashtables.h
+++ b/include/net/inet_hashtables.h
@@ -389,7
Adrian Bunk wrote:
sysctl_tr_rif_timeout can now become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Pavel Emelyanov [EMAIL PROTECTED]
---
e5accd81b924224d40a3f38204c08cf6896ed79b
diff --git a/net/802/tr.c b/net/802/tr.c
index 3f16b17..18c6647 100644
--- a/net/802
Adrian Bunk wrote:
struct ipv4_devconf can now become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/linux/inetdevice.h |2 --
net/ipv4/devinet.c |2 +-
2 files changed, 1 insertion(+), 3 deletions
Adrian Bunk wrote:
This patch makes the needlessly global nf_ct_path[] static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Pavel Emelyanov [EMAIL PROTECTED]
Thanks, Adrian!
---
6396fbcebe3eb61f7e6eb1a671920a515912b005
diff --git a/net/netfilter/nf_conntrack_standalone.c
b
Adrian Bunk wrote:
Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
([RAW]: Consolidate proc interface.) did not only change raw6_seq_ops
(including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing
functions from there), it also removed the only user of raw6_seq_ops...
The commit
David Miller wrote:
From: Pavel Emelyanov [EMAIL PROTECTED]
Date: Thu, 24 Jan 2008 16:15:13 +0300
The comment about race free view of the set of network
namespaces was a bit hasty. Look (there even can be only
one CPU, as discovered by Alexey Dobriyan and Denis Lunev):
...
Instead, I
We have INET_MATCH, INET_TW_MATCH and INET6_MATCH to test
sockets and twbuckets for matching, but ipv6 twbuckets are
tested manually.
Here's the INET6_TW_MATCH to help with it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/linux/ipv6.h|8
net/ipv6
-559
inet_hash_connect586 25-561
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_hashtables.h |5 ++
net/ipv4/inet_hashtables.c| 32 +-
net/ipv6/inet6_hashtables.c | 93
Add the net parameter to udp_get_port family of calls and
udp_lookup one and use it to filter sockets.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv4/udp.c | 25 ++---
net/ipv6/udp.c | 10 ++
2 files changed, 20 insertions(+), 15 deletions
Add a net argument to inet_lookup and propagate it further
into lookup calls. Plus tune the __inet_check_established.
The dccp and inet_diag, which use that lookup functions
pass the init_net into them.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_hashtables.h | 48
-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_hashtables.h |2 ++
net/ipv4/inet_connection_sock.c |8 +---
net/ipv4/inet_hashtables.c |8 ++--
3 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/include/net/inet_hashtables.h b/include/net
Add a net argument to inet6_lookup and propagate it further.
Actually, this is tcp-v6 implementation of what was done for
tcp-v4 sockets in a previous patch.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/linux/ipv6.h |8
include/net/inet6_hashtables.h
Arnaldo Carvalho de Melo wrote:
Em Thu, Jan 31, 2008 at 03:32:09PM +0300, Pavel Emelyanov escreveu:
These two functions are the same except for what they call
to check_established and hash for a socket.
This saves half-a-kilo for ipv4 and ipv6.
Good stuff!
Yesterday I was perusing
The hashlimit_ipv6_mask() is called from under IP6_NF_IPTABLES
config option, but is not under it by itself.
gcc warns us about it :) :
net/netfilter/xt_hashlimit.c:473: warning: ‘hashlimit_ipv6_mask’ defined but
not used
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net
on the namespace, we didn't get
the one on.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Denis Lunev [EMAIL PROTECTED]
---
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 6b178e1..ff9fb6b 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1344,6
.
is accepted this patch will not break the __inet6_check_est.
logic.
This will also help with per-namespace socket lookup patches
in the nearest future.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
index 5d35a4c..c347860 100644
This is also simple, but introduces more changes, since
then mem counter is altered in more places.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |4 ++--
include/net/ip.h|2 +-
include/net/ipv6.h
Move it to the netns_frags, adjust the usage and
make the appropriate ctl table writable.
Now fragment, that live in different namespaces can
live for different times.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |4 +++-
net/ipv4
. The conntrack_reasm
netns-ization is not done - we have to make at least the
core netfilter per namespace first, but this reasm code
is patched to keep working in the initial namespace.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe netdev
differently,
bu the result is all the tables are in appropriate files.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/ip.h |5 --
include/net/ipv6.h |1 -
include/net/netfilter/ipv6/nf_conntrack_ipv6.h |4
. Each inet_frag_queue is
tagged with this one.
The conntrack_reasm is not netns-izated, so it has
one statis netns_frags instance to keep working in
init namespace.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |8 ++--
include/net/netns/ipv4.h
This is simple - just move the variable from struct inet_frags
to struct netns_frags and adjust the usage appropriately.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |4 +++-
include/net/ip.h|2 +-
include/net/ipv6
Since we have one hashtable to lookup the fragment, having
different secret_interval-s for hash rebuild doesn't make
sense, so move this one to inet_frags.
The inet_frags_ctl becomes empty after this, so remove it.
The appropriate ctl table is kept read-only in namespaces.
Signed-off-by: Pavel
the
hash table as well, which is global.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |2 +-
net/ipv4/inet_fragment.c|8
net/ipv4/ip_fragment.c |2 +-
net/ipv6/netfilter/nf_conntrack_reasm.c
On namespace start we mainly prepare the ctl variables.
When the namespace is stopped we have to kill all the
fragments that point to this namespace.
The inet_frags_exit_net() handles it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |1 +
net/ipv4
Each namespace has to have own tables to tune their
different parameters, so duplicate the tables and
register them.
All the tables in sub-namespaces are temporarily made
read-only.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/netns/ipv4.h |1 +
include/net/netns/ipv6
This is the same as with the timeout variable.
Currently, after exceeding the high threshold _all_
the fragments are evicted, but it will be fixed in
later patch.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_frag.h |4 ++--
net/ipv4/inet_fragment.c
, then this patch fixes it and
besides makes use if the dif variable declared in the function.
Fits both, net-2.6 and net-2.6.25.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/ipv6/inet6_hashtables.c b/net/ipv6/inet6_hashtables.c
index d0b3447..a66a7d8 100644
--- a/net/ipv6
Pull the struct net pointer up to the showing functions
to filter the sockets depending on their namespaces.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/raw.h |3 ++-
net/ipv4/raw.c| 20
net/ipv6/raw.c|4 ++--
3 files changed, 16
To do so, just register the proper subsystem and create files in
-init callbacks.
No other special per-namespace handling for raw sockets is required.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv4/raw.c | 22 +++---
net/ipv6/raw.c | 22
Happily, in all the rest places (-bind callbacks only), that require the
struct net, we have a socket, so get the net from it.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv4/raw.c |2 +-
net/ipv6/raw.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
This requires just to pass the appropriate struct net pointer
into __raw_v[46]_lookup and skip sockets that do not belong
to a needed namespace.
The proper net is get from skb-dev in all the cases.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv4/raw.c | 21
is to be done in a place,
where the parms are really freed. Am I right with that?
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 29b8ee4..cc8a2f1 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1316,8 +1316,6 @@ void
the ipv6_devconf from (e.g. routing
code), so this part of job is to be done after the appropriate
parts are virtualized.
However, after this set user can play with the ipv6_devconf
inside a namespace not affecting the others.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
--
To unsubscribe from
The addrconf sysctls and neigh sysctls are registered and
unregistered always in pairs, so they can be joined into
one (well, two) functions, that accept the struct inet6_dev
and do all the job.
This also get rids of unneeded ifdefs inside the code.
Signed-off-by: Pavel Emelyanov [EMAIL
the ipv6_add_dev()
call for loopback, because this function will need the
net-devconf_dflt pointer to be already set.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/netns/ipv6.h |2 +
net/ipv6/addrconf.c | 82 +++---
2 files
All its users are in net/ipv6/addrconf.c's sysctl handlers.
Since they already have the struct net to get from, the
per-net ipv6_devconf_dflt can already be used.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv6/addrconf.c |6 +++---
1 files changed, 3 insertions(+), 3
This error code will be needed to abort the namespace
creation if needed.
Probably, this is to be checked when a new device is
created (currently it is ignored).
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv6/addrconf.c |6 +++---
1 files changed, 3 insertions(+), 3
This includes passing the net to __addrconf_sysctl_register
and saving this on the ctl_table-extra2 to be used in
handlers (those, needing it).
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv6/addrconf.c | 24 ++--
1 files changed, 14 insertions(+), 10
Actually the net-ipv6.devconf_all can be used in a few places,
but to keep the /proc/sys/net/ipv6/conf/ sysctls work consistently
in the namespace we should use the per-net devconf_all in the
sysctl forwarding handler.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ipv6/addrconf.c
When I studied the neighbor code I puzzled over what
the NUD can mean for quite a long time.
Finally I asked Alexey and he said that this was smth
like neighbor unreachability detection.
Does it worth adding a comment helping future developers
understand what's going on?
Signed-off-by: Pavel
Hi, Patrick.
Pavel Emelyanov wrote:
There are tree paths in it, that set the skb-proto and then
perform common receive manipulations (basically call netif_rx()).
I think, that we can make this code flow easier to understand
by introducing the vlan_set_encap_proto() function (I hope
--264
dn_dev_sysctl576 224-352
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
The feature of ipvs ctls is that the net/ipv4/vs path
is common for core ipvs ctls and for two schedulers,
so I make it exported and re-use it in modules.
Two other .c files required linux/sysctl.h to make the
extern declaration of this path compile well.
Signed-off-by: Pavel Emelyanov [EMAIL
-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/net/ip.h b/include/net/ip.h
index 8be48c8..2ad4d2f 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -177,6 +177,8 @@ extern void inet_get_local_port_range(int *low, int *high);
extern int sysctl_ip_default_ttl;
extern int
This patch includes many places, that only required
replacing the ctl_table-s with appropriate ctl_paths
and call register_sysctl_paths().
Nothing special was done with them.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/appletalk/sysctl_net_atalk.c | 24
This one is almost the same as the hunks in the
first patch, but ax25 tables are created dynamically.
So this patch differs a bit to handle this case.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/ax25/sysctl_net_ax25.c | 27 +--
1 files changed, 5
/addrconf.c. This code is made similar
to those in ipv[46].
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
net/decnet/dn_dev.c| 52 +++--
net/decnet/sysctl_net_decnet.c | 23 +++---
2 files changed, 20 insertions(+), 55
() and removes no longer needed code.
After this the net/netfilter/nf_sysctl.c file contains
the paths only.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/linux/netfilter.h|8 -
include/net/netfilter/nf_conntrack_l3proto.h |2
net/netfilter
and 3 in this series are still applied after this)
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
index fef4442..65ddb25 100644
--- a/include/net/inet_hashtables.h
+++ b/include/net/inet_hashtables.h
@@ -264,37 +264,14
makes the code
more readable.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 4b6dd1e..9a283fc 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -165,6 +165,16 @@ static int neigh_forced_gc(struct neigh_table *tbl
inet_hash_connect 1165 686-479
Exporting this is for dccp module.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
include/net/inet_hashtables.h | 27 ++-
net/ipv4/inet_hashtables.c| 27 +++
2 files
+1
tcp_v4_err 1304 973-331
tcp_v4_rcv 20891744-345
tcp_v4_do_rcv826 462-364
Exporting is for dccp module (used via e.g. inet_lookup).
Signed-off-by: Pavel Emelyanov [EMAIL
236 150 -86
inet_twdr_twcal_tick 395 307 -88
tcp_v4_rcv 17441480-264
tcp_timewait_state_process 975 644-331
Export it for ipv6 module.
Signed-off-by: Pavel Emelyanov [EMAIL
Eric Dumazet wrote:
Pavel Emelyanov a écrit :
This one is used in quite many places in the networking code and
seems to big to be inline.
After the patch net/ipv4/build-in.o loses 725 bytes:
add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725)
function
Hi
The pneigh_lookup/delete silently concerns, that the
key_len of the table is more that 4 bytes. Look:
u32 hash_val = *(u32 *)(pkey + key_len - 4);
The hash_val for the proxy neighbor entry is four last bytes
from the pkey.
But the dn_neigh_tables' key_len is sizeof(__le16), that
Eric Dumazet wrote:
Pavel Emelyanov a écrit :
Eric Dumazet wrote:
Pavel Emelyanov a écrit :
This one is used in quite many places in the networking code and
seems to big to be inline.
After the patch net/ipv4/build-in.o loses 725 bytes:
add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099
the state lock.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 1af522b..1face71 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -759,7 +759,7 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t
*saddr
The LOOPBACK_OVERHEAD is not used in this file at all.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 662b8d1..3d1c743 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -64,8 +64,6 @@ struct pcpu_lstats
.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 5b18315..4add9bd 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -124,8 +124,8 @@ static void __exit vlan_cleanup_module(void)
{
int i;
- vlan_netlink_fini
1 - 100 of 361 matches
Mail list logo
