Re: [PATCH net V2] cxgb4: fix thermal zone build error

2018-11-15 Thread Randy Dunlap
d of IS_ENABLED to fix the issue. > > Fixes: e70a57fa59bb (cxgb4: fix thermal configuration dependencies) > Reported-by: Randy Dunlap > Signed-off-by: Ganesh Goudar Acked-by: Randy Dunlap Thanks. > --- > V2: Fixing spelling mistake and avoid preprocessor conditionals. >

Re: [PATCH] add an initial version of snmp_counter.rst

2018-11-10 Thread Randy Dunlap
On 11/9/18 10:13 AM, yupeng wrote: > The snmp_counter.rst run a set of simple experiments, explains the > meaning of snmp counters depend on the experiments' results. This is > an initial version, only covers a small part of the snmp counters. > > Signed-off-by: yupeng > --- >

Re: [PATCH net-next] net: core: change bool members of struct net_device to bitfield members

2018-10-08 Thread Randy Dunlap
On 10/8/18 1:00 PM, Heiner Kallweit wrote: > bool is good as parameter type or function return type, but if used > for struct members it consumes more memory than needed. > Changing the bool members of struct net_device to bitfield members > allows to decrease the memory footprint of this struct.

Re: [PATCH bpf-next] flow_dissector: fix build failure without CONFIG_NET

2018-09-18 Thread Randy Dunlap
are not compiled and move the BPF_PROG_TYPE > definition in the #ifdef CONFIG_NET block. > > Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") > Reported-by: Randy Dunlap > Signed-off-by: Willem de Bruijn Works for me. Thanks. Acked-by: Randy Du

Re: linux-next: Tree for Jul 25 (netfilter)

2018-07-25 Thread Randy Dunlap
n_nat_ipv4.o: In function `nft_chain_nat_exit': nft_chain_nat_ipv4.c:(.exit.text+0x9): undefined reference to `nft_unregister_chain_type' net/ipv4/netfilter/nft_chain_nat_ipv4.o: In function `nft_chain_nat_init': nft_chain_nat_ipv4.c:(.init.text+0x9): undefined reference to `nft_register_chain_type' Report

[PATCH v2] tcp: identify cryptic messages as TCP seq # bugs

2018-07-17 Thread Randy Dunlap
From: Randy Dunlap Attempt to make cryptic TCP seq number error messages clearer by (1) identifying the source of the message as "TCP", (2) identifying the errors as "seq # bug", and (3) grouping the field identifiers and values by separating them with commas. E.g., t

Re: [PATCH net-next] TCP: make seq # error messages more readable

2018-07-13 Thread Randy Dunlap
On 07/13/2018 06:38 AM, Eric Dumazet wrote: > > > On 07/12/2018 05:48 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Attempt to make cryptic TCP seq number error messages clearer by >> (1) adding the function name, (2) identifying the errors as "seq

[PATCH net-next] TCP: make seq # error messages more readable

2018-07-12 Thread Randy Dunlap
From: Randy Dunlap Attempt to make cryptic TCP seq number error messages clearer by (1) adding the function name, (2) identifying the errors as "seq # bug", and (3) grouping the field identifiers and values by separating them with commas. E.g., the following message is changed from

[PATCH] isdn/capi: fix defined but not used warnings

2018-07-07 Thread Randy Dunlap
From: Randy Dunlap Fix build warnings in drivers/isdn/capi/ when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../drivers/isdn/capi/capi.c:1324:12: warning: 'capi20_proc_show' defined but not used [-Wunused-function] ../drivers/isdn/capi/capi.c:1347:12

[PATCH] connector: fix defined but not used warning

2018-07-07 Thread Randy Dunlap
From: Randy Dunlap Fix a build warning in connector.c when CONFIG_PROC_FS is not enabled by marking the unused function as __maybe_unused. ../drivers/connector/connector.c:242:12: warning: 'cn_proc_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Evgeniy

Re: mmotm 2018-05-25-14-52 uploaded (drivers/net/ethernet/ti/davinci_mdio.c)

2018-05-25 Thread Randy Dunlap
[forgot to add netdev] On 05/25/2018 04:14 PM, Randy Dunlap wrote: > On 05/25/2018 02:52 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-25-14-52 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-re

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Randy Dunlap
On 05/14/2018 02:10 PM, Sean Young wrote: > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. and then patch 3 says a third choice: The context provided to a BPF_PROG_RAWIR_DECODER is a struct

Re: [net 1/1] net/mlx5: Fix build break when CONFIG_SMP=n

2018-05-14 Thread Randy Dunlap
y_hint’: > include/linux/mlx5/driver.h:1299:13: error: > ‘struct irq_desc’ has no member named ‘affinity_hint’ > > Fixes: 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") > Signed-off-by: Saeed Mahameed <sae...@mellanox.com> > CC: Randy Du

Re: linux-next: Tree for May 9 (mlx5)

2018-05-09 Thread Randy Dunlap
On 05/09/2018 04:21 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180508: > on x86_64: # CONFIG_SMP is not set In file included from ../drivers/net/ethernet/mellanox/mlx5/core/main.c:43:0: ../include/linux/mlx5/driver.h: In function 'mlx5_get_vector_affinity_hint':

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Randy Dunlap
ns_rdma. > 4 The function name is wrong in rdma_create_trans() comment. > 5 There is no variable initialized in struct virtio_chan. > 6 The variable name is wrong in p9_virtio_zc_request() comment. > > Signed-off-by: Sun Lianwen <sunlw.f...@cn.fujitsu.com> > Reviewed-by: Randy Dun

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Randy Dunlap
On 05/07/2018 05:45 PM, Sun Lianwen wrote: > There are follow comment errors: > 1 The function name is wrong in p9_release_pages() comment. > 2 The function name and variable name is wrong in p9_poll_workfn() comment. > 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. > 4 The

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Randy Dunlap
Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > Signed-off-by: Sridhar Samudrala > --- > MAINTAINERS|7 + > include/linux/netdevice.h | 16 + > include/net/net_failover.h | 52 +++ > net/Kconfig| 10 + >

Re: [PATCH bpf-next] xsk: fix 64-bit division

2018-05-07 Thread Randy Dunlap
he GCC built-in. > > Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt") > Signed-off-by: Björn Töpel <bjorn.to...@intel.com> I don't know why the subject says xsk (instead of xdp), but anyway: Reported-by: Randy Dunlap <rdun...@infradead.org&g

Re: linux-next: Tree for May 7 (net/xdp)

2018-05-07 Thread Randy Dunlap
On 05/06/2018 10:31 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20180504: > on i386: net/xdp/xdp_umem.o: In function `xdp_umem_reg': xdp_umem.c:(.text+0x47e): undefined reference to `__udivdi3' -- ~Randy

Re: [PATCH] atm: zatm: Fix potential Spectre v1

2018-05-03 Thread Randy Dunlap
On 05/03/2018 11:17 AM, Gustavo A. R. Silva wrote: > pool can be indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/atm/zatm.c:1462 zatm_ioctl() warn: potential

Re: [net-next] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread Randy Dunlap
On 04/27/2018 03:35 AM, Ahmed Abdelsalam wrote: > This patch adds a documentation for seg_flowlabel sysctl into > Documentation/networking/ip-sysctl.txt > > Signed-off-by: Ahmed Abdelsalam > --- > Documentation/networking/ip-sysctl.txt | 13 + > 1 file changed,

Re: [PATCH] fault-injection: reorder config entries

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > This patch reorders Kconfig entries, so that menuconfig displays proper > indentation. > > Signed-off-by: Mikulas Patocka <mpato...@redhat.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Tested-by: Randy Dunlap <rdu

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:57 PM, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, Randy Dunlap wrote: > >> On 04/25/2018 01:02 PM, Mikulas Patocka wrote: >>> >>> >>> From: Mikulas Patocka <mpato...@redhat.com> >>> Subject: [PA

Re: [PATCH v4] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > > > From: Mikulas Patocka > Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options > > This patch introduces a fault-injection option "kvmalloc_fallback". This > option makes kvmalloc randomly fall back to

[PATCH] netfilter: fix nf_tables filter chain type build

2018-04-21 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix build errors due to a missing Kconfig dependency term. Fixes these build errors: net/ipv6/netfilter/nft_chain_nat_ipv6.o: In function `nft_nat_do_chain': net/ipv6/netfilter/nft_chain_nat_ipv6.c:37: undefined reference to `nft_do_chain' ne

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Randy Dunlap
On 04/20/18 13:01, Alexander Duyck wrote: > On Fri, Apr 20, 2018 at 10:23 AM, Randy Dunlap <rdun...@infradead.org> wrote: >> On 04/20/18 09:28, Alexander Duyck wrote: >>> This series is meant to add support for SR-IOV on devices when the VFs are >>> not managed

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Randy Dunlap
On 04/20/18 09:28, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto - https://patchwork.kernel.org/patch/10241225/ > pci-stub -

[PATCH] textsearch: fix kernel-doc warnings and add kernel-api section

2018-04-16 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Make lib/textsearch.c usable as kernel-doc. Add textsearch() function family to kernel-api documentation. Fix kernel-doc warnings in : ../include/linux/textsearch.h:65: warning: Incorrect use of kernel-doc format: * get_next_block - fetc

Re: [PATCH net-next V2] Documentation/networking: Add net DIM documentation

2018-03-21 Thread Randy Dunlap
+int my_driver_handle_interrupt(struct my_driver_entity *my_entity, ...) > +{ > + ... > + /* A struct to hold current measured data */ > + struct net_dim_sample dim_sample; > + ... > + /* Initiate data sample struct with current data */ > + net_dim_sample(my_entity->events, > +my_entity->packets, > +my_entity->bytes, > +_sample); > + /* Call net DIM */ > + net_dim(_entity->dim, dim_sample); > + ... > +} > + > +/* My entity's initialization function (my_entity was already allocated) */ > +int my_driver_init_my_entity(struct my_driver_entity *my_entity, ...) > +{ > + ... > + /* Initiate struct work_struct with my driver's callback function */ > + INIT_WORK(_entity->dim.work, my_driver_do_dim_work); > + ... > +} > Reviewed-by: Randy Dunlap <rdun...@infradead.org> thanks, -- ~Randy

Re: [PATCH net-next] Documentation/networking: Add net DIM documentation

2018-03-21 Thread Randy Dunlap
On 03/21/2018 11:20 AM, Marcelo Ricardo Leitner wrote: > On Wed, Mar 21, 2018 at 11:30:29AM +0200, Tal Gilboa wrote: > ... >> +Dynamic Interrupt Moderation (DIM) (in networking) refers to changing the >> interrupt >> +moderation configuration of a channel in order to optimize packet >>

Re: [PATCH net-next] Documentation/networking: Add net DIM documentation

2018-03-21 Thread Randy Dunlap
On 03/21/2018 02:30 AM, Tal Gilboa wrote: > Net DIM is a generic algorithm, purposed for dynamically > optimizing network devices interrupt moderation. This > document describes how it works and how to use it. > > Signed-off-by: Tal Gilboa > --- >

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-09 Thread Randy Dunlap
On 03/09/2018 04:07 PM, Andrew Morton wrote: > On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote: > >> When max() is used in stack array size calculations from literal values >> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler >> thinks this is a

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-08 Thread Randy Dunlap
On 03/08/2018 11:14 AM, Doug Ledford wrote: > On 3/8/2018 1:04 PM, David Miller wrote: >> From: Saeed Mahameed >> Date: Wed, 7 Mar 2018 17:26:03 -0800 >> >>> Hi Dave and Doug, >>> >>> This series includes shared code updates (IPSec part2) for mlx5 core >>> driver for both

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-05 Thread Randy Dunlap
Hi, On 03/05/2018 05:34 PM, Alexei Starovoitov wrote: > diff --git a/kernel/module.c b/kernel/module.c > index ad2d420024f6..6cfa35795741 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3669,6 +3683,17 @@ static int load_module(struct load_info *info, const > char __user *uargs, >

[PATCH] net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

2018-03-02 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Lots of the wireless driver vendor Kconfig symol help text says "questions about cards." (2 spaces between "about" and "cards") Besides dropping one of those spaces, it also needs some other word inserted there. I

[PATCH] ethernet: natsemi: correct spelling

2018-03-02 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Correct spelling of National Semi-conductor (no hyphen) in drivers/net/ethernet/. Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- drivers/net/ethernet/8390/Kconfig |2 +- drivers/net/ethernet/natsemi/Kconfig |6 +++---

Re: Kernel panic with 4.16-rc1 (and 4.16-rc2) running selftest

2018-02-23 Thread Randy Dunlap
[add Matthew Wilcox; hopefully he can look/see] On 02/23/2018 04:13 PM, Cong Wang wrote: > On Fri, Feb 23, 2018 at 3:27 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Fri, Feb 23, 2018 at 11:00 AM, Randy Dunlap <rdun...@infradead.org> wrote: >>> [adding netde

Re: Kernel panic with 4.16-rc1 (and 4.16-rc2) running selftest

2018-02-23 Thread Randy Dunlap
[adding netdev] On 02/23/2018 08:05 AM, Khalid Aziz wrote: > I am seeing a kernel panic with 4.16-rc1 and 4.16-rc2 kernels when running > selftests > from tools/testing/selftests. Last messages from selftest before kernel panic > are: > > > running psock_tpacket test >

Re: [net-next v2 2/2] bpf: Add eBPF seccomp sample programs

2018-02-17 Thread Randy Dunlap
On 02/16/2018 11:36 PM, Sargun Dhillon wrote: > + close(111); > + assert(errno == EBADF); > + close(999); > + assert(errno = EPERM); should that be == ? > + > + return 0; > +} -- ~Randy

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap <rdun...@infradead.org> wrote: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove km

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/13/2018 02:09 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> On 02/12/2018 04:28 AM, Michael Ellerman wrote: >>> Randy Dunlap <rdun...@infradead.org> writes: >>> >>>> From: Randy Dunlap <rdun...@infr

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Randy Dunlap
On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Randy Dunlap
On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

[PATCH] headers: untangle kmemleak.h from mm.h

2018-02-11 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Currently #includes for no obvious reason. It looks like it's only a convenience, so remove kmemleak.h from slab.h and add to any users of kmemleak_* that don't already #include it. Also remove from source files that do not use it. This is

Re: [PATCH RFC 2/4] netlink: add generic object description infrastructure

2018-02-07 Thread Randy Dunlap
On 02/06/2018 05:37 PM, Pablo Neira Ayuso wrote: > This patch allows netlink busses to provide object descriptions to > userspace, in terms of supported attributes and its corresponding > datatypes. > > Userspace sends a requests that looks like: > > netlink header > NLA_DESC_REQ_BUS

Re: [PATCH v4 04/36] nds32: Kernel booting and initialization

2017-12-19 Thread Randy Dunlap
On 12/17/2017 10:46 PM, Greentime Hu wrote: > From: Greentime Hu > > This patch includes the kernel startup code. It can get dtb pointer > passed from bootloader. It will create a temp mapping by tlb > instructions at beginning and goto start_kernel. > > Signed-off-by:

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap
On 12/19/2017 11:27 AM, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote: >> On 12/19/2017 10:31 AM, Andy Shevchenko wrote: >>> Replace sscanf() with mac_pton(). >>> >>> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.in

Re: [PATCH v1] bridge: Use helpers to handle MAC address

2017-12-19 Thread Randy Dunlap
On 12/19/2017 10:10 AM, Andy Shevchenko wrote: > Use > %pM to print MAC > mac_pton() to convert it from ASCII to binary format, and > ether_addr_copy() to copy. > > Signed-off-by: Andy Shevchenko (same) select GENERIC_NET_UTILS ? >

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap
On 12/19/2017 10:31 AM, Andy Shevchenko wrote: > Replace sscanf() with mac_pton(). > > Signed-off-by: Andy Shevchenko You don't need to select GENERIC_NET_UTILS for that? > --- > drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +--- > 1 file changed, 1

net/wireless/certs/*.x509 binary files

2017-12-18 Thread Randy Dunlap
This is just an FYI/acknowledgment that net/wireless/certs/*.x509 binary file(s) practically kills use of Linux kernel tarballs. Of course, someone can always enable EXPERT and CFG80211_CERTIFICATION_ONUS and disable the REGDB kconfig symbols to get around this. Oh, and then chmod +x

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Randy Dunlap
;> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>>> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>>>> Another week, another rc. >>>> >>>> um (uml) won't build on i386 or x86_64: >>>> CC init/main.o >&

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-11 Thread Randy Dunlap
On 12/11/2017 02:19 AM, Daniel Borkmann wrote: > Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] > > On 12/11/2017 09:32 AM, Richard Weinberger wrote: >> Randy, >> >> Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >>> On 12/10

Re: Linux 4.15-rc3 (uml + bpf_perf_event.h)

2017-12-10 Thread Randy Dunlap
On 12/10/2017 06:08 PM, Linus Torvalds wrote: > Another week, another rc. > um (uml) won't build on i386 or x86_64: CC init/main.o In file included from ../include/linux/perf_event.h:18:0, from ../include/linux/trace_events.h:10, from

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-12-05 Thread Randy Dunlap
On 11/30/2017 02:38 AM, David Laight wrote: > From: Kees Cook >> Sent: 29 November 2017 22:28 >> On Wed, Nov 29, 2017 at 2:07 AM, David Laight >> wrote: >>> From: Linus Torvalds Sent: 29 November 2017 02:29 On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding

[PATCH] cfg80211: fix kernel-doc warnings

2017-12-03 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Drop kernel-doc comment for this value since this value was dropped in a previous commit. Fixes >100 of these warnings: ../include/net/cfg80211.h:3278: warning: Excess enum value 'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flag

Re: [PATCH] leds: trigger: Introduce a NETDEV trigger

2017-11-28 Thread Randy Dunlap
On 11/28/2017 01:54 PM, Ben Whitten wrote: > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 3f9ddb9..4ec1853 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -126,4 +126,11 @@ config LEDS_TRIGGER_PANIC > a different

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-27 Thread Randy Dunlap
Hi, Mostly typos/spellos... On 11/27/2017 09:18 AM, Djalal Harouni wrote: > Cc: Serge Hallyn > Cc: Andy Lutomirski > Suggested-by: Rusty Russell > Suggested-by: Kees Cook > Signed-off-by: Djalal Harouni

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 02:04 PM, Randy Dunlap wrote: > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: >> This macro deduplicates a lot of similar code across the hci_debugfs.c >> module. Targeting to be moved to seq_file.h eventually. >> >> Signed-off-by: Andy Shevchenko <and

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

2017-11-22 Thread Randy Dunlap
On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > This macro deduplicates a lot of similar code across the hci_debugfs.c > module. Targeting to be moved to seq_file.h eventually. > > Signed-off-by: Andy Shevchenko > --- > net/bluetooth/hci_debugfs.c | 184 >

Re: [PATCH net-next v2 0/2] netem: fix compilation on 32 bit

2017-11-14 Thread Randy Dunlap
> 1 file changed, 7 insertions(+), 10 deletions(-) > Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. -- ~Randy

Re: [PATCH] netem: fix 64 bit divide

2017-11-14 Thread Randy Dunlap
er in > nanoseconds") > Reported-by: Randy Dunlap <rdun...@infradead.org> > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> Hi Stephen, I still get it. Maybe it's this % operator: skb->data[prandom_u32() % skb_headlen(skb)] ^=

Re: linux-next: Tree for Nov 14 (net/sched/sch_netem)

2017-11-14 Thread Randy Dunlap
On 11/13/2017 10:20 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.16 material to your linux-next included trees > until v4.15-rc1 has been released. > > Changes since 20171113: on i386: ERROR: "__moddi3" [net/sched/sch_netem.ko] undefined! -- ~Randy

[PATCH] textsearch: fix typos in library helpers

2017-10-20 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix spellos (typos) in textsearch library helpers. Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- lib/ts_fsm.c |2 +- lib/ts_kmp.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- lnx-414-rc5.orig/lib/ts_fsm.c

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-11 Thread Randy Dunlap
On 10/11/17 11:01, Stephen Hemminger wrote: > On Sun, 8 Oct 2017 16:39:16 +0200 > Petr Vorel wrote: > >> Signed-off-by: Petr Vorel > > Ok, applied. But iproute2 is really limited to Linux and bash is lingua > franca on Linux > no French, please.

Re: [PATCH v4 4/4] samples/bpf: Add documentation on cross compilation

2017-09-20 Thread Randy Dunlap
On 09/20/17 09:11, Joel Fernandes wrote: > Acked-by: Alexei Starovoitov > Signed-off-by: Joel Fernandes > --- > samples/bpf/README.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/samples/bpf/README.rst b/samples/bpf/README.rst >

[PATCH] Documentation: networking: fix ASCII art in switchdev.txt

2017-09-16 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix ASCII art in Documentation/networking/switchdev.txt: Change non-ASCII "spaces" to ASCII spaces. Change 2 erroneous '+' characters in ASCII art to '-' (at the '*' characters

Re: [PATCH] Documentation: fix ascii art in networking docs

2017-09-16 Thread Randy Dunlap
On 09/16/17 11:18, Andreas Schwab wrote: > On Sep 16 2017, Pavel Machek wrote: > >> diff --git a/Documentation/networking/switchdev.txt >> b/Documentation/networking/switchdev.txt >> index 5e40e1f..6309e90 100644 >> --- a/Documentation/networking/switchdev.txt >> +++

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 10:36 AM, David Miller wrote: > From: Randy Dunlap <rdun...@infradead.org> > Date: Tue, 15 Aug 2017 09:41:53 -0700 > >> On 08/15/2017 06:51 AM, Neal Cardwell wrote: >>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah >>> <mohamed.a.alrs

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 06:08 AM, mohamedalrshah wrote: > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > index 91a2557..474f72c 100644 > --- a/net/ipv4/Kconfig > +++ b/net/ipv4/Kconfig > @@ -677,6 +677,17 @@ config TCP_CONG_BBR > bufferbloat, policers, or AQM schemes that do not provide a delay >

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Randy Dunlap
On 08/15/2017 06:51 AM, Neal Cardwell wrote: > On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah > wrote: > >> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight) >> +{ >> + struct tcp_sock *tp = tcp_sk(sk); >> + struct agilesdtcp *ca

Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies

2017-06-13 Thread Randy Dunlap
: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from > PHYs") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Tested-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > drivers/net/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+

Re: mdio-thunder.c:undefined reference to `mdiobus_unregister'

2017-06-12 Thread Randy Dunlap
On 06/11/17 19:14, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 32c1431eea4881a6b17bd7c639315010aeefa452 > commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 net: phy: Allow splitting > MDIO bus/device support from PHYs >

Re: [Regression, 4.12-rc1] Address family not supported by protocol

2017-06-09 Thread Randy Dunlap
[adding netdev] Hi Paul, Did you get anywhere with this? The only difference that I see in the kernel config files is 4.12-rc1 says: # CONFIG_NET_SCH_DEFAULT is not set and 4.11 does not have that kconfig option. On 05/15/17 05:53, Paul Menzel wrote: > Dear Linux folks, > > > When building

[PATCH] net: phy: fix kernel-doc warnings

2017-06-04 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix kernel-doc warnings (typo) in drivers/net/phy/phy.c: ..//drivers/net/phy/phy.c:259: warning: No description found for parameter 'features' ..//drivers/net/phy/phy.c:259: warning: Excess function parameter 'feature' descr

[PATCH] net/phy: fix mdio-octeon dependency and build

2017-05-23 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix build errors by making this driver depend on OF_MDIO, like several other similar drivers do. drivers/built-in.o: In function `octeon_mdiobus_remove': mdio-octeon.c:(.text+0x196ee0): undefined reference to `mdiobus_unregister' mdio-octeon.c:

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Randy Dunlap
On 05/15/17 18:21, Stephen Rothwell wrote: > Hi all, > > Changes since 20170515: > on i386 or x86_64: when CONFIG_INET is not enabled: ../net/core/sock.c: In function 'skb_orphan_partial': ../net/core/sock.c:1810:2: error: implicit declaration of function 'skb_is_tcp_pure_ack'

Re: linux-next: Tree for Apr 26 (net/can/bcm.c)

2017-04-26 Thread Randy Dunlap
On 04/26/17 01:03, Stephen Rothwell wrote: > Hi all, > > Changes since 20170424: > on x86_64: when CONFIG_PROC_FS is not enabled: ../net/can/bcm.c:1541:14: error: 'struct netns_can' has no member named 'bcmproc_dir' ../net/can/bcm.c:1601:14: error: 'struct netns_can' has no member named

[PATCH -next] net/phy: fix phy_bcm_nsp_usb3.c build and kconfig

2017-01-30 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> This driver uses mdio* (PHYLIB) interfaces, so it should select PHYLIB. PHYLIB depends on NETDEVICES to this driver should also depend on NETDEVICES. Fixes these build errors: drivers/built-in.o: In function `nsp_usb3_phy_init': phy-bcm-nsp-

Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

2017-01-09 Thread Randy Dunlap
On 01/09/17 08:32, Vivien Didelot wrote: > Hi Randy, > > Randy Dunlap <rdun...@infradead.org> writes: > >> On 01/08/17 17:18, Florian Fainelli wrote: >>> On 01/08/2017 03:17 PM, Vivien Didelot wrote: >>>> DSA wraps SWITCHDEV, thus select it ins

Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV

2017-01-08 Thread Randy Dunlap
On 01/08/17 17:18, Florian Fainelli wrote: > On 01/08/2017 03:17 PM, Vivien Didelot wrote: >> DSA wraps SWITCHDEV, thus select it instead of depending on it. >> >> Signed-off-by: Vivien Didelot > > Reviewed-by: Florian Fainelli > but

Re: linux-next: Tree for Dec 1 (ethernet/mellanox)

2016-12-01 Thread Randy Dunlap
On 11/30/16 22:42, Stephen Rothwell wrote: > Hi all, > > Changes since 20161130: > on i386: when CONFIG_INET is not enabled: drivers/built-in.o: In function `mlx5e_test_loopback': en_selftest.c:(.text+0x690bde): undefined reference to `ip_send_check' en_selftest.c:(.text+0x690c42): undefined

[PATCH] netdevice.h: fix kernel-doc warning

2016-11-21 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Fix kernel-doc warning in (missing ':'): ..//include/linux/netdevice.h:1904: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]' Signed-off-by: Randy Dunlap <rdun...@infradead.org> --- include/linux/netdevice.h

Re: linux-next: Tree for Nov 9 (netdev, netfilter v6)

2016-11-09 Thread Randy Dunlap
On 11/08/16 20:40, Stephen Rothwell wrote: > Hi all, > > Changes since 20161108: > > The drm-misc tree gained a build failure, so I used the version from > next-20161108. > > The sound-asoc tree still had its build failure, so I used the version > from next-20161028. (similar to yesterday,

Re: linux-next: Tree for Nov 8 (netdev, netfilter)

2016-11-08 Thread Randy Dunlap
CH_SOCKET) || \ IS_ENABLED(CONFIG_NETFILTER_XT_TARGET_TPROXY) and CONFIG_NF_SOCKET_IPV4=y See net/ipv4/netfilter/nf_socket_ipv4.c. Reported-by: Randy Dunlap <rdun...@infradead.org> -- ~Randy

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread Randy Dunlap
On 11/03/16 23:53, Joe Perches wrote: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >>> This introduces the Freescale Data Path Acceleration Architecture >>> +static inline size_t

Re: [net-next RFC v2 9/9] doc: Add LSM / BPF Checmate docs

2016-08-29 Thread Randy Dunlap
On 08/29/16 04:47, Sargun Dhillon wrote: > This adds documentation on how to operate, and develop against the > Checmate LSM and Cgroup controller. > > Signed-off-by: Sargun Dhillon > --- > Documentation/security/Checmate.txt | 54 > + > 1

Re: linux-next: Tree for Aug 16 (mellanox/mlx5 & sound/oss/)

2016-08-16 Thread Randy Dunlap
On 08/15/16 21:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20160815: > on i386: sound/built-in.o:(.data+0x5c): multiple definition of `dev_list' drivers/built-in.o:(.data+0x6aee8): first defined here ld: Warning: size of symbol `dev_list' changed from 8 in drivers/built-in.o to 16

Re: [PATCH] net: bfin_mac: Fix a few spelling fixes

2016-08-14 Thread Randy Dunlap
On 08/12/16 05:58, LABBE Corentin wrote: > This patch respell some word badly spelled. > - Invidate instead of Invalidate > - proble instead of probe > > Signed-off-by: LABBE Corentin > --- > drivers/net/ethernet/adi/bfin_mac.c | 8 > 1 file changed, 4

Re: [RFC V2 PATCH 01/25] net: introduce NET policy

2016-08-04 Thread Randy Dunlap
On 08/04/16 12:36, kan.li...@intel.com wrote: > From: Kan Liang > > This patch introduce NET policy subsystem. If proc is supported in the > system, it creates netpolicy node in proc system. > > Signed-off-by: Kan Liang > --- >

Re: [RFC PATCH 30/30] Documentation/networking: Document net policy

2016-07-18 Thread Randy Dunlap
On 07/17/16 23:56, kan.li...@intel.com wrote: > From: Kan Liang > > Signed-off-by: Kan Liang > --- > Documentation/networking/netpolicy.txt | 158 > + > 1 file changed, 158 insertions(+) > create mode 100644

Re: [patch net-next 2/2] devlink: fix trace format string

2016-07-14 Thread Randy Dunlap
acing facility") > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Thanks. > --- > include/trace/events/devlink.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/devlink

Re: [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint

2016-07-14 Thread Randy Dunlap
On 07/14/16 02:37, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > Turned on that driver->owner which is struct module is not available when > modules are disabled. Better to depend on a driver name which is > always available. > > Reported-by: Randy

Re: linux-next: Tree for Jul 13 (net/core/devlink with Tracing)

2016-07-13 Thread Randy Dunlap
On 07/12/16 23:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20160712: > on x86_64: (full randconfig file is attached) CC net/core/devlink.o In file included from ../include/trace/define_trace.h:95:0, from ../include/trace/events/devlink.h:51,

Re: [PATCH] of_mdio: select fixed phy support unconditionally

2016-06-25 Thread Randy Dunlap
gt; a small increase in code size for cases that do not need fixed phy > support, but it should avoid all of the link-time problems. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: d1bd330a229f ("of_mdio: Enable fixed PHY support if driver is a > module")

Re: Regarding VRF support in Linux Kernel

2016-06-22 Thread Randy Dunlap
On 06/22/16 14:05, Ajith Adapa wrote: > Hi, > > I am following the steps present in > (https://www.kernel.org/doc/Documentation/networking/vrf.txt) and > trying to create IPv4 VRF in latest Fedora 24 distribution with 4.5 > Linux kernel. > > [root@localhost ip]# uname -a > Linux

Re: linux-next: Tree for Mar 21 (openvswitch)

2016-03-21 Thread Randy Dunlap
On 03/20/16 21:13, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.7 related material to your linux-next included > trees until after v4.6-rc1 is released. > > Changes since 20160318: > on i386: ERROR: "nf_nat_icmp_reply_translation" [net/openvswitch/openvswitch.ko] undefined!

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/09/16 09:07, Randy Dunlap wrote: > On 03/09/16 08:48, Daniel Borkmann wrote: >> On 03/09/2016 05:44 PM, Randy Dunlap wrote: >>> On 03/08/16 21:38, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20160308: >&g

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/09/16 08:48, Daniel Borkmann wrote: > On 03/09/2016 05:44 PM, Randy Dunlap wrote: >> On 03/08/16 21:38, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20160308: >> >> on x86_64: >> >> ../net/core/filter.c: In function 'bp

Re: linux-next: Tree for Mar 9 (net: bpf)

2016-03-09 Thread Randy Dunlap
On 03/08/16 21:38, Stephen Rothwell wrote: > Hi all, > > Changes since 20160308: > on x86_64: ../net/core/filter.c: In function 'bpf_skb_get_tunnel_opt': ../net/core/filter.c:1824:2: error: implicit declaration of function 'ip_tunnel_info_opts_get' [-Werror=implicit-function-declaration]

Re: linux-next: Tree for Dec 31 (net/xfrm/xfrm_input.c)

2015-12-31 Thread Randy Dunlap
On 12/31/15 04:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20151223: > seen on i386 or x86_64: In file included from ../net/xfrm/xfrm_input.c:17:0: ../include/net/ip6_tunnel.h: In function 'ip6tunnel_xmit': ../include/net/ip6_tunnel.h:93:2: error: implicit declaration of function

  1   2   3   >