From: Herbert Xu [EMAIL PROTECTED]
Date: Sat, 28 Apr 2007 15:52:46 +1000
==
Remove NETIF_F_INTERNAL_STATS: default to internal stats.
Herbert Xu conviced me that a new flag was overkill; every driver
currently overrides get_stats, so we might as well make the internal
one the
On Sat, Apr 28, 2007 at 03:46:01PM +1000, Rusty Russell wrote:
OK, I did a quick check, and the only one I could find was br_if.c which
calls register_netdevice() and doesn't set get_stats. I don't think
that zeroes in this case matters.
Thanks for following up on this Rusty!
Actually I
From: Herbert Xu [EMAIL PROTECTED]
Date: Wed, 11 Apr 2007 22:23:17 +1000
On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:
Actually, I did this precisely because I really didn't want to start
exposing bogus stats in /proc/net/dev. An audit might clarify if this
is an
Hi:
[NET]: Get rid of NETIF_F_INTERNAL_STATS
The recently added NETIF_F_INTERNAL_STATS isn't very useful. If the
device driver needs to set it then it can always override get_stats
instead. All existing drivers that have stats (which should be every
one) will override get_stats anyway. Those
On Wed, 2007-04-11 at 17:56 +1000, Herbert Xu wrote:
Hi:
[NET]: Get rid of NETIF_F_INTERNAL_STATS
The recently added NETIF_F_INTERNAL_STATS isn't very useful. If the
device driver needs to set it then it can always override get_stats
instead. All existing drivers that have stats (which
On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:
Actually, I did this precisely because I really didn't want to start
exposing bogus stats in /proc/net/dev. An audit might clarify if this
is an actual issue.
Fair enough. Still returning zeros when get_stats isn't available
