Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-06 Thread Jarek Poplawski
On 04-12-2006 16:34, Patrick McHardy wrote: Fix a regression from my nfmark mask patch for cls_fw. Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below mentioned race. Sorry for eavesdropping, but have a look at htb_classify

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-06 Thread Patrick McHardy
Jarek Poplawski wrote: On 04-12-2006 16:34, Patrick McHardy wrote: Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below mentioned race. Sorry for eavesdropping, but have a look at htb_classify starting comment. It is also

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-05 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 04 Dec 2006 16:34:46 +0100 [NET_SCHED]: cls_fw: fix NULL pointer dereference When the first fw classifier is initialized, there is a small window between the -init() and -change() calls, during which the classifier is active

[NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread Patrick McHardy
Fix a regression from my nfmark mask patch for cls_fw. Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below mentioned race. [NET_SCHED]: cls_fw: fix NULL pointer dereference When the first fw classifier is initialized

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread jamal
On Mon, 2006-04-12 at 16:34 +0100, Patrick McHardy wrote: Fix a regression from my nfmark mask patch for cls_fw. Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below mentioned race. AFAIK, that has been there forever. Alexey

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread Thomas Graf
* jamal [EMAIL PROTECTED] 2006-12-04 11:25 On Mon, 2006-04-12 at 16:34 +0100, Patrick McHardy wrote: Fix a regression from my nfmark mask patch for cls_fw. Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below mentioned

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread Patrick McHardy
Thomas Graf wrote: * jamal [EMAIL PROTECTED] 2006-12-04 11:25 On Mon, 2006-04-12 at 16:34 +0100, Patrick McHardy wrote: Fix a regression from my nfmark mask patch for cls_fw. Thomas, Jamal, do you have an idea what this old method stuff is used for? It seems it is only used during the below

Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference

2006-12-04 Thread Thomas Graf
* Patrick McHardy [EMAIL PROTECTED] 2006-12-04 17:39 It just seems this code is entirely useless and the only thing it does is cause short term unexpected behaviour during the race I mentioned. Yes, the whole head == NULL branch should be removed. One thing we should probably do is to move