Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Thomas Graf
* Harald Welte [EMAIL PROTECTED] 2005-07-30 12:30 This (long-awaited) patch adds the generic nfnetlink-based userspace logging. nfnetlink_log can be used for any protocol family, and supports upt to 65535 logging groups (that could go to separate logging daemons, e.g.). Same very minor

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 01:20:39PM +0200, Thomas Graf wrote: * Harald Welte [EMAIL PROTECTED] 2005-07-30 12:30 This (long-awaited) patch adds the generic nfnetlink-based userspace logging. nfnetlink_log can be used for any protocol family, and supports upt to 65535 logging groups (that

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Subject: Re: [PATCH] add new nfnetlink_log subsystem Date: Thu, 4 Aug 2005 00:19:41 +0200 no, it hasn't. I am travelling and don't have the space for a debian/i386 installation in addition to the debian/x86_64 on this box, sorry :( That sounds risky. I

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Andi Kleen
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote: From: Harald Welte [EMAIL PROTECTED] Date: Thu, 4 Aug 2005 00:03:53 +0200 However, all nfnetlink-based protocols are supposed to be both endian and 32/64 as well as alignment (*) safe. the protocol definitions always use

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Harald Welte
On Thu, Aug 04, 2005 at 06:50:42AM -0700, David S. Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Subject: Re: [PATCH] add new nfnetlink_log subsystem Date: Thu, 4 Aug 2005 00:19:41 +0200 no, it hasn't. I am travelling and don't have the space for a debian/i386 installation

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Andi Kleen
Unless I'm overlooking something, to the best of my knowledge I don't think we could still run into any trouble here. Still risky. Here's a different idea. Define a new aligned u64 type and use that on i386 too. Like /* Must be #define because __attribute__ doesn't work on typedefs */

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread Harald Welte
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote: From: Harald Welte [EMAIL PROTECTED] Date: Thu, 4 Aug 2005 00:03:53 +0200 However, all nfnetlink-based protocols are supposed to be both endian and 32/64 as well as alignment (*) safe. the protocol definitions always use

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-03 Thread Andi Kleen
no, it hasn't. I am travelling and don't have the space for a debian/i386 installation in addition to the debian/x86_64 on this box, sorry :( That sounds risky. I would ask for this stuff not being merged before it isn't tested. However, all nfnetlink-based protocols are supposed to be both

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-02 Thread Harald Welte
On Mon, Aug 01, 2005 at 09:54:47PM -0300, Arnaldo Carvalho de Melo wrote: On 8/1/05, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: CC net/netfilter/nfnetlink_queue.o net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': net/netfilter/nfnetlink_queue.c:1030: error:

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-02 Thread Harald Welte
Hi Acme! On Mon, Aug 01, 2005 at 09:54:47PM -0300, Arnaldo Carvalho de Melo wrote: Are you aware of this one? :-) Perhaps Dave commited some mistake while merging, this is on 2.6.14.git latest. Ah, this is with 'make allyesconfig'. Dave's tree is missing the attached patch. -- - Harald

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-01 Thread Arnaldo Carvalho de Melo
CC net/netfilter/nfnetlink_queue.o net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': net/netfilter/nfnetlink_queue.c:1030: error: `proc_net_netfilter' undeclared (first use in this function) net/netfilter/nfnetlink_queue.c:1030: error: (Each undeclared identifier is reported

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-01 Thread Arnaldo Carvalho de Melo
On 8/1/05, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: CC net/netfilter/nfnetlink_queue.o net/netfilter/nfnetlink_queue.c: In function `init_or_cleanup': net/netfilter/nfnetlink_queue.c:1030: error: `proc_net_netfilter' undeclared (first use in this function)

[PATCH] add new nfnetlink_log subsystem

2005-07-30 Thread Harald Welte
Hi Dave! This (long-awaited) patch adds the generic nfnetlink-based userspace logging. nfnetlink_log can be used for any protocol family, and supports upt to 65535 logging groups (that could go to separate logging daemons, e.g.). The patch is incremental to my nf_log update in [EMAIL