On Sat, 6 Jan 2007 20:09:36 +0100, Ivo Van Doorn wrote:
[...]
@@ -359,7 +361,7 @@ static int ieee80211_ioctl_remove_sta(struct
net_device *dev,
The patch is line-wrapped here. Applied, but please try to fix your
mail client settings.
Thanks for the patch,
Jiri
--
Jiri Benc
SUSE Labs
-
To
Ivo van Doorn wrote:
+#define __bss_tim_set(__bss, __aid) __set_bit((__aid), (__bss)-tim)
+
__set/clear_bit demands unsigned long, tim is u8. That causes quite some
warnings here.
...
static inline void bss_tim_clear(struct ieee80211_local *local,
struct
On Tue, 2007-01-02 at 16:22 +, Christoph Hellwig wrote:
This really screams to be converted to __set_bit.
Whoops, I should really have jumped into this thread earlier but somehow
missed it.
This cannot be converted to __set_bit because the IEEE specs mandate
this format.
We can insert a
On Fri, 2007-01-05 at 21:08 +0100, Ivo van Doorn wrote:
This patch uses the __set_bit and __clear_but as suggested by Christoph.
It also removes the local argument since it was unused.
NACK. This breaks spec compliance for drivers that use the TIM in their
beacon frames.
johannes
On Sat, 2007-01-06 at 17:52 +0100, Johannes Berg wrote:
On Fri, 2007-01-05 at 21:08 +0100, Ivo van Doorn wrote:
This patch uses the __set_bit and __clear_but as suggested by Christoph.
It also removes the local argument since it was unused.
NACK. This breaks spec compliance for drivers
Johannes Berg wrote:
On Fri, 2007-01-05 at 21:08 +0100, Ivo van Doorn wrote:
This patch uses the __set_bit and __clear_but as suggested by Christoph.
It also removes the local argument since it was unused.
NACK. This breaks spec compliance for drivers that use the TIM in their
beacon
On Sat, 2007-01-06 at 18:00 +0100, Jan Kiszka wrote:
Johannes Berg wrote:
On Fri, 2007-01-05 at 21:08 +0100, Ivo van Doorn wrote:
This patch uses the __set_bit and __clear_but as suggested by Christoph.
It also removes the local argument since it was unused.
NACK. This breaks spec
Bit ordering, I see. Then go for my original patch + comments why this
is open-coded in __bss_tim_set/clear + removed unused arguments from
those functions, OK?
Sounds good to me, care to send a new patch?
This patch returns to the original format for setting and clearing the tim bit,
as
On Tuesday 02 January 2007 17:22, Christoph Hellwig wrote:
On Tue, Jan 02, 2007 at 04:30:41PM +0100, Ivo Van Doorn wrote:
+static inline void __bss_tim_set(struct ieee80211_local *local,
+struct ieee80211_if_ap *bss, int aid)
+{
+ bss-tim[(aid)/8] |= 1((aid)
On 1/1/07, Jan Kiszka [EMAIL PROTECTED] wrote:
Hacking a bit on rt2x00 to make it work in master and ad-hoc mode, lockdep
popped up on some hostapd ioctls, pointing out remaining inconsistencies
related to sta_lock:
1. sta_lock holders must always be protected against softirq
2.
10 matches
Mail list logo
