Re: [PATCH] improved xfrm_audit_log() patch

2007-08-23 Thread Joy Latten
On Wed, 2007-08-22 at 20:05 -0700, David Miller wrote: I would suggest, at this point, to make purpose built situation specific interfaces that pass specific objects (the ones being operated upon) to the audit layer. Let the audit layer pick out the bits it actually wants in the format it

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-23 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 12:15:10 -0500 For example, when auditing the addition of a policy, either xfrm_user_audit_policy_add(xp, result, skb) or pfkey_audit_policy_add(xp, result) will get called. I need two because xfrm_user gets loginuid/secid from

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) Looks good, applied to net-2.6.24, thanks Joy. Something is still buggered up in this patch, you can't add this local audit_info variable unconditionally to these functions, and alternatively you also can't add a

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread Joy Latten
On Wed, 2007-08-22 at 12:51 -0700, David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) Looks good, applied to net-2.6.24, thanks Joy. Something is still buggered up in this patch, you can't add this local audit_info variable

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 20:29:17 -0500 On Wed, 2007-08-22 at 12:51 -0700, David Miller wrote: From: David Miller [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) Looks good, applied to net-2.6.24, thanks Joy. Something is still

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-21 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Wed, 15 Aug 2007 11:16:29 -0500 On Tue, 2007-08-07 at 18:32 -0700, David Miller wrote: From: Joy Latten [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 15:56:47 -0500 @@ -426,10 +426,15 @@ struct xfrm_audit }; #ifdef CONFIG_AUDITSYSCALL -extern

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-15 Thread Joy Latten
On Tue, 2007-08-07 at 18:32 -0700, David Miller wrote: From: Joy Latten [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 15:56:47 -0500 @@ -426,10 +426,15 @@ struct xfrm_audit }; #ifdef CONFIG_AUDITSYSCALL -extern void xfrm_audit_log(uid_t auid, u32 secid, int type, int result, -

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-07 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 15:56:47 -0500 @@ -426,10 +426,15 @@ struct xfrm_audit }; #ifdef CONFIG_AUDITSYSCALL -extern void xfrm_audit_log(uid_t auid, u32 secid, int type, int result, - struct xfrm_policy *xp, struct xfrm_state *x);

[PATCH] improved xfrm_audit_log() patch

2007-08-02 Thread Joy Latten
Sorry for delay, here is xfrm_audit_log() modification with recommended changes. Let me know if this looks better. Regards, Joy Signed-off-by: Joy Latten [EMAIL PROTECTED] diff -urpN linux-2.6.22/include/linux/audit.h linux-2.6.22.patch10/include/linux/audit.h ---