Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-20 Thread Matthew Wilcox
On Tue, Mar 20, 2018 at 10:46:20AM -0400, David Miller wrote: > From: Maor Gottlieb > Date: Tue, 20 Mar 2018 14:41:49 +0200 > > > Saeed, Matan and I okay with this fix as well, it looks like it > > shouldn't impact on the insertion rate. > > I've applied this to net-next,

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-20 Thread David Miller
From: Maor Gottlieb Date: Tue, 20 Mar 2018 14:41:49 +0200 > Saeed, Matan and I okay with this fix as well, it looks like it > shouldn't impact on the insertion rate. I've applied this to net-next, thanks everyone.

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-20 Thread Maor Gottlieb
On 3/20/2018 5:29 AM, Saeed Mahameed wrote: On Thu, 2018-03-15 at 18:30 -0700, Matthew Wilcox wrote: On Thu, Mar 15, 2018 at 11:58:07PM +, Saeed Mahameed wrote: On Wed, 2018-03-14 at 19:57 -0700, Matthew Wilcox wrote: From: Matthew Wilcox The mlx5 driver calls

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-19 Thread Saeed Mahameed
On Thu, 2018-03-15 at 18:30 -0700, Matthew Wilcox wrote: > On Thu, Mar 15, 2018 at 11:58:07PM +, Saeed Mahameed wrote: > > On Wed, 2018-03-14 at 19:57 -0700, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > > > The mlx5 driver calls ida_pre_get() in a loop for

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-15 Thread Matthew Wilcox
On Thu, Mar 15, 2018 at 11:58:07PM +, Saeed Mahameed wrote: > On Wed, 2018-03-14 at 19:57 -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > The mlx5 driver calls ida_pre_get() in a loop for no readily apparent > > reason. The driver uses ida_simple_get()

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-15 Thread Saeed Mahameed
On Wed, 2018-03-14 at 19:57 -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > The mlx5 driver calls ida_pre_get() in a loop for no readily apparent > reason. The driver uses ida_simple_get() which will call > ida_pre_get() > by itself and there's no need to use

[PATCH] mlx5: Remove call to ida_pre_get

2018-03-14 Thread Matthew Wilcox
From: Matthew Wilcox The mlx5 driver calls ida_pre_get() in a loop for no readily apparent reason. The driver uses ida_simple_get() which will call ida_pre_get() by itself and there's no need to use ida_pre_get() unless using ida_get_new(). Signed-off-by: Matthew Wilcox