Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:15:34 -0600 This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a network namespaces is

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-10 Thread Eric W. Biederman
Paul E. McKenney [EMAIL PROTECTED] writes: I know I cannot use get_net for the reference in in /proc because otherwise I could not release the network namespace unless I was to unmount the filesystem, which is not a desirable property. I think I can change the idiom to: struct net

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-10 Thread Eric W. Biederman
Krishna Kumar2 [EMAIL PROTECTED] writes: Eric W. Biederman wrote on 09/09/2007 02:45:34 AM: Hi Eric, +static int register_pernet_operations(struct list_head *list, + struct pernet_operations *ops) +{ snip +out: + return error; + +out_undo: + /* If I have an error

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-10 Thread Pavel Emelyanov
Eric W. Biederman wrote: [snip] --- /dev/null +++ b/include/net/net_namespace.h @@ -0,0 +1,68 @@ +/* + * Operations on the network namespace + */ +#ifndef __NET_NET_NAMESPACE_H +#define __NET_NET_NAMESPACE_H + +#include asm/atomic.h +#include linux/workqueue.h +#include linux/list.h

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-10 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: Eric W. Biederman wrote: [snip] --- /dev/null +++ b/include/net/net_namespace.h @@ -0,0 +1,68 @@ +/* + * Operations on the network namespace + */ +#ifndef __NET_NET_NAMESPACE_H +#define __NET_NET_NAMESPACE_H + +#include asm/atomic.h

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric Dumazet
Eric W. Biederman a écrit : This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a network namespaces is created or destroyed. - struct net. The network namespace data

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
Paul E. McKenney [EMAIL PROTECTED] writes: On Sat, Sep 08, 2007 at 03:15:34PM -0600, Eric W. Biederman wrote: This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
Eric Dumazet [EMAIL PROTECTED] writes: Nice work Eric ! Thanks. struct net is not a very descriptive name imho, why dont stick ns or namespace somewhere ? My fingers rebelled, and struct net seems to be sufficiently descriptive. However that is a cosmetic detail and if there is a general

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Paul E. McKenney
On Sun, Sep 09, 2007 at 04:04:45AM -0600, Eric W. Biederman wrote: Paul E. McKenney [EMAIL PROTECTED] writes: On Sat, Sep 08, 2007 at 03:15:34PM -0600, Eric W. Biederman wrote: This is the basic infrastructure needed to support network namespaces. This infrastructure is: -

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Krishna Kumar2
Eric W. Biederman wrote on 09/09/2007 02:45:34 AM: Hi Eric, +static int register_pernet_operations(struct list_head *list, + struct pernet_operations *ops) +{ snip +out: + return error; + +out_undo: + /* If I have an error cleanup all namespaces I initialized */ +

[PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-08 Thread Eric W. Biederman
This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a network namespaces is created or destroyed. - struct net. The network namespace data structure. This structure

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-08 Thread Paul E. McKenney
On Sat, Sep 08, 2007 at 03:15:34PM -0600, Eric W. Biederman wrote: This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a network namespaces is created or destroyed.