Re: [PATCH 1/3] ne: Add platform_driver

2007-04-28 Thread Andrew Morton
On Wed, 25 Apr 2007 01:54:50 +0900 (JST) Atsushi Nemoto [EMAIL PROTECTED] wrote: @@ -880,4 +964,7 @@ void __exit cleanup_module(void) } } } +#else /* MODULE */ +module_init(ne_init); +module_exit(ne_exit); #endif /* MODULE */ Are we sure about this part? It is

Re: [PATCH 1/3] ne: Add platform_driver

2007-04-28 Thread Atsushi Nemoto
On Sat, 28 Apr 2007 00:57:27 -0700, Andrew Morton [EMAIL PROTECTED] wrote: +#else /* MODULE */ +module_init(ne_init); +module_exit(ne_exit); #endif /* MODULE */ Are we sure about this part? It is unusual to have special treatment dependent upon MODULE. Yes, it is unusual now, but

Re: [PATCH 1/3] ne: Add platform_driver

2007-04-28 Thread Atsushi Nemoto
On Sat, 28 Apr 2007 11:07:26 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: * Add platform_driver interface to ne driver. (Existing legacy ports did not covered by this ne_driver for now) * Make ioaddr 'unsigned long'. * Move a printk down to show dev-name assigned in register_netdev.

[PATCH 1/3] ne: Add platform_driver

2007-04-24 Thread Atsushi Nemoto
Currently ne.c has some codes to support RBTX49XX boards but it is not complete. Instead of adding more hacks to fix it, this patch add an generic platform_driver interface to the driver and let RBTX49XX use it. This is a first step. * Add platform_driver interface to ne driver. (Existing