Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

From: Eric Dumazet Date: Wed, 24 Aug 2016 10:23:34 -0700 > From: Eric Dumazet > > per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

On Wed, 2016-08-24 at 11:04 -0700, Rick Jones wrote: > On 08/24/2016 10:23 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; > > Is it possible it is non-trivially slower on other architectures? No, in

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

On Wed, 2016-08-24 at 11:00 -0700, John Fastabend wrote: > Looks good to me. I guess we can also do the same for overlimit qstats. > > Acked-by: John Fastabend Not sure about overlimit, although I could probably change these : net/sched/act_bpf.c:85:

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

On 08/24/2016 10:23 AM, Eric Dumazet wrote: From: Eric Dumazet per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; Is it possible it is non-trivially slower on other architectures? rick jones Signed-off-by: Eric Dumazet ---

Re: [PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

On 16-08-24 10:23 AM, Eric Dumazet wrote: > From: Eric Dumazet > > per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; > > Signed-off-by: Eric Dumazet > --- > include/net/sch_generic.h |2 +- > 1 file changed, 1 insertion(+), 1

[PATCH net-next] net: minor optimization in qdisc_qstats_cpu_drop()

From: Eric Dumazet per_cpu_inc() is faster (at least on x86) than per_cpu_ptr(xxx)++; Signed-off-by: Eric Dumazet --- include/net/sch_generic.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/sch_generic.h