Re: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-14 Thread Steve Wise
On Tue, 2006-06-13 at 16:46 -0500, Steve Wise wrote: On Tue, 2006-06-13 at 14:36 -0700, Sean Hefty wrote: Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM (see

RE: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-14 Thread Caitlin Bestler
[EMAIL PROTECTED] wrote: On Tue, 2006-06-13 at 16:46 -0500, Steve Wise wrote: On Tue, 2006-06-13 at 14:36 -0700, Sean Hefty wrote: Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM

Re: [PATCH v2 1/2] iWARP Connection Manager.

2006-06-13 Thread Steve Wise
snip +static void cm_event_handler(struct iw_cm_id *cm_id, + struct iw_cm_event *iw_event) +{ + struct iwcm_work *work; + struct iwcm_id_private *cm_id_priv; + unsigned long flags; + + work = kmalloc(sizeof(*work), GFP_ATOMIC); + if (!work) +

RE: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-13 Thread Sean Hefty
Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM (see drivers/infiniband/core/cm.c function cm_recv_handler()). But I think we should at least log an error because a lost event will

RE: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-13 Thread Steve Wise
On Tue, 2006-06-13 at 14:36 -0700, Sean Hefty wrote: Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM (see drivers/infiniband/core/cm.c function cm_recv_handler()). But I think

Re: [PATCH v2 1/2] iWARP Connection Manager.

2006-06-12 Thread Tom Tucker
Andrew, thanks for the review, comments inline... On Thu, 2006-06-08 at 00:54 -0700, Andrew Morton wrote: On Wed, 07 Jun 2006 15:06:05 -0500 Steve Wise [EMAIL PROTECTED] wrote: This patch provides the new files implementing the iWARP Connection Manager. Review Changes: -

Re: [PATCH v2 1/2] iWARP Connection Manager.

2006-06-08 Thread Andrew Morton
On Wed, 07 Jun 2006 15:06:05 -0500 Steve Wise [EMAIL PROTECTED] wrote: This patch provides the new files implementing the iWARP Connection Manager. Review Changes: - sizeof - sizeof() - removed printks - removed TT debug code - cleaned up lock/unlock around switch statements.

[PATCH v2 1/2] iWARP Connection Manager.

2006-06-07 Thread Steve Wise
This patch provides the new files implementing the iWARP Connection Manager. Review Changes: - sizeof - sizeof() - removed printks - removed TT debug code - cleaned up lock/unlock around switch statements. - waitqueue - completion for destroy path. --- drivers/infiniband/core/iwcm.c |