Re: [PATCH v2 4/7] AMSO1100 Memory Management.

2006-06-16 Thread Nick Piggin
Tom Tucker wrote: On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote: On Wed, 07 Jun 2006 15:06:55 -0500 Steve Wise [EMAIL PROTECTED] wrote: +void c2_free(struct c2_alloc *alloc, u32 obj) +{ + spin_lock(alloc-lock); + clear_bit(obj, alloc-table); +

Re: [PATCH v2 4/7] AMSO1100 Memory Management.

2006-06-12 Thread Tom Tucker
On Thu, 2006-06-08 at 01:17 -0700, Andrew Morton wrote: On Wed, 07 Jun 2006 15:06:55 -0500 Steve Wise [EMAIL PROTECTED] wrote: +void c2_free(struct c2_alloc *alloc, u32 obj) +{ + spin_lock(alloc-lock); + clear_bit(obj, alloc-table); + spin_unlock(alloc-lock); +} The

Re: [PATCH v2 4/7] AMSO1100 Memory Management.

2006-06-08 Thread Andrew Morton
On Wed, 07 Jun 2006 15:06:55 -0500 Steve Wise [EMAIL PROTECTED] wrote: +void c2_free(struct c2_alloc *alloc, u32 obj) +{ + spin_lock(alloc-lock); + clear_bit(obj, alloc-table); + spin_unlock(alloc-lock); +} The spinlock is unneeded here. What does all the code in this file

[PATCH v2 4/7] AMSO1100 Memory Management.

2006-06-07 Thread Steve Wise
Review Changes: - sizeof - sizeof() --- drivers/infiniband/hw/amso1100/c2_alloc.c | 256 drivers/infiniband/hw/amso1100/c2_mm.c| 378 + 2 files changed, 634 insertions(+), 0 deletions(-) diff --git