RE: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-26 Thread Dexuan Cui
; Jason Wang > <jasow...@redhat.com>; KY Srinivasan <k...@microsoft.com>; Haiyang Zhang > <haiya...@microsoft.com>; vkuzn...@redhat.com; j...@perches.com > Subject: Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets > > Hi, > > I will be worki

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-26 Thread Cathy Avery
Hi, I will be working with Dexuan to possibly port this functionality into RHEL. Here are my initial comments. Mostly stylistic. They are prefaced by CAA. Thanks, Cathy Avery On 04/07/2016 09:36 PM, Dexuan Cui wrote: Hyper-V Sockets (hv_sock) supplies a byte-stream based communication

RE: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-13 Thread Dexuan Cui
...@canonical.com; jasow...@redhat.com; cav...@redhat.com; KY > Srinivasan <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; > j...@perches.com; vkuzn...@redhat.com > Subject: Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets > > From: Dexuan Cui <

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-13 Thread David Miller
From: Dexuan Cui Date: Thu, 7 Apr 2016 18:36:51 -0700 > +struct vmpipe_proto_header { > + u32 pkt_type; > + u32 data_size; > +} __packed; There is no reason to specify __packed here. The types are strongly sized to word aligned quantities. No holes are possible in

RE: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
> From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, April 8, 2016 9:15 > On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > > diff --git a/include/net/af_hvsock.h b/include/net/af_hvsock.h > [] > > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV (5 * PAGE_SIZE) > > +#define

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Joe Perches
On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. [] > diff --git

[PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-07 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other