Re: [RESEND] [PATCH v2] [1/5] pasemi_mac: minor bugfixes

2007-04-28 Thread Jeff Garzik
Olof Johansson wrote: Ethernet bugfixes: * Move the was_full/wake_queue logic from tx_intr to clean_tx * Fix polarity in checks in pasemi_mac_close Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: linux-2.6/drivers/net/pasemi_mac.c

Re: [RESEND] [PATCH v2] [1/5] pasemi_mac: minor bugfixes

2007-04-28 Thread Olof Johansson
On Sat, Apr 28, 2007 at 11:20:17AM -0400, Jeff Garzik wrote: +if (was_full) +netif_wake_queue(mac-netdev); + Isn't this was_full check redundant? Using standard test-and-clear atomic logic, netif_wake_queue() will not issue spurious wakeups. Take a look at its

[RESEND] [PATCH v2] [1/5] pasemi_mac: minor bugfixes

2007-04-27 Thread Olof Johansson
Ethernet bugfixes: * Move the was_full/wake_queue logic from tx_intr to clean_tx * Fix polarity in checks in pasemi_mac_close Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: linux-2.6/drivers/net/pasemi_mac.c === ---