Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-16 Thread Andrew Morton
Mark Brown [EMAIL PROTECTED] wrote: +if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE || + ecmd-port == PORT_INTERNAL)) { What's PORT_INTERNAL? ethtool doesn't appear to define that. drivers/net/natsemi.c: In function `netdev_set_ecmd':

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-16 Thread Mark Brown
On Thu, Mar 16, 2006 at 01:09:02AM -0800, Andrew Morton wrote: Mark Brown [EMAIL PROTECTED] wrote: + if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE || + ecmd-port == PORT_INTERNAL)) { What's PORT_INTERNAL? ethtool doesn't appear to define that. It should be

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-13 Thread Mark Brown
On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: Not that my opinion should hold much weight, having been absent from the driver for some time, but yuck. Is there no better way to do this thatn sprinkling poo all over it? The changes are mostly isolated into check_link(),

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-13 Thread thockin
On Mon, Mar 13, 2006 at 06:23:31PM +, Mark Brown wrote: On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: Not that my opinion should hold much weight, having been absent from the driver for some time, but yuck. Is there no better way to do this thatn sprinkling poo

[patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-12 Thread Mark Brown
This patch provides a module option which configures the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can be