Re: lockups with netconsole on e1000 on media insertion

2005-08-07 Thread John Bäckstrand
Steven Rostedt wrote: I don't have the card, so I can't test it. But if this works (after removing the previous patch) then this is the better solution. I can confirm that this alone does not work for the simple unplug/re-plug cycle I described, it still locks up hard. Tried this alone on

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread John Bäckstrand
Andi Kleen wrote: The patch was for 2.6.12, did a quick untested port to 2.6.13rc5. -Andi Only try a limited number to send packets in netpoll Thanks, worked nicely! --- John Bäckstrand - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 13:45 +0200, Andi Kleen wrote: John Bäckstrand [EMAIL PROTECTED] writes: I've been trying to hunt down a hard lockup issue with some hardware of mine, but I've possibly hit a kernel bug instead. When using netconsole on my e1000, if I unplug the cable and then

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
This is fixing the symptom and is not the cure. Unfortunately I don't have a e1000 card so I can't try a fix. But I did have a e100 card that would lock up the same way. The problem was that netpoll_poll calls the cards netpoll routine (in e1000_main.c e1000_netpoll). In the e100 case,

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: This is fixing the symptom and is not the cure. Unfortunately I don't have a e1000 card so I can't try a fix. But I did have a e100 card that would lock up the same way. The problem was that netpoll_poll calls the cards netpoll routine

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
On Fri, Aug 05, 2005 at 10:10:13AM -0400, Steven Rostedt wrote: On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: This is fixing the symptom and is not the cure. Unfortunately I don't have a e1000 card so I can't try a fix. But I did have a e100 card that would lock up the same way.

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 16:14 +0200, Andi Kleen wrote: On Fri, Aug 05, 2005 at 10:10:13AM -0400, Steven Rostedt wrote: On Fri, 2005-08-05 at 15:55 +0200, Andi Kleen wrote: This is fixing the symptom and is not the cure. Unfortunately I don't have a e1000 card so I can't try a fix. But I

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread David S. Miller
From: Steven Rostedt [EMAIL PROTECTED] Date: Fri, 05 Aug 2005 10:27:06 -0400 Darn it, since this should really be reported. Yes, the core netpoll should bail out, but it is also a problem with the driver and should be fixed. I don't get how you can even remotely claim this to be a problem

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Steven Rostedt
On Fri, 2005-08-05 at 07:36 -0700, David S. Miller wrote: From: Steven Rostedt [EMAIL PROTECTED] Date: Fri, 05 Aug 2005 10:27:06 -0400 Darn it, since this should really be reported. Yes, the core netpoll should bail out, but it is also a problem with the driver and should be fixed. I

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 01:45:55PM +0200, Andi Kleen wrote: John B?ckstrand [EMAIL PROTECTED] writes: I've been trying to hunt down a hard lockup issue with some hardware of mine, but I've possibly hit a kernel bug instead. When using netconsole on my e1000, if I unplug the cable and then

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
I still don't like this fix. Yes, you're right, it should eventually give up. But here it gives up way too easily - 5 could easily translate to 5 microseconds. This is analogous to giving up on serial transmit if CTS is down for 5 loops. I'd be much happier if there were some udelay or the

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Fri, Aug 05, 2005 at 11:56:50PM +0200, Andi Kleen wrote: I still don't like this fix. Yes, you're right, it should eventually give up. But here it gives up way too easily - 5 could easily translate to 5 microseconds. This is analogous to giving up on serial transmit if CTS is down for 5

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Andi Kleen
But why are we in a hurry to dump the backlog on the floor? Why are we worrying about the performance of netpoll without the cable plugged in at all? We shouldn't be optimizing the data loss case. Because a system shouldn't stall for minutes (or forever like right now) at boot just because

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread Matt Mackall
On Sat, Aug 06, 2005 at 01:51:22AM +0200, Andi Kleen wrote: But why are we in a hurry to dump the backlog on the floor? Why are we worrying about the performance of netpoll without the cable plugged in at all? We shouldn't be optimizing the data loss case. Because a system shouldn't stall