Re: [PATCH] DM9000 - spinlock fixes

2005-07-25 Thread Sascha Hauer
Hi, On Sat, Jul 23, 2005 at 05:25:18PM +0100, Ben Dooks wrote: Fix DM9000 driver usage of spinlocks, which mainly came to light when running a kernel with spinlock debugging. These come down to: 1) Un-initialised spin lock 2) Several cases of using spin_xxx(lock) and not spin_xxx(lock)

Re: SKB tutorial, Blog, and NET TODO

2005-07-25 Thread Jamal Hadi Salim
Sorry, I read my emails in a LIFO manner - typically that works well with last email in thread covering all the previous, but occasionally something is left over. On Sat, 2005-23-07 at 18:14 +0200, Thomas Graf wrote: i.e you map the time slots to weights and priorities on the rings to the

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread Jamal Hadi Salim
On Sun, 2005-24-07 at 23:18 -0400, Jamal Hadi Salim wrote: Posting a bunch of patches that explicitly set input_dev to dev right before netif_rx() sort of further proves my point :-) ;- Let me sleep it over and think about it - I am not thinking straight right now. I am back home, so

Re: [PATCH] DM9000 - incorrect ioctl() handling

2005-07-25 Thread Jeff Garzik
I'll throw these into the driver... Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Netlink connector

2005-07-25 Thread Patrick McHardy
Evgeniy Polyakov wrote: On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED]) wrote: On Sun, 24 Jul 2005, David S. Miller wrote: From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 13:14:55 +0400 Andrew has no objection against connector and it lives in

Re: Netlink connector

2005-07-25 Thread Eric Leblond
Le lundi 25 juillet 2005 à 16:32 +0200, Patrick McHardy a écrit : Evgeniy Polyakov wrote: On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED]) wrote: If I understand correctly it tries to workaround some netlink limitations (limited number of netlink families and

Re: [E1000-devel] Re: drop counts

2005-07-25 Thread Jesse Brandeburg
On Thu, 21 Jul 2005, [EMAIL PROTECTED] wrote: dropped: rnbc does not mean dropped, see above. mpc means dropped. fifo: mpc means the fifo overflowed, and the packet was dropped (the only time we drop). missed: this should also be mpc because it shows we missed the packet. Wow, thanks! So

Re: Problems with e1000 and flow control

2005-07-25 Thread Jesse Brandeburg
On Tue, 19 Jul 2005, Jason L Tibbitts III wrote: mii-tool -v eth0: eth0: negotiated 100baseTx-FD flow-control, link ok product info: vendor 00:50:43, model 2 rev 3 basic mode: autonegotiation enabled basic status: autonegotiation complete, link ok capabilities: 100baseTx-FD

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Mon, 25 Jul 2005 09:50:33 -0400 how about we set it in only ing_filter() if it is zero. i.e, if (!skb-input_dev) skb-input_dev = skb-dev-ifindex; - Ok... how about we take this one step further? The idea being: 1)

E1000 driver PHY reset bug on Dell 2800

2005-07-25 Thread Russell Johnson
I just upgraded my Dell 2800 from kernel 2.6.7 to 2.6.11 and noticed that the e1000 driver doesn't work when I change the MTU from 1500 to something larger. I traced the bug down to the following item in e1000_main.c::e1000_up(). In a past life I recall PHY's needing to explicitly have the

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Sun, 24 Jul 2005 23:25:53 -0700 When these other changes go in, is there any chance that we can get support for more than 256 routing tables? That can help make all of these virtual interfaces more useful for some of us with strange routing fetishes

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Mon, 25 Jul 2005 09:50:33 -0400 if (!skb-input_dev) skb-input_dev = skb-dev-ifindex; - We get rid of the printk and all other places that set input_dev except for mirred. Any new actions can continue to set it if

Re: Netlink connector

2005-07-25 Thread Evgeniy Polyakov
On Mon, Jul 25, 2005 at 04:43:43PM +0200, Eric Leblond ([EMAIL PROTECTED]) wrote: Le lundi 25 juillet 2005 à 16:32 +0200, Patrick McHardy a écrit : Evgeniy Polyakov wrote: On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED]) wrote: If I understand correctly it

Re: [2.6 patch] net/ipv4/: possible cleanups

2005-07-25 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 24 Jul 2005 00:05:30 +0200 This patch contains the following possible cleanups: - make needlessly global code static - #if 0 the following unused global function: - xfrm4_state.c: xfrm4_state_fini - remove the following unneeded

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 00:35:05 +0200 We can also use ifindex and hold a reference. We won't access input_dev too often so a __dev_get_by_ifindex() won't be too expensive given the number of interfaces is not too big but that's another issue. Since the