The correct way to go about this is to go through each included header
file and check if any of its symbols are used in the source file.
Or if this is too tedious just leave it alone.
Hi Herbert,
thanks for your feedback.
Dave,
please discard this patch for now.
Ratz,
Unfortunately
On Tue, Feb 07, 2006 at 09:07:34PM -0800, David S. Miller wrote:
From: Horms [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 12:09:29 +0900
Unfortunately this seems like it is going to be more tedious than
we first thought. I would guess writing some sort of tool to analyse
symbols and headers
On Wednesday 08 February 2006 01:44, David S. Miller wrote:
From: Ben Greear [EMAIL PROTECTED]
Date: Tue, 07 Feb 2006 16:39:52 -0800
Rick Jones wrote:
In the realm of straw ideas, how often are netdevs added and removed,
and would leaving a tombstone behind consume too much memory?
[PATCH] Better fixup for the orinoco driver
The latest kernel added a pretty ugly fix for the orinoco etherleak bug
which contains bogus skb-len checks already done by the caller and causes
copies of all odd sized frames (which are quite common)
While the skb-len check should be ripped
On Wed, Feb 08, 2006 at 02:26:32PM +0900, FUJITA Tomonori ([EMAIL PROTECTED])
wrote:
Mike Christie and I've developed the SCSI Userspace target
framework. Target LLDs (for Fibre channel, iSCSI HBAs, etc) pass SCSI
commands to SCSI commands to the user-space daemon. The daemon
executes the
On Wednesday 08 February 2006 11:34, Eric Dumazet wrote:
1) Instead of storing a 2-uple {pointer,generation} (and using 12 or 16 bytes
on 64 bits platforms), we could just use a 32 bit quantity
[(ifindex8)+(gen_number)]
That would add an 2^24 netdevice limit. Someone will sooner or later
On Wed, Feb 08, 2006 at 07:46:48AM +1100, Herbert Xu wrote:
I suggest that we simply bail out always. If the dst decides to die
on us later on, the packet will be dropped anyway. So there is no
great urgency to retry here. Once we have the proper resolution
queueing, we can then do the
On 2/8/06, Roberto Nibali [EMAIL PROTECTED] wrote:
I've thought about the linux/modules.h header (ignoring the fact
mentioned by Herbert because of its small chance of happening) and my
suggestion was/is to move it to ip_vs.h. I'll ping Arnaldo regarding
this cleanup, since he's done it
Hello!
netlink overrun was broken while improvement of netlink.
Destination socket is used in the place where it was meant to be source socket,
so that now overrun is never sent to user netlink sockets, when it should be,
and it even can be set on kernel socket, which results in complete deadlock
loopback driver carefully uses per_cpu storage for statistics but updates
loopback_dev.last_rx
As last_rx is only used by bond driver to detect link activity, and loopback
dev wont be used as a bond slave, can we avoid this write access that slowdown
SMP platforms, because of cache ping pongs
Hello!
When a netlink message is not related to a netlink socket,
it is issued by kernel socket with pid 0. Netlink pid has nothing
to do with current-pid. I called it incorrectly, if it was named port,
the confusion would be avoided.
Jamal, please, review. Did you have reasons to do this?
Hi,
Just wondering if anybody got a chance to review the below patch.
This version(as per Rick's comment on v1 patch) includes support
for TCP timestamps.
Thanks,
Ravi
-Original Message-
From: Ravinandan Arakali [mailto:[EMAIL PROTECTED]
Sent: Wednesday, January 25, 2006 11:53 AM
To:
jamal wrote:
On Wed, 2006-08-02 at 18:27 +0300, Alexey Kuznetsov wrote:
When a netlink message is not related to a netlink socket,
it is issued by kernel socket with pid 0. Netlink pid has nothing
to do with current-pid. I called it incorrectly, if it was named
port, the confusion would
Ravinandan Arakali wrote:
Hi,
Just wondering if anybody got a chance to review the below patch.
This version(as per Rick's comment on v1 patch) includes support
for TCP timestamps.
It's been merged in the 'lro' branch of netdev-2.6.git for a little
while now. Once it gets additional review
On Tue, 07 Feb 2006 16:26:01 -0800 (PST)
David S. Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 7 Feb 2006 16:19:42 -0800
Also, isn't a lot of the problem reduced if network devices
are affinitied?
Not for routing/firewalling, we touch the
On Wed, Feb 08, 2006 at 05:17:24PM +0200, Kristian Slavov wrote:
During NETDEV_DOWN we clear IF_READY, and we don't set it back in
NETDEV_UP. While starting to perform DAD on the link-local address, we
notice that the device is not in IF_READY, and we abort autoconfiguration
process (which
Stephen Hemminger wrote:
On Tue, 07 Feb 2006 16:26:01 -0800 (PST)
David S. Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 7 Feb 2006 16:19:42 -0800
Also, isn't a lot of the problem reduced if network devices
are affinitied?
Not for
Stephen Hemminger wrote:
On Wed, 08 Feb 2006 11:24:24 -0800
Ben Greear [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
On Tue, 07 Feb 2006 16:26:01 -0800 (PST)
David S. Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 7 Feb 2006 16:19:42 -0800
this should be on netdev (cc'd), i included some of the thread here.
On 2/7/06, Yoseph Basri [EMAIL PROTECTED] wrote:
Hello kernel maillist,
I'm new member maillist.
Currently, I receive the warning log from my kernel.
Since update to
Linux 2.6.14.3 #1 SMP Fri Nov 25 20:20:05 SGT 2005
jamal wrote:
Ok, thanks for the reminder Hasso.
so essentially at the moment the pid that will show up (if
quagga added the v6 route) will be that of quagga, correct?
No. Quote from Alexey:
Netlink pid has nothing to do with current-pid. I called it
incorrectly, if it was named port, the
On Wed, 08 Feb 2006 12:20:22 -0800
Ben Greear [EMAIL PROTECTED] wrote:
I have a dual-port SysKonnect NIC. In 'lspci' I see one entry
(was expecting two..but maybe that is a separate issue). The
chipset appears to be SK-9Exx 10/100/1000Base-T adapter (rev 12).
skge does not seem to support
On Wed, 08 Feb 2006 12:18:23 -0800
David Carlton [EMAIL PROTECTED] wrote:
On Mon, 06 Feb 2006 15:50:28 -0800 (PST), David S. Miller [EMAIL
PROTECTED] said:
From: David Carlton [EMAIL PROTECTED]
Date: Mon, 06 Feb 2006 14:38:10 -0800
I'm working on an application that we're trying to
On Wed, 2006-08-02 at 22:50 +0200, Hasso Tepper wrote:
jamal wrote:
Ok, thanks for the reminder Hasso.
so essentially at the moment the pid that will show up (if
quagga added the v6 route) will be that of quagga, correct?
No. Quote from Alexey:
I sense you missed my question. I
jamal wrote:
On Wed, 2006-08-02 at 22:50 +0200, Hasso Tepper wrote:
jamal wrote:
Ok, thanks for the reminder Hasso.
so essentially at the moment the pid that will show up (if
quagga added the v6 route) will be that of quagga, correct?
No. Quote from Alexey:
I sense you missed my
On Wed, 2006-08-02 at 23:41 +0200, Hasso Tepper wrote:
jamal wrote:
At the moment if a route (v6 or v4) was added by quagga and i had a
socket that was listening in a different process - what pid will i see
(in my user space app)? Is it of the quagga process or is it 0?
No, it's
From: Nicolas DICHTEL [EMAIL PROTECTED]
Date: Mon, 06 Feb 2006 12:00:30 +0100
in the same way of this patch, why dst_entry are stored for
RAW socket ? In case of specific IPSec rules for ICMPv6,
xfrm state can be different for the same destination.
Attached, a proposed patch.
We cache the
jamal wrote:
So the question is what would be the address/nl_pid of something
issued by an ioctl (refer to my earlier email to Alexey).
It's the kernel who creates this message and puts it to the netlink
domain, so I'd say 0.
--
Hasso Tepper
-
To unsubscribe from this list: send the line
From: Eric Dumazet [EMAIL PROTECTED]
Date: Wed, 08 Feb 2006 16:06:31 +0100
loopback driver carefully uses per_cpu storage for statistics but updates
loopback_dev.last_rx
This has been discussed before, this is an attribute every
driver must keep uptodate. Things like bonding use it,
for
On Wednesday 08 February 2006 20:12, Stephen Hemminger wrote:
On Tue, 07 Feb 2006 16:26:01 -0800 (PST)
David S. Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Tue, 7 Feb 2006 16:19:42 -0800
Also, isn't a lot of the problem reduced if network devices
From: Jeff Garzik [EMAIL PROTECTED]
Date: Wed, 08 Feb 2006 13:02:15 -0500
Ravinandan Arakali wrote:
Hi,
Just wondering if anybody got a chance to review the below patch.
This version(as per Rick's comment on v1 patch) includes support
for TCP timestamps.
It's been merged in the 'lro'
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
ppp is the biggest offender.
drivers/net/ppp_async.c | 34 ++--
drivers/net/ppp_generic.c | 128 +++---
drivers/net/ppp_synctty.c | 26 -
drivers/net/pppoe.c |2
4
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm not sure
which is more ugly.
Why wouldn't explicit comparison against NULL be the preferred fix?
--
James Carlson 42.703N 71.076W [EMAIL PROTECTED]
-
To
From: Jesse Brandeburg [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 12:07:14 -0800
this should be on netdev (cc'd), i included some of the thread here.
...
I though Herbert had fixed these, and it looks like half the patches
got into 2.6.14.3, but not the fix to the fix committed on 9-6 (not in
James Carlson [EMAIL PROTECTED] wrote:
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm not sure
which is more ugly.
Treating it as a boolean looks good to me. It's better than the existing
code because it shuts sparse
James And the solution is to treat it as a boolean instead?! I'm
James not sure which is more ugly.
James Why wouldn't explicit comparison against NULL be the
James preferred fix?
if (ptr) and if (!ptr) are the preferred idiom for testing whether
a pointer is NULL. What is
The ethernet controller is integrated into the chipset. Therefore, no
mismatch between MSI/MSIX chipset support and device support should exist.
Ayaz
Roland Dreier wrote:
Roland Is forcedeth ever used with a discrete ethernet
Roland controller? I thought that nforce NICs are always
From: Andi Kleen [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 23:20:38 +0100
But are you sure the hash table used for that would be strong enough
to handle the load?
With RCU locking I think it is.
And what happens when a ifindex is reused? Then packets could end up
on the wrong interface. That
Hello!
What about the dilemma of when there are no netlink sockets
involved? ;-
i.e what is the semantics when there is no netlink socket to map them
to, such as in the case of ioctl?
0, which is legal address of kernel socket.
In this case it means that kernel did the operation.
Moreover,
[EMAIL PROTECTED] wrote on 02/08/2006 02:19:20 PM:
James Carlson [EMAIL PROTECTED] wrote:
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm not sure
which is more ugly.
Treating it as a boolean looks good to me.
From: David Stevens [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 14:45:08 -0800
Why would sparse complain about this? 0 is a well-defined
pointer value (the only value guaranteed to be by the language).
Because sparse goes beyond the standards and tries to
catch cases that usually end up
James Carlson writes:
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm not sure
which is more ugly.
Why wouldn't explicit comparison against NULL be the preferred fix?
I just think this whole you shouldn't compare a
David S. Miller writes:
Because sparse goes beyond the standards and tries to
catch cases that usually end up being bugs.
When has a pointer comparison with an explicit 0 ever caused a bug?
Paul.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
David S. Miller wrote:
From: David Stevens [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 14:45:08 -0800
Why would sparse complain about this? 0 is a well-defined
pointer value (the only value guaranteed to be by the language).
Because sparse goes beyond the standards and tries to
catch
On Wed, Feb 08, 2006 at 02:45:08PM -0800, David Stevens wrote:
[EMAIL PROTECTED] wrote on 02/08/2006 02:19:20 PM:
James Carlson [EMAIL PROTECTED] wrote:
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm not
From: Stephen Hemminger [EMAIL PROTECTED]
IMHO converting skb-dev to skb-devindex and using ifindex sounds best.
It gets rid of the need to refcount as much but keeps the safety from
buggy protocols. Ipv6 could probably use ifindex as well.
A couple years ago, we identified a
jamal wrote:
a) if user-app using netlink modifies something, the event will report
the nl_pid mapped to its pid or other non-zero value depending on
the number of netlink sockets mapped to that process/user-app
It will always be nl_pid of the socket. And don't forget that this pid and
On Thursday 09 February 2006 00:07, David Stevens wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
IMHO converting skb-dev to skb-devindex and using ifindex sounds best.
It gets rid of the need to refcount as much but keeps the safety from
buggy protocols. Ipv6 could probably use ifindex
On Wed, Feb 08, 2006 at 02:47:12PM -0800, David S. Miller wrote:
From: David Stevens [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 14:45:08 -0800
Why would sparse complain about this? 0 is a well-defined
pointer value (the only value guaranteed to be by the language).
Because sparse
Hello.
In article [EMAIL PROTECTED] (at Wed, 08 Feb 2006 17:17:24 +0200), Kristian
Slavov [EMAIL PROTECTED] says:
During NETDEV_DOWN we clear IF_READY, and we don't set it back in
NETDEV_UP. While starting to perform DAD on the link-local address, we
notice that the device is not in
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Thu, 09 Feb 2006 08:44:36 +0900 (JST)
Hello.
In article [EMAIL PROTECTED] (at Wed, 08 Feb 2006 17:17:24 +0200), Kristian
Slavov [EMAIL PROTECTED] says:
During NETDEV_DOWN we clear IF_READY, and we don't set it back in
NETDEV_UP. While
Alexey Dobriyan [EMAIL PROTECTED] wrote:
Oh, and for the record: current sparse from Linus doesn't warn about
this. Slightly modified sparse warns. Bugs which were uncovered by
more or less trivial and slightly broken sparse patch [1] are:
[PATCH] dscc4: fix dscc4_init_dummy_skb
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 09 Feb 2006 10:49:37 +1100
The difference between gcc -pedantic and sparse is that it doesn't
warn about obviously correct cases like p != 0 or p = 0.
So obviously correct that you left out an equals sign in the
second case :-)
-
To unsubscribe
On Wed, 8 Feb 2006, David S. Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 09 Feb 2006 10:49:37 +1100
The difference between gcc -pedantic and sparse is that it doesn't
warn about obviously correct cases like p != 0 or p = 0.
So obviously correct that you left out an equals
In article [EMAIL PROTECTED] (at Wed, 08 Feb 2006 15:59:31 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
Good spot. Please drop {}, otherwise, I agree. Thank you.
I'll take care of fixing that when I put in the fix.
Okay, thanks.
Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
On Wed, Feb 08, 2006 at 03:58:59PM -0800, David S. Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 09 Feb 2006 10:49:37 +1100
The difference between gcc -pedantic and sparse is that it doesn't
warn about obviously correct cases like p != 0 or p = 0.
So obviously correct that
On Thu, 2006-09-02 at 01:46 +0300, Alexey Kuznetsov wrote:
Hello!
What about the dilemma of when there are no netlink sockets
involved? ;-
i.e what is the semantics when there is no netlink socket to map them
to, such as in the case of ioctl?
0, which is legal address of kernel
On Tue, 7 Feb 2006, David S. Miller wrote:
From: Jesse Brandeburg [EMAIL PROTECTED]
Date: Tue, 7 Feb 2006 17:41:28 -0800 (Pacific Standard Time)
so we generally call dev_alloc_skb to get the receive buffers to give to
our hardware. When we use multiple receive buffers what is the right way
Hello!
BTW, Alexey - if you have a chance can you look at the breakage of
sendmsg() in relation to multicast that exists today?
If it is is about groups 31, which cannot be mapped to nl_groups,
it is possible just to add setsockopt(), setting dst_group. It is just
to complete the API.
Do
From: jamal [EMAIL PROTECTED]
Date: Wed, 08 Feb 2006 19:07:25 -0500
On Thu, 2006-09-02 at 01:46 +0300, Alexey Kuznetsov wrote:
Hello!
What about the dilemma of when there are no netlink sockets
involved? ;-
i.e what is the semantics when there is no netlink socket to map them
On Mon, Jan 30, 2006 at 02:28:43PM -0800, Jean Tourrilhes wrote:
On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote:
I'll post a revert patch for the patch I originally sent so that we go
back to the original behavior.
Sorry, I may have overreacted. I think that's a
David S. Miller [EMAIL PROTECTED] wrote:
From: Nicolas DICHTEL [EMAIL PROTECTED]
Date: Mon, 06 Feb 2006 12:00:30 +0100
in the same way of this patch, why dst_entry are stored for
RAW socket ? In case of specific IPSec rules for ICMPv6,
xfrm state can be different for the same destination.
On 2/8/06, David S. Miller [EMAIL PROTECTED] wrote:
From: Jesse Brandeburg [EMAIL PROTECTED]
Date: Wed, 8 Feb 2006 12:07:14 -0800
this should be on netdev (cc'd), i included some of the thread here.
...
I though Herbert had fixed these, and it looks like half the patches
got into
Begin forwarded message:
Date: Thu, 09 Feb 2006 06:10:49 +0100
From: Knut Petersen [EMAIL PROTECTED]
To: linux-kernel@vger.kernel.org
Subject: Assert: CPU #..., mangle/filter comefrom() = ...
As there probably is a reason to printk assertions:
[ 28.616455] ADDRCONF(NETDEV_CHANGE):
63 matches
Mail list logo
