Re: [PATCH 0/5] NetXen: Driver bug fixes

2007-03-10 Thread Jeff Garzik
Amit Kale wrote: On Friday 09 March 2007 22:26, Jeff Garzik wrote: Linsys Contractor Mithlesh Thukral wrote: Hi All, I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent mails. The patches will be with respect to netdev#upstream. Are you sure you don't want some of these

Re: 2.6.19/2.6.20 BUG in inet_rtm_newaddr()/__inet_insert_ifa()

2007-03-10 Thread Evgeniy Polyakov
On Fri, Mar 09, 2007 at 07:22:36PM +0100, Frank van Maarseveen ([EMAIL PROTECTED]) wrote: Ok that worked.. not as I expected. I don't understand the EINVAL and ip addr shows no broadcast address for eth0 when a classless address is added as the primary (and only) address like in the above

Re: SSB/b44 build failure

2007-03-10 Thread John W. Linville
On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote: Hi, In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig symbols disabled, I get this (on x86_64): drivers/built-in.o: In function `b44_init': b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register'

Re: SSB/b44 build failure

2007-03-10 Thread Adrian Bunk
On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote: On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote: Hi, In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig symbols disabled, I get this (on x86_64): drivers/built-in.o: In function `b44_init':

[PATCHES 0/11] skb-mac.raw refactorings

2007-03-10 Thread Arnaldo Carvalho de Melo
Hi David, Paving the way for turning the layer headers offsets, to shrink struct sk_buff on 64bits (and perhaps on 32 bits too). Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22.git - Arnaldo - To unsubscribe from this list: send the

[PATCH 01/11] [HIPPI/FDDI]: Make {hippi,fddi}_type_trans set skb-dev

2007-03-10 Thread Arnaldo Carvalho de Melo
Now all the _type_trans routines are consistent in this regard. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/net/defxx.c |2 -- drivers/net/rrunner.c |1 - drivers/net/skfp/skfddi.c |1 - drivers/s390/net/lcs.c|1 - net/802/fddi.c|

[PATCH 03/11] [AOE]: Introduce aoe_hdr()

2007-03-10 Thread Arnaldo Carvalho de Melo
For consistency with other skb-mac.raw users. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/block/aoe/aoe.h|9 + drivers/block/aoe/aoecmd.c | 14 +++--- drivers/block/aoe/aoenet.c |2 +- 3 files changed, 17 insertions(+), 8 deletions(-) From

[PATCH 02/11] [QETH]: Use eth_hdr()

2007-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/s390/net/qeth_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) From 2d1f252de2e0047e163f70ae77e0a96c0a6f4c4d Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Sat, 10 Mar 2007

[PATCH 05/11] [LLC]: Use skb_reset_mac_header in llc_alloc_frame

2007-03-10 Thread Arnaldo Carvalho de Melo
skb-head is equal to skb-data after alloc_skb, so reset the mac header while this is true, i.e. before skb_reserve. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/llc/llc_sap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) From

[PATCH 06/11] [LLC]: Use skb_reset_mac_header in llc_mac_hdr_init

2007-03-10 Thread Arnaldo Carvalho de Melo
skb_push updates and returns skb-data, so we can just call skb_reset_mac_header after the call to skb_push. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/llc/llc_output.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) From

[PATCH 10/11] [TCP]: Use skb_set_mac_header in tcp_collapse

2007-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/tcp_input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) From c1ce9fb6cfdf6da2aef6ce29e9d6954d81ebc410 Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Sat, 10 Mar 2007 12:48:37

[PATCH 11/11] [SK_BUFF]: Introduce skb_mac_header()

2007-03-10 Thread Arnaldo Carvalho de Melo
For the places where we need a pointer to the mac header, it is still legal to touch skb-mac.raw directly if just adding to, subtracting from or setting it to another layer header. This one also converts some more cases to skb_reset_mac_header() that my regex missed as it had no spaces before

[PATCH 08/11] [SK_BUFF] xfrm: Use skb_set_mac_header in the memmove cases

2007-03-10 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/xfrm4_mode_tunnel.c |6 -- net/ipv6/xfrm6_mode_beet.c |6 -- net/ipv6/xfrm6_mode_tunnel.c |6 -- 3 files changed, 12 insertions(+), 6 deletions(-) From 858930f8bd6535a05328f92db5364b862427de2f Mon Sep 17

[PATCH 09/11] [TCP]: Do the layer header setting in tcp_collapse relative to skb-data

2007-03-10 Thread Arnaldo Carvalho de Melo
That is equal to skb-head before skb_reserve, to help in the layer header changes. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/tcp_input.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) From c530bf48cc881327a6a2567cb85b87805e92c596 Mon Sep 17 00:00:00

Re: SSB/b44 build failure

2007-03-10 Thread John W. Linville
On Sat, Mar 10, 2007 at 04:38:16PM +0100, Adrian Bunk wrote: On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6a4325b..b2e1deb 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -1402,6 +1402,7 @@

Re: SSB/b44 build failure

2007-03-10 Thread Michael Buesch
On Saturday 10 March 2007 16:38, Adrian Bunk wrote: On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote: On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote: Hi, In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig symbols disabled, I get this (on

Re: SSB/b44 build failure

2007-03-10 Thread Christoph Hellwig
On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote: FWIW, this is coming from the port of b44 to use the SSB bus which I'm carrying in the wireless-dev tree. SSB (i.e. Sonics Silicon Backplane) is a bus used in Broadcom SoCs including the b44 and bcm43xx hardware. The SSB bus

Re: SSB/b44 build failure

2007-03-10 Thread Michael Buesch
On Saturday 10 March 2007 19:05, Christoph Hellwig wrote: On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote: FWIW, this is coming from the port of b44 to use the SSB bus which I'm carrying in the wireless-dev tree. SSB (i.e. Sonics Silicon Backplane) is a bus used in

Re: [PATCH] natsemi: netpoll fixes

2007-03-10 Thread Sergei Shtylyov
Hello. Mark Huth wrote: #ifdef CONFIG_NET_POLL_CONTROLLER static void natsemi_poll_controller(struct net_device *dev) { + struct netdev_private *np = netdev_priv(dev); + disable_irq(dev-irq); - intr_handler(dev-irq, dev); + + /* + * A real interrupt might have already

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-10 Thread Willy Tarreau
On Wed, Mar 07, 2007 at 07:51:35PM -0800, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 07 Mar 2007 19:10:47 -0800 David Miller wrote: What about Willy Tarreau's supposedly even faster variant? Or does this incorporate that set of improvements? That's

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Andi Kleen
Simon Arlott [EMAIL PROTECTED] writes: On 09/03/07 20:42, Francois Romieu wrote: Simon Arlott [EMAIL PROTECTED] : When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged back in. rtl8139_interrupt

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Simon Arlott
On 10/03/07 13:38, Andi Kleen wrote: Simon Arlott [EMAIL PROTECTED] writes: On 09/03/07 20:42, Francois Romieu wrote: Simon Arlott [EMAIL PROTECTED] : When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged

RE: [PATCH 1/2] NET: Multiple queue network device support

2007-03-10 Thread Waskiewicz Jr, Peter P
-Original Message- From: Thomas Graf [mailto:[EMAIL PROTECTED] Sent: Friday, March 09, 2007 6:35 PM To: Waskiewicz Jr, Peter P Cc: Kok, Auke-jan H; David Miller; Garzik, Jeff; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg, Jesse; Kok, Auke; Ronciak, John

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Matt Mackall
On Fri, Mar 09, 2007 at 09:42:43PM +0100, Francois Romieu wrote: Simon Arlott [EMAIL PROTECTED] : When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged back in. rtl8139_interrupt (spin_lock(tp-lock))

[PATCH 1/4] PPPoE: miscellaneous smaller cleanups

2007-03-10 Thread Florian Zumbiehl
Hi, below is a patch that just removes dead code/initializers without any effect (first access is an assignment) that I stumbled accross while reading the source. Florian --- diff --git a/drivers/net/pppoe.c

[PATCH 2/4] PPPoE: race between interface going down and connect()

2007-03-10 Thread Florian Zumbiehl
Hi, below you find a patch that (hopefully) fixes a race between an interface going down and a connect() to a peer on that interface. Before, connect() would determine that an interface is up, then the interface could go down and all entries referring to that interface in the item_hash_table

[PATCH 3/4] PPPoE: memory leak when socket is release()d before PPPIOCGCHAN has been called on it

2007-03-10 Thread Florian Zumbiehl
Hi, below you find a patch that fixes a memory leak when a PPPoE socket is release()d after it has been connect()ed, but before the PPPIOCGCHAN ioctl ever has been called on it. This is somewhat of a security problem, too, since PPPoE sockets can be created by any user, so any user can easily

[PATCH 4/4] PPPoE: race between interface going down and release()

2007-03-10 Thread Florian Zumbiehl
Hi, below you find the last patch for now. It (hopefully) fixes a race between a socket being release()d and the interface it's using going down. As pppoe_release() didn't lock the socket, and pppoe_flush_dev() did the locking in the wrong place, pppoe_flush_dev() could set po-pppoe_dev to NULL,

Re: netconsole system freeze when cable unplugged

2007-03-10 Thread Andi Kleen
On Sat, Mar 10, 2007 at 02:06:28PM +, Simon Arlott wrote: On 10/03/07 13:38, Andi Kleen wrote: Simon Arlott [EMAIL PROTECTED] writes: On 09/03/07 20:42, Francois Romieu wrote: Simon Arlott [EMAIL PROTECTED] : When I unplug the cable the system just stops responding to anything, at all.