Re: SACK scoreboard

2008-01-09 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 14:12:47 +0200 (EET) If I'd hint my boss that I'm involved in something like this I'd bet that he also would get quite crazy... ;-) I'm partially paid for making TCP more RFCish :-), or at least that the places where thing diverge

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Jay Vosburgh
Krzysztof Oledzki [EMAIL PROTECTED] wrote: Fine. Just let you know that someone test your patches and everything works, except mentioned problem. And I appreciate it; I just wanted to make sure our many fans following along at home didn't misunderstand. Could you let me know if

Re: [PATCH net-2.6.25] [IPV4] Remove unsupported DNAT (RTCF_NAT and RTCF_NAT) in IPV4

2008-01-09 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Wed, 2 Jan 2008 23:31:37 +0200 - The DNAT (Destination NAT) is not implemented in IPV4. - This patch remove the code which checks these flags in net/ipv4/arp.c and net/ipv4/route.c. The RTCF_NAT and RTCF_NAT should stay in the header

Re: [patch 5/9][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-09 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 07 Jan 2008 17:36:35 +0100 Thanks Benjamin to catch this. I think I have to apologize to Eric, I thought I tested with this option off but it wasn't and Eric was right. I will wait a little for feedbacks and send a V3. I would have

Re: make ipv6_sysctl_register to return a value

2008-01-09 Thread David Miller
Why did you post this again? It's identical to patch 1/9 from the previous series you sent out. This is confusing, since it makes me think you wanted me to perhaps do something different or update an already submitted patch. -- To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2008-01-09 Thread Pavel Emelyanov
Hi, Patrick. Pavel Emelyanov wrote: There are tree paths in it, that set the skb-proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the

Re: [PATCH net-2.6.25 1/6][NET] Simple ctl_table to ctl_path conversions.

2008-01-09 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 18:54:57 +0300 This patch includes many places, that only required replacing the ctl_table-s with appropriate ctl_paths and call register_sysctl_paths(). Nothing special was done with them. Signed-off-by: Pavel Emelyanov

Re: [PATCH net-2.6.25 2/6][IPVS] Switch to using ctl_paths.

2008-01-09 Thread David Miller
From: Simon Horman [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 11:49:16 +0900 On Tue, Jan 08, 2008 at 06:58:11PM +0300, Pavel Emelyanov wrote: The feature of ipvs ctls is that the net/ipv4/vs path is common for core ipvs ctls and for two schedulers, so I make it exported and re-use it in

Re: [PATCH net-2.6.25 3/6][DECNET] Switch to using ctl_paths.

2008-01-09 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 19:02:16 +0300 The decnet includes two places to patch. The first one is the net/decnet table itself, and it is patched just like other subsystems in the first patch in this series. The second place is a bit more complex - it

Re: [PATCH net-2.6.25 4/6][AX25] Switch to using ctl_paths.

2008-01-09 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 19:05:18 +0300 This one is almost the same as the hunks in the first patch, but ax25 tables are created dynamically. So this patch differs a bit to handle this case. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied.

Re: [PATCH net-2.6.25 5/6][NETFILTER] Switch to using ctl_paths in nf_queue and conntrack modules

2008-01-09 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 17:10:58 +0100 Pavel Emelyanov wrote: This includes the most simple cases for netfilter. The first part is tne queue modules for ipv4 and ipv6, on which the net/ipv4/ and net/ipv6/ paths are reused from the appropriate

Re: [PATCH net-2.6.25 6/6][NETFILTER] Use the ctl paths instead of hand-made analogue

2008-01-09 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 17:13:30 +0100 Pavel Emelyanov wrote: The conntracks subsystem has a similar infrastructure to maintain ctl_paths, but since we already have it on the generic level, I think it's OK to switch to using it. So, basically,

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread David Miller
From: [EMAIL PROTECTED] Date: 8 Jan 2008 19:38:40 -0500 That doesn't seem to do it. Not entirely, at least. After downloading and partially re-uploading an 800M file, slabtop reports: Ok, I'll let you and Francois work out how to fix this for good. Please submit just the outright leak bug

Re: 2.6.24-rc6-mm1

2008-01-09 Thread Jarek Poplawski
On Wed, Jan 09, 2008 at 08:57:53AM +0900, FUJITA Tomonori wrote: ... diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c new file mode 100644 index 000..495575a --- /dev/null +++ b/lib/iommu-helper.c @@ -0,0 +1,80 @@ +/* + * IOMMU helper functions for the free area management + */ +

Re: [RFC 1/2] [XFRM] remove ifdef crypto

2008-01-09 Thread David Miller
From: Sebastian Siewior [EMAIL PROTECTED] Date: Sat, 8 Jan 2008 22:26:37 +0100 and select the crypto subsystem if neccessary Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
Hi, I want to make a bond with my wireless card. The ipw driver create two interfaces (wlan0 and wmaster0). When i switch the rf_kill button, ifplug detect wlan0 unplugged but not wmaster0. If i down wlan0 (while rf_kil ), bonding detect the inactivity when i up the interface. Have you some

Re: [PATCH net-2.6.25] [BRIDGE] Remove unused macros from ebt_vlan.c

2008-01-09 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Tue, 8 Jan 2008 16:38:15 +0200 Remove two unused macros, INV_FLAG and SET_BITMASK from net/bridge/netfilter/ebt_vlan.c. Signed-off-by: Rami Rosen [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in

Re: [Patch 2.6.22.2 ] : drivers/net/via-rhine.c: Offload checksum handling to VT6105M

2008-01-09 Thread Roger Luethi
[top posting because context may be missing otherwise, over a week later] Excellent analysis, Willy. Quite frankly, I am not keen on making this driver any more complex, especially if the gains are marginal at best. VIA Rhine will never be high-performance hardware, and we have too much special

Re: SACK scoreboard

2008-01-09 Thread Evgeniy Polyakov
Hi. On Wed, Jan 09, 2008 at 08:03:18AM +0100, Andi Kleen ([EMAIL PROTECTED]) wrote: It adds severe spikes in CPU utilization that are even moderate line rates begins to affect RTTs. Or do you think it's OK to process 500,000 SKBs while locked in a software interrupt. You can always

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Herbert Xu
On Wed, Jan 09, 2008 at 08:38:56AM +0100, Eric Dumazet wrote: I am not sure this is valid, since it will do this : r = rt_hash_table[st-bucket].chain; if (r) return rcu_dereference(r); So compiler might be dumb enough do dereference rt_hash_table[st-bucket].chain two times. That

Re: make ipv6_sysctl_register to return a value

2008-01-09 Thread Daniel Lezcano
David Miller wrote: Why did you post this again? It's identical to patch 1/9 from the previous series you sent out. This is confusing, since it makes me think you wanted me to perhaps do something different or update an already submitted patch. I thought you was expecting a new netns ipv6

[PATCH] AX25: kill user triggable printks

2008-01-09 Thread maximilian attems
sfuzz can easily trigger any of those. move the printk message to the corresponding comment: makes the intention of the code clear and easy to pick up on an scheduled removal. as bonus simplify the braces placement. Signed-off-by: maximilian attems [EMAIL PROTECTED] --- net/ax25/af_ax25.c |

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Krzysztof Oledzki
On Tue, 8 Jan 2008, Jay Vosburgh wrote: Krzysztof Oledzki [EMAIL PROTECTED] wrote: Fine. Just let you know that someone test your patches and everything works, except mentioned problem. And I appreciate it; I just wanted to make sure our many fans following along at home didn't

[PATCH v3] AX25: kill user triggable printks

2008-01-09 Thread maximilian attems
sfuzz can easily trigger any of those. move the printk message to the corresponding comment: makes the intention of the code clear and easy to pick up on an scheduled removal. as bonus simplify the braces placement. Signed-off-by: maximilian attems [EMAIL PROTECTED] --- net/ax25/af_ax25.c |

[ATM]: Check IP header validity in mpc_send_packet

2008-01-09 Thread Herbert Xu
Hi Dave: [ATM]: Check IP header validity in mpc_send_packet Al went through the ip_fast_csum callers and found this piece of code that did not validate the IP header. While root crashing the machine by sending bogus packets through raw or AF_PACKET sockets isn't that serious, it is still nice

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Eric Dumazet
On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu [EMAIL PROTECTED] wrote: On Wed, Jan 09, 2008 at 08:38:56AM +0100, Eric Dumazet wrote: I am not sure this is valid, since it will do this : r = rt_hash_table[st-bucket].chain; if (r) return rcu_dereference(r); So compiler might

Re: [PATCH] AX25: kill user triggable printks

2008-01-09 Thread maximilian attems
On Wed, Jan 09, 2008 at 11:11:23AM +0100, maximilian attems wrote: + /* support for old structure may go away some time + * ax25_sendmsg(): uses old (6 digipeater) + * socket structure.\n, + */ urrgs overseen

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Sergej Stepanov
Am Dienstag, den 08.01.2008, 22:05 +0300 schrieb Anton Vorontsov: Otherwise oops will happen if ethernet device has not been opened: Unable to handle kernel paging request for data at address 0x014c Faulting instruction address: 0xc016f7f0 Oops: Kernel access of bad area, sig: 11 [#1]

[patch] pegasus.c

2008-01-09 Thread Petko Manolov
Hi Jeff, Attached you'll find a patch that is fixing a driver bug triggered when malformed string is passed to the 'devid' module parameter. The expected format is: device_name:vendor_id:device_id:flags but it turned out people often type: somename::0 instead of:

[PATCH 3/5] iwlwifi: iwl3945 fix oops while pci remove

2008-01-09 Thread Joonwoo Park
The nic controller's clock on/off irq (CSR_INT_BIT_MAC_CLK_ACTV) is generated when device goes on/off Unlikely turning on the device, irq by off the device may cause oops because iwl_pci_remove already freed required resources The irq_tasklet should not be invoked at that condition $sudo

[PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi

2008-01-09 Thread Joonwoo Park
After disabling interrupts, it's possible irq tasklet is pending or running This patch eleminates races for down iwlwifi Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- drivers/net/wireless/iwlwifi/iwl3945-base.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[PATCH 0/5] iwlwifi: iwl3945 fix races, getting rid of sleep from context

2008-01-09 Thread Joonwoo Park
Hello, This patchset does fix iwl3945's races and some other stuff. For now it works for just iwl3945 but if some of them is needed for iwl4965, I would work for it. patch against 2.6.24-rc7 [PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and

[PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask

2008-01-09 Thread Joonwoo Park
After enabling/disabling interrupts flushing is required Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- drivers/net/wireless/iwlwifi/iwl-io.h |2 ++ drivers/net/wireless/iwlwifi/iwl3945-base.c |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git

[PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-09 Thread Joonwoo Park
Eleminiate task queuing of iwl_pci_probe, register hw to ieee80211 immediately Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- drivers/net/wireless/iwlwifi/iwl3945-base.c | 66 +- 1 files changed, 43 insertions(+), 23 deletions(-) diff --git

[PATCH 5/5] iwlwifi: iwl3945 switch private workqueue to ieee80211-workqueue

2008-01-09 Thread Joonwoo Park
The ieee80211 provides workqueue for nic drivers. private workqueue dosen't need anymore TODO: remove workqueue in iwl_priv Signed-off-by: Joonwoo Park [EMAIL PROTECTED] --- drivers/net/wireless/iwlwifi/iwl-3945.c |6 ++-- drivers/net/wireless/iwlwifi/iwl3945-base.c | 53

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Tetsuo Handa
Hello. Brent Casavant wrote: However, the program would occasionally get into a situation where a call to recv(sockfd, buf, len, MSG_PEEK) returns some number of bytes less than the requested length, and persists in this state (i.e. retrying the call continues to return the same amount of

[PATCH net-2.6.25] [IPVS] Added include for ip_vs.h for ctl_path (build was broken)

2008-01-09 Thread Rami Rosen
Hi, The build was broken with this error: In file included from net/ipv4/ipvs/ip_vs_rr.c:27: include/net/ip_vs.h:857: error: array type has incomplete element type make[3]: *** [net/ipv4/ipvs/ip_vs_rr.o] Error 1 This was due to missing include to the header file for

Re: [ATM]: Check IP header validity in mpc_send_packet

2008-01-09 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 21:27:45 +1100 [ATM]: Check IP header validity in mpc_send_packet Al went through the ip_fast_csum callers and found this piece of code that did not validate the IP header. While root crashing the machine by sending bogus packets

Re: [PATCH net-2.6.25] [IPVS] Added include for ip_vs.h for ctl_path (build was broken)

2008-01-09 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 13:33:49 +0200 Hi, The build was broken with this error: In file included from net/ipv4/ipvs/ip_vs_rr.c:27: include/net/ip_vs.h:857: error: array type has incomplete element type make[3]: *** [net/ipv4/ipvs/ip_vs_rr.o]

Re: [PATCH net-2.6.25 0/4] [NET]: Bloat, bloat and more bloat

2008-01-09 Thread Ilpo Järvinen
On Sat, 5 Jan 2008, Arnaldo Carvalho de Melo wrote: Em Sat, Jan 05, 2008 at 03:39:04PM +0200, Ilpo Järvinen escreveu: Hi Dave, After Arnaldo got codiff's inline instrumentation bugs fixed (thanks! :-)), I got my .c-inline-bloat-o-meter to power up reliably after some tweaking and bug

Re: make ipv6_sysctl_register to return a value

2008-01-09 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 09 Jan 2008 10:56:48 +0100 To clear out any confusion, please can you just ignore all my previous patches, I will resend a new serie rebased on the work done by Pavel. Ok, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Gerrit Renker
Roland, - apparently, i got crashes when loading/unloading other driver modules just after ccid2 or ccid3 had been loaded/unloaded _once_ (have not used them at all, just modprobe module;modprobe -r module) snip the easiest way to reproduce is: while true;do modprobe

Re: SACK scoreboard

2008-01-09 Thread Ilpo Järvinen
On Tue, 8 Jan 2008, John Heffner wrote: Andi Kleen wrote: David Miller [EMAIL PROTECTED] writes: The big problem is that recovery from even a single packet loss in a window makes us run kfree_skb() for a all the packets in a full window's worth of data when recovery completes.

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 09, 2008 at 12:28:27PM +, Gerrit Renker escreveu: Roland, - apparently, i got crashes when loading/unloading other driver modules just after ccid2 or ccid3 had been loaded/unloaded _once_ (have not used them at all, just modprobe module;modprobe -r module) snip the

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Johannes Berg
Rank 1: __ieee80211_rx Warning at net/mac80211/rx.c:1672 Reported 6 times (11 total reports) Same issue that was ranked 2nd last week Johannes has diagnosed this as a driver bug in the iwlwifi drivers More info:

Re: FW: ccid2/ccid3 oopses

2008-01-09 Thread Gerrit Renker
| the easiest way to reproduce is: | | while true;do modprobe dccp_ccid2/3;modprobe -r dccp_ccid2/3;done | after short time, the kernel oopses (messages below) | snip | | Gerrit, the control socket isn't attached to any CCID module, so the | CCID modules should be safe to remove, and

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Paul E. McKenney
On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu [EMAIL PROTECTED] wrote: On Wed, Jan 09, 2008 at 08:38:56AM +0100, Eric Dumazet wrote: I am not sure this is valid, since it will do this : r =

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Paul E. McKenney
On Wed, Jan 09, 2008 at 06:31:26AM -0800, David Miller wrote: From: Paul E. McKenney [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 06:22:58 -0800 On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu [EMAIL PROTECTED] wrote: diff

Re: SACK scoreboard

2008-01-09 Thread John Heffner
David Miller wrote: From: John Heffner [EMAIL PROTECTED] Date: Tue, 08 Jan 2008 23:27:08 -0500 I also wonder how much of a problem this is (for now, with window sizes of order 1 packets. My understanding is that the biggest problems arise from O(N^2) time for recovery because every ack

Re: SACK scoreboard

2008-01-09 Thread Andi Kleen
Postponing freeing of the skb has major drawbacks. Some time ago I Yes, the trick would be to make sure that it also does not tie up too much memory. e.g. it would need some throttling at least. Also the fast path of kmem_cache_free() is actually not that much different from just putting

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread David Miller
From: Paul E. McKenney [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 06:22:58 -0800 On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu [EMAIL PROTECTED] wrote: diff --git a/net/ipv4/route.c b/net/ipv4/route.c index d337706..28484f3

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Andy Gospodarek
On Tue, Jan 08, 2008 at 11:58:34PM -0800, Jay Vosburgh wrote: Krzysztof Oledzki [EMAIL PROTECTED] wrote: Fine. Just let you know that someone test your patches and everything works, except mentioned problem. And I appreciate it; I just wanted to make sure our many fans following

Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
Hi, I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. It fails in the Stateless Address Autoconfiguration section with 6 tests. These tests are for Duplicate Address Detection (DAD). They are detect for the Link Local Address a duplicate address on the network. It seems that

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-09 Thread Arjan van de Ven
Johannes Berg wrote: Rank 1: __ieee80211_rx Warning at net/mac80211/rx.c:1672 Reported 6 times (11 total reports) Same issue that was ranked 2nd last week Johannes has diagnosed this as a driver bug in the iwlwifi drivers More info:

Re: [PATCH 0/0]: Cassini bug fixes.

2008-01-09 Thread Laszlo Attila Toth
David Miller wrote: Over the past day I've put together the following set of bug fixes for the Cassini driver. At least with my setup it appears to basically work fine, not leak memory, and the SKB BUG messages go away too. I'll be honest and say that I've devoted a couple days to this work,

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote: Hi, I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. It fails in the Stateless Address Autoconfiguration section with 6 tests. These tests are for Duplicate Address Detection (DAD). They are detect for the

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil [EMAIL PROTECTED] says: So I think we should disable the interface now, if DAD fails on a hardware based LLA. I don't want to do this, at least, unconditionally. Options (not exclusive): - we could have

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Thu, 10 Jan 2008 01:38:57 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: - we could have dad_reaction interface variable and 1: disable interface = 1: disable IPv6 0: ignore (as we do now) Argh, 0, 0 and 0, maybe. --yoshfuji -- To

Re: Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread John W. Linville
On Wed, Jan 09, 2008 at 09:00:05AM +, [EMAIL PROTECTED] wrote: Hi, I want to make a bond with my wireless card. The ipw driver create two interfaces (wlan0 and wmaster0). When i switch the rf_kill button, ifplug detect wlan0 unplugged but not wmaster0. If i down wlan0 (while rf_kil

[patch net-2.6.25 10/10][NETNS][IPV6] make icmpv6_time sysctl per namespace

2008-01-09 Thread Daniel Lezcano
This patch moves the icmpv6_time sysctl to the network namespace structure. Because the ipv6 protocol is not yet per namespace, the variable is accessed relatively to the initial network namespace. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/netns/ipv6.h |1 +

[patch net-2.6.25 07/10][NETNS][IPV6] make ip6_frags per namespace

2008-01-09 Thread Daniel Lezcano
The ip6_frags is moved to the network namespace structure. Because there can be multiple instances of the network namespaces, and the ip6_frags is no longer a global static variable, a helper function has been added to facilitate the initialization of the variables. Until the ipv6 protocol is not

[patch net-2.6.25 05/10][NETNS][IPV6] make multiple instance of sysctl tables

2008-01-09 Thread Daniel Lezcano
Each network namespace wants its own set of sysctl value, eg. we should not be able from a namespace to set a sysctl value for another namespace , especially for the initial network namespace. This patch duplicates the sysctl table when we register a new network namespace for ipv6. The duplicated

[patch net-2.6.25 04/10][NETNS][IPV6] make the ipv6 sysctl to be a netns subsystem

2008-01-09 Thread Daniel Lezcano
The initialization of the sysctl for the ipv6 protocol is changed to a network namespace subsystem. That means when a new network namespace is created the initialization function for the sysctl will be called. That do not change the behavior of the sysctl in case of the kernel with the network

[patch net-2.6.25 06/10][NETNS][IPV6] make bindv6only sysctl per namespace

2008-01-09 Thread Daniel Lezcano
This patch moves the bindv6only sysctl to the network namespace structure. Until the ipv6 protocol is not per namespace, the sysctl variable is always from the initial network namespace. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/ipv6.h |1 -

[patch net-2.6.25 00/10][NETNS][IPV6] make sysctl per namespace - V3

2008-01-09 Thread Daniel Lezcano
The following patchset makes the ipv6 sysctl to handle multiple network namespaces. Each instance of a network namespace as its own set of sysctl values, that means the behavior of the ipv6 stack can be different depending on the sysctl values setup in the different network namespaces. Changelog:

[patch net-2.6.25 02/10][NETNS][IPV6] make a subsystem for af_inet6

2008-01-09 Thread Daniel Lezcano
This patch add a network namespace subsystem for the af_inet6 module. It does nothing right now, but one of its purpose is to receive the different variables for sysctl in order to initialize them. When the sysctl variable will be moved to the network namespace structure, they will be no longer

[patch net-2.6.25 08/10][NETNS][IPV6] make mld_max_msf readonly in other namespaces

2008-01-09 Thread Daniel Lezcano
The mld_max_msf protects the system with a maximum allowed multicast source filters. Making this variable per namespace can be potentially an problem if someone inside a namespace set it to a big value, that will impact the whole system including other namespaces. I don't see any benefits to

[patch net-2.6.25 03/10][NETNS][IPV6] add ipv6 structure for netns

2008-01-09 Thread Daniel Lezcano
Like the ipv4 part, this patch adds an ipv6 structure in the net structure to aggregate the different resources to make ipv6 per namespace. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/net_namespace.h |4 include/net/netns/ipv6.h| 10 ++ 2 files changed,

[patch net-2.6.25 01/10][NETNS][IPV6] make ipv6_sysctl_register to return a value

2008-01-09 Thread Daniel Lezcano
This patch makes the function ipv6_sysctl_register to return a value. The af_inet6 init function is now able to handle an error and catch it from the initialization of the sysctl. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/ipv6.h |2 +- net/ipv6/af_inet6.c

[patch net-2.6.25 09/10][NETNS][IPV6] make sysctls route per namespace

2008-01-09 Thread Daniel Lezcano
All the sysctl concerning the routes are moved to the network namespace structure. A helper function is called to initialize the variables. Because the ipv6 protocol is not yet per namespace, the variables are accessed relatively from the network namespace. Signed-off-by: Daniel Lezcano [EMAIL

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Jay Vosburgh
Andy Gospodarek [EMAIL PROTECTED] wrote: [...] My initial concern was that a slave device could disappear out from under us, but it seems like this certainly isn't the case since all calls to bond_release are protected by rtnl-locks, so I think you are correct that we are safe. I'll test this on

Re: [NET] ROUTE: fix rcu_dereference() uses in /proc/net/rt_cache

2008-01-09 Thread Eric Dumazet
David Miller a écrit : From: Paul E. McKenney [EMAIL PROTECTED] Date: Wed, 9 Jan 2008 06:22:58 -0800 On Wed, Jan 09, 2008 at 11:37:27AM +0100, Eric Dumazet wrote: On Wed, 9 Jan 2008 20:46:37 +1100 Herbert Xu [EMAIL PROTECTED] wrote: diff --git a/net/ipv4/route.c b/net/ipv4/route.c

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Wed, 9 Jan 2008, Tetsuo Handa wrote: Did you try MSG_WAITALL flag? See man 2 recv. A TCP socket handles data in bytes. You cannot complain if the amount received by recv() is smaller than expected unless you use MSG_WAITALL flag. Yes. It made no difference, as noted in the comments in the

Re: SACK scoreboard

2008-01-09 Thread SANGTAE HA
On Jan 9, 2008 9:56 AM, John Heffner [EMAIL PROTECTED] wrote: I also wonder how much of a problem this is (for now, with window sizes of order 1 packets. My understanding is that the biggest problems arise from O(N^2) time for recovery because every ack was expensive. Have current

Re: [Bridge] Re: [ANNOUNCE] bridge-utils 1.4

2008-01-09 Thread Alon Bar-Lev
On 1/9/08, Denys Fedoryshchenko [EMAIL PROTECTED] wrote: As mentioned in http://marc.info/?l=linux-bridgem=113105949718826w=2 Released package doesn't contain ./configure script For people who know what is make on, it is easy to run autoconf , but some know only how to use ./configure :-)

Re: SACK scoreboard

2008-01-09 Thread John Heffner
SANGTAE HA wrote: On Jan 9, 2008 9:56 AM, John Heffner [EMAIL PROTECTED] wrote: I also wonder how much of a problem this is (for now, with window sizes of order 1 packets. My understanding is that the biggest problems arise from O(N^2) time for recovery because every ack was expensive.

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2008-01-09 Thread Patrick McHardy
Pavel Emelyanov wrote: Hi, Patrick. Pavel Emelyanov wrote: There are tree paths in it, that set the skb-proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto()

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Neil Horman
On Thu, Jan 10, 2008 at 01:38:57AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil [EMAIL PROTECTED] says: So I think we should disable the interface now, if DAD fails on a hardware based LLA. I don't want to do

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Matvejchikov Ilya
Hi folks! I had the same problem too. The solution was the following: http://www.mail-archive.com/netdev@vger.kernel.org/msg37951.html Also have a look at the potential multicasting recovery problem in fs_enet driver: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Best regards,

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-09 Thread Matvejchikov Ilya
Hi folks! I had the same problem too. The solution was the following: http://www.mail-archive.com/netdev@vger.kernel.org/msg37951.html Also have a look at the potential multicasting recovery problem in fs_enet driver: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Best regards,

Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

2008-01-09 Thread Andy Gospodarek
On Wed, Jan 09, 2008 at 09:54:56AM -0800, Jay Vosburgh wrote: Andy Gospodarek [EMAIL PROTECTED] wrote: [...] My initial concern was that a slave device could disappear out from under us, but it seems like this certainly isn't the case since all calls to bond_release are protected by

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
On Wed, Jan 09, 2008 at 11:17:48AM -0500, Neil Horman wrote: On Wed, Jan 09, 2008 at 04:36:56PM +0100, Karsten Keil wrote: Hi, I tried to run the 1.5.0 Beta2 TAHI Selftest on recent Linux kernel. It fails in the Stateless Address Autoconfiguration section with 6 tests. These tests

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread Karsten Keil
On Thu, Jan 10, 2008 at 01:40:51AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 10 Jan 2008 01:38:57 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: - we could have dad_reaction interface variable and 1: disable interface = 1: disable

Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread linel patrice
I'm doing a bonding with my eth0(e1000 driver) and my wlan card(iwl4965). It work like i want, when i'm in wifi the dhcp give me my ethernet adress. When i unplug the cable, my wlan card become in charge of network. My problem is when i disconnect the wlan card, the bonding does not detect it

Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
I'm doing a bonding with my eth0(e1000 driver) and my wlan card(iwl4965). It work like i want, when i'm in wifi the dhcp give me my ethernet adress. When i unplug the cable, my wlan card become in charge of network. My problem is when i disconnect the wlan card, the bonding does not detect it

Re : Re : Bonding : Monitoring of 4965 wireless card

2008-01-09 Thread patnel972-linux
I ignore it, but it seems like it prevent bonding detect link of wlan0. I enslave wlan0 and i already use use_carrier=1; I use bond to have my etherenet ip in wifi at office, else the wireless connection give temporary and you must pass through proxy then. I'll try arp monitoring but this is

[PATCH net-2.6.25 17/19] [NETNS] Pass namespace through ip_rt_ioctl.

2008-01-09 Thread Denis V. Lunev
... up to rtentry_to_fib_config Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/route.h |2 +- net/ipv4/af_inet.c |2 +- net/ipv4/fib_frontend.c |8

[PATCH net-2.6.25 11/19] [NETNS] Show routing information from correct namespace (fib_hash.c)

2008-01-09 Thread Denis V. Lunev
This is the second part (for the CONFIG_IP_FIB_HASH case) of the patch #4, where we have created proc files in namespaces. Now we can dump correct info in them. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]

[PATCH net-2.6.25 9/19] [NETNS] Add netns parameter to inet_(dev_)add_type.

2008-01-09 Thread Denis V. Lunev
The patch extends the inet_addr_type and inet_dev_addr_type with the network namespace pointer. That allows to access the different tables relatively to the network namespace. The modification of the signature function is reported in all the callers of the inet_addr_type using the pointer to the

[PATCH net-2.6.25 7/19] [IPV4] Unify access to the routing tables.

2008-01-09 Thread Denis V. Lunev
Replace the direct pointers to local and main tables with calls to fib_get_table() with appropriate argument. This doesn't introduce additional dereferences, but makes the access to fib tables uniform in any (CONFIG_IP_MULTIPLE_TABLES) case. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by:

[PATCH net-2.6.25 6/19] [NETNS] Refactor fib initialization so it can handle multiple namespaces.

2008-01-09 Thread Denis V. Lunev
This patch makes the fib to be initialized as a subsystem for the network namespaces. The code does not handle several namespaces yet, so in case of a creation of a network namespace, the creation/initialization will not occur. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano

[PATCH net-2.6.25 3/19] [NETNS] Namespacing in the generic fib rules code.

2008-01-09 Thread Denis V. Lunev
Move static rules_ops rules_mod_lock to the struct net, register the pernet subsys to init them and enjoy the fact that the core rules infrastructure works in the namespace. Real IPv4 fib rules virtualization requires fib tables support in the namespace and will be done seriously later in the

[PATCH netns-2.6.25 0/19] routing virtualization v2

2008-01-09 Thread Denis V. Lunev
Hi, Dave! This set adds namespace support for routing tables rules manipulation in the different namespaces. So, one could create a namespace and setup IPv4 routing there how he wants. After this patch user will have the ability to configure and observe its own isolated set of routing

[PATCH net-2.6.25 1/19] [NETNS] Add netns parameter to fib_rules_(un)register.

2008-01-09 Thread Denis V. Lunev
The patch extends the different fib rules API in order to pass the network namespace pointer. That will allow to access the different tables from a namespace relative object. As usual, the pointer to the init_net variable is passed as parameter so we don't break the network. Acked-by: Benjamin

[PATCH net-2.6.25 2/19] [NETNS] Pass fib_rules_ops into default_pref method.

2008-01-09 Thread Denis V. Lunev
fib_rules_ops contains operations and the list of configured rules. ops will become per/namespace soon, so we need them to be known in the default_pref callback. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED]

[PATCH net-2.6.25 4/19] [NETNS] Add namespace to API for routing /proc entries creation.

2008-01-09 Thread Denis V. Lunev
This adds netns parameter to fib_proc_init/exit and replaces __init specifier with __net_init. After this, we will not yet have these proc files show info from the specific namespace - this will be done when these tables become namespaced. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by:

[PATCH net-2.6.25 5/19] [IPV4] Check fib4_rules_init failure.

2008-01-09 Thread Denis V. Lunev
This adds error paths into both versions of fib4_rules_init (with/without CONFIG_IP_MULTIPLE_TABLES) and returns error code to the caller. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] ---

[PATCH net-2.6.25 8/19] [NETNS] Add netns parameter to fib_get_table/fib_new_table.

2008-01-09 Thread Denis V. Lunev
This patch extends the fib_get_table and the fib_new_table functions with the network namespace pointer. That will allow to access the table relatively from the network namespace. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev

[PATCH net-2.6.25 10/19] [NETNS] Add netns to nl_info structure.

2008-01-09 Thread Denis V. Lunev
nl_info is used to track the end-user destination of routing change notification. This is a natural object to hold a namespace on. Place it there and utilize the context in the appropriate places. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by:

[PATCH net-2.6.25 13/19] [NETNS] Namespacing IPv4 fib rules.

2008-01-09 Thread Denis V. Lunev
The final trick for rules: place fib4_rules_ops into struct net and modify initialization path for this. Acked-by: Benjamin Thery [EMAIL PROTECTED] Acked-by: Daniel Lezcano [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/netns/ipv4.h |5 +

  1   2   >