Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Junling Zheng
On 2015/6/2 14:52, Willy Tarreau wrote: > On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: >> On 2015/6/2 14:27, Greg KH wrote: >>> On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: From: Junling Zheng Date: Tue, 2 Jun 2015 12:05:32 +0800 > So, the prob

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Scott Feldman
On Mon, Jun 1, 2015 at 10:24 PM, David Miller wrote: > From: Toshiaki Makita > Date: Tue, 02 Jun 2015 13:51:06 +0900 > >> On 2015/06/02 3:39, sfel...@gmail.com wrote: >>> From: Scott Feldman >>> >>> Remove support for legacy ndo ops >>> .ndo_vlan_rx_add_vid/.ndo_vlan_rx_kill_vid. Rocker will us

[BUG] be2net breaks when dma_alloc_coherent memory is not zeroed out

2015-06-02 Thread Joerg Roedel
Hi, yesterday I bisected an issue with one of my be2net adapters and AMD IOMMU enabled. In 4.1-rc it suddenly broke and didn't initialize anymore. It turned out that the be2net driver breaks when the memory returned from dma_alloc_coherent is not zeroed out. I introduced that change to the AMD IOM

Re: [PATCH net] net/mlx4: double free of dev_vfs

2015-06-02 Thread Or Gerlitz
On Mon, Jun 1, 2015 at 5:41 PM, wrote: > --- a/drivers/net/ethernet/mellanox/mlx4/main.c > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c > @@ -2685,6 +2685,7 @@ disable_sriov: > free_mem: > dev->persist->num_vfs = 0; > kfree(dev->dev_vfs); > + dev->dev_vfs = NULL; >

Re: [PATCH net] net/mlx4: need to call close fw if alloc icm is called twice

2015-06-02 Thread Or Gerlitz
On Mon, Jun 1, 2015 at 5:41 PM, wrote: > --- a/drivers/net/ethernet/mellanox/mlx4/main.c > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c > @@ -2837,6 +2837,7 @@ slave_start: > > existing_vfs, >

[PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes

2015-06-02 Thread Or Gerlitz
When CONFIG_RFS_ACCEL or SMP aren't set, we fail to build, fix it. Also, avoid build warning as of unused function on that setup. Fixes: c66fa19c405a ('net/mlx4: Add EQ pool') Reported-by: Michael Ellerman Signed-off-by: Matan Barak Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/

linux-next: manual merge of the scsi tree with the net-next tree

2015-06-02 Thread Stephen Rothwell
Hi James, Today's linux-next merge of the scsi tree got a conflict in drivers/target/target_core_user.c between commit 5538d294dd66 ("treewide: Add missing vmalloc.h inclusion") from the net-next tree and commit 7ad09a15e76b ("target: Minimize SCSI header #include directives") from the scsi tree.

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Scott Feldman
On Mon, Jun 1, 2015 at 11:50 PM, Guenter Roeck wrote: [cut] > I brought this up before. No idea if my e-mail got lost or what happened. > > We use a fid per port, and a fid per bridge group. With VLANs, this is > completely > ignored, ahd there is only a single fid per vlan for the entire switch

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Oliver Neukum
On Mon, 2015-06-01 at 18:14 -0700, Laura Abbott wrote: > Bluetooth devices off of some buses such as USB may lose power across > suspend/resume. When this happens, drivers may need to have the setup > function called again and behave differently than a cold power on. Yes, but what is the point? We

[PATCH RFC 2/2] cdc_ncm: split the cdc_ncm_ndp funciton

2015-06-02 Thread Enrico Mioso
Split this function in two new ones: - cdc_ncm_ndp16_find: finds an NDP block in the chain mathcing a supplied signature; a pointer to it is returned in case of success; - cdc_ncm_ndp16_push: create and add to skb a new NDP block; cdc_ncm_ndp16_push refers to the last NDP visited by cdc_ncm_ndp1

[PATCH RFC 1/2] cdc_ncm: add the currently processed NDP frame to global driver data

2015-06-02 Thread Enrico Mioso
This is useful to split up the cdc_ncm_ndp function later on. The resulting code will be anyway stateful. Signed-Off-By: Enrico Mioso --- include/linux/usb/cdc_ncm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb/cdc_ncm.h b/include/linux/usb/cdc_ncm.h index 7c9b484..91722

[PATCH RFC 0/2] cdc_ncm refactoring

2015-06-02 Thread Enrico Mioso
I changed my mind, and decided to try in following this new way. This series splits the cdc_ncm_ndp function in two parts: - one that finds NDP blocks already present in the SKB being sent out - one that pushes new ones, starting from where the _find function left. After this splitting it seems mo

[PATCH] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Denis Kirjanov
Perform the address length check first, before calling the the proto specific bind() function Signed-off-by: Denis Kirjanov --- net/ipv4/af_inet.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 6ad0f7a..333e2fa 100644 -

Re: [PATCH net-next v2 01/14] sfc: Add code to export port_num in netdev->dev_port

2015-06-02 Thread Shradha Shah
On 01/06/15 20:01, David Miller wrote: > From: Shradha Shah > Date: Mon, 1 Jun 2015 14:00:12 +0100 > >> In the case where we have multiple functions (PFs and VFs), this >> sysfs entry is useful to identify the physical port corresponding >> to the function we are interested in. >> >> Signed-off

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-02 Thread Jouni Malinen
On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote: > Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg: > >IOW, I think something like this would make sense: > > That looks definitely cleaner :-) Indeed.. That AAD length-in-the-buffer design came from the over ten year old cod

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

2015-06-02 Thread Wei Liu
Hi Eric Sorry for coming late to the discussion. On Thu, Apr 16, 2015 at 05:42:16AM -0700, Eric Dumazet wrote: > On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: > > > He suggested that after he'd been prodded by 4 more e-mails in which two > > of us guessed what he was trying to get at.

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Luis Henriques
On Tue, Jun 02, 2015 at 03:05:57PM +0800, Junling Zheng wrote: > On 2015/6/2 14:52, Willy Tarreau wrote: > > On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: > >> On 2015/6/2 14:27, Greg KH wrote: > >>> On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: > From: Junling

nouveau + netpoll: BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2015-06-02 Thread Meelis Roos
I recently activated netconsole on one of my computers to debug boot crash with big IOMMU size. Left netconsole on and got the BUG about sleeping function called from invalid context when netconsole is doing printk during nouveau initialization. Full dmesg and .configare below. [0.00]

[PATCH net-next v3 00/15] sfc: ndo_get_phys_port_id, vadaptor stats and PF unload when Vf's assigned to guest

2015-06-02 Thread Shradha Shah
This is the third and last instalment of SRIOV for EF10 patches. This patch set includes implementation of ndo_get_phys_port_id and changes to the MAC statistics code in order to support vadaptor statistics. It also includes code to deal with PF unload when Vf's are still assigned to the guest.

[PATCH net-next v3 03/15] sfc: Add sysfs entry for flags (link control and primary)

2015-06-02 Thread Shradha Shah
On every adapter there will be one primary PF per adaptor and one link control PF per port. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10.c | 58 - 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef1

[PATCH net-next v3 02/15] sfc: Add paranthesis correctly on all branches of the if statement

2015-06-02 Thread Shradha Shah
This change is a stylistic change and does not affect functionality. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 06605ab..14c520

[PATCH net-next v3 01/15] sfc: Add code to export port_num in netdev->dev_port

2015-06-02 Thread Shradha Shah
In the case where we have multiple functions (PFs and VFs), this sysfs entry is useful to identify the physical port corresponding to the function we are interested in. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/n

[PATCH net-next v3 05/15] sfc: add "port_" prefix to MAC stats

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko The MAC stats are per-port and will only be displayed on the PF with control of the link (one per physical port). Vadapter stats will also be displayed for this PF, so distinguish the MAC stats by adding a prefix of "port_". Signed-off-by: Shradha Shah --- drivers/net/ethe

[PATCH net-next v3 04/15] sfc: Implement ndo_gets_phys_port_id() for EF10 VFs

2015-06-02 Thread Shradha Shah
Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10.c | 11 +++ drivers/net/ethernet/sfc/ef10_sriov.c | 14 ++ drivers/net/ethernet/sfc/ef10_sriov.h | 3 +++ drivers/net/ethernet/sfc/efx.c| 1 + drivers/net/ethernet/sfc/net_driver.h | 2 ++ drivers/n

[PATCH net-next v3 06/15] sfc: set the port-id when calling MC_CMD_MAC_STATS

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko The port-id must be known so that the RMON level can be set for the collection of vadapter stats. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/mcdi_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/sfc/mcdi_port.c b/drivers/net/

[PATCH net-next v3 07/15] sfc: display vadaptor statistics for all interfaces

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko All interfaces will display vadaptor statistics, so set all the relevant bits in the stats bitmask. Only functions with the LINKCTRL flag will see other stats, including (per-port) MAC stats. The vadaptor stats are from rx_unicast to tx_overflow. Signed-off-by: Shradha Shah

[PATCH net-next v3 09/15] sfc: update netdevice statistics to use vadaptor stats

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko The netdevice statistics (in /proc/net/dev) are per-function stats so they must use the vadaptor stats. Change the use of MAC stats to vadaptor stats, and remove any statistics that can only be measured per-port. All stats that are removed will be shown as zeroes when these

[PATCH net-next v3 08/15] sfc: DMA the VF stats only when requested

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko Firmware does not support a periodic DMA of vadaptor-stats on VFs, so only update the stats buffer when stats are requested (when running "ethtool -S" or an ip/ifconfig command that reports stats). Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10.c | 149

[PATCH net-next v3 12/15] sfc: don't update stats on VF when called in atomic context

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko The ifenslave command to set up a bond runs in an atomic context, and it queries the stats on the devices that are being enslaved. A VF needs to make an MCDI call to update its stats, which is not allowed in atomic context. The releasing of the stats_lock is moved to the beg

[PATCH net-next v3 11/15] sfc: suppress vadaptor stats when EVB is not present

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko The raw_mask array is not initialised, so it needs to be explicitly set to zero in the 'else' branch. If the EVB capability is not present, a port cannot have multiple functions so the per-port MAC stats are correct and should match the corresponding vadaptor stats, so this

[PATCH net-next v3 13/15] sfc: do not allow VFs to be destroyed if assigned to guests

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/ef10_sriov.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c index cd52454..083c534 100644 --- a/drivers/net/ethernet/sfc/ef1

[PATCH net-next v3 10/15] sfc: suppress ENOENT error messages from MC_CMD_MAC_STATS

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko MC_CMD_MAC_STATS can be called on a function before a vadaptor has been created, as the kernel can call into this through ndo_get_stats/ndo_get_stats64. If MC_CMD_MAC_STATS is called before the DMA queues have been setup, so that a vadaptor has not been created yet, firmware

[PATCH net-next v3 15/15] sfc: leak vports if a VF is assigned during PF unload

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko If any VF is assigned as the PF is unloaded, do not attempt to remove its vport or the vswitch. These will be removed if the driver binds to the PF again, as an entity reset occurs during probe. A 'force' flag is added to efx_ef10_pci_sriov_disable() to distinguish between

[PATCH net-next v3 14/15] sfc: force removal of VF and vport on driver removal

2015-06-02 Thread Shradha Shah
From: Daniel Pieczko When the driver unloads, force the unbind and removal of any VFs in the host with the PF. The PF cannot remove vports and vswitches if they are still being used by a VF driver, and when unloading the sfc driver the removal order is not guaranteed, so the instruction from the

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Jamal Hadi Salim
On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says master is the default. Want we want, I believe, is to adjust what the man page says (and the bridge vlan command itself), by making the default master and self. The kernel and driver are fine

[net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Denis Kirjanov
Perform the address length check first, before calling the proto specific bind() function Signed-off-by: Denis Kirjanov v2: add the proper tag tp the subject --- net/ipv4/af_inet.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_ine

[PATCH] ethernet: micrel: use time_after_eq

2015-06-02 Thread Antonio Murdaca
use the time_after_eq macro for jiffies comparison operation Signed-off-by: Antonio Murdaca --- drivers/net/ethernet/micrel/ksz884x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index 6f332eb..

[PATCH RESEND net] openvswitch: disable LRO

2015-06-02 Thread Jiri Benc
Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the user space, do the same as bridging does and call dev_disable_lro in th

Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.14-stable tree

2015-06-02 Thread gregkh
This is a note to let you know that I've just added the patch titled net: socket: Fix the wrong returns for recvmsg and sendmsg to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Andrew Lunn
> +int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port, u16 vid, > + u16 bridge_flags) > +{ > + struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + struct mv88e6xxx_vtu_entry entry = { 0 }; > + int prev_vid = vid ? vid - 1 : 4095; > + int i, ret; >

Re: [PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-06-02 Thread Andy Gospodarek
On Mon, Jun 01, 2015 at 04:05:56PM -0700, David Miller wrote: > From: Simon Horman > Date: Mon, 1 Jun 2015 13:25:04 +0900 > > > The rocker (switch) of a rocker_port may be trivially obtained from > > the latter it seems cleaner not to pass the former to a function when > > the latter is being pa

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Robert Shearman
On 02/06/15 01:06, Thomas Graf wrote: On 06/01/15 at 05:46pm, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an i

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Guenter Roeck
On 06/02/2015 12:44 AM, Scott Feldman wrote: On Mon, Jun 1, 2015 at 11:50 PM, Guenter Roeck wrote: [cut] I brought this up before. No idea if my e-mail got lost or what happened. We use a fid per port, and a fid per bridge group. With VLANs, this is completely ignored, ahd there is only a si

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Andrew Lunn
> Also, we already have cases where the switch is connected to the CPU with > more than one Ethernet port. It is easy to imagine that the user of such > a system might want to configure two bridge groups. Hi Guenter I think that is orthogonal. Having multiple CPU ports should really only be see

Re: [PATCH] sctp: fix ASCONF list handling

2015-06-02 Thread Neil Horman
On Mon, Jun 01, 2015 at 07:28:21PM -0300, Marcelo Ricardo Leitner wrote: > On Mon, Jun 01, 2015 at 10:00:28AM -0400, Neil Horman wrote: > > On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: > > > On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: > > > > On Thu, May

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy in the monitor control register, since this feature is not needed. Signed-off-by: Vivien Didelot Should this be a separate patch, unrelated to the patch set ? If I understand correctly, this effectively disables IGMP/

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Josh Boyer
On Mon, Jun 1, 2015 at 9:28 PM, Marcel Holtmann wrote: > Hi Laura, > >> Bluetooth devices off of some buses such as USB may lose power across >> suspend/resume. When this happens, drivers may need to have the setup >> function called again and behave differently than a cold power on. >> Add a rese

Re: [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch disables egress of unknown unicast destination addresses. Hi Vivien, seems to me this patch is unrelated to the rest of the series. Not sure if we really want this. If an address is in the arp cache but has timed out from the bridge da

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit disables SA learning and refreshing for the CPU port. Hi Vivien, This patch also seems to be unrelated to the rest of the series. Can you add an explanation why it is needed ? With this in place, how does the CPU port SA find its way

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: > On 06/02/15 03:10, Scott Feldman wrote: > > >> Actually, we're now consistent with bridge man page which says master >> is the default. >> >> Want we want, I believe, is to adjust what the man page says (and the >> bridge vlan command itsel

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 14 +++--- drivers/net/dsa/mv

Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-06-02 Thread Josh Hunt
On 05/29/2015 09:37 PM, Josh Hunt wrote: On 05/29/2015 04:48 PM, Tom Herbert wrote: Hi Josh, Why did you need to move the resubmit label? Grabbing nhoff out of the skb's cb didn't seem relevant anymore, unless we're requiring the decapsulating code to update the control block before it return

Re: [net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Hannes Frederic Sowa
Hello, On Tue, Jun 2, 2015, at 14:21, Denis Kirjanov wrote: > Perform the address length check first, before calling > the proto specific bind() function Can you give more detail why you did this change and what bug it fixes? Thanks, Hannes -- To unsubscribe from this list: send the line "unsubs

[PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-02 Thread Dan Murphy
Add support for the TI dp83867 Gigabit ethernet phy device. The DP83867 is a robust, low power, fully featured Physical Layer transceiver with integrated PMD sublayers to support 10BASE-T, 100BASE-TX and 1000BASE-T Ethernet protocols. Signed-off-by: Dan Murphy --- v2 - Add device tree support a

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch adds the glue between DSA and switchdev to add and delete SWITCHDEV_OBJ_PORT_VLAN objects. This will allow the DSA switch drivers implementing the port_vlan_add and port_vlan_del functions to access the switch VLAN database through userspa

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Guenter Roeck
On 06/02/2015 06:42 AM, Andrew Lunn wrote: Also, we already have cases where the switch is connected to the CPU with more than one Ethernet port. It is easy to imagine that the user of such a system might want to configure two bridge groups. Hi Guenter I think that is orthogonal. Having multi

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:24:39AM +, Joao Martins wrote: > > On 19 May 2015, at 17:23, Wei Liu wrote: > > On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: > >> Introduces persistent grants for TX path which follows similar code path > >> as the grant mapping. > >> > >> It start

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Andrew Lunn
On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >Disable the mirroring policy in the monitor control register, since this > >feature is not needed. > > > >Signed-off-by: Vivien Didelot > > Should this be a separate patch, unrelated

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Marcel Holtmann
Hi Josh, >>> Bluetooth devices off of some buses such as USB may lose power across >>> suspend/resume. When this happens, drivers may need to have the setup >>> function called again and behave differently than a cold power on. >>> Add a reset_resume function for drivers to call. During the >>> re

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:25:10AM +, Joao Martins wrote: > > On 19 May 2015, at 17:32, Wei Liu wrote: > > > On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: > >> It starts by doing a lookup in the tree for a gref. If no persistent > >> grant is found on the tree, it will do gra

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-06-02 Thread Wei Liu
On Fri, May 22, 2015 at 10:26:48AM +, Joao Martins wrote: [...] > >>return IRQ_HANDLED; > >> } > >> @@ -168,8 +169,12 @@ static int xenvif_start_xmit(struct sk_buff *skb, > >> struct net_device *dev) > >>cb = XENVIF_RX_CB(skb); > >>cb->expires = jiffies + vif->drain_timeout; > >>

Re: [net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Denis Kirjanov
On 6/2/15, Hannes Frederic Sowa wrote: > Hello, > > On Tue, Jun 2, 2015, at 14:21, Denis Kirjanov wrote: >> Perform the address length check first, before calling >> the proto specific bind() function > > Can you give more detail why you did this change and what bug it fixes? I've sent the v2 vers

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an interface for each "tunnel" endpoint doesn't

Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread roopa
On 6/1/15, 3:58 PM, David Miller wrote: From: Roopa Prabhu Date: Wed, 27 May 2015 11:37:05 -0700 - if (rtm->rtm_scope != RT_SCOPE_UNIVERSE) - goto errout; + if (nlh->nlmsg_type != RTM_DELROUTE && + rtm->rtm_scope != RT_SCOPE_UNIVERSE) +

Re: [RFC net-next 2/3] ipv4: storing and retrieval of per-nexthop encap

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: Parse RTA_ENCAP attribute for one path and multipath routes. The encap length is stored in a newly added field to fib_nh, nh_encap_len, although this is added to a padding hole in the structure so that it doesn't increase the size at all. The encap data

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWST. It uses the encap data which w

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

2015-06-02 Thread Eric Dumazet
On Tue, 2015-06-02 at 10:52 +0100, Wei Liu wrote: > Hi Eric > > Sorry for coming late to the discussion. > > On Thu, Apr 16, 2015 at 05:42:16AM -0700, Eric Dumazet wrote: > > On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: > > > > > He suggested that after he'd been prodded by 4 more e-m

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Robert Shearman
On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWS

Re: [RFC net-next 2/3] ipv4: storing and retrieval of per-nexthop encap

2015-06-02 Thread Robert Shearman
On 02/06/15 17:01, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Parse RTA_ENCAP attribute for one path and multipath routes. The encap length is stored in a newly added field to fib_nh, nh_encap_len, although this is added to a padding hole in the structure so that it doesn't increase

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread roopa
On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says master is the default. Want we want, I believe, is to adjust what the man page says (and th

[PATCH 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index c6dc1dfd25d5..9ddf

[PATCH 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on funciton 0 or there will be an infinite recursion.

BOOKING=============

2015-06-02 Thread Mr David Brink
I am writing you this email to make reservations for my family at your hotel. Arrival day : 15/06/2015 Departure day: 30/06/2015 Number Of Gusts: 4 Adult Kindly send the total quotation so as to forward my card for the full payment only. Thanks Mr David Brink -- To unsubscribe from this list: se

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-06-02 Thread roopa
On 5/27/15, 9:01 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov wrote: On Wed, May 27, 2015 at 9:59 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov wrote: On Tue, May 26, 2015 at 7:28 PM, Stephen Hemminger wrote: On Thu, 21 May

Re: [Intel-wired-lan] [PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Alexander Duyck
On 06/02/2015 10:04 AM, Mark D Rustad wrote: Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on fun

[PATCH net-next V10 0/4] openvswitch: Add support for 802.1AD

2015-06-02 Thread Thomas F Herbert
Add support for 802.1AD to the openvswitch kernel module. V10: Implement reviewer comments: Consolidate vlan parsing functions. Splits netlink parsing and flow conversion into a separate patch. Uses double encap attribute encapsulation for 802.1ad. Netlink attributes now look like this: eth_

[PATCH net-next V10 2/4] General check for vlan ethernet types

2015-06-02 Thread Thomas F Herbert
This patch adds a function to check for vlan ethernet types. There is a use case in openvswitch and it should be useful elsewhere. Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_v

[PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow_netlink.c | 186 ++--- 1 file changed, 157 insertions(+), 29 deletio

[PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow.c | 82 ++ net/openvswitch/flow.h | 3 ++ 2 files changed, 73 insertions(+), 12 deletions(-) diff --git a/

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Flavio Leitner
It seems patch 01 didn't make it to ovs dev mailing list, but it is available on netdev mailing list. fbl -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-next V10 1/4] openvswitch: 802.1ad uapi changes.

2015-06-02 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op

[PATCH 00/10] net: thunderx: fix problems reported by static check tools

2015-06-02 Thread Aleksey Makarov
These are fixes for the problems that were reported by static check tools. Aleksey Makarov (9): net: thunderx: fix constants net: thunderx: introduce a function for mailbox access net: thunderx: rework mac address handling net: thunderx: delete unused variables net: thunderx: add static

[PATCH 04/10] net: thunderx: rework mac address handling

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:385:40: sparse: cast to restricted __le64 Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nic.h | 4 ++-- drivers/net/ethernet/cavium/thunder/nic_main.c

[PATCH 07/10] net: thunderx: fix nicvf_set_rxfh()

2015-06-02 Thread Aleksey Makarov
This fixes a copypaste bug that was discovered by a static analysis tool: The patch 4863dea3fab0: "net: Adding support for Cavium ThunderX network controller" from May 26, 2015, leads to the following static checker warning: drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c:517 nicvf_se

[PATCH 03/10] net: thunderx: introduce a function for mailbox access

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:153:25: sparse: cast to restricted __le64 Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 27 +++- 1 file changed, 17 insertions(

[PATCH 05/10] net: thunderx: delete unused variables

2015-06-02 Thread Aleksey Makarov
They were left from development stage Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethe

[PATCH 09/10] net: thunderx: check if memory allocation was successful

2015-06-02 Thread Aleksey Makarov
This fixes a coccinelle warning: coccinelle warnings: (new ones prefixed by >>) >> drivers/net/ethernet/cavium/thunder/nicvf_queues.c:360:1-11: alloc >> with no test, possible model on line 367 vim +360 drivers/net/ethernet/cavium/thunder/nicvf_queues.c 354 err = nicvf_alloc_q_desc_

[PATCH 10/10] net: thunderx: use GFP_KERNEL in thread context

2015-06-02 Thread Aleksey Makarov
GFP_KERNEL should be used in the thread context Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicv

[PATCH 08/10] net: thunderx: remove unneeded type conversions

2015-06-02 Thread Aleksey Makarov
No need to cast void* to u8*: pointer arithmetics works same way for both. Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net

[PATCH 06/10] net: thunderx: add static

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/nicvf_main.c:1141:26: sparse: symbol 'nicvf_get_stats64' was not declared. Should it be static? Also remove unused declarations Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavi

[PATCH 02/10] net: thunderx: fix constants

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/thunder_bgx.c:897:24: sparse: constant 0x3000 is so big it is long Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 10 +- 1 file change

[PATCH 01/10] net: thunderx: Cleanup duplicate NODE_ID macros, add nic_get_node_id()

2015-06-02 Thread Aleksey Makarov
From: Robert Richter There are duplicate NODE_ID macro definitions. Move all of them to nic.h for usage in nic and bgx driver and introduce nic_get_node_id() helper function. This patch also fixes 64bit mask which should have been ULL by reworking the node calculation. Signed-off-by: Robert Ric

Re: [Intel-wired-lan] [PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Rustad, Mark D
> On Jun 2, 2015, at 10:48 AM, Alexander Duyck > wrote: > > I'm pretty sure these could cause some serious errors if you direct assign > the device into a VM since you then end up with multiple devices sharing a > bus. Also it would likely have side-effects on a LOM (Lan On Motherboard) as >

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > In order to be able to function as a Label Edge Router in an MPLS > network, it is necessary to be able to take IP packets and impose an > MPLS encap and forward them out. The traditional approach of setting > up an interface for each "tunnel" endpoint doesn't scale for

Re: [RFC net-next 1/3] net: infra for per-nexthop encap data

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > Having to add a new interface to apply encap onto a packet is a > mechanism that works well today, allowing the setup of the encap to be > done separately from the routes out of them, meaning that routing > protocols and other user-space apps don't need to do anything sp

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > Allow creating an mpls device for the purposes of encapsulating IP > packets with: > > ip link add type ipmpls > > This device defines its per-nexthop encapsulation data as a stack of > labels, in the same format as for RTA_NEWST. It uses the encap data > which will ha

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
roopa writes: > On 6/1/15, 9:46 AM, Robert Shearman wrote: >> In order to be able to function as a Label Edge Router in an MPLS >> network, it is necessary to be able to take IP packets and impose an >> MPLS encap and forward them out. The traditional approach of setting >> up an interface for ea

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/2/15, 11:30 AM, Eric W. Biederman wrote: roopa writes: On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approa

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack o

  1   2   >