Re: [PATCH] HTB O(1) class lookup

2007-02-06 Thread Jarek Poplawski
On Mon, Feb 05, 2007 at 06:14:13PM +0100, Simon Lodal wrote: On Monday 05 February 2007 11:16, Jarek Poplawski wrote: On 01-02-2007 12:30, Andi Kleen wrote: Simon Lodal [EMAIL PROTECTED] writes: Memory is generally not an issue, but CPU is, and you can not beat the CPU efficiency of

Re: [RESEND PATCH 0/7] [S390]: Introduction of AF_IUCV sockets support

2007-02-06 Thread Heiko Carstens
On Mon, Feb 05, 2007 at 03:00:50PM +0100, Frank Pavlic wrote: Hello, seems that Patch 1/7 is lost and did not make its way to the mailing list :-( That's the reason why I resend the whole patch set again. Here we go ... [...] [1/7] [S390]: Rewrite of the IUCV base code, part 1 Patch 1 has

RE: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-06 Thread Steve Hill
Vlad Yasevich wrote on 05 February 2007 20:35: would you mind terribly, changing the -d $net to the -i $net, and run the script with the interface name instead? I seem to get the same failure when dropping traffic based on interface as I do when dropping based on address. When I block at the

Re: [PATCH 7/7] [S390]: Add AF_IUCV socket support

2007-02-06 Thread Christoph Hellwig
-#define NPROTO 32 /* should be enough for now.. */ +#define NPROTO 33 /* should be enough for now.. */ You can't simply increase NPROTO, but there should be holes left. Ask DaveM for a proper allocation. - To unsubscribe from this

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Martin Josefsson
On Mon, 5 Feb 2007, David Miller wrote: Let's audit NF_CT_STAT_INC() usage to make sure :-) net/netfilter/nf_conntrack_core.c: destroy_conntrack: Inside write_{lock,unlock}_bh(). death_by_timeout: Ditto. __nf_conntrack_find: Inside read_{lock,unlock}_bh() via callers.

Re: spidernet: dynamic phy setup code

2007-02-06 Thread Ishizaki Kou
Ben-san, Jens-san Thanks for your comments and advices. First, we should apologize to you that some troubles which we informed about spidernet auto-negotiation are caused by our mistake. We used wrong MACRO for advertise variable to phy-def-ops-setup_aneg(). We will post the revised patch for

Re: [PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:17:09PM +0300, Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 07:00:44PM +0200, Ahmed S. Darwish wrote: A trivial patch to use ARRAY_SIZE macro. You're supposed to remove it ans use ARRAY_SIZE where old macro is used. --- a/drivers/net/wireless/wavelan.p.h

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. Remove it and use ARRAY_SIZE instead. --- a/drivers/net/ixgb/ixgb_param.c +++

Re: [PATCH 2.4 0/3] e1000: update to 7.3.20

2007-02-06 Thread Willy Tarreau
Hi Auke, On Mon, Feb 05, 2007 at 05:01:02PM -0800, Kok, Auke wrote: Willy, Please pull: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.4 e1000 to receive an update for the e1000 driver. This updates the e1000 driver in the 2.4 kernel to version 7.3.20-k4, roughly the

[PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-06 Thread Li Yang
Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 29 ++--- 1 files changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index

[PATCH 2/4] ucc_geth: Switch kmalloc to kzalloc and clean some redundant kmalloc casts

2007-02-06 Thread Li Yang
From: Ahmed S. Darwish [EMAIL PROTECTED] Switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 21 - 1 files changed, 8 insertions(+), 13

[PATCH 3/4] ucc_geth: Remove obsolete workaround of link speed change

2007-02-06 Thread Li Yang
The workaround used a long delay of 4s which caused problem when two link-changes happens at the same time. Signed-off-by: Li Yang [EMAIL PROTECTED] Signed-off-by: Wu Xiaochuan [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 71 +++

[PATCH 4/4] ucc_geth: Add support to local-mac-address property

2007-02-06 Thread Li Yang
IEEE-1275 defines “local-mac-address” to be a standard property name to specify preassigned network address. This patch adds support for it. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Ingo Molnar
* Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 05 Feb 2007 18:44:08 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: I bet this rcu_read_lock()-implies-preempt_disable() assumption has spread into other areas of the tree as well. Me too. Although one expects that other holes

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Neil Horman
On Tue, Feb 06, 2007 at 10:24:05AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. snip Thank you Yoshifuji. To be honest, I've been focused on functionality rather than pretty so far, figuring I'd clean up the tabbing from my various patch inclusions/reversions when we had agreed that the

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-06 Thread Kumar Gala
On Feb 6, 2007, at 5:31 AM, Li Yang wrote: Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Nack. iopa() isn't that generic, shouldn't we really be using the dma mapping API here? - k Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 29

IP_FREEBIND and CAP_NET_ADMIN (was: Re: [PATCH/RFC 05/10] Remove local address check on IP output)

2007-02-06 Thread KOVACS Krisztian
On Wednesday 10 January 2007 07:47, Patrick McHardy wrote: KOVACS Krisztian wrote: ip_route_output() contains a check to make sure that no flows with non-local source IP addresses are routed. Unfortunately this check makes it completely impossible to use non-local bound sockets as no

[PATCH v3] d80211: Add control structure for beacontemplates

2007-02-06 Thread Ivo van Doorn
Previous send v2 had a null pointer error in it. When rt2500usb and rt73usb will start using beacontemplates, they would also need a control structure to be passed along to correctly set the tx parameters. This patch will add a ieee80211_tx_control pointer to the ieee80211_if_init_conf structure.

Re: [patch 01/11] user of the jiffies rounding code: Networking

2007-02-06 Thread Auke Kok
David Miller wrote: From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:30:52 -0800 From: Arjan van de Ven [EMAIL PROTECTED] This patch introduces users of the round_jiffies() function in the networking code. These timers all were of the about once a second or about once every X seconds

[PATCH 0/7] sky2 v1.12 patches

2007-02-06 Thread Stephen Hemminger
New driver version for 2.6.21 inclusion: * WOL * TSO support for 88E8055 * more PCI id's * experimental support for Yukon Extreme Patches are against current netdev-2.6#upstream -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH 2/7] sky2: use dev_err for error reports

2007-02-06 Thread Stephen Hemminger
Use the standard dev_xxx functions instead of printk directly for error reports. Fix a bug where the initialization would return 0 if allocation of network device failed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 75

[PATCH 7/7] sky2: version 1.12

2007-02-06 Thread Stephen Hemminger
Updated version for WOL and new id's Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- sky2-dev.orig/drivers/net/sky2.c2007-02-06 10:44:29.0 -0800 +++ sky2-dev/drivers/net/sky2.c 2007-02-06

[PATCH 5/7] sky2: Yukon Extreme support

2007-02-06 Thread Stephen Hemminger
This is basic support for the new Yukon Extreme chip, extracted from the new vendor driver 10.0.4.3. Since this is untested hardware, it has a big fat warning for now. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 49

[PATCH 3/7] sky2: TSO support for EC_U

2007-02-06 Thread Stephen Hemminger
The Yukon EC_U chipset apparently supports TSO but only for non-Jumbo frame sizes because it lacks a Ram buffer. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- sky2-dev.orig/drivers/net/sky2.c

[PATCH 4/7] sky2: safer transmit timeout

2007-02-06 Thread Stephen Hemminger
Rather than trying to be smart about possible transmit timeout causes. Just clear all pending frames and reset the PHY. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-)

[PATCH 1/7] sky2: add Wake On Lan support

2007-02-06 Thread Stephen Hemminger
Adds basic magic packet wake on lan support to the sky2 driver. Note: initial WOL value is based on BIOS settings. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 208 ++--- drivers/net/sky2.h | 28 ++- 2 files

[PATCH 6/7] sky2: add new chip ids

2007-02-06 Thread Stephen Hemminger
More new chip id's from vendor driver version 10.0.4.3 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |4 1 file changed, 4 insertions(+) --- sky2-dev.orig/drivers/net/sky2.c2007-02-06 10:44:26.0 -0800 +++ sky2-dev/drivers/net/sky2.c 2007-02-06

Re: [RFC/TOY]Extensible hashing and RCU

2007-02-06 Thread linux
For purposes of discussion, I've attached a toy implementation for doing dynamic resizing of a hashtable. It is useless, except as a proof of concept. I think this is very similar to what you are describing, no? Er... not quite; that has a lot more overhead than what I was thinking about.

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 6 Feb 2007 13:34:01 +0100 * Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 05 Feb 2007 18:44:08 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: I bet this rcu_read_lock()-implies-preempt_disable() assumption has spread into

Re: IP_FREEBIND and CAP_NET_ADMIN

2007-02-06 Thread David Miller
From: KOVACS Krisztian [EMAIL PROTECTED] Date: Tue, 6 Feb 2007 15:36:18 +0100 Neither of these require IP_FREEBIND as core functionality, and will probably work if IP_FREEBIND would be bound to CAP_NET_ADMIN. So the question is: shall we take the IP_FREEBIND approach, this would change a

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Neil Horman
On Tue, Feb 06, 2007 at 07:51:44AM -0500, Neil Horman wrote: On Tue, Feb 06, 2007 at 10:24:05AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. snip Thank you Yoshifuji. To be honest, I've been focused on functionality rather Ok, New patch attached, taking Vlad and Yoshifujis latest

[PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread Eric Dumazet
Hi David During an oprofile session of linux-2.6.20 on a dual opteron system, I noticed an expensive divide was done in tg3_poll(). I am using gcc-4.1.1, so the following comment from drivers/net/tg3.c seems over-optimistic : /* Do not place this n-ring entries value into the tp struct

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: that was pretty much the only place in the whole kernel that got hit by some rcu-preempt side-effect - and even this appears to show that it's a real bug that was in hiding. No, rather, it's the only location that triggered an automated

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 21:53:24 +0100 I am using gcc-4.1.1, so the following comment from drivers/net/tg3.c seems over-optimistic : /* Do not place this n-ring entries value into the tp struct itself, * we really want to expose these constants to GCC

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread Michael Chan
On Tue, 2007-02-06 at 21:53 +0100, Eric Dumazet wrote: Signed-off-by: Eric Dumazet [EMAIL PROTECTED] plain text document attachment (tg3_avoid_divide.patch) --- linux-2.6.20/drivers/net/tg3.c.orig 2007-02-06 22:30:39.0 +0100 +++ linux-2.6.20-ed/drivers/net/tg3.c 2007-02-06

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 6 Feb 2007 22:02:51 +0100 So i'm wondering what other assumptions there are (or can be) about rcu_read_lock() also being a preempt-off point. Thanks! I showed the examples in my detailed analysis yesterday. Beause I love hearing myself say the

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread Michael Chan
On Tue, 2007-02-06 at 13:19 -0800, David Miller wrote: Because I've seen gcc optimize this properly before (at least on sparc64), it means that either: 1) There is a GCC bug where the properties of the constants do not propagate. 2) GCC really thinks the divide is cheaper (code

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 14:05:41 -0800 On Tue, 2007-02-06 at 21:53 +0100, Eric Dumazet wrote: Signed-off-by: Eric Dumazet [EMAIL PROTECTED] plain text document attachment (tg3_avoid_divide.patch) --- linux-2.6.20/drivers/net/tg3.c.orig 2007-02-06

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 14:09:16 -0800 No objections. I will create another patch to convert similar divisions in other spots. I actually checked and those cases work on true constants so do not generate the divide instructions. - To unsubscribe from this

Re: [Ipw2100-devel] [RFC] Runtime power management on ipw2100

2007-02-06 Thread Matthew Garrett
On Thu, Feb 01, 2007 at 09:47:05AM +0800, Zhu Yi wrote: On Wed, 2007-01-31 at 07:52 +, Matthew Garrett wrote: From my understanding, the intention of this patch is to defer the device self-initialization work (including firmware loading) from netdev initialization time to netdev open time

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread Eric Dumazet
Michael Chan a écrit : On Tue, 2007-02-06 at 21:53 +0100, Eric Dumazet wrote: Signed-off-by: Eric Dumazet [EMAIL PROTECTED] plain text document attachment (tg3_avoid_divide.patch) --- linux-2.6.20/drivers/net/tg3.c.orig 2007-02-06 22:30:39.0 +0100 +++ linux-2.6.20-ed/drivers/net/tg3.c

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-06 Thread Vlad Yasevich
Steve Hill wrote: Vlad Yasevich wrote on 05 February 2007 20:35: would you mind terribly, changing the -d $net to the -i $net, and run the script with the interface name instead? I seem to get the same failure when dropping traffic based on interface as I do when dropping based on

Re: [PATCH 5/7] sky2: Yukon Extreme support

2007-02-06 Thread Francois Romieu
Stephen Hemminger [EMAIL PROTECTED] : [...] @@ -289,8 +289,10 @@ struct sky2_port *sky2 = netdev_priv(hw-dev[port]); u16 ctrl, ct1000, adv, pg, ledctrl, ledover, reg; - if (sky2-autoneg == AUTONEG_ENABLE - !(hw-chip_id == CHIP_ID_YUKON_XL || hw-chip_id ==

Fw: [Bugme-new] [Bug 7952] New: slattach only works every other time

2007-02-06 Thread Andrew Morton
Begin forwarded message: Date: Tue, 6 Feb 2007 13:01:55 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7952] New: slattach only works every other time http://bugzilla.kernel.org/show_bug.cgi?id=7952 Summary: slattach only works every other time

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: From: Ingo Molnar [EMAIL PROTECTED] Date: Tue, 6 Feb 2007 22:02:51 +0100 So i'm wondering what other assumptions there are (or can be) about rcu_read_lock() also being a preempt-off point. Thanks! I showed the examples in my detailed analysis

Re: [PATCH 5/7] sky2: Yukon Extreme support

2007-02-06 Thread Stephen Hemminger
static bool is_yukon_extreme(struct sky2_hw *hw) { return hw-chip_id == CHIP_ID_YUKON_XL || hw-chip_id == CHIP_ID_YUKON_EC_U || hw-chip_id == CHIP_ID_YUKON_EX; These chips aren't extreme, it might be easier to turn the test around and test for the chips

Re: [patch 05/11] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls

2007-02-06 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 16:31:04 -0800 From: Joe Jin [EMAIL PROTECTED] Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls in the bonding driver. Signed-off-by: Joe Jin [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Jeff asked

Re: [PATCH] tg3 : avoid an expensive divide

2007-02-06 Thread David Miller
Eric, I've applied your patch as-is to net-2.6.21, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC][PATCH][IPSEC][0/3]inter address family ipsec tunnel

2007-02-06 Thread David Miller
From: Kazunori MIYAZAWA [EMAIL PROTECTED] Date: Fri, 29 Dec 2006 14:47:02 +0900 I fixed the compile issue when we configure IPv6 as a module. [1/3] exporting xfrm_state_afinfo [2/3] supporting IPv6 over IPv4 IPsec [3/3] supporting IPv4 over IPv6 IPsec These patches can be applied to

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Vlad Yasevich
Hi Neil a few comments. sorry, just can't resist... :) @@ -2627,6 +2673,9 @@ static void addrconf_dad_completed(struct inet6_ifaddr *ifp) * Configure the address for reception. Now it is valid. */ + if (ifp-flags IFA_F_OPTIMISTIC) +

Re: [PATCH] igmp: check add_grhead() return value

2007-02-06 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Mon, 5 Feb 2007 18:04:33 +0300 OK, now that we aren't seeing crashes which can be attributed to these NULL dereferences any longer. -- add_grhead() allocates memory with GFP_ATOMIC and in at least two places skb

Re: [PATCH 0/7] [S390]: Introduction of AF_IUCV sockets support

2007-02-06 Thread David Miller
From: Frank Pavlic [EMAIL PROTECTED] Date: Fri, 2 Feb 2007 13:05:28 +0100 The patch set consists of following patches: [1/7] [S390]: Rewrite of the IUCV base code, part 1 [2/7] [S390]: Rewrite of the IUCV base code, part 2 [3/7] [S390]: Adapt monreader driver to new IUCV API [4/7] [S390]:

depending on IPv6 symbols (was: [RFC][PATCH][IPSEC][0/3]inter address family ipsec tunnel)

2007-02-06 Thread Roland Dreier
David We see so many issues with ipv6 symbols dependencies in David various subsystems (netfilter, xfrm, etc.). It is a sign David that we need some kind of long range plan to deal with this David problem. Since the ipv6 module can't be unloaded anyways, David and it's been

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-02-06 Thread Marcelo Tosatti
On Sat, Feb 03, 2007 at 08:43:49PM -0200, Marcelo Tosatti wrote: Hi Arnd, Most of these are unused as well, I guess it would be good to go through the whole list and see what can be removed. Done. Will go through the entire file list before posting the next patch. Done. Did you run

Re: depending on IPv6 symbols

2007-02-06 Thread Roland Dreier
config FOO depends on (IPV6 || IPV6=n) OK, I'll add the same hack for INFINIBAND_IPOIB too. I doubt there's anyone that really cares about IPoIB built-in with modular IPv6. Would you like a patch to do the same thing for INET_IPGRE (and fix the #ifdefs in ip_gre.c)? - R. - To

Re: depending on IPv6 symbols

2007-02-06 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 14:53:58 -0800 Would you like a patch to do the same thing for INET_IPGRE (and fix the #ifdefs in ip_gre.c)? Sure, although I'm surprised nobody noticed that build failure before :-) - To unsubscribe from this list: send the line

Re: Please pull upstream-fixes branch of wireless-2.6

2007-02-06 Thread Jeff Garzik
Would you mind rebasing resending, kind sir? Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: depending on IPv6 symbols

2007-02-06 Thread Roland Dreier
David Sure, although I'm surprised nobody noticed that build David failure before :-) OK, coming up. (It's not a build failure though, it's wrong code: if CONFIG_IPV6=m then the code inside #ifdef CONFIG_IPV6 in ip_gre.c just doesn't get built, even though it should) - R. - To

Re: [PATCH 1/4] skge: handle zero address at open

2007-02-06 Thread Jeff Garzik
Stephen Hemminger wrote: Some motherboards are broken and have no address set. Failing at probe time prevents the device from ever being used (like to download a fixed BIOS). Instead warn on probe and check again when device is brought up. That way the address can be set. Signed-off-by:

Re: [PATCH 1/3] NetXen: Fixes for ppc architecture.

2007-02-06 Thread Jeff Garzik
Amit S. Kale wrote: NetXen: Fixes for ppc architecture. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] applied 2-3. patch #1 failed to apply. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 09/11] Remove unused kernel config option DLCI_COUNT

2007-02-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Robert P. J. Day [EMAIL PROTECTED] Remove the unused kernel config option DLCI_COUNT. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver

2007-02-06 Thread David Young
On Mon, Dec 18, 2006 at 05:57:23PM -0200, Marcelo Tosatti wrote: /* Channel flags. */ Did you send this part to netbsd also? We really don't want to fork radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's all rolled together for convenience. No,

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-06 Thread Jeff Garzik
Li Yang wrote: Get rid of private immrbar_virt_to_phys() routine and use generic iopa(). Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 29 ++--- 1 files changed, 6 insertions(+), 23 deletions(-) I'll await resend pending resolution of comments

Re: [PATCH 1/7] sky2: add Wake On Lan support

2007-02-06 Thread Jeff Garzik
Stephen Hemminger wrote: Adds basic magic packet wake on lan support to the sky2 driver. Note: initial WOL value is based on BIOS settings. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 208 ++--- drivers/net/sky2.h

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Auke Kok
Ahmed S. Darwish wrote: On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. Remove it and use ARRAY_SIZE instead. ---

Re: dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3]

2007-02-06 Thread Ingo Molnar
Mattia, * Mattia Dongili [EMAIL PROTECTED] wrote: I have it halfways reproducible now and I'm working to find the root cause. Thanks for providing the info. Great, I'm obviously available to test any patch :) Could you try the patch below? The RCU serialization code (a rare call but

Re: [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Auke Kok
Ahmed S. Darwish wrote: Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Acked-by: Auke Kok [EMAIL PROTECTED] Cheers, Auke --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c

Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. OK, but checks you're changing are strange. idx there is signed so BUG_ON(idx 0 || idx

Re: dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3]

2007-02-06 Thread Mattia Dongili
On Tue, Feb 06, 2007 at 05:48:26PM +0100, Ingo Molnar wrote: Mattia, * Mattia Dongili [EMAIL PROTECTED] wrote: I have it halfways reproducible now and I'm working to find the root cause. Thanks for providing the info. Great, I'm obviously available to test any patch :) Could

[RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Adrian Bunk
On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote: ... Changes since 2.6.20-rc6-mm2: ... git-netdev-all.patch ... git trees ... This patch contains the following possible cleanups: - move extern declarations to atl1.h - make needlessly global code static Signed-off-by: Adrian

Re: dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3]

2007-02-06 Thread Tilman Schmidt
Am 06.02.2007 20:28 schrieb Mattia Dongili: On Tue, Feb 06, 2007 at 05:48:26PM +0100, Ingo Molnar wrote: Could you try the patch below? The RCU serialization code (a rare call but can be common in some types of setups) has a nasty implicit dependency on the HZ tick - which until now was a

Re: dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3]

2007-02-06 Thread Thomas Gleixner
On Wed, 2007-02-07 at 00:12 +0100, Tilman Schmidt wrote: No, not this. Anyway the last patch Thomas forwarded does fix the problem. Which one would that be? I might try it for comparison. Find the combined patch of all fixlets on top of -mm3 below. tglx Index:

Re: [PATCH netdev#atl1 1/3] atl1: remove whitespace damage

2007-02-06 Thread Jeff Garzik
Jay Cliburn wrote: From: Jay Cliburn [EMAIL PROTECTED] atl1: fix whitespace damage Remove trailing whitespace and spaces preceding tabs. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] applied 1-3 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] sky2: flow control off

2007-02-06 Thread Jeff Garzik
Stephen Hemminger wrote: Turn flow control off for sky2. When flow control is on, the transmitter may get randomly stuck. Perhaps there is hardware problem, but until Marvell provides errata information for workaround, it should default to off. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Jay Cliburn
On Tue, 6 Feb 2007 23:12:29 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Jan 29, 2007 at 08:45:28PM -0800, Andrew Morton wrote: ... Changes since 2.6.20-rc6-mm2: ... git-netdev-all.patch ... git trees ... This patch contains the following possible cleanups: - move extern

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Jeff Garzik
Jay Cliburn wrote: Your patch is just a little bit out ahead of us. Some of your suggested changes are already in the pipeline; we're just waiting for Jeff to merge netdev#atl1 into netdev#ALL. Should be soon. Technical note: merging #atl1 into #ALL happens each time netdev-2.6.git is

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread Adrian Bunk
On Tue, Feb 06, 2007 at 06:19:10PM -0600, Jay Cliburn wrote: On Tue, 6 Feb 2007 23:12:29 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: ... This patch contains the following possible cleanups: - move extern declarations to atl1.h - make needlessly global code static Adrian, The atl1

Re: [RFC: -mm patch] drivers/net/atl1/: possible cleanups

2007-02-06 Thread J. K. Cliburn
On 2/6/07, Jeff Garzik [EMAIL PROTECTED] wrote: Jay Cliburn wrote: Your patch is just a little bit out ahead of us. Some of your suggested changes are already in the pipeline; we're just waiting for Jeff to merge netdev#atl1 into netdev#ALL. Should be soon. Technical note: merging #atl1

Re: dynticks + iptables almost stops the boot process [was: Re: 2.6.20-rc6-mm3]

2007-02-06 Thread Andrew Morton
On Wed, 07 Feb 2007 00:17:33 +0100 Thomas Gleixner [EMAIL PROTECTED] wrote: On Wed, 2007-02-07 at 00:12 +0100, Tilman Schmidt wrote: No, not this. Anyway the last patch Thomas forwarded does fix the problem. Which one would that be? I might try it for comparison. Find the combined

hostap_cs_{resume,suspend}(): inconsequent NULL checking

2007-02-06 Thread Adrian Bunk
The Coverity checker spotted the following in drivers/net/wireless/hostap/hostap_cs.c: -- snip -- ... static int hostap_cs_suspend(struct pcmcia_device *link) { struct net_device *dev = (struct net_device *) link-priv; int dev_open = 0; struct hostap_interface *iface =

[PATCH netdev#atl1 1/1] atl1: clean up extern, global scope declarations

2007-02-06 Thread Jay Cliburn
From: Jay Cliburn [EMAIL PROTECTED] atl1: move extern to header file; make some global code static Move an extern declaration to a header file. Make needlessly global functions static. Noticed by Adrian Bunk. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- drivers/net/atl1/atl1.h |

[PATCH] bcm43xx: Fix for oops on resume

2007-02-06 Thread Larry Finger
There is a kernel oops on bcm43xx when resuming due to an overly tight timeout loop. Signed-off-by: Larry Finger[EMAIL PROTECTED] --- Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx.h === ---

[PATCH] bcm43xx: Fix incorrect definition of PHY revision

2007-02-06 Thread Larry Finger
There is a typographical error in the spefications that interchange the PHY version and revision. Fixing this error makes all BCM43xx varieties work at full CCCK rates. Signed-off-by: Larry Finger[EMAIL PROTECTED] --- John, This patch should be put into wireless-2.6 and into 'upstream' as

Re: [PATCH] sky2: flow control off

2007-02-06 Thread Stephen Hemminger
On Tue, 06 Feb 2007 19:18:07 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: Turn flow control off for sky2. When flow control is on, the transmitter may get randomly stuck. Perhaps there is hardware problem, but until Marvell provides errata information for workaround,

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-02-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, AFAIK, we have not heard objectsions and I finally agree on this. Please apply. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --yoshfuji In article [EMAIL PROTECTED] (at Wed, 3 Jan 2007 18:57:48 +0900), Masahide NAKAMURA [EMAIL PROTECTED] says: Add checksum default defines for

Re: [patch 11/11] netfilter warning fix

2007-02-06 Thread Patrick McHardy
Ingo Molnar wrote: * David Miller [EMAIL PROTECTED] wrote: net/netfilter/nf_conntrack_core.c, calls: l4proto = __nf_ct_l4proto_find((u_int16_t)pf, protonum); whichs assumes that preemption is disabled. Yes, that is certainly broken. you are right - i mistakenly read that mail only up

[IPROUTE2] tc build failure and netfilter headers.

2007-02-06 Thread YOSHIFUJI Hideaki / 吉藤英明
Stephen, I think we should include include/linux/netfilter/{x_tables.h,xt_tcpudp.h} in iproute2 distribution to avoid compilation failure of tc. Regards, --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [IPROUTE2] tc build failure and netfilter headers.

2007-02-06 Thread Stephen Hemminger
On Wed, 07 Feb 2007 16:33:53 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: Stephen, I think we should include include/linux/netfilter/{x_tables.h,xt_tcpudp.h} in iproute2 distribution to avoid compilation failure of tc. Regards, --yoshfuji Okay, but but we are