[PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-08-22 Thread Sreenivasa Honnur
- Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -urpN patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c ---

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread Krishna Kumar2
Hi Dave, David Miller [EMAIL PROTECTED] wrote on 08/22/2007 09:52:29 AM: From: Krishna Kumar2 [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 09:41:52 +0530 snip Because TSO does batching already, so it's a very good tit for tat comparison of the new batching scheme vs. an existing one.

Re: net-2.6.24 failure with netconsole

2007-08-22 Thread Herbert Xu
Andrew Morton [EMAIL PROTECTED] wrote: David, there's basically no reason ever why anyone should add BUG() or BUG_ON() to net code. Please consider rejecting any patches which add new ones. WARN_ON() is *much* better. It at least gives the user a chance of getting some disgnostic info

Re: Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-08-22 Thread Herbert Xu
Chuck Ebbert [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: [c05be67f] kernel_recvmsg+0x31/0x40 18:57:54 osama kernel: [e0bc52d4] svc_udp_recvfrom+0x114/0x368 [sunrpc] svc_udp_recvfrom is calling kernel_recvmsg with iov == NULL.

[PATCH 2.6.24 1/3]S2io: Added support for set_mac_address driver entry point

2007-08-22 Thread Sreenivasa Honnur
- Added set_mac_address driver entry point - Copying permanent mac address to dev-perm_addr Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -urpN orig/drivers/net/s2io.c patch1/drivers/net/s2io.c --- orig/drivers/net/s2io.c

[PATCH 2.6.24 3/3]S2io: Updating transceiver information in ethtool function

2007-08-22 Thread Sreenivasa Honnur
- Update transceiver information in ethtool function Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -urpN patch2/drivers/net/s2io.c patch3/drivers/net/s2io.c --- patch2/drivers/net/s2io.c 2007-08-18 07:19:21.0 +0530 +++

[PATCH 0/10 Rev4] Implement skb batching and support in IPoIB

2007-08-22 Thread Krishna Kumar
This set of patches implements the batching xmit capability (changed from API), and adds support for batching in IPoIB. Also included is a sample patch for E1000 (ported - thanks to Jamal's E1000 changes from earlier kernel). I will use this patch for testing E1000 TSO vs batching after the

[PATCH 1/10 Rev4] [Doc] HOWTO Documentation for batching

2007-08-22 Thread Krishna Kumar
Add Documentation describing batching skb xmit capability. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- batching_skb_xmit.txt | 78 ++ 1 files changed, 78 insertions(+) diff -ruNp org/Documentation/networking/batching_skb_xmit.txt

[PATCH 2/10 Rev4] [core] Add skb_blist support for batching

2007-08-22 Thread Krishna Kumar
Introduce skb_blist, NETIF_F_BATCH_SKBS, use single API for batching/no-batching, etc. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/netdevice.h |4 net/core/dev.c| 21 ++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff -ruNp

[PATCH 3/10 Rev4] [sched] Modify qdisc_run to support batching

2007-08-22 Thread Krishna Kumar
Modify qdisc_run() to support batching. Modify callers of qdisc_run to use batching, modify qdisc_restart to implement batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/netdevice.h |2 + include/net/pkt_sched.h |6 +-- net/core/dev.c| 44

[PATCH 4/10 Rev4] [ethtool] Add ethtool support

2007-08-22 Thread Krishna Kumar
Add ethtool support to enable/disable batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/ethtool.h |2 ++ include/linux/netdevice.h |2 ++ net/core/dev.c| 36 net/core/ethtool.c| 27

[PATCH 5/10 Rev4] [IPoIB] Header file changes

2007-08-22 Thread Krishna Kumar
IPoIB header file changes to use batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib.h new/drivers/infiniband/ulp/ipoib/ipoib.h ---

[PATCH 6/10 Rev4] [IPoIB] CM Multicast changes

2007-08-22 Thread Krishna Kumar
IPoIB CM Multicast changes based on header file changes. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_cm.c| 13 + ipoib_multicast.c |4 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_cm.c

[PATCH 7/10 Rev4] [IPoIB] Verbs changes

2007-08-22 Thread Krishna Kumar
IPoIB verb changes to use batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_verbs.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_verbs.c new/drivers/infiniband/ulp/ipoib/ipoib_verbs.c ---

[PATCH 8/10 Rev4] [IPoIB] Post and work completion handler changes

2007-08-22 Thread Krishna Kumar
IPoIB internal post and work completion handler changes. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_ib.c | 207 - 1 files changed, 163 insertions(+), 44 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_ib.c

[PATCH 9/10 Rev4] [IPoIB] Implement batching

2007-08-22 Thread Krishna Kumar
IPoIB: implement the new batching API. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_main.c | 251 --- 1 files changed, 171 insertions(+), 80 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_main.c

[PATCH 10/10 Rev4] [E1000] Implement batching

2007-08-22 Thread Krishna Kumar
E1000: Implement batching capability (ported thanks to changes taken from Jamal). Not all changes are made in this as in IPoIB, eg, handling out of order skbs (see XXX in the first mail). Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- e1000_main.c | 150

Oops in e100_up

2007-08-22 Thread Gerrit Renker
With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed from console): Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 00 00 01 00 00 00 e9 4e ff ff ff 89 d0 e8 b3 f8 0b 00 eb 8e 0f 0b eb fe 55 89 e5 56 53 83 ec 0c 8b 98 dc 01 00 00

Re: net-2.6.24 failure with netconsole

2007-08-22 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 22:54:38 -0700 Has anyone tested all this new napi stuff with netconsole? It's pretty disastrous. It immediately goes BUG in napi_enable(). Thomas Graf has found and fixed a bug in the netconsole napi bits a few hours ago, maybe it

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread David Miller
From: Krishna Kumar2 [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 12:33:04 +0530 Does turning off batching solve that problem? What I mean by that is: batching can be disabled if a TSO device is worse for some cases. This new batching stuff isn't going to be enabled or disabled on a per-device

Re: Oops in e100_up

2007-08-22 Thread David Miller
From: Gerrit Renker [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 09:56:48 +0100 With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed from console): Probably the NAPI conversion, I'll try to get to diagnosing this one soon but I've been wrapped up in some other tasks so

Re: net-2.6.24 failure with netconsole

2007-08-22 Thread Thomas Graf
* Andrew Morton [EMAIL PROTECTED] 2007-08-21 22:54 Which used to be a BUG. It later oopsed via a null-pointer deref in net_rx_action(), which is a much preferable result. I fixed this already Index: net-2.6.24/include/linux/netpoll.h

[PATCH net-2.6.24] [NET] Cleanup: DIV_ROUND_UP

2007-08-22 Thread Ilpo Järvinen
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- net/ipv4/tcp_output.c |6 +- net/key/af_key.c | 17 + 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 10b2e39..bca4ee2 100644 ---

[PATCH -mm] drivers/net/e1000e/netdev.c warning fix

2007-08-22 Thread Michal Piotrowski
Hi, This patch fixes the following compilation warning drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’: drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’ Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ --- linux-mm-clean/drivers/net/e1000e/netdev.c

Re: [PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()

2007-08-22 Thread Benjamin Thery
Oops, don't use the previous version of the patch: the change in dev_mc_unsync() was not correct. Sorry. This one is a lot better (it compiles and runs). :) Benjamin -- B e n j a m i n T h e r y - BULL/DT/Open Software RD http://www.bull.com From: [EMAIL PROTECTED] Subject: net/core: Fix

[PATCH 2.6.23-rc3-mm1] request_irq fix DEBUG_SHIRQ handling Re: 2.6.23-rc2-mm1: rtl8139 inconsistent lock state

2007-08-22 Thread Jarek Poplawski
On 10-08-2007 01:49, Mariusz Kozlowski wrote: Hello, = [ INFO: inconsistent lock state ] 2.6.23-rc2-mm1 #7 - inconsistent {in-hardirq-W} - {hardirq-on-W} usage. ifconfig/5492 [HC0[0]:SC0[0]:HE1:SE1] takes: (tp-lock){+...},

[PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

2007-08-22 Thread Nick Bowler
I was asked to resend my message here, so here it is. Please CC me on replies. --- In testing our ESP/AH offload hardware, I discovered an issue with how AH handles mutable fields in IPv4. RFC 4302 (AH) states the following on the subject: For IPv4, the entire option is viewed as a unit;

Re: [PATCH 10/10 Rev4] [E1000] Implement batching

2007-08-22 Thread Kok, Auke
Krishna Kumar wrote: E1000: Implement batching capability (ported thanks to changes taken from Jamal). Not all changes are made in this as in IPoIB, eg, handling out of order skbs (see XXX in the first mail). Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- e1000_main.c |

Re: [PATCH -mm] drivers/net/e1000e/netdev.c warning fix

2007-08-22 Thread Kok, Auke
Michal Piotrowski wrote: Hi, This patch fixes the following compilation warning drivers/net/e1000e/netdev.c: In function ‘e1000_setup_rctl’: drivers/net/e1000e/netdev.c:1963: warning: unused variable ‘pages’ Regards, Michal also exposes a symbol issue. I think I want to remove this

[PATCH 1/4] ehea: fix interface to DLPAR tools

2007-08-22 Thread Jan-Bernd Themann
Userspace DLPAR tool expects decimal numbers to be written to and read from sysfs entries. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c

[PATCH 2/4] ehea: fix module parameter description

2007-08-22 Thread Jan-Bernd Themann
Update the module parameter description of use_mcs to show correct default value Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c

[PATCH 3/4] ehea: fix queue destructor

2007-08-22 Thread Jan-Bernd Themann
Includes hcp_epas_dtor in eq/cq/qp destructors to unmap HW register. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea_qmr.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/ehea/ehea_qmr.c b/drivers/net/ehea/ehea_qmr.c index

[PATCH 4/4] ehea: show physical port state

2007-08-22 Thread Jan-Bernd Themann
Introduces a module parameter to decide whether the physical port link state is propagated to the network stack or not. It makes sense not to take the physical port state into account on machines with more logical partitions that communicate with each other. This is always possible no matter what

[NET] sgiseeq: Fix return type of sgiseeq_remove

2007-08-22 Thread Ralf Baechle
The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 384b468..0fb74cb 100644 ---

[PATCH 1/3] e1000e: retire last_tx_tso workaround

2007-08-22 Thread Auke Kok
This TSO-related workaround is no longer needed since it's only applicable for 8254x silicon. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/e1000.h | 15 +++ drivers/net/e1000e/netdev.c | 20 ++-- 2 files changed, 5 insertions(+), 30

[PATCH 2/3] e1000e: Add read code and printout of PBA number (board identifier)

2007-08-22 Thread Auke Kok
The PBA number allows customers and support to directly identify the type of board and characteristics such as different skews. Slightly enhance loading messages by adding module name to printout. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/defines.h |6 --

[PATCH 3/3] e1000e: Remove conditional packet split disable flag

2007-08-22 Thread Auke Kok
This flag conflicts with e1000's Kconfig symbol and we'll leave the feature enabled by default for now. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000e/netdev.c

[PATCH] [03/10] pasemi_mac: Enable L2 caching of packet headers

2007-08-22 Thread Olof Johansson
Enable settings to target l2 for the first few cachelines of the packet, since we'll access them to get to the various headers. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === ---

[PATCH] [00/10] pasemi_mac patches for 2.6.24

2007-08-22 Thread Olof Johansson
Hi, pasemi_mac patches for 2.6.24: 01/10: pasemi_mac: Abstract out register access 02/10: pasemi_mac: Stop using the pci config space accessors for register read/writes 03/10: pasemi_mac: Enable L2 caching of packet headers 04/10: pasemi_mac: Fix memcpy amount for short receives 05/10:

[PATCH] [09/10] pasemi_mac: Fix RX checksum flags

2007-08-22 Thread Olof Johansson
RX side flag to use is CHECKSUM_UNNECESSARY, not CHECKSUM_COMPLETE. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++

[PATCH] [01/10] pasemi_mac: Abstract out register access

2007-08-22 Thread Olof Johansson
Abstract out the PCI config read/write accesses into reg read/write ones, still calling the pci accessors on the back end. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === ---

[PATCH] [08/10] pasemi_mac: Fix TX ring wrap checking

2007-08-22 Thread Olof Johansson
The old logic didn't detect full (tx) ring cases properly, causing overruns and general badness. Clean it up a bit and abstract out the ring size checks, always making sure to leave 1 slot open. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c

[PATCH] [05/10] pasemi_mac: RX performance tweaks

2007-08-22 Thread Olof Johansson
Various RX performance tweaks, do some explicit prefetching of packet data, etc. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++

[PATCH] [10/10] pasemi_mac: Clean TX ring in poll

2007-08-22 Thread Olof Johansson
Unfortunately there's no timeout for how long a packet can sit on the TX ring after completion before an interrupt is generated, and we want to have a threshold that's larger than one packet per interrupt. So we have to have a timer that occasionally cleans the TX ring even though there hasn't

[PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Olof Johansson
Move away from using the pci config access functions for simple register access. Our device has all of the registers in the config space (hey, from the hardware point of view it looks reasonable :-), so we need to somehow get to it. Newer firmwares have it in the device tree such that we can just

[PATCH] [06/10] pasemi_mac: Batch up TX buffer frees

2007-08-22 Thread Olof Johansson
Postpone pci unmap and skb free of the transmitted buffers to outside of the tx ring lock, batching them up 32 at a time. Also increase the count threshold to 128. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c

[PATCH] [04/10] pasemi_mac: Fix memcpy amount for short receives

2007-08-22 Thread Olof Johansson
Fix up memcpy for short receives. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drivers/net/pasemi_mac.c @@ -516,9 +516,7 @@

[PATCH] [07/10] pasemi_mac: Enable LLTX

2007-08-22 Thread Olof Johansson
Enable LLTX on pasemi_mac: we're already doing sufficient locking in the driver to enable it. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c

[PATCH 00/16] xfrm netlink interface cleanups

2007-08-22 Thread Thomas Graf
This patchset converts the xfrm netlink bits over to the type safe netlink interface and does some cleanups. xfrm_user.c | 1041 1 file changed, 433 insertions(+), 608 deletions(-) - To unsubscribe from this list: send the line

[PATCH 01/16] [XFRM] netlink: Use nlmsg_put() instead of NLMSG_PUT()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-20 17:09:48.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 09/16] [XFRM] netlink: Use nlmsg_parse() to parse attributes

2007-08-22 Thread Thomas Graf
Uses nlmsg_parse() to parse the attributes. This actually changes behaviour as unknown attributes (type MAXTYPE) no longer cause an error. Instead unknown attributes will be ignored henceforth to keep older kernels compatible with more recent userspace tools. Signed-off-by: Thomas Graf [EMAIL

[PATCH 08/16] [XFRM] netlink: Use nlmsg_new() and type-safe size calculation helpers

2007-08-22 Thread Thomas Graf
Moves all complex message size calculation into own inlined helper functions and makes use of the type-safe netlink interface. Using nlmsg_new() simplifies the calculation itself as it takes care of the netlink header length by itself. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index:

[PATCH 02/16] [XFRM] netlink: Use nlmsg_end() and nlmsg_cancel()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:10:34.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 16/16] [XFRM] netlink: Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()

2007-08-22 Thread Thomas Graf
These functions are only used once and are a lot easier to understand if inlined directly into the function. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === ---

[PATCH 06/16] [XFRM] netlink: Move algorithm length calculation to its own function

2007-08-22 Thread Thomas Graf
Adds alg_len() to calculate the properly padded length of an algorithm attribute to simplify the code. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c

[PATCH 12/16] [XFRM] netlink: Rename attribyte array from xfrma[] to attrs[]

2007-08-22 Thread Thomas Graf
Increases readability a lot. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:10.0 +0200 +++

[PATCH 10/16] [XFRM] netlink: Establish an attribute policy

2007-08-22 Thread Thomas Graf
Adds a policy defining the minimal payload lengths for all the attributes allowing for most attribute validation checks to be removed from in the middle of the code path. Makes updates more consistent as many format errors are recognised earlier, before any changes have been attempted.

[PATCH 14/16] [XFRM] netlink: Use nla_memcpy() in xfrm_update_ae_params()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:35:13.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 13/16] [XFRM] netlink: Use nlattr instead of rtattr

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:29.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 05/16] [XFRM] netlink: Use nla_put()/NLA_PUT() variantes

2007-08-22 Thread Thomas Graf
Also makes use of copy_sec_ctx() in another place and removes duplicated code. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21

[PATCH 04/16] [XFRM] netlink: Use nlmsg_broadcast() and nlmsg_unicast()

2007-08-22 Thread Thomas Graf
This simplifies successful return codes from 0 to 0. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:13:57.0 +0200 +++

[PATCH 03/16] [XFRM] netlink: Use nlmsg_data() instead of NLMSG_DATA()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:12:20.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 15/16] [XFRM] netlink: Remove dependency on rtnetlink

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:36:59.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21

[PATCH 07/16] [XFRM] netlink: Clear up some of the CONFIG_XFRM_SUB_POLICY ifdef mess

2007-08-22 Thread Thomas Graf
Moves all of the SUB_POLICY ifdefs related to the attribute size calculation into a function. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c

Re: [PATCH 1/10 Rev4] [Doc] HOWTO Documentation for batching

2007-08-22 Thread Randy Dunlap
On Wed, 22 Aug 2007 13:58:58 +0530 Krishna Kumar wrote: Add Documentation describing batching skb xmit capability. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- batching_skb_xmit.txt | 78 ++ 1 files changed, 78 insertions(+)

Re: [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy

2007-08-22 Thread Willy Tarreau
On Wed, Aug 22, 2007 at 11:56:42AM -0400, Chuck Ebbert wrote: On 08/22/2007 05:39 AM, Willy Tarreau wrote: This patch contains errata fixes for the realtek phy. It only renamed the defines to be phy specific. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] Signed-off-by: Greg

Re: Oops in e100_up

2007-08-22 Thread Kok, Auke
Gerrit Renker wrote: With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed from console): Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 00 00 01 00 00 00 e9 4e ff ff ff 89 d0 e8 b3 f8 0b 00 eb 8e 0f 0b eb fe 55 89 e5 56 53 83

r8169: slow samba performance

2007-08-22 Thread Bruce Cole
Just upgraded a motherboard and it came with an onboard Realtek card which appears to use the r8169 driver. The machine is a samba server and when serving files to a local Linux or Windows client, I only get approx 40-60 kbps. Write performance is fine though, in the tens of mbps and scp, nfs,

Re: Oops in e100_up

2007-08-22 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 22, 2007 at 09:35:04AM -0700, Kok, Auke escreveu: Gerrit Renker wrote: With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed from console): Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 00 00 01 00 00 00 e9 4e ff ff

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread Rick Jones
David Miller wrote: I think the jury is still out, but seeing TSO perform even slightly worse with the batching changes in place would be very worrysome. This applies to both throughput and cpu utilization. Should it be any more or less worrysome than small packet performance (eg the TCP_RR

[PATCH] santize tc_ematch headers

2007-08-22 Thread Stephen Hemminger
The headers in tc_ematch are used by iproute2, so these headers should be processed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- include/linux/Kbuild |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/Kbuild b/include/linux/Kbuild index

Re: [RFC IPROUTE]: Add flow classifier support

2007-08-22 Thread Stephen Hemminger
On Wed, 30 May 2007 11:42:01 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: The iproute patch for the flow classifier. This patch is on hold since the netlink changes haven't made it upstream yet. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line

[ANNOUNCE] iproute2-2.6.23-rc3

2007-08-22 Thread Stephen Hemminger
There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches http://developer.osdl.org/shemminger/iproute2/download/iproute2-2.6.23-rc3.tar.gz Johannes Berg (1): show multicast groups PJ Waskiewicz (1): iproute2:

[PATCH] netdevice: kernel docbook addition

2007-08-22 Thread Stephen Hemminger
Add more kernel doc's for part of the network device API. This is only a start, and needs more work. Applies against net-2.6.24 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/Documentation/DocBook/kernel-api.tmpl 2007-08-21 15:43:37.0 -0700 +++

Re: [PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

2007-08-22 Thread David Miller
From: Nick Bowler [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 10:22:53 -0400 In testing our ESP/AH offload hardware, I discovered an issue with how AH handles mutable fields in IPv4. RFC 4302 (AH) states the following on the subject: For IPv4, the entire option is viewed as a unit; so

Re: [PATCH] santize tc_ematch headers

2007-08-22 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 10:18:38 -0700 The headers in tc_ematch are used by iproute2, so these headers should be processed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks Stephen. - To unsubscribe from this list: send the line

Re: [RFC IPROUTE]: Add flow classifier support

2007-08-22 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 10:46:15 -0700 On Wed, 30 May 2007 11:42:01 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: The iproute patch for the flow classifier. This patch is on hold since the netlink changes haven't made it upstream yet. I

Re: [PATCH] xfrm: export sysctl_xfrm_acq_expires

2007-08-22 Thread David Miller
From: Neil Horman [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 15:42:02 -0400 Hey all- I had noticed that an extra sysctl for xfrm had been added while back (specifically sysctl_xfrm_acq_expires). Unlike its related sysctl's however, this was never exported so that out-of-tree modules

[PATCH] xfrm: export sysctl_xfrm_acq_expires

2007-08-22 Thread Neil Horman
Hey all- I had noticed that an extra sysctl for xfrm had been added while back (specifically sysctl_xfrm_acq_expires). Unlike its related sysctl's however, this was never exported so that out-of-tree modules could access it, and I thought it would be a good idea if it was. This patch

Re: [PATCH 02/16] [XFRM] netlink: Use nlmsg_end() and nlmsg_cancel()

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:40 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) Looks good, applied to net-2.6.24, thanks Joy. Something is still buggered up in this patch, you can't add this local audit_info variable unconditionally to these functions, and alternatively you also can't add a

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 10:09:37 -0700 Should it be any more or less worrysome than small packet performance (eg the TCP_RR stuff I posted recently) being rather worse with TSO enabled than with it disabled? That, like any such thing shown by the batching

Re: [PATCH] netdevice: kernel docbook addition

2007-08-22 Thread Randy Dunlap
On Wed, 22 Aug 2007 12:33:14 -0700 Stephen Hemminger wrote: Add more kernel doc's for part of the network device API. This is only a start, and needs more work. Applies against net-2.6.24 Thanks! --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To

[PATCH 2/2] Net: ath5k, remove sysctls

2007-08-22 Thread Jiri Slaby
ath5k, remove sysctls Syscalls were buggy and defunct in later kernels (due to sysctl check). Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 069bfbe93facb3468f579568434d18f1268a487c tree 87c19ebf2c91d9fb07f1847adcb6098f2235eaaa parent b01c0e9a02b248c3e2f2923da9728ba2c3961dee author Jiri

[RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Paul Moore
Over in LSM/SELinux land there has been a lot of talk recently about how to deal with loopback and forwarded traffic, specifically, how to preserve the sender's security label on those two types of traffic. Yes, there is the existing sk_buff.secmark field but that is already being used for

Re: [PATCH 04/16] [XFRM] netlink: Use nlmsg_broadcast() and nlmsg_unicast()

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:42 +0200 This simplifies successful return codes from 0 to 0. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 05/16] [XFRM] netlink: Use nla_put()/NLA_PUT() variantes

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:43 +0200 Also makes use of copy_sec_ctx() in another place and removes duplicated code. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 06/16] [XFRM] netlink: Move algorithm length calculation to its own function

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:44 +0200 Adds alg_len() to calculate the properly padded length of an algorithm attribute to simplify the code. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 07/16] [XFRM] netlink: Clear up some of the CONFIG_XFRM_SUB_POLICY ifdef mess

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:45 +0200 Moves all of the SUB_POLICY ifdefs related to the attribute size calculation into a function. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 09/16] [XFRM] netlink: Use nlmsg_parse() to parse attributes

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:47 +0200 Uses nlmsg_parse() to parse the attributes. This actually changes behaviour as unknown attributes (type MAXTYPE) no longer cause an error. Instead unknown attributes will be ignored henceforth to keep older kernels

Re: [PATCH 10/16] [XFRM] netlink: Establish an attribute policy

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:48 +0200 Adds a policy defining the minimal payload lengths for all the attributes allowing for most attribute validation checks to be removed from in the middle of the code path. Makes updates more consistent as many format

Re: [PATCH 11/16] [XFRM] netlink: Enhance indexing of the attribute array

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:49 +0200 nlmsg_parse() puts attributes at array[type] so the indexing method can be simpilfied by removing the obscuring - 1. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line

Re: [PATCH 12/16] [XFRM] netlink: Rename attribyte array from xfrma[] to attrs[]

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:50 +0200 Increases readability a lot. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. I named it like this to mean XFRM Attributes :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Vitaly Bordug
On Tue, 21 Aug 2007 11:47:41 -0500 Scott Wood [EMAIL PROTECTED] wrote: Vitaly Bordug wrote: On Fri, 17 Aug 2007 13:17:18 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device

Re: [PATCH 13/16] [XFRM] netlink: Use nlattr instead of rtattr

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:51 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 14/16] [XFRM] netlink: Use nla_memcpy() in xfrm_update_ae_params()

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:52 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 15/16] [XFRM] netlink: Remove dependency on rtnetlink

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:53 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 16/16] [XFRM] netlink: Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()

2007-08-22 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:55:54 +0200 These functions are only used once and are a lot easier to understand if inlined directly into the function. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Also applied. Thanks for doing all of this work Thomas! :) -

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:53:59 -0500 Scott Wood wrote: Signed-off-by: Scott Wood [EMAIL PROTECTED] Acked-by: Vitaly Bordug [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +-

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 16:31:34 -0400 We're currently talking about several different ideas to solve the problem, including leveraging the sk_buff.secmark field, and one of the ideas was to add an additional field to the sk_buff structure. Knowing how well

  1   2   >