[PATCH] Net: Remove FASTCALL macro

2007-12-12 Thread Harvey Harrison
X86_32 was the last user of the FASTCALL macro, now that it uses regparm(3) by default, this macro expands to nothing. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Should this be coordinated with the FASTCALL() removal in the x86 git tree? drivers/net/ns83820.c |5 +

[PATCH 3/4] [NETDEV] ixp2000: rtnl_lock out of loop will be faster

2007-12-12 Thread Wang Chen
[PATCH 3/4] [NETDEV] ixp2000: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the loop will be faster for this approach. Signed-off-by: Wang Chen [EMAIL

[PATCH 2/4] [NETDEV] cxgb3: rtnl_lock out of loop will be faster

2007-12-12 Thread Wang Chen
[PATCH 2/4] [NETDEV] cxgb3: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the loop will be faster for this approach. Signed-off-by: Wang Chen [EMAIL

[PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster

2007-12-12 Thread Wang Chen
[PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the loop will be faster for this approach. Signed-off-by: Wang Chen [EMAIL

Re: [PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

2007-12-12 Thread Subrata Modak
Would you like to submit the Driver Test Cases to LTP ? Or, if you have your Driver test cases written in C, we can port to LTP and have it inside the LTP package. You can also check out the following links for more info, and can always ping me for anything:

[PATCH 1/4] [NETDEV] cxgb2: rtnl_lock out of loop will be faster

2007-12-12 Thread Wang Chen
[PATCH 1/4] [NETDEV] cxgb2: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the loop will be faster for this approach. Signed-off-by: Wang Chen [EMAIL

Re: [4/4] DST: Algorithms used in distributed storage.

2007-12-12 Thread Evgeniy Polyakov
On Wed, Dec 12, 2007 at 12:12:47PM +0300, Dmitry Monakhov ([EMAIL PROTECTED]) wrote: On 14:47 Mon 10 Dec , Evgeniy Polyakov wrote: Algorithms used in distributed storage. Mirror and linear mapping code. Hi, i've finally take a look on your DST solution. It seems what your current

Re: [4/4] DST: Algorithms used in distributed storage.

2007-12-12 Thread Dmitry Monakhov
On 14:47 Mon 10 Dec , Evgeniy Polyakov wrote: Algorithms used in distributed storage. Mirror and linear mapping code. Hi, i've finally take a look on your DST solution. It seems what your current implementation will not work on nonstandard devices for example software raid0. other comments

[PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

2007-12-12 Thread Denis V. Lunev
netns: network namespace was passed into dev_getbyhwaddr but not used Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] diff --git a/net/core/dev.c b/net/core/dev.c index 06615df..677f35b 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -675,7 +675,7 @@ struct net_device *dev_getbyhwaddr(struct

[PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const

2007-12-12 Thread Denis V. Lunev
IPv4: thresholds in fib_trie.c are not modified, make them const Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 45a6e4d..57a2c46 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -299,10 +299,10 @@ static inline void

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: This is why initially I suggested another status code in order to split the ring logic with driver status. but also not filling any buffers as long as VIRTIO_CONFIG_DEV_OPEN is not set. I will have a look but I think that add_status needs

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Rusty Russell: On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote: That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in virtio_ring.c - maybe we can use that. Its hidden in callback and restart handling, what about adding

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Andrew Morton
On Thu, 29 Nov 2007 10:42:49 +0900 Joonwoo Park [EMAIL PROTECTED] wrote: 2007/11/29, Zhu Yi [EMAIL PROTECTED]: Good catch. But it will be better if you add it into iwl_cancel_deferred_work(). Thanks. I agree with you. Actually, I considered it, but I was afraid of side effect.

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-12 Thread Andreas Henriksson
On Tue, Dec 11, 2007 at 05:14:06PM -0800, Stephen Hemminger wrote: On Sun, 09 Dec 2007 18:10:22 +0100 Andreas Henriksson [EMAIL PROTECTED] wrote: I think both previous patches where broken on big-endian platforms. Here's an updated patch again. I'm very sorry for the inconvenience! [...] +

[virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-12 Thread Dor Laor
commit 763769621d271d92204ed27552d75448587c1ac0 Author: Dor Laor [EMAIL PROTECTED] Date: Wed Dec 12 14:52:00 2007 +0200 [virtio-net][PATCH] Don't arm tx hrtimer with a constant 50us each transmit The current start_xmit sets 500us hrtimer to kick the host. The problem is that if

RE: [PATCH] Increase virtual FIFOs in ucc_geth.

2007-12-12 Thread Joakim Tjernlund
On Tue, 2007-12-11 at 19:51 +0800, Li Yang wrote: -Original Message- From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 11, 2007 6:58 PM To: Li Yang Cc: netdev@vger.kernel.org Subject: RE: [PATCH] Increase virtual FIFOs in ucc_geth. On Tue,

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -406,10 +405,10 @@ again: Hmm, while I agree in general with the patch, I fail to find the proper version of virtio_net where this patch applies. I tried kvm.git and

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Daniel Mack
Hi Remy, On Tue, Dec 11, 2007 at 09:31:03PM +0100, Remy Bohmer wrote: This controller is also used on many other boards, like the e.g. Atmel AT91sam9261-ek board. On that board on both the rising _and_ falling edge an interrupt is generated. However, request_irq() is called with IRQF_SHARED

Re: [PATCH] [IPSEC]: Add populate from packet (PFP) support

2007-12-12 Thread Herbert Xu
On Tue, Dec 11, 2007 at 07:23:52PM -0800, Tyler Hicks wrote: RFC 4301 requires us to associate each SPD entry with a set of flags to determine how to assign the selector values when creating a new SAD entry. Each selector in the new xfrm_state can either be assigned using the corresponding

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-12 Thread Herbert Xu
Andrew Morton [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Remove stray rtnl_unlock(). Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9542 Adnrew, please cc Jay Vosburgh [EMAIL PROTECTED] on bonding issues. diff -puN

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-12 Thread Dor Laor
Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -406,10 +405,10 @@ again: Hmm, while I agree in general with the patch, I fail to find the proper version of virtio_net where this patch applies. I

Re: [Bug 9542] BUG: bad unlock balance detected!

2007-12-12 Thread Herbert Xu
On Tue, Dec 11, 2007 at 10:06:14PM +, Andrew Morton wrote: events/0/9 just changed the state of lock: (mc-mca_lock){-+..}, at: [c0412602] mld_ifc_timer_expire+0x130/0x1fb but this lock took another, soft-read-irq-unsafe lock in the past: (bond-lock){-.--} and interrupts could

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Joonwoo Park
2007/12/12, Andrew Morton [EMAIL PROTECTED]: Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar fashion? Hi Andrew, Both of them was applied to mainline. commit 3ae6a054553ee8b7f74bf7de8904022b26705778 Author: Joonwoo Park [EMAIL PROTECTED] Date: Thu Nov 29 10:43:16 2007

Re: [PATCH 7/7] [NETDEV]: myri10ge Fix possible causing oops of net_rx_action

2007-12-12 Thread Joonwoo Park
2007/12/12, Subrata Modak [EMAIL PROTECTED]: Would you like to submit the Driver Test Cases to LTP ? Or, if you have your Driver test cases written in C, we can port to LTP and have it inside the LTP package. You can also check out the following links for more info, and can always ping me for

[PATCH] Remove unused define from loopback driver

2007-12-12 Thread Pavel Emelyanov
The LOOPBACK_OVERHEAD is not used in this file at all. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index 662b8d1..3d1c743 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -64,8 +64,6 @@ struct pcpu_lstats {

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Remy Bohmer
Hello Daniel, However, request_irq() is called with IRQF_SHARED only, so neither IRQT_RISING nor IRQT_FALLING is set and the value defaults to IRQT_NOEDGE. How can you get IRQs? The DM9000 adapter is connected to a GPIO line on the at91sam9261-ek board, the board-specific code has a generic

Re: DM9000_IRQ_FLAGS

2007-12-12 Thread Daniel Mack
Hi, On Dec 12, 2007, at 3:46 PM, Remy Bohmer wrote: The DM9000 adapter is connected to a GPIO line on the at91sam9261-ek board, the board-specific code has a generic handler for every GPIO interrupt. So, the Device driver __does not need to know__ the type of interrupt, It just installs a

Re: [RFC] net: napi fix

2007-12-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 21:46:34 -0800 Isn't this a better fix for all drivers, rather than peppering every driver with the special case. This is how the logic worked up until 2.6.24. Stephen this is not the problem. The problem is that the driver is

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 21:39:39 -0800 On Wed, 12 Dec 2007 13:01:27 +0900 Joonwoo Park [EMAIL PROTECTED] wrote: [NETDEV]: tehuti Fix possible causing oops of net_rx_action Signed-off-by: Joonwoo Park [EMAIL PROTECTED] ---

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 13:01:27 +0900 @@ -305,6 +305,8 @@ static int bdx_poll(struct napi_struct *napi, int budget) netif_rx_complete(dev, napi); bdx_enable_interrupts(priv); + if (unlikely(work_done ==

Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action.

2007-12-12 Thread David Miller
From: Brandeburg, Jesse [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 16:38:37 -0800 @@ -3933,6 +3933,10 @@ quit_polling: e1000_set_itr(adapter); netif_rx_complete(poll_dev, napi); e1000_irq_enable(adapter); + if (work_done ==

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread David Miller
From: Lachlan Andrew [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 16:14:36 -0800 This thread started because TCP processing interferes with RTT estimation. This problem would be eliminated if time-stamping were done as soon as the packet comes off the NIC. We don't do that because such

Re: [GIT PULL] SCTP bug fixes for net-2.6

2007-12-12 Thread Vlad Yasevich
Jijo Chacko wrote: Hello experts, [ sorry if my questions are irrelevent to any one of you ]. I am trying to develop a frame work, where i transport all HTTP traffic over SCTP. On user space, i can do this easily over SCTP, BSD-style sockets. If i am to write a kernel module(say

Re: [PATCH 1/2] qe: add function qe_clock_source()

2007-12-12 Thread Timur Tabi
Timur Tabi wrote: Add function qe_clock_source() which takes a string containing the name of a QE clock source (as is typically found in device trees) and returns the matching enum qe_clock value. Update booting-without-of.txt to indicate that the UCC properties rx-clock and tx-clock are

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-12 Thread Timur Tabi
Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock properties. Update the device

Re: [RFC] net: napi fix

2007-12-12 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 15:05:26 +0900 Could you explain how it fix the problem? IMHO I think your patch cannot solve the problem. The drivers can call netif_rx_complete and net_rx_action can do list_move_tail also. Stephen is confused about what the bug

[PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread Michal Schmidt
Hello, Once created, an IP tunnel can't be bound to another device. (reported as https://bugzilla.redhat.com/show_bug.cgi?id=419671) To reproduce: # create a tunnel: ip tunnel add tunneltest0 mode ipip remote 10.0.0.1 dev eth0 # try to change the bounding device from eth0 to eth1: ip tunnel

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-12 Thread Dor Laor
Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Rusty Russell: On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote: That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in virtio_ring.c - maybe we can use that. Its hidden in callback and

Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread Patrick McHardy
Michal Schmidt wrote: +static void ipip_tunnel_bind_dev(struct net_device *dev) +{ ... + dev-iflink = tunnel-parms.link; +} + static int ipip_tunnel_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) { @@ -723,6 +757,10 @@ ipip_tunnel_ioctl (struct net_device *dev, struct

[PATCH] [IPROUTE]: Avoid overflow for larger rto_min in print_route

2007-12-12 Thread Satoru SATOH
This includes a workaround for overflow while conversion of larger rto_min (e.g. 3s) unit. Signed-off-by: Satoru SATOH [EMAIL PROTECTED] ip/iproute.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index f4200ae..fa722c6 100644 ---

Re: ip neigh show not showing arp cache entries?

2007-12-12 Thread Chris Friesen
I retested it on an x86 machine and am seeing similar problems. First, arp gives the arp table as expected: [EMAIL PROTECTED]:/tftpboot/cnp/0-0-5-0/0-0-5-0 arp -n Address HWtype HWaddress Flags Mask Iface 172.24.0.9 ether 00:03:CC:51:06:5E C

Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread Michal Schmidt
On Wed, 12 Dec 2007 17:00:14 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: If you change dev-iflink this should trigger a rtnetlink notification. OK, I've added netdev_state_change(dev). Here's the new patch. Once created, an IP tunnel can't be bound to another device. (reported as

Re: [PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 16:50:09 +0800 Wang Chen [EMAIL PROTECTED] wrote: [PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster Before this patch, it gets and releases the lock at each iteration of the loop. Changing unregister_netdev to unregister_netdevice and locking outside of the

Re: [kvm-devel] [virtio-net][PATCH] Don't arm tx hrtimer with a constant 500us each transmit

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: Christian Borntraeger wrote: Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -406,10 +405,10 @@ again: Hmm, while I agree in general with the patch, I fail to find

Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread Patrick McHardy
Michal Schmidt wrote: On Wed, 12 Dec 2007 17:00:14 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: If you change dev-iflink this should trigger a rtnetlink notification. OK, I've added netdev_state_change(dev). Here's the new patch. Looks good to me, thanks. -- To unsubscribe from this

[PATCH 2/7] [TFRC]: Loss interval code needs the macros/inlines that were moved

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] This moves the inlines (which were previously declared as macros) back into packet_history.h since the loss detection code needs to be able to read entries from the RX history in order to create the relevant loss entries: it needs at least

[RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Thomas Klein
This patch adds kdump support using the new PPC crash shutdown hook to the ehea driver. The driver now keeps a list of firmware handles which have to be freed in case of a crash. The crash handler does the minimum required: it frees the firmware resource handles plus broadcast/multicast

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Gerrit Renker
| This time around I'm not doing any reordering, just trying to use your | patches as is, but adding this patch as-is produces a kernel that will | crash, no? | | The loss history and the RX/TX packet history slabs are all created in | tfrc.c using the three different __init routines of the

Re: [PATCHES 0/7]: DCCP patches for 2.6.25

2007-12-12 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 14:36:46 -0200 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Pulled and pushed out to net-2.6.25, thanks! -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 12:55:13 +0100 Andreas Henriksson [EMAIL PROTECTED] wrote: On Tue, Dec 11, 2007 at 05:14:06PM -0800, Stephen Hemminger wrote: On Sun, 09 Dec 2007 18:10:22 +0100 Andreas Henriksson [EMAIL PROTECTED] wrote: I think both previous patches where broken on big-endian

[PATCH 3/7] [TFRC]: Ringbuffer to track loss interval history

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] A ringbuffer-based implementation of loss interval history is easier to maintain, allocate, and update. The `swap' routine to keep the RX history sorted is due to and was written by Arnaldo Carvalho de Melo, simplifying an earlier macro-based variant.

[PATCH 6/7] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] This hooks up the TFRC Loss Interval database with CCID 3 packet reception. In addition, it makes the CCID-specific computation of the first loss interval (which requires access to all the guts of CCID3) local to ccid3.c. The patch also fixes an omission in

[PATCH 4/7] [CCID3]: Redundant debugging output / documentation

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] Each time feedback is sent two lines are printed: ccid3_hc_rx_send_feedback: client ... - entry ccid3_hc_rx_send_feedback: Interval ...usec, X_recv=..., 1/p=... The first line is redundant and thus removed. Further, documentation of

[PATCH 1/7] [TFRC]: Put RX/TX initialisation into tfrc.c

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] This separates RX/TX initialisation and puts all packet history / loss intervals initialisation into tfrc.c. The organisation is uniform: slab declaration - {rx,tx}_init() - {rx,tx}_exit() Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by:

[PATCH 5/7] [TFRC]: CCID3 (and CCID4) needs to access these inlines

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] This moves two inlines back to packet_history.h: these are not private to packet_history.c, but are needed by CCID3/4 to detect whether a new loss is indicated, or whether a loss is already pending. Signed-off-by: Gerrit Renker [EMAIL PROTECTED]

[PATCHES 0/7]: DCCP patches for 2.6.25

2007-12-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Best Regards, - Arnaldo b/net/dccp/ccids/ccid3.c |2 b/net/dccp/ccids/ccid3.h |5 b/net/dccp/ccids/lib/loss_interval.c | 161 ++-

[PATCH 7/7] [TFRC]: Remove previous loss intervals implementation

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/lib/loss_interval.c | 266

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 07:20:34 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 21:39:39 -0800 On Wed, 12 Dec 2007 13:01:27 +0900 Joonwoo Park [EMAIL PROTECTED] wrote: [NETDEV]: tehuti Fix possible causing oops of

[PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-12 Thread Jochen Friedrich
This patch adds support to use the fixed-link property of an ethernet node to fs_enet for the CONFIG_PPC_CPM_NEW_BINDING case. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

Re: ip neigh show not showing arp cache entries?

2007-12-12 Thread Eric Dumazet
Chris Friesen a écrit : I retested it on an x86 machine and am seeing similar problems. First, arp gives the arp table as expected: [EMAIL PROTECTED]:/tftpboot/cnp/0-0-5-0/0-0-5-0 arp -n Address HWtype HWaddress Flags MaskIface 172.24.0.9 ether

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Gerrit Renker
| +static struct kmem_cache *tfrc_lh_slab __read_mostly;/* === */ | | Yup, this one, is introduced as above but is not initialized at the | module init routine, please see, it should be OK and we can move on: | |

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Dave Jones
On Wed, Dec 12, 2007 at 05:53:43PM +0100, Thomas Klein wrote: +static void ehea_update_adapter_handles(struct ehea_adapter *adapter) +{ +int i, k; +int j = 0; + +memset(adapter-res_handles, sizeof(adapter-res_handles), 0); arguments wrong way around. Dave --

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 12, 2007 at 04:56:32PM +, Gerrit Renker escreveu: | This time around I'm not doing any reordering, just trying to use your | patches as is, but adding this patch as-is produces a kernel that will | crash, no? | | The loss history and the RX/TX packet history slabs are all

Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #2)

2007-12-12 Thread Kok, Auke
Kok, Auke wrote: All, here is the second version of the igb (82575) ethernet controller driver. This driver was previously posted 2007-07-13. Many comments received were addressed: - removed indirection wrappers in the same way as e1000e and ixgbe. - cleaned up largely against sparse,

Re: 2.6.24-rc4-mm1

2007-12-12 Thread Cedric Le Goater
Ilpo Järvinen wrote: On Wed, 5 Dec 2007, David Miller wrote: From: Reuben Farrelly [EMAIL PROTECTED] Date: Thu, 06 Dec 2007 17:59:37 +1100 On 5/12/2007 4:17 PM, Andrew Morton wrote: - Lots of device IDs have been removed from the e1000 driver and moved over to e1000e. So if your e1000

Re: [RFC] net: napi fix

2007-12-12 Thread Andrew Gallatin
David Miller wrote: From: Andrew Gallatin [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 12:29:23 -0500 Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then block

[PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-12 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Jeff, can you ack this to go through Paul's tree (assuming nothing wrong with it)? drivers/net/gianfar.c | 137 - drivers/net/gianfar.h | 13 +++- drivers/net/gianfar_ethtool.c | 41

Re: [RFC] net: napi fix

2007-12-12 Thread Andrew Gallatin
[I apologize for loosing threading, I'm replying from the archives] The problem is that the driver is doing a NAPI completion and re-enabling chip interrupts with work_done == weight, and that is illegal. The only time at least myri10ge will do this is due to the !netif_running(netdev)

Re: [RFC] net: napi fix

2007-12-12 Thread David Miller
From: Andrew Gallatin [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 12:29:23 -0500 Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then block any new polls from

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-12 Thread Jay Vosburgh
Herbert Xu [EMAIL PROTECTED] wrote: diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix +++ a/drivers/net/bonding/bond_sysfs.c @@ -,8 +,6 @@ static ssize_t

[PATCH 1/8][BNX2]: Add ring constants.

2007-12-12 Thread Michael Chan
[BNX2]: Add ring constants. Define the various ring constants to make the code cleaner. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 4e7b46e..dfe50c2 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -468,8 +468,7 @@

[PATCH 5/8][BNX2]: Add init. code to handle RX pages.

2007-12-12 Thread Michael Chan
[BNX2]: Add init. code to handle RX pages. Add new fields to keep track of the pages and the page rings. Add functions to allocate and free pages. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index db3b750..38e8e31 100644 ---

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: I think the change below handles the race. Otherwise please detail the use case. [...] @@ -292,6 +292,9 @@ static int virtnet_open(struct net_devic return -ENOMEM; napi_enable(vi-napi); + +

[PATCH 0/8][BNX2]: Add S/G jumbo RX support.

2007-12-12 Thread Michael Chan
[BNX2]: Add S/G jumbo RX support. David, 8 patches will follow to implement S/G for jumbo RX packets. Please review for 2.6.25. Thanks. Signed-off-by: Michael Chan [EMAIL PROTECTED] --- drivers/net/bnx2.c | 510 +++- drivers/net/bnx2.h | 43 +- drivers/net/bnx2_fw.h | 7034

[PATCH 2/8][BNX2]: Restructure RX fast path handling.

2007-12-12 Thread Michael Chan
[BNX2]: Restructure RX fast path handling. Add a new function to handle new SKB allocation and to prepare the completed SKB. This makes it easier to add support for non-linear SKB. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index

[PATCH 3/8][BNX2]: Restructure RX ring init. code.

2007-12-12 Thread Michael Chan
[BNX2]: Restructure RX ring init. code. Factor out the common functions that will be used to initialize the normal RX rings and the page rings. Change the copybreak constant RX_COPY_THRESH to 128. This same constant will be used for the max. size of the linear SKB when pages are used.

[PATCH 6/8][BNX2]: Add fast path code to handle RX pages.

2007-12-12 Thread Michael Chan
[BNX2]: Add fast path code to handle RX pages. Add function to reuse a page in case of allocation or other errors. Add code to construct the completed SKB with the additional data in the pages. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c

[PATCH 7/8][BNX2]: Enable S/G for jumbo RX.

2007-12-12 Thread Michael Chan
[BNX2]: Enable S/G for jumbo RX. If the MTU requires more than 1 page for the SKB, enable the page ring and calculate the size of the page ring. This will guarantee order-0 allocation regardless of the MTU size. Fixup loopback test packet size so that we don't deal with the pages during

[PATCH 8/8][BNX2]: Update version to 1.6.9.

2007-12-12 Thread Michael Chan
[BNX2]: Update version to 1.6.9. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index ae081c8..469d259 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAMEbnx2 #define PFX

Re: ip neigh show not showing arp cache entries?

2007-12-12 Thread Chris Friesen
Eric Dumazet wrote: Chris Friesen a écrit : Is this expected behaviour? Probably not... Still a 2.6.14 kernel ? Yep. Embedded hardware, so I'm unable to test with a more recent kernel. Could you send the result of : strace ip neigh show I've attached two strace runs, one of ip neigh

Re: ip neigh show not showing arp cache entries?

2007-12-12 Thread Eric Dumazet
Chris Friesen a écrit : Eric Dumazet wrote: Chris Friesen a écrit : Is this expected behaviour? Probably not... Still a 2.6.14 kernel ? Yep. Embedded hardware, so I'm unable to test with a more recent kernel. And what is the version of ip command you have on this machine ? ip -V You

[PATCH] netfilter : xt_hashlimit should use time_after_eq()

2007-12-12 Thread Eric Dumazet
Hi David Patrick I believe this patch is needed for linux-2.6.24 Thank you [PATCH] netfilter : xt_hashlimit should use time_after_eq() In order to avoid jiffies wraparound and its effect, special care must be taken when doing comparisons ... Signed-off-by: Eric Dumazet [EMAIL PROTECTED]

Re: [PATCH 1/3] [IPSEC]: Make xfrm_lookup flags argument a bit-field

2007-12-12 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 09:57:59 +0800 [IPSEC]: Make xfrm_lookup flags argument a bit-field This patch introduces an enum for bits in the flags argument of xfrm_lookup. This is so that we can cram more information into it later. Since all current users

Re: [PATCH 2/3] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-12 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 09:58:00 +0800 [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch adds the functions

Re: [RFC] net: napi fix

2007-12-12 Thread Kok, Auke
David Miller wrote: From: Andrew Gallatin [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 12:29:23 -0500 Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then

Re: [PATCH 3/3] [IPSEC]: Add ICMP host relookup support

2007-12-12 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 09:58:01 +0800 [IPSEC]: Add ICMP host relookup support RFC 4301 requires us to relookup ICMP traffic that does not match any policies using the reverse of its payload. This patch implements this for ICMP traffic that originates from

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 10:35:56 +0800 [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice Since the caller and the upper caller doesn't hod the rtnl semaphore. We should use unregister_netdev instead of unregister_netdevice.

Re: [PATCH] Net: Remove FASTCALL macro

2007-12-12 Thread David Miller
From: Harvey Harrison [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 00:09:03 -0800 X86_32 was the last user of the FASTCALL macro, now that it uses regparm(3) by default, this macro expands to nothing. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] Applied to net-2.6.25, thanks. -- To

Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

2007-12-12 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 14:05:17 +0300 netns: network namespace was passed into dev_getbyhwaddr but not used Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Applied. Please always put the subsystem name in the headline in all capitals and surround it

[PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-12 Thread Andrew Gallatin
Remove the bogus netif_running() check from myri10ge_poll(). This eliminates any chance that myri10ge_poll() can trigger an oops by calling netif_rx_complete() and returning with work_done == budget. Signed-off-by: Andrew Gallatin [EMAIL PROTECTED] diff --git a/drivers/net/myri10ge/myri10ge.c

Re: [RFC] mac80211: clean up frame receive handling

2007-12-12 Thread drago01
On Dec 12, 2007 7:24 PM, Johannes Berg [EMAIL PROTECTED] wrote: [comments welcome. I really need a refresher on what the frame formats mean but I think I did the right thing with skb-protocol here, I also think we had a bug with rfc2042 header frames bigger than 15xx bytes and

Re: [PATCH] XFRM: Display the audited SPI value in host byte order

2007-12-12 Thread David Miller
From: Paul Moore [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 14:05:42 -0500 Currently the IPsec protocol SPI values are written to the audit log in network byte order which is different from almost all other values which are recorded in host byte order. This patch corrects this inconsistency by

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-12 Thread Andy Gospodarek
On Wed, Dec 12, 2007 at 09:46:55AM -0800, Jay Vosburgh wrote: Herbert Xu [EMAIL PROTECTED] wrote: diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix +++

Re: [PATCH] netfilter : xt_hashlimit should use time_after_eq()

2007-12-12 Thread Patrick McHardy
Eric Dumazet wrote: Hi David Patrick I believe this patch is needed for linux-2.6.24 Thank you [PATCH] netfilter : xt_hashlimit should use time_after_eq() In order to avoid jiffies wraparound and its effect, special care must be taken when doing comparisons ... Looks good, thanks Eric.

[PATCH] XFRM: Display the audited SPI value in host byte order

2007-12-12 Thread Paul Moore
Currently the IPsec protocol SPI values are written to the audit log in network byte order which is different from almost all other values which are recorded in host byte order. This patch corrects this inconsistency by writing the SPI values to the audit record in host byte order.

Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-12 Thread David Miller
From: Andrew Gallatin [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 13:38:34 -0500 Remove the bogus netif_running() check from myri10ge_poll(). This eliminates any chance that myri10ge_poll() can trigger an oops by calling netif_rx_complete() and returning with work_done == budget.

Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread David Miller
From: Michal Schmidt [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 17:29:33 +0100 On Wed, 12 Dec 2007 17:00:14 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: If you change dev-iflink this should trigger a rtnetlink notification. OK, I've added netdev_state_change(dev). Here's the new patch.

Re: [PATCH] Remove unused define from loopback driver

2007-12-12 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 17:44:54 +0300 The LOOPBACK_OVERHEAD is not used in this file at all. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied to net-2.6.25, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const

2007-12-12 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 14:05:55 +0300 -static int halve_threshold = 25; -static int inflate_threshold = 50; -static int halve_threshold_root = 15; -static int inflate_threshold_root = 25; halve_threshold_root and inflate_threshold_root have different

Re: [PATCH 1/8][BNX2]: Add ring constants.

2007-12-12 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Wed, 12 Dec 2007 10:58:22 -0800 [BNX2]: Add ring constants. Define the various ring constants to make the code cleaner. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied to net-2.6.25 -- To unsubscribe from this list: send the line

  1   2   >