[PATCH net-next] cxgb4: Enhance driver to update FW, when FW is too old

2015-10-06 Thread Hariprasad Shenai
t4_check_fw_version() can return several error codes (-EINVAL, -EBUSY, -EAGAIN). The present code sets the adapter state to UNINIT only if its an EFAULT. In all the error cases set the adapter to uninitialized state. In t4_check_fw_version() if call to t4_read_flash() fails, repeat the operation

[GIT PULL nf-next 0/2] Fourth Round of IPVS Updates for v4.4

2015-10-06 Thread Simon Horman
Hi Pablo, please consider these build warning cleanups from David Ahern and myself. They resolve some minor side effects of Eric Biederman' heroic work to cleanup IPVS which you recently pulled: its queued up for v4.4 so no need to worry about earlier kernel versions. The following changes since

[PATCH nf-next 2/2] ipvs: Remove possibly unused variables from ip_vs_conn_net_{init,cleanup}

2015-10-06 Thread Simon Horman
If CONFIG_PROC_FS is undefined then the arguments of proc_create() and remove_proc_entry() are unused. As a result the net variables of ip_vs_conn_net_{init,cleanup} are unused. net/netfilter/ipvs//ip_vs_conn.c: In function ‘ip_vs_conn_net_init’: net/netfilter/ipvs//ip_vs_conn.c:1350:14: warning:

[PATCH nf-next 1/2] ipvs: Remove possibly unused variable from ip_vs_out

2015-10-06 Thread Simon Horman
From: David Ahern Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if CONFIG_IP_VS_IPV6 is not enabled: ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’: ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’

Re: netpoll_send_skb_on_dev warning with bnx2

2015-10-06 Thread Vinson Lee
On Fri, Oct 2, 2015 at 6:10 AM, Neil Horman wrote: > On Thu, Oct 01, 2015 at 08:25:46PM -0700, Vinson Lee wrote: >> Hi. >> >> I am seeing a netpoll_send_skb_on_dev warning with bnx2. It happens on >> Linux 4.1 and I am able to reproduce the warning with Linux 4.3-rc3. >> >>

Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile

2015-10-06 Thread Mark Brown
On Tue, Oct 06, 2015 at 06:25:08AM -0700, David Miller wrote: > > 4) David should then merge the regmap for-next branch into net-next > Nope, this doesn't work at all. > It is my tree which people depend upon, not the other way around. Yes, it does work - this is the way we normally handle

Re: linux-next: Tree for Oct 6

2015-10-06 Thread Hans-Peter Nilsson
> From: Sudip Mukherjee > Date: Tue, 6 Oct 2015 14:33:46 +0200 > On Tue, Oct 06, 2015 at 06:25:22PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20151002: > > The build for cris allmodconfig is failing with the error: > > net/sched/sch_dsmark.c:

Re: HW communication debugging interface - ideas?

2015-10-06 Thread Jiri Pirko
Tue, Oct 06, 2015 at 04:54:09PM CEST, john.fastab...@gmail.com wrote: >On 15-10-06 01:14 AM, Jiri Pirko wrote: >> Mon, Oct 05, 2015 at 05:47:09PM CEST, john.fastab...@gmail.com wrote: >>> On 15-10-05 08:35 AM, Jiri Pirko wrote: Mon, Oct 05, 2015 at 05:29:09PM CEST, john.fastab...@gmail.com

[PATCH v3 0/5] net: dsa: complete and fix the dsa unbinding

2015-10-06 Thread Neil Armstrong
In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions. First, the missing kfree were added, the remove function were completed then kfree were removed in favor to

Re: HW communication debugging interface - ideas?

2015-10-06 Thread John Fastabend
On 15-10-06 01:14 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 05:47:09PM CEST, john.fastab...@gmail.com wrote: >> On 15-10-05 08:35 AM, Jiri Pirko wrote: >>> Mon, Oct 05, 2015 at 05:29:09PM CEST, john.fastab...@gmail.com wrote: On 15-10-05 08:18 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015

[PATCH v3 2/5] net: dsa: add missing dsa_switch mdiobus remove

2015-10-06 Thread Neil Armstrong
To prevent memory leakage on unbinding, add missing mdiobus unregister and unallocation calls. Reviewed-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/dsa/dsa.c

[PATCH v3 4/5] net: dsa: switch to devm_ calls and remove kfree calls

2015-10-06 Thread Neil Armstrong
Now the kfree calls exists in the the remove functions, remove them in all places except the of_probe functions and replace allocation calls with their devm_ counterparts. Reviewed-by: Florian Fainelli Signed-off-by: Neil Armstrong ---

Re: HW communication debugging interface - ideas?

2015-10-06 Thread Andrew Lunn
> Sure just throwing out an idea. I suspect whatever interface you have > will include the vendor-id or some other identifier and a set of > parsers in user space to pretty print the msg. If you are going to use wireshark, in this case, all you need to do is make the stream as being Ethernet

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Jiri Benc
Some more feedback after doing a deeper review. On Mon, 5 Oct 2015 10:58:17 -0700, Pravin B Shelar wrote: > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -703,6 +703,32 @@ err: > return NETDEV_TX_OK; > } > > +static int geneve_egress_tun_info(struct net_device *dev,

Re: [PATCH RFC v1 7/7] net/faraday: Enable offload checksum according to device-tree

2015-10-06 Thread Sergei Shtylyov
Hello. On 10/6/2015 6:09 AM, Gavin Shan wrote: This enables IP/UDP/TCP offload checksum according to information passed on from bootloader through device-tree. The offload doesn't working properly when the interface works in NCSI mode. Signed-off-by: Gavin Shan ---

[PATCH v3 5/5] net: dsa: exit probe if no switch were found

2015-10-06 Thread Neil Armstrong
If no switch were found in dsa_setup_dst, return -ENODEV and exit the dsa_probe cleanly. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index

[PATCH v3 3/5] net: dsa: complete dsa_switch_destroy

2015-10-06 Thread Neil Armstrong
When unbinding dsa, complete the dsa_switch_destroy to unregister the fixed link phy then cleanly unregister and destroy the net devices. Reviewed-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 37

[PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTNETLINK

[PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed

2015-10-06 Thread Maxime Bizon
With this setup: * non IPv6 checksumming capable network hardware * GRO off * IPv6 SNAT I get this when I receive an UDPv6 reply: ": hw csum failure" Call trace: * nf_ip6_checksum() calls __skb_checksum_complete() * nf_nat_ipv6_csum_update() & nf_nat_ipv6_manip_pkt() * __udp6_lib_rcv() =>

Re: [PATCH net-next 10/15] ipv4: Cache net in ip_build_and_send_pkt and ip_queue_xmit

2015-10-06 Thread Eric W. Biederman
Eric Dumazet writes: > On Tue, 2015-10-06 at 13:53 -0500, Eric W. Biederman wrote: >> Compute net and store it in a variable in the functions >> ip_build_and_send_pkt and ip_queue_xmit so that it does not need to be >> recomputed next time it is needed. >> >>

Re: [PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread Eric W. Biederman
roopa writes: > On 10/6/15, 12:44 PM, Eric W. Biederman wrote: >> Roopa Prabhu writes: >> >>> From: Roopa Prabhu >>> >>> This patch adds support for MPLS multipath routes. >>> >>> Includes following changes to

[PATCH net] bpf: clear sender_cpu before xmit

2015-10-06 Thread Alexei Starovoitov
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before forwarding") the skb->sender_cpu needs to be cleared before xmit. Fixes: 3896d655f4d4 ("bpf: introduce bpf_clone_redirect() helper") Signed-off-by: Alexei Starovoitov --- That is similar to pending patches for

Re: [PATCH net-next 10/15] ipv4: Cache net in ip_build_and_send_pkt and ip_queue_xmit

2015-10-06 Thread Eric Dumazet
On Tue, 2015-10-06 at 22:26 -0500, Eric W. Biederman wrote: > So what I am really reading it for is ip_local_out which I change to > take a struct net a few patches later in the series. The patches that > changes everything is noticably cleaner and easier to review with these > couple of patches

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Alexei Starovoitov
On 10/6/15 1:39 AM, Daniel Borkmann wrote: [...] Also classic BPF would then need to test for it, since a socket filter doesn't really know whether native eBPF is loaded there or a classic-to-eBPF transformed one, and classic never makes use of this. Anyway, it could be done by adding a bit flag

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Pravin Shelar
On Tue, Oct 6, 2015 at 11:45 AM, Jiri Benc wrote: > On Tue, 6 Oct 2015 11:28:08 -0700, Pravin Shelar wrote: >> What do you have in mind? I do not see way to fix this issue in vport-*.c. > > It seems to me that e.g. the code you have in vxlan_egress_tun_info in >

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Jiri Benc
On Tue, 6 Oct 2015 11:26:31 -0700, Pravin Shelar wrote: > I do not see need to drop and reallocate dst in this operation. I just > need to set source IP address and source and dst port in the metadata > dst already set in skb. If I'm looking at the code correctly, metadata_dst is stored in the

Re: [PATCH v2 4/5] net: phy: Broadcom Cygnus internal Etherent PHY driver

2015-10-06 Thread Arun Parameswaran
On 15-09-30 09:04 PM, kbuild test robot wrote: > Hi Arun, > > [auto build test results on v4.3-rc3 -- if it's inappropriate base, please > ignore] > > config: um-allyesconfig (attached as .config) > reproduce: > git checkout 0560b94805aa3bb38439b4f72b776d85d2aac394 > # save the

[PATCH net-next 02/15] xfrm: Only compute net once in xfrm_policy_queue_process

2015-10-06 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- net/xfrm/xfrm_policy.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 418daa038edf..be1776bc5673 100644 --- a/net/xfrm/xfrm_policy.c +++

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Pravin Shelar
On Tue, Oct 6, 2015 at 12:03 PM, Jiri Benc wrote: > On Tue, 6 Oct 2015 11:55:35 -0700, Pravin Shelar wrote: >> We should be able to use lwtunnel devices on 4.3. How about using >> tunnel device parameters to detect lwtunnel support. For example in >> case of vxlan tunnel

[PATCH net] xps: clear skb sender_cpu before tee

2015-10-06 Thread dho
From: "Devon H. O'Dell" The netfilter tee code does not clear skb->sender_cpu after copying the skb. When both CONFIG_XPS and CONFIG_NET_RX_BUSY_POLL are active, it is possible for a tee rule to duplicate a skb from input, leaving its its napi queue id set. Because this field is

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Daniel Borkmann
On 10/06/2015 07:50 PM, Alexei Starovoitov wrote: On 10/6/15 1:39 AM, Daniel Borkmann wrote: [...] Also classic BPF would then need to test for it, since a socket filter doesn't really know whether native eBPF is loaded there or a classic-to-eBPF transformed one, and classic never makes use of

[PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk

2015-10-06 Thread Eric W. Biederman
It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket is known. Signed-off-by: "Eric W. Biederman" --- drivers/net/ipvlan/ipvlan_core.c| 2 +- drivers/net/ppp/pptp.c | 2 +-

[PATCH net-next 03/15] net: Pass net into dst_output and remove dst_output_okfn

2015-10-06 Thread Eric W. Biederman
Replace dst_output_okfn with dst_output Signed-off-by: "Eric W. Biederman" --- include/net/dst.h | 6 +- net/decnet/dn_nsp_out.c | 4 ++-- net/ipv4/ip_forward.c | 2 +- net/ipv4/ip_output.c| 7 --- net/ipv4/ip_vti.c

[PATCH net-next 05/15] ipv4: Merge __ip_local_out and __ip_local_out_sk

2015-10-06 Thread Eric W. Biederman
Signed-off-by: "Eric W. Biederman" --- include/net/ip.h| 3 +-- net/ipv4/ip_output.c| 9 ++--- net/ipv4/route.c| 2 +- net/ipv4/xfrm4_policy.c | 2 +- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/include/net/ip.h

[PATCH net-next 08/15] ipv6: Merge ip6_local_out and ip6_local_out_sk

2015-10-06 Thread Eric W. Biederman
Stop hidding the sk paramater with an inline helper function and make all of the callers pass it, so that it is clear what the function is doing. Signed-off-by: "Eric W. Biederman" --- drivers/net/ipvlan/ipvlan_core.c| 2 +- include/net/ip6_tunnel.h| 2 +-

[PATCH net-next 07/15] ipv6: Merge __ip6_local_out and __ip6_local_out_sk

2015-10-06 Thread Eric W. Biederman
Only __ip6_local_out_sk has callers so rename __ip6_local_out_sk __ip6_local_out and remove the previous __ip6_local_out. Signed-off-by: "Eric W. Biederman" --- include/net/ipv6.h | 3 +-- net/ipv6/output_core.c | 9 ++--- net/ipv6/route.c| 2 +-

[PATCH net-next 04/15] dst: Pass a sk into .local_out

2015-10-06 Thread Eric W. Biederman
For consistency with the other similar methods in the kernel pass a struct sock into the dst_ops .local_out method. Simplifying the socket passing case is needed a prequel to passing a struct net reference into .local_out. Signed-off-by: "Eric W. Biederman" ---

[PATCH net-next 10/15] ipv4: Cache net in ip_build_and_send_pkt and ip_queue_xmit

2015-10-06 Thread Eric W. Biederman
Compute net and store it in a variable in the functions ip_build_and_send_pkt and ip_queue_xmit so that it does not need to be recomputed next time it is needed. Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_output.c | 10 ++ 1 file changed, 6 insertions(+),

[PATCH] bridge/netfilter: avoid unused label warning

2015-10-06 Thread Arnd Bergmann
With the ARM mini2440_defconfig, the bridge netfilter code gets built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6 disabled, which leads to a harmless gcc warning: net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit': net/bridge/br_netfilter_hooks.c:792:2: warning:

[PATCH v3 3/5] net: phy: Add Broadcom phy library for common interfaces

2015-10-06 Thread Arun Parameswaran
This patch adds the Broadcom phy library to consolidate common interfaces shared by Broadcom phy's. Moved the common interfaces to the 'bcm-phy-lib.c' and updated the Broadcom PHY drivers to use the new APIs. Signed-off-by: Arun Parameswaran --- drivers/net/phy/Kconfig

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Alexei Starovoitov
On 10/6/15 10:56 AM, Eric Dumazet wrote: On Tue, 2015-10-06 at 10:50 -0700, Alexei Starovoitov wrote: was also thinking that we can do it only in paths that actually have multiple protocol layers, since today bpf is mainly used with tcpdump(raw_socket) and new af_packet fanout both have cb

[PATCH 1/1] net: ipv4: tcp.c Fixed an assignment coding style issue

2015-10-06 Thread Yuvaraja Mariappan
>From beecc68c2ec1fecda34d26fcbc3c821e617b7bcb Mon Sep 17 00:00:00 2001 From: Yuvaraja Mariappan Date: Tue, 6 Oct 2015 10:53:29 -0700 Subject: [PATCH 1/1] net: ipv4: tcp.c Fixed an assignment coding style issue Fixed an assignment coding style issue Signed-off-by: Yuvaraja

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Pravin Shelar
On Tue, Oct 6, 2015 at 8:42 AM, Jiri Benc wrote: > Some more feedback after doing a deeper review. > Thanks for the review. > On Mon, 5 Oct 2015 10:58:17 -0700, Pravin B Shelar wrote: >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -703,6 +703,32 @@ err: >>

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Jiri Benc
On Tue, 6 Oct 2015 11:55:35 -0700, Pravin Shelar wrote: > We should be able to use lwtunnel devices on 4.3. How about using > tunnel device parameters to detect lwtunnel support. For example in > case of vxlan tunnel IFLA_VXLAN_COLLECT_METADATA flags can confirm > lwtunnel support. You would have

[PATCH] af_unix: constify the sock parameter in unix_sk()

2015-10-06 Thread Paul Moore
Make unix_sk() just like inet[6]_sk() by constify'ing the sock parameter. Signed-off-by: Paul Moore --- include/net/af_unix.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/af_unix.h b/include/net/af_unix.h index cb1b9bb..b36d837 100644 ---

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Pravin Shelar
On Tue, Oct 6, 2015 at 11:55 AM, Jiri Benc wrote: > On Tue, 6 Oct 2015 11:26:31 -0700, Pravin Shelar wrote: >> I do not see need to drop and reallocate dst in this operation. I just >> need to set source IP address and source and dst port in the metadata >> dst already set in

[PATCH v3 1/5] dt-bindings: net: Broadcom iProc MDIO bus driver device tree binding

2015-10-06 Thread Arun Parameswaran
Add device tree binding documentation for the Broadcom iProc MDIO bus driver. Signed-off-by: Arun Parameswaran --- .../devicetree/bindings/net/brcm,iproc-mdio.txt| 23 ++ 1 file changed, 23 insertions(+) create mode 100644

[PATCH v3 2/5] net: phy: Broadcom iProc MDIO bus driver

2015-10-06 Thread Arun Parameswaran
This patch adds support for the Broadcom iProc MDIO bus interface. The MDIO interface can be found in the Broadcom iProc family Soc's. The MDIO bus is accessed using a combination of command and data registers. This MDIO driver provides access to the Etherent GPHY's connected to the MDIO bus.

Re: [PATCH] bridge/netfilter: avoid unused label warning

2015-10-06 Thread Nikolay Aleksandrov
On 10/06/2015 09:22 PM, Arnd Bergmann wrote: > With the ARM mini2440_defconfig, the bridge netfilter code gets > built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6 > disabled, which leads to a harmless gcc warning: > > net/bridge/br_netfilter_hooks.c: In function

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Jiri Benc
On Tue, 6 Oct 2015 12:21:24 -0700, Pravin Shelar wrote: > It should report the flag when device parameters are requested by > userspace if there is support for lwtunnel. So check for the flag > should be good enough test for lwtunnel support. Why is that not > reliable check? Which device? You'll

Re: [PATCHv3 net 2/6] openvswitch: Fix skb leak in ovs_fragment()

2015-10-06 Thread Joe Stringer
On 6 October 2015 at 07:12, Sergei Shtylyov wrote: > Hello. > > On 10/6/2015 1:23 AM, Joe Stringer wrote: > >> If ovs_fragment() was unable to fragment the skb due to an L2 header >> that exceeds the supported length, skbs would be leaked. Fix the bug. >> >>

[PATCHv4 net 3/6] openvswitch: Ensure flow is valid before executing ct

2015-10-06 Thread Joe Stringer
The ct action uses parts of the flow key, so we need to ensure that it is valid before executing that action. Fixes: 7f8a436eaa2c "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v4: Extend "fixes" hash in

[PATCHv4 net 6/6] openvswitch: Change CT_ATTR_FLAGS to CT_ATTR_COMMIT

2015-10-06 Thread Joe Stringer
Previously, the CT_ATTR_FLAGS attribute, when nested under the OVS_ACTION_ATTR_CT, encoded a 32-bit bitmask of flags that modify the semantics of the ct action. It's more extensible to just represent each flag as a nested attribute, and this requires no additional error checking to reject flags

[PATCHv4 net 4/6] openvswitch: Reject ct_state unsupported bits

2015-10-06 Thread Joe Stringer
Previously, if userspace specified ct_state bits in the flow key which are currently undefined (and therefore unsupported), then they would be ignored. This could cause unexpected behaviour in future if userspace is extended to support additional bits but attempts to communicate with the current

[PATCHv4 net 2/6] openvswitch: Fix skb leak in ovs_fragment()

2015-10-06 Thread Joe Stringer
If ovs_fragment() was unable to fragment the skb due to an L2 header that exceeds the supported length, skbs would be leaked. Fix the bug. Fixes: 7f8a436eaa2c "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar

[PATCHv4 net 1/6] openvswitch: Fix typos in CT headers

2015-10-06 Thread Joe Stringer
These comments hadn't caught up to their implementations, fix them. Fixes: 7f8a436eaa2c "openvswitch: Add conntrack action" Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v4: Extend "fixes" hash in commit message. v3: No change. v2: Acked.

[PATCHv4 net 5/6] openvswitch: Extend ct_state match field to 32 bits

2015-10-06 Thread Joe Stringer
The ct_state field was initially added as an 8-bit field, however six of the bits are already being used and use cases are already starting to appear that may push the limits of this field. This patch extends the field to 32 bits while retaining the internal representation of 8 bits. This should

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Andy Lutomirski
On Tue, Oct 6, 2015 at 10:56 AM, Eric Dumazet wrote: > On Tue, 2015-10-06 at 10:50 -0700, Alexei Starovoitov wrote: > >> was also thinking that we can do it only in paths that actually >> have multiple protocol layers, since today bpf is mainly used with >>

Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out

2015-10-06 Thread Julian Anastasov
Hello, On Tue, 6 Oct 2015, Simon Horman wrote: > Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and > ip_vs_in_icmp_v6") the net variable in ip_vs_out() appears to be unused > unless CONFIG_IP_VS_IPV6 is set. To resolve this remove the net variable > and dereference net

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Jiri Benc
On Tue, 6 Oct 2015 11:28:08 -0700, Pravin Shelar wrote: > What do you have in mind? I do not see way to fix this issue in vport-*.c. It seems to me that e.g. the code you have in vxlan_egress_tun_info in drivers/net/vxlan.c can be put into vxlan_get_egress_tun_info in

[PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry - moves

[PATCH net-next v2 0/2] mpls: multipath support

2015-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry - Adds

[PATCH net-next v2 2/2] mpls: flow-based multipath selection

2015-10-06 Thread Roopa Prabhu
From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Eric Dumazet
On Tue, 2015-10-06 at 10:50 -0700, Alexei Starovoitov wrote: > was also thinking that we can do it only in paths that actually > have multiple protocol layers, since today bpf is mainly used with > tcpdump(raw_socket) and new af_packet fanout both have cb cleared > on RX, because it just came out

Re: [PATCH net] openvswitch: Fix egress tunnel info.

2015-10-06 Thread Pravin Shelar
On Tue, Oct 6, 2015 at 8:56 AM, Jiri Benc wrote: > On Mon, 5 Oct 2015 12:37:50 -0700, Pravin Shelar wrote: >> That would involve lot of refactoring vxlan xmit code. I do not want >> to make such change in net tree at such late stage. > > Fair enough. But then, the minimal fix

[PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk

2015-10-06 Thread Eric W. Biederman
In the rare case where sk != skb->sk ip_local_out_sk arranges to call dst->output differently if the skb is queued or not. This is a bug. Fix this bug by passing the sk parameter of ip_local_out_sk through from ip_local_out_sk to __ip_local_out_sk (skipping __ip_local_out). Fixes:

[PATCH net-next 09/15] ipv4: Cache net in iptunnel_xmit

2015-10-06 Thread Eric W. Biederman
Store net in a variable in ip_tunnel_xmit so it does not need to be recomputed when it is used again. Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_tunnel_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_tunnel_core.c

[PATCH v3 0/5] Add support for Broadcom's iProc MDIO and Cygnus Ethernet PHY

2015-10-06 Thread Arun Parameswaran
Hi This patchset adds support for the iProc MDIO interface and the Broadcom Cygnus SoC's internal Ethernet PHY. The internal Ethernet PHY(s) in the Cygnus SoC's are accessed via the MDIO interface found in most of the iProc based chips. The patch also consolidates the common API's used by the

Re: [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-06 Thread David Miller
From: Mark Brown Date: Mon, 5 Oct 2015 15:25:31 +0100 > On Mon, Oct 05, 2015 at 06:16:09AM -0700, David Miller wrote: > >> >> Applied. > >> > Thanks David. However, I've sent a v3 patch, and also expecting feedback >> > from Mark Brown on the regmap portion of it. > >>

Re: [PATCH] amd-xgbe: Check for successful buffer allocation before use

2015-10-06 Thread David Miller
From: Tom Lendacky Date: Mon, 5 Oct 2015 10:51:03 -0500 > The kasprintf function can return NULL if the allocation fails. Check for > successful allocation before attempting to use the returned buffer. > > Signed-off-by: Tom Lendacky Applied,

Re: [PATCH] ipvs: Remove unused net variable from ip_vs_out

2015-10-06 Thread Julian Anastasov
Hello, On Fri, 2 Oct 2015, Simon Horman wrote: > Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and ip_vs_in_icmp_v6") > the net net variable in ip_vs_out() appears to be unused so remove it. > > Signed-off-by: Simon Horman > --- >

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

2015-10-06 Thread Pratyush Anand
On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Acked-by: Pratyush Anand -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

2015-10-06 Thread Neil Armstrong
On 10/03/2015 10:54 PM, Sergei Shtylyov wrote: > On 10/3/2015 6:20 PM, Neil Armstrong wrote: > >>> On 10/3/2015 5:25 PM, Neil Armstrong wrote: >>> To prevent memory leakage on unbinding, add missing kfree calls. Signed-off-by: Neil Armstrong ---

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-06 Thread Jiri Pirko
Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This patchset allows new rocker worlds to be easily added in future (like >> eBPF >> based one I have been working

Re: [net-next:master 647/682] fib_semantics.c:undefined reference to `__divdi3'

2015-10-06 Thread David Miller
From: Peter Nørlund Date: Mon, 5 Oct 2015 23:31:58 +0200 > What is the proper way to supply fixes for this kind of errors? Should > I submit the original patches again with the bug fixed, or should I > submit a patch fixing this particular problem? I imagine bisecting >

Re: [PATCH v2 5/5] net: dsa: exit probe if no switch were found

2015-10-06 Thread Neil Armstrong
On 10/03/2015 09:27 PM, Florian Fainelli wrote: > Le 03/10/2015 07:26, Neil Armstrong a écrit : >> If no switch were found in dsa_setup_dst, return -ENODEV and >> exit the dsa_probe cleanly. >> >> Tested-by: Andrew Lunn >> Tested-by: Florian Fainelli >>

Re: [PATCH v2 3/5] net: dsa: complete dsa_switch_destroy

2015-10-06 Thread Neil Armstrong
On 10/03/2015 09:25 PM, Florian Fainelli wrote: > Le 03/10/2015 07:26, Neil Armstrong a écrit : >> When unbinding dsa, complete the dsa_switch_destroy to unregister the >> fixed link phy then cleanly unregister and destroy the net devices. >> >> Signed-off-by: Neil Armstrong

Re: [patch net-next 00/14] rocker: add support for multiple worlds

2015-10-06 Thread John Fastabend
[...] >> >> Its related in that if you expose your device model you do not need >> opaque strings to do wholesale reconfiguration of the device. Instead >> if the parts of the device that are configurable are exposed to the >> user they can build the "world" they want. > > The disconnect here, I

Re: [PATCH v2 net-next] ipv4: Fix compilation errors in fib_rebalance

2015-10-06 Thread David Miller
From: Peter Nørlund Date: Tue, 6 Oct 2015 07:24:47 +0200 > This fixes > > net/built-in.o: In function `fib_rebalance': > fib_semantics.c:(.text+0x9df14): undefined reference to `__divdi3' > > and > > net/built-in.o: In function `fib_rebalance': >

Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-10-06 Thread David Miller
From: Carol Soto Date: Mon, 5 Oct 2015 10:24:19 -0500 > > > On 10/4/2015 3:03 AM, Or Gerlitz wrote: >> On 9/29/2015 9:38 PM, cls...@linux.vnet.ibm.com wrote: >>> From: Carol L Soto >>> >>> Test interrupts fails if not all completion

Re: [PATCH net-next v2] net: Fix unused variable compile warning

2015-10-06 Thread David Miller
From: Cong Wang Date: Mon, 5 Oct 2015 10:53:57 -0700 > On Thu, Oct 1, 2015 at 8:49 AM, David Ahern wrote: >> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if >> CONFIG_IP_VS_IPV6 is not enabled: >> >>

Re: [PATCH net-next 1/2] bpf: enable non-root eBPF programs

2015-10-06 Thread Ingo Molnar
* Alexei Starovoitov wrote: > On 10/5/15 3:14 PM, Daniel Borkmann wrote: > >One scenario that comes to mind ... what happens when there are kernel > >pointers stored in skb->cb[] (either from the current layer or an old > >one from a different layer that the skb went through

Re: [PATCH] ipvs: Remove unused net variable from ip_vs_out

2015-10-06 Thread Simon Horman
On Tue, Oct 06, 2015 at 09:35:29AM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 2 Oct 2015, Simon Horman wrote: > > > Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and > > ip_vs_in_icmp_v6") > > the net net variable in ip_vs_out() appears to be unused so remove it. > >

Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-10-06 Thread Matan Barak
On 10/5/2015 11:12 PM, Or Gerlitz wrote: On Mon, Oct 5, 2015 at 6:24 PM, Carol Soto wrote: On 10/4/2015 3:03 AM, Or Gerlitz wrote: On 9/29/2015 9:38 PM, cls...@linux.vnet.ibm.com wrote: From: Carol L Soto Test interrupts fails if

[PATCH net-next v4] net: Microchip encx24j600 driver

2015-10-06 Thread jon
From: Jon Ringle This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet controller over a SPI bus interface. This driver makes use of the regmap API to optimize access to registers by caching registers where possible. Datasheet:

[PATCH] af_unix: introduce unix_sk_const helper

2015-10-06 Thread Arnd Bergmann
Commit 124613012db1 ("af_unix: Convert the unix_sk macro to an inline function for type safety") was recently added to catch incorrect uses of the unix_sk helper using compiler warnings. It has now caught one such case in lsm_audit.c. The code is technically correct, but as it converts a const

[PATCH v4] net/bonding: send arp in interval if no active slave

2015-10-06 Thread Jarod Wilson
From: Uwe Koziolek With some very finicky switch hardware, active backup bonding can get into a situation where we play ping-pong between interfaces, trying to get one to come up as the active slave. There seems to be an issue with the switch's arp replies either taking

Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-06 Thread Russell King
Add support for the ethtool statistic interface, returning the full set of statistics which both Armada 370 and Armada XP can support. Signed-off-by: Russell King --- Andrew, Here's the patch updated to use the example set by mv643xx_eth.c.

Re: [PATCH] bridge/netfilter: avoid unused label warning

2015-10-06 Thread Arnd Bergmann
On Tuesday 06 October 2015 21:28:29 Nikolay Aleksandrov wrote: > I posted a fix for this a couple of days ago, but I like your approach better. > Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure > which > jurisdiction this falls into exactly) we can drop it. > Just

Re: [PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' > > - 'struct

Re: [PATCH v2] Documentation: improve line discipline method descriptions

2015-10-06 Thread Paul Bolle
Hi Tilman, On wo, 2015-09-30 at 01:45 +0200, Tilman Schmidt wrote: > --- a/Documentation/serial/tty.txt > +++ b/Documentation/serial/tty.txt > + Should [...] set receive_room > + in the tty_struct to the maximum amount of data > + the

Re: [PATCH v4] net/bonding: send arp in interval if no active slave

2015-10-06 Thread Jarod Wilson
Jarod Wilson wrote: From: Uwe Koziolek With some very finicky switch hardware, active backup bonding can get into a situation where we play ping-pong between interfaces, trying to get one to come up as the active slave. There seems to be an issue with the switch's arp

Re: [PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Roopa Prabhu writes: > >> From: Roopa Prabhu >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to support multipath: >> - splits struct mpls_route

Re: [PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread roopa
On 10/6/15, 12:44 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> From: Roopa Prabhu >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to support multipath: >> - splits struct mpls_route into

Re: [PATCH net-next v2 1/2] mpls: multipath support

2015-10-06 Thread roopa
On 10/6/15, 1:11 PM, Eric W. Biederman wrote: > ebied...@xmission.com (Eric W. Biederman) writes: > >> Roopa Prabhu writes: >> >>> From: Roopa Prabhu >>> >>> This patch adds support for MPLS multipath routes. >>> >>> Includes following

Re: [patch net-next v2 06/13] rocker: introduce worlds infrastructure

2015-10-06 Thread Rustad, Mark D
Jiri Pirko wrote: >>> + int (*port_init)(struct rocker_port *rocker_port, void *priv, >>> +void *port_priv); >> >> Yuck, void *. Can we do better? > > I see nothing wrong with this priv usage. It's done like this on many > places. I think it is

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

2015-10-06 Thread John Fastabend
[...] >>> >>> Using void * in these ops is unacceptable, I can't agree to this patch. >>> >>> There is a much cleaner way to architect this. If you look at the ops >>> defined, they're mostly duplicates of the already defined >>> switchdev_ops. It would be much cleaner to: >>> >>> 0) set port

Re: [PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX

2015-10-06 Thread Carol Soto
On 10/6/2015 4:39 PM, Or Gerlitz wrote: On Wed, Oct 7, 2015 at 12:27 AM, wrote: From: Carol L Soto If we get MAX_MSIX interrupts would like to have each receive ring with his own msix interrupt line. so 9293267a3e2a was only

[PATCH net-next] tcp: ensure prior synack rtx behavior with small backlogs

2015-10-06 Thread Eric Dumazet
From: Eric Dumazet Some applications use a listen() backlog of 1. Prior kernels were silently enforcing a qlen_log of 4, so that we were sending up to /proc/sys/net/ipv4/tcp_synack_retries SYNACK messages. Fixes: ef547f2ac16b ("tcp: remove max_qlen_log") Signed-off-by:

Re: [PATCH] igb: improve handling of disconnected adapters

2015-10-06 Thread kbuild test robot
Hi Jarod, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: i386-randconfig-x009-201540 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>):

  1   2   3   >