[PATCH v2 net] bnx2x: Prevent FW assertion when using Vxlan

2015-12-18 Thread Yuval Mintz
FW has a rare corner case in which a fragmented packet using lots of frags would not be linearized, causing the FW to assert while trying to transmit the packet. To prevent this, we need to make sure the window of fragements containing MSS worth of data contains 1 BD less than for regular packets

Re: [PATCH iproute2] ip, route: fix minor compile warning

2015-12-18 Thread Daniel Borkmann
On 12/18/2015 02:12 AM, Stephen Hemminger wrote: On Mon, 14 Dec 2015 16:53:20 +0100 Daniel Borkmann wrote: On 12/14/2015 04:51 PM, Phil Sutter wrote: On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote: Seems like gcc (4.8.3) doesn't catch this false

[PATCH iproute2 v3 0/3] improve lwtunnel route support

2015-12-18 Thread Paolo Abeni
This patch series try to improve the current route based lwtunnel support in iproute2, namely adding support for the COLLECT_METADATA flag in vxlan and gre link, and for ip6 encap type in lwtunnel. Tunnel devices need to have the COLLECT_METADATA flag set in order to be used for route based

[PATCH iproute2 v3 3/3] lwtunnel: implement support for ip6 encap

2015-12-18 Thread Paolo Abeni
Currently ip6 encap support for lwtunnel is missing. This patch implement it, mostly duplicating the ipv4 parts. Also be sure to insert a space after the encap type, when showing lwtunnel, to avoid the tunnel type and the following argument being merged into a single word. Signed-off-by: Paolo

[PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-18 Thread shh.xie
From: Shaohui Xie Freescale's PCS PHY can support backplane, this patch provides 10GBASE-KR and 1000BASE-KX support. Signed-off-by: Shaohui Xie --- drivers/net/phy/Kconfig |7 + drivers/net/phy/Makefile|1 +

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread Daniel Trautmann
On Thu, Dec 17, 2015 at 03:45:08PM -0500, David Miller wrote: > From: "David Rivshin (Allworx)" > Date: Wed, 16 Dec 2015 23:02:08 -0500 > > > I have tested on the following hardware configurations: > > - (EVMSK) dual emac with two real MDIO-connected phys using

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-18 Thread Xin Long
On Fri, Dec 18, 2015 at 10:26 AM, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: >> >> I'm just wondering, why do not we handle the genuine double rehash >> issue inside rhashtable? i mean it's just a temporary error that a >> simple

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Lorenzo Colitti
On Fri, Dec 18, 2015 at 9:14 AM, Eric Dumazet wrote: > Adding support for SYN_RECV request sockets to tcp_abort() > is quite easy after our tcp listener rewrite. I added test coverage for this to our tests. Without this patch, attempting to destroy an SYN_RECV socket

Re: [PATCH iproute2 v2 3/3] lwtunnel: implement support for ip6 encap

2015-12-18 Thread Paolo Abeni
On Thu, 2015-12-17 at 17:30 -0800, Stephen Hemminger wrote: > On Wed, 16 Dec 2015 13:22:28 +0100 > Paolo Abeni wrote: > > > Currently ip6 encap support for lwtunnel is missing. > > This patch implement it, mostly duplicating the ipv4 parts. > > > > Also be sure to insert a

[PATCH iproute2 v3 2/3] gre: add support for collect metadata flag

2015-12-18 Thread Paolo Abeni
This patch add support for IFLA_GRE_COLLECT_METADATA via the 'external' keyword to the gre link. Signed-off-by: Paolo Abeni --- ip/link_gre.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ip/link_gre.c b/ip/link_gre.c index 58f416c..c85741f 100644 ---

[PATCH iproute2 v3 1/3] vxlan: add support for collect metadata flag

2015-12-18 Thread Paolo Abeni
This patch add support for IFLA_VXLAN_COLLECT_METADATA via the 'external' keyword to the vxlan link. Also enforce mutual exclusion between 'vni' and 'external'. Signed-off-by: Paolo Abeni --- ip/iplink_vxlan.c | 19 +-- 1 file changed, 17 insertions(+), 2

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-18 Thread Edward Cree
On 17/12/15 18:06, Tom Herbert wrote: > I'm not sure that we need bits in VXLAN or any other encapsulation. It > should be sufficient in udp_set_csum that if we already have > CHECKSUM_PARTIAL that can always be used to do local checksum offload. My understandingis that otherwise

[PATCH net] openvswitch: correct encoding of set tunnel action attributes

2015-12-18 Thread Simon Horman
In a set action tunnel attributes should be encoded in a nested action. I noticed this because ovs-dpctl was reporting an error when dumping flows due to the incorrect encoding of tunnel attributes in a set action. Fixes: fc4099f17240 ("openvswitch: Fix egress tunnel info.") Signed-off-by: Simon

Re: [iproute PATCH] ip{,6}tunnel: have a shared stats parser/printer

2015-12-18 Thread Phil Sutter
On Thu, Dec 17, 2015 at 05:14:21PM -0800, Stephen Hemminger wrote: > I just fixed the sscanf formats and after that this patch caused build error. > tunnel.c: In function ‘tnl_print_stats’: > tunnel.c:211:13: error: ‘ptr’ undeclared (first use in this function) > if (sscanf(ptr,

[iproute PATCH v2] ip{,6}tunnel: have a shared stats parser/printer

2015-12-18 Thread Phil Sutter
This has a slight side-effect of not aborting when /proc/net/dev is malformed, but OTOH stats are not parsed for uninteresting interfaces. Signed-off-by: Phil Sutter --- Changes since v1: - Fix conflict resolution (sscan from 'buf' instead of 'ptr'). --- ip/ip6tunnel.c | 21

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-18 Thread Andrew Lunn
On Fri, Dec 18, 2015 at 05:30:54PM +0800, shh@gmail.com wrote: > +static int fsl_backplane_probe(struct phy_device *phydev) > +{ > + struct fsl_xgkr_inst *xgkr_inst; > + struct device_node *child, *parent, *lane_node; > + const char *lane_name; > + int len; > + int ret; > +

Re: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-18 Thread kbuild test robot
Hi Shaohui, [auto build test ERROR on net/master] [also build test ERROR on v4.4-rc5 next-20151217] url: https://github.com/0day-ci/linux/commits/shh-xie-gmail-com/net-phy-adds-backplane-driver-for-Freescale-s-PCS-PHY/20151218-181424 config: um-allmodconfig (attached as .config) reproduce

Re: [PATCH iproute2] iplink: support 'stable-privacy' IPv6 addrgenmode

2015-12-18 Thread Bjørn Mork
Stephen Hemminger writes: > On Wed, 16 Dec 2015 16:15:14 +0100 > Bjørn Mork wrote: > >> Signed-off-by: Bjørn Mork > > Does not apply to current code base. Probably because of Hannes recent > changes. Yes, I saw that you applied Hannes'

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Eric Dumazet
On Fri, 2015-12-18 at 17:38 +0900, Lorenzo Colitti wrote: > On Fri, Dec 18, 2015 at 9:14 AM, Eric Dumazet wrote: > > Adding support for SYN_RECV request sockets to tcp_abort() > > is quite easy after our tcp listener rewrite. > > I added test coverage for this to our

Re: Instantaneous Threshold ECN marking for DCTCP

2015-12-18 Thread Florian Westphal
Bryce Cronkite-Ratcliff wrote: > Is there a way to achieve this simple threshold-ECN marking AQM with > tc, or another approach? Use codel or fq-codel with 'ce_threshold' added by Eric Dumazet, see

Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Eric Dumazet
On Fri, 2015-12-18 at 14:24 +0800, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 01:34:16PM +0800, Herbert Xu wrote: > > On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > > > FYI, we noticed the below changes on > > > > > > https://github.com/0day-ci/linux > > >

Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: > > You can avoid the comment by using the self documented and lockdep > enabled primitive > > iter->walker->tbl = rcu_dereference_protected(ht->tbl, > lockdep_is_held(>lock)); That is just

Review & Reply

2015-12-18 Thread J.Tynan
Greetings, My name is Mr.Michael J. Tynan, I am a banker with Bank Of America. It is true that we have not meet each other in person, but I strongly believe in trust and friendship in every business. I have a Lebanese deceased customer's abandoned fund, which I am his personal financial adviser

Re: [PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

2015-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2015 7:36 AM, zyjzyj2...@gmail.com wrote: From: yzhu1 In 802.3ad mode, the speed and duplex is needed. But in some NICs, there is a time span between NIC up state and getting speed and duplex. As such, sometimes a slave in 802.3ad mode is in up state

[PATCH] netcp: fix regression in receive processing

2015-12-18 Thread Arnd Bergmann
A cleanup patch I did was unfortunately wrong and introduced multiple serious bugs in the netcp rx processing, as indicated by these correct gcc warnings: drivers/net/ethernet/ti/netcp_core.c:776:14: warning: 'buf_ptr' may be used uninitialized in this function [-Wuninitialized]

[PATCH v2 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-18 Thread Daniele Palmas
This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization. V2: Added comment for highlighting FLAG_NOARP usage for those devices Daniele Palmas (2): net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile

[PATCH v2 1/2] net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card

2015-12-18 Thread Daniele Palmas
Unlike DW5550, Dell DW5812 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2 2/2] net: usb: cdc_ncm: Adding Dell DW5813 LTE AT Mobile Broadband Card

2015-12-18 Thread Daniele Palmas
Unlike DW5550, Dell DW5813 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent

2015-12-18 Thread Jesper Dangaard Brouer
On Fri, 18 Dec 2015 16:16:39 +0300 Dmitrii Shcherbakov wrote: > b3 buffer has been deleted previously so b2 is followed by b4 which is not > consistent > > Signed-off-by: Dmitrii Shcherbakov > --- Acked-by: Jesper Dangaard Brouer

[PATCH 11/14] openvswitch: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- net/openvswitch/flow_table.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c

[PATCH 13/14] sunrpc: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- net/sunrpc/svc_xprt.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index

[PATCH 03/14] ipv4, ipv6: use list_for_each_entry*

2015-12-18 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- net/ipv4/af_inet.c| 6 ++ net/ipv4/tcp_output.c | 6 ++ net/ipv6/addrconf.c | 8 +++- net/ipv6/af_inet6.c | 7 ++- 4 files changed, 9

[PATCH 01/14] Bluetooth: use list_for_each_entry*

2015-12-18 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- net/bluetooth/af_bluetooth.c | 12 ++-- net/bluetooth/cmtp/capi.c| 8 ++-- net/bluetooth/hci_core.c | 8 +++- net/bluetooth/rfcomm/core.c

[PATCH 14/14] net: pktgen: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- net/core/pktgen.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index

[PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Arnd Bergmann
The recently added generic ILA translation facility fails to build when CONFIG_NETFILTER is disabled: net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared inside parameter list net/ipv6/ila/ila_xlat.c:235:27: error: array type has incomplete element type 'struct nf_hook_ops'

[PATCH 04/14] x25: use list_for_each_entry*

2015-12-18 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- net/x25/x25_forward.c | 20 ++-- net/x25/x25_link.c| 23 ++- net/x25/x25_route.c | 29 +++-- 3

[PATCH 08/14] caif: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- net/caif/chnl_net.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index

[PATCH 10/14] lapb: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- net/lapb/lapb_iface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c index fc60d9d..49abba7

splice-bind deadlock (was: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code)

2015-12-18 Thread Rainer Weikusat
Rainer Weikusat writes: > Hannes Frederic Sowa writes: > > [...] > >> There is still a deadlock lingering around > > [...] > >> http://lists.openwall.net/netdev/2015/11/10/4 [...] > (a while ago) A: socketpair() >

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-18 Thread Vlad Yasevich
On 12/17/2015 02:33 PM, Vlad Yasevich wrote: > On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: >> Em 17-12-2015 16:29, Vlad Yasevich escreveu: >>> On 12/17/2015 09:30 AM, Xin Long wrote: In sctp_close, sctp_make_abort_user may return NULL because of memory allocation failure. If

[PATCH 12/14] net: sched: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- net/sched/sch_htb.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 15ccd7f..5f7aa74 100644

[PATCH 09/14] net: dsa: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- net/dsa/dsa.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 208d1b2..2ab4a19 100644 ---

[PATCH 07/14] batman-adv: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- net/batman-adv/icmp_socket.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/net/batman-adv/icmp_socket.c

Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field

2015-12-18 Thread Phil Sutter
On Fri, Dec 18, 2015 at 04:16:38PM +0300, Dmitrii Shcherbakov wrote: > Remove printing according to the previously used encoding of mpu and overhead > values within the tc_ratespec's mpu field. This encoding is no longer being > used as a separate 'overhead' field in the ratespec structure has

Re: [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent

2015-12-18 Thread Phil Sutter
On Fri, Dec 18, 2015 at 04:16:39PM +0300, Dmitrii Shcherbakov wrote: > b3 buffer has been deleted previously so b2 is followed by b4 which is not > consistent > > Signed-off-by: Dmitrii Shcherbakov Acked-by: Phil Sutter -- To unsubscribe from this list:

Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field

2015-12-18 Thread Jesper Dangaard Brouer
On Fri, 18 Dec 2015 16:16:38 +0300 Dmitrii Shcherbakov wrote: > Remove printing according to the previously used encoding of mpu and overhead > values within the tc_ratespec's mpu field. This encoding is no longer being > used as a separate 'overhead' field in the

Re: [PATCH 03/14] ipv4, ipv6: use list_for_each_entry*

2015-12-18 Thread Julia Lawall
.net> > CC: Geliang Tang <geliangt...@163.com>, netdev@vger.kernel.org, > linux-ker...@vger.kernel.org > > Hi Geliang, > > [auto build test WARNING on net/master] > [also build test WARNING on v4.4-rc5 next-20151218] > > url: > https://github.com/0day-ci/linu

[PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the checksums, or CHECKSUM_NONE if the packet is bad or it was unable to verify it. The current version of veth will replace CHECKSUM_NONE with CHECKSUM_UNNECESSARY, which causes corrupt

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-18 Thread Marcelo Ricardo Leitner
On Fri, Dec 18, 2015 at 09:08:46AM -0500, Vlad Yasevich wrote: > On 12/17/2015 02:33 PM, Vlad Yasevich wrote: > > On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: ... > >> There is a check on sctp_cmd_delete_tcb() that avoids calling that on temp > >> assocs on > >> listening sockets, but

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-18 Thread Phil Sutter
On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > > Dmitrii, did iproute2 without your change even print the overhead as set > > by you before? Looking at the code, I'd assume not. > > Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel > (also tag

[PATCH net-next 5/5] sfc: Downgrade or remove some error messages

2015-12-18 Thread Bert Kenward
Depending on configuration the NIC may return errors for unprivileged functions and/or VFs. Where these are expected and handled, reduce the level of any output. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 20 ++--

[PATCH net-next 4/5] sfc: Downgrade EPERM messages from MCDI to debug

2015-12-18 Thread Bert Kenward
From: Tomáš Pilař When running in an unprivileged function we expect some MC commands to fail with permission errors. To avoid log spew downgrade these to debug only. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 7 --- 1

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote: > > The recently added generic ILA translation facility fails to > > build when CONFIG_NETFILTER is disabled: > > > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state'

[PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation

2015-12-18 Thread Bert Kenward
For unprivileged functions operations can be authorised by an admin function. Extra steps are introduced to the MCDI protocol in this situation - the initial response from the MCDI tells us that the operation has been deferred, and we must retry when told. We then receive an event telling us to

[PATCH net-next 1/5] sfc: Retry MCDI after NO_EVB_PORT error on a VF

2015-12-18 Thread Bert Kenward
After reboot the vswitch configuration from the PF may not be complete before the VF attempts to restore filters. In that case we see NO_EVB_PORT errors from the MC. Retry up to a time limit or until a different result is seen. Signed-off-by: Bert Kenward ---

[PATCH net-next 3/5] sfc: Make failed filter removal less noisy

2015-12-18 Thread Bert Kenward
There are situations - mostly reset related - where our view of the filter table differs from the hardware. In this case we may try and remove filters that aren't actually installed. This isn't that interesting in most situations, so downgrade the logging. Signed-off-by: Bert Kenward

Fw: [Bug 109581] New: WARNING: CPU: 1 PID: 0 at net/sched/sch_hfsc.c:1429 hfsc_dequeue+0x166/0x2da()

2015-12-18 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 18 Dec 2015 17:12:15 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 109581] New: WARNING: CPU: 1 PID: 0 at

Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field

2015-12-18 Thread Dmitrii Shcherbakov
Jesper, > Thank you Dmitrii for cleaning this up :-) You are welcome :^) I should read more carefully: its what you asked from the beginning. Thank you, Dmitrii Shcherbakov -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH net-next 0/5] sfc: additional virtual function support​

2015-12-18 Thread Bert Kenward
This introduces the client side of a mechanism to defer authorisation of operations, for example multicast subscription. Although primarily aimed at SRIOV VFs this can also apply to unprivileged PFs. Also handle reboot ordering corner cases better and reduce the level of some logging. Bert

commit e34d65696d2e broke stmmac ethernet on socfpga

2015-12-18 Thread Dinh Nguyen
Hi, It appears that commit e34d65696d2e 'stmmac: create of compatible mdio bus for stmmac driver' is causing this error on the SoCFPGA platform: [1.767246] libphy: PHY stmmac-0: not found [1.772106] eth0: Could not attach to PHY [1.776129] stmmac_open: Cannot attach to PHY

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Pablo Neira Ayuso
On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote: > The recently added generic ILA translation facility fails to > build when CONFIG_NETFILTER is disabled: > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared > inside parameter list >

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-18 Thread Josh Snyder
I was also puzzled that binding succeeded. Looking into the code paths involved, in inet_csk_get_port, we quickly goto have_snum. From there, we end up dropping into tb_found. Since !hlist_empty(>owners), we end up checking that (tb->fastreuseport > 0 && sk->sk_reuseport && uid_eq(tb->fastuid,

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-18 Thread Dmitrii Shcherbakov
Phil, > Dmitrii, did iproute2 without your change even print the overhead as set > by you before? Looking at the code, I'd assume not. Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel (also tag 4.2 - 64291f7db5bd8150a74ad2036f1037e6a0428df2): ~/src/iproute2/tc$ uname

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Cong Wang
(Cc'ing Eric B and Tom) On Fri, Dec 18, 2015 at 9:54 AM, Vijay Pandurangan wrote: > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-18 Thread Tom Herbert
On Fri, Dec 18, 2015 at 2:41 AM, Edward Cree wrote: > On 17/12/15 18:06, Tom Herbert wrote: >> I'm not sure that we need bits in VXLAN or any other encapsulation. It >> should be sufficient in udp_set_csum that if we already have >> CHECKSUM_PARTIAL that can always be used

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-18 Thread David Miller
From: Bjørn Mork Date: Wed, 16 Dec 2015 16:44:38 +0100 > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new

[PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Damien Riegel
Technologic Systems provides an IP compatible with the SJA1000, instantiated in an FPGA. Because of some bus widths issue, access to registers is made through a "window" that works like this: base + 0x0: address to read/write base + 0x2: 8-bit register value This commit adds a new

Re: [PATCH net-next] nfp: call netif_carrier_off() during init

2015-12-18 Thread David Miller
From: Jakub Kicinski Date: Thu, 17 Dec 2015 14:18:44 + > Netdevs default to carrier on, we should call netif_carrier_off() > during initialization since we handle carrier state changes in the > driver. > > Signed-off-by: Jakub Kicinski

[PATCH 05/23] netfilter-bridge: brace placement

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Change brace placement to eliminate checkpatch error. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_log.c | 6 ++

Re: [PATCH 00/23] Netfilter updates for net-next

2015-12-18 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 18 Dec 2015 21:26:26 +0100 > The following patchset contains the first batch of Netfilter updates for > the upcoming 4.5 kernel. This batch contains userspace netfilter header > compilation fixes, support for packet mangling in nf_tables,

[PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the checksums, or CHECKSUM_NONE if the packet is bad or it was unable to verify it. The current version of veth will replace CHECKSUM_NONE with CHECKSUM_UNNECESSARY, which causes corrupt

Re: [iproute PATCH v2] ip{,6}tunnel: have a shared stats parser/printer

2015-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2015 11:58:06 +0100 Phil Sutter wrote: > This has a slight side-effect of not aborting when /proc/net/dev is > malformed, but OTOH stats are not parsed for uninteresting interfaces. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Fix

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: > Add support for fixed-link PHY") added initial fixed-link PHY support > for CPSW, but missed a few considerations. > > This

[PATCH 12/23] netfilter: nf_tables: remove unused struct members

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/netfilter/nf_tables.h

[PATCH 10/23] netfilter: ipv6: avoid nf_iterate recursion

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal The previous patch changed nf_ct_frag6_gather() to morph reassembled skb with the previous one. This means that the return value is always NULL or the skb argument. So change it to an err value. Instead of invoking NF_HOOK recursively with threshold to

[PATCH 00/23] Netfilter updates for net-next

2015-12-18 Thread Pablo Neira Ayuso
Hi David, The following patchset contains the first batch of Netfilter updates for the upcoming 4.5 kernel. This batch contains userspace netfilter header compilation fixes, support for packet mangling in nf_tables, the new tracing infrastructure for nf_tables and cgroup2 support for iptables.

[PATCH 01/23] netfilter: ebtables: use __u64 from linux/types.h

2015-12-18 Thread Pablo Neira Ayuso
From: Mikko Rapeli Fixes userspace compilation error: linux/netfilter_bridge/ebtables.h:38:2: error: unknown type name ‘uint64_t’ Signed-off-by: Mikko Rapeli Signed-off-by: Pablo Neira Ayuso ---

pull-request: mac80211-next 2015-12-18

2015-12-18 Thread Johannes Berg
Hi Dave, Before we all go on vacation/holidays, I have a few bugfixes for net-next. The remain-on-channel ones are quite necessary since Ilan's patch broke things quite a bit, causing crashes. If the issue with the strange mail formatting persists let me know and I'll send these through some

Re: [PATCH net-next v4 4/4] ila: Add generic ILA translation facility

2015-12-18 Thread David Miller
From: Florian Westphal Date: Fri, 11 Dec 2015 12:19:04 +0100 > So if we do ILA in init ns it & pass such skbs to other netns > it would be preferable to use nf_register_net_hooks in a namespace > once the first ila translation is added within that namespace. Right, the idea is

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Dec 2015 15:37:37 +0100 > The recently added generic ILA translation facility fails to > build when CONFIG_NETFILTER is disabled: > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared > inside parameter list >

Re: [PATCH iproute2 v3 0/3] improve lwtunnel route support

2015-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2015 10:50:35 +0100 Paolo Abeni wrote: > This patch series try to improve the current route based > lwtunnel support in iproute2, namely adding support for the > COLLECT_METADATA flag in vxlan and gre link, and for ip6 > encap type in lwtunnel. > > Tunnel

Re: [PATCH net-next v3 0/2] net: Allow accepted sockets to be bound to l3mdev domain

2015-12-18 Thread David Miller
From: David Ahern Date: Wed, 16 Dec 2015 13:20:42 -0800 > Allow accepted sockets to derive their sk_bound_dev_if setting from the > l3mdev domain in which the packets originated. This version adds a sysctl > to control whether the setting is inherited, making the

[PATCH 1/2] can: sja1000: add documentation for Technologic Systems version

2015-12-18 Thread Damien Riegel
This commit adds documentation for the Technologic Systems version of SJA1000. The difference with the NXP version is in the way the registers are accessed. Signed-off-by: Damien Riegel --- Documentation/devicetree/bindings/net/can/sja1000.txt | 3 ++- 1 file

Re: [PATCH net 0/2] Mellanox mlx4 driver fixes

2015-12-18 Thread David Miller
From: Or Gerlitz Date: Thu, 17 Dec 2015 15:35:36 +0200 > Two small fixes from Jenny for code flows that deal with time-stamping. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH 19/23] netfilter: cttimeout: add netns support

2015-12-18 Thread Pablo Neira Ayuso
From: Pablo Neira Add a per-netns list of timeout objects and adjust code to use it. Signed-off-by: Pablo Neira Ayuso --- include/net/net_namespace.h | 3 + include/net/netfilter/nf_conntrack_timeout.h | 2 +-

[PATCH 21/23] netfilter: implement xt_cgroup cgroup2 path match

2015-12-18 Thread Pablo Neira Ayuso
From: Tejun Heo This patch implements xt_cgroup path match which matches cgroup2 membership of the associated socket. The match is recursive and invertible. For rationales on introducing another cgroup based match, please refer to a preceding commit "sock, cgroup: add

[PATCH 11/23] netfilter: Set /proc/net entries owner to root in namespace

2015-12-18 Thread Pablo Neira Ayuso
From: Philip Whineray Various files are owned by root with 0440 permission. Reading them is impossible in an unprivileged user namespace, interfering with firewall tools. For instance, iptables-save relies on /proc/net/ip_tables_names contents to dump only loaded tables. This

[PATCH 23/23] netfilter: meta: add support for setting skb->pkttype

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal This allows to redirect bridged packets to local machine: ether type ip ether daddr set aa:53:08:12:34:56 meta pkttype set unicast Without 'set unicast', ip stack discards PACKET_OTHERHOST skbs. It is also useful to add support for a '-m cluster like' nft

[PATCH 14/23] netfilter: nf_tables: extend tracing infrastructure

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal nft monitor mode can then decode and display this trace data. Parts of LL/Network/Transport headers are provided as separate attributes. Otherwise, printing IP address data becomes virtually impossible for userspace since in the case of the netdev family

[PATCH 17/23] netfilter: nfnetlink_log: Change setter functions to be void

2015-12-18 Thread Pablo Neira Ayuso
From: "Rosen, Rami" Change return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void. This patch changes the return type of the static methods nfulnl_set_timeout() and nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods

[PATCH 16/23] netfilter: ipv6: nf_defrag: fix NULL deref panic

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Valdis reports NULL deref in nf_ct_frag6_gather. Problem is bogus use of skb_queue_walk() -- we miss first skb in the list since we start with head->next instead of head. In case the element we're looking for was head->next we won't find a result and then

[PATCH 08/23] netfilter: remove duplicate include

2015-12-18 Thread Pablo Neira Ayuso
From: stephen hemminger Signed-off-by: Stephen Hemminger Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_reject_ipv4.c | 1 - net/ipv6/netfilter/nf_reject_ipv6.c | 1 - 2 files changed, 2 deletions(-) diff

[PATCH 15/23] netfilter: nf_tables: wrap tracing with a static key

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Only needed when meta nftrace rule(s) were added. The assumption is that no such rules are active, so the call to nft_trace_init is "never" needed. When nftrace rules are active, we always call the nft_trace_* functions, but will only send netlink messages

[PATCH 18/23] netfilter: nf_tables: fix nf_log_trace based tracing

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal nf_log_trace() outputs bogus 'TRACE:' strings because I forgot to update the comments array. Fixes: 33d5a7b14bfd0 ("netfilter: nf_tables: extend tracing infrastructure") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso

[PATCH 02/23] netfilter: fix include files for compilation

2015-12-18 Thread Pablo Neira Ayuso
From: Mikko Rapeli Add missing header dependencies and other small changes so that each file compiles alone in userspace. Signed-off-by: Mikko Rapeli Signed-off-by: Pablo Neira Ayuso ---

[PATCH 22/23] nfnetlink: add nfnl_dereference_protected helper

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal to avoid overly long line in followup patch. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH 20/23] netfilter: prepare xt_cgroup for multi revisions

2015-12-18 Thread Pablo Neira Ayuso
From: Tejun Heo xt_cgroup will grow cgroup2 path based match. Postfix existing symbols with _v0 and prepare for multi revision registration. Signed-off-by: Tejun Heo Cc: Daniel Borkmann Cc: Daniel Wagner CC:

[PATCH 13/23] netfilter: nft_payload: add packet mangling support

2015-12-18 Thread Pablo Neira Ayuso
From: Patrick McHardy Add support for mangling packet payload. Checksum for the specified base header is updated automatically if requested, however no updates for any kind of pseudo headers are supported, meaning no stateless NAT is supported. For checksum updates different

[PATCH 06/23] netfilter-bridge: layout of if statements

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Eliminate some checkpatch issues by improved layout of if statements. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_ip6.c | 4 ++--

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Marc Kleine-Budde
On 12/18/2015 09:17 PM, Damien Riegel wrote: > Technologic Systems provides an IP compatible with the SJA1000, > instantiated in an FPGA. Because of some bus widths issue, access to > registers is made through a "window" that works like this: > > base + 0x0: address to read/write > base +

  1   2   >