RE: [RFC 3/5] net/ethtool: support set coalesce per queue

2015-12-21 Thread Liang, Kan
> On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: > [...] > > --- a/net/core/ethtool.c > > +++ b/net/core/ethtool.c > > @@ -1778,6 +1778,37 @@ static int > ethtool_get_per_queue_coalesce(struct net_device *dev, > >   return 0; > >  } > > > > +static int

[REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Oleksandr Natalenko
Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c tcp_cwnd_reduction() that, possibly, cause division by zero, and therefore, kernel panic in interrupt handler [1]. Reverting

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-21 Thread Richard Cochran
On Mon, Dec 21, 2015 at 04:35:23PM +0200, Saeed Mahameed wrote: > think of a case where: > CPU1: is just about to call > "schedule_delayed_work(>overflow_work, > tstamp->overflow_period);" > CPU2: cancel_delayed_work > > In this case cancel_dalyed_work_sync (CPU2) will wait for CPU1 to > complete

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Souptick Joarder
Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw,

Re: [iproute PATCH v2] ip{,6}tunnel: have a shared stats parser/printer

2015-12-21 Thread Phil Sutter
On Mon, Dec 21, 2015 at 12:00:06PM +0100, Daniel Borkmann wrote: > On 12/18/2015 11:58 AM, Phil Sutter wrote: > > This has a slight side-effect of not aborting when /proc/net/dev is > > malformed, but OTOH stats are not parsed for uninteresting interfaces. > > > > Signed-off-by: Phil Sutter

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-21 Thread Willy Tarreau
On Mon, Dec 21, 2015 at 12:38:27PM -0800, Tom Herbert wrote: > On Fri, Dec 18, 2015 at 11:00 PM, Willy Tarreau wrote: > > On Fri, Dec 18, 2015 at 06:38:03PM -0800, Eric Dumazet wrote: > >> On Fri, 2015-12-18 at 19:58 +0100, Willy Tarreau wrote: > >> > Hi Josh, > >> > > >> > On Fri,

RE: [Intel-wired-lan] [PATCH] ixgbevf: Fix handling of napi budget when multiple queues are enabled per vector

2015-12-21 Thread Schmitt, Phillip J
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of William Dauchy > Sent: Friday, October 30, 2015 10:16 AM > To: da...@davemloft.net > Cc: William Dauchy; netdev@vger.kernel.org; adu...@mirantis.com; intel- >

[iproute PATCH] iptunnel: Fix compile error in ip/tunnel.c

2015-12-21 Thread Phil Sutter
I repeatedly failed to get this right, so now I have to clean up my mess afterwards. Fixes: 7d6aadcd0a1dc ("ip{,6}tunnel: have a shared stats parser/printer") Signed-off-by: Phil Sutter --- ip/tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/tunnel.c

Re: Commit-8b63ec18 breaks setting PHY pad-skew settings

2015-12-21 Thread Florian Fainelli
On 21/12/15 02:40, Roosen Henri wrote: > Hi David, > > Unfortunately Linux kernel commit-8b63ec1837fa4c1ea604b278d201454eb3b85066 > breaks setting pad-skew settings for Micrel PHY's. > > Please see Documentation/devicetree/bindings/net/micrel-ksz90x1.txt: at the > examples, it proposes to do

RE: [RFC 2/5] net/ethtool: support get coalesce per queue

2015-12-21 Thread Liang, Kan
> On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Device driver has to provide an interface to get per queue coalesce. > > The interrupt coalescing parameters of each masked queue will be > > copied back to user space one by one. >

RE: Does the Community use Coverity ?

2015-12-21 Thread Jeff Haran
> -Original Message- > From: pavi1729 [mailto:pavitra1...@gmail.com] > Sent: Thursday, December 17, 2015 2:04 AM > To: Jeff Haran > Cc: kernelnewb...@kernelnewbies.org; linux-fsde...@vger.kernel.org; > linux-...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: Does the Community use

Re: [PATCH -next] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-21 Thread Florian Westphal
Eric Dumazet wrote: > > - net = sk ? sock_net(sk) : dev_net(skb_dst(skb)->dev); > > + have_full_sk = sk && sk_fullsock(sk); > > + net = have_full_sk ? sock_net(sk) : dev_net(skb_dst(skb)->dev); > > But the net pointer can be derived from timewait the same, not sure

[Patch net] addrconf: always initialize sysctl table data

2015-12-21 Thread Cong Wang
When sysctl performs restrict writes, it allows to write from a middle position of a sysctl file, which requires us to initialize the table data before calling proc_dostring() for the write case. Fixes: 3d1bec99320d ("ipv6: introduce secret_stable to ipv6_devconf") Reported-by: Sasha Levin

RE: [RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

2015-12-21 Thread Liang, Kan
> > +#define MAX_QUEUE 4096 > > +#define MAX_QUEUE_MASK (MAX_QUEUE / 64) > > + > > +/** > > + * struct ethtool_per_queue_op - apply sub command to the queues in > mask. > > + * @cmd: ETHTOOL_PERQUEUE > > + * @queue_mask: Mask the queues which sub command apply to > > + *

[PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-21 Thread Florian Westphal
tcp_md5_do_lookup requires a full socket, so once we extend _send_reset() to also accept timewait socket we would have to change if (!sk && hash_location) to something like if ((!sk || !sk_fullsock(sk)) && hash_location) { ... } else { (sk && sk_fullsock(sk)) tcp_md5_do_lookup() } Switch

[PATCH v2 -next 3/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-21 Thread Florian Westphal
Hannes points out that when we generate tcp reset for timewait sockets we pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). Make it cope with inet tw sockets and then provide tw sk. This makes RSTs appear on correct interface when SO_BINDTODEVICE is used. Packetdrill test

[PATCH v2 -next 0/3] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-21 Thread Florian Westphal
This is V2, this time as a small series since I followed Erics advice to split this into smaller chunks, I hope this makes it easier to review. First patch adds inet_sk_transparent helper. Second patch contains an if/else swap that I split from the original TW_RST v1 one. Third patch is the

[PATCH -next 1/3] net: add inet_sk_transparent() helper

2015-12-21 Thread Florian Westphal
Avoids cluttering tcp_v4_send_reset when followup patch extends it to deal with timewait sockets. Suggested-by: Eric Dumazet Signed-off-by: Florian Westphal --- include/net/request_sock.h | 2 +- include/net/tcp.h | 12 2 files

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-21 Thread Cong Wang
On Mon, Dec 21, 2015 at 1:54 AM, Andrey Ryabinin wrote: > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. > >

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-21 Thread Tom Herbert
On Fri, Dec 18, 2015 at 11:00 PM, Willy Tarreau wrote: > On Fri, Dec 18, 2015 at 06:38:03PM -0800, Eric Dumazet wrote: >> On Fri, 2015-12-18 at 19:58 +0100, Willy Tarreau wrote: >> > Hi Josh, >> > >> > On Fri, Dec 18, 2015 at 08:33:45AM -0800, Josh Snyder wrote: >> > > I was also

[PATCH net-next] ip_tunnel: Move stats update to iptunnel_xmit()

2015-12-21 Thread Pravin B Shelar
By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Julian Calaby
occinelle script (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > Patch is against linux-next (localversion-next is -next-20151221) > > drivers/net/wireles

[PATCH V1 15/16] i40iw: add entry in rdma_netlink

2015-12-21 Thread Faisal Latif
Add entry for port mapper services. Signed-off-by: Faisal Latif --- include/uapi/rdma/rdma_netlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h index c19a5dc..4fa418d 100644 ---

[PATCH V1 16/16] i40iw: changes for build of i40iw module

2015-12-21 Thread Faisal Latif
MAINTAINERS, Kconfig, and Makefile to build i40iw module Signed-off-by: Faisal Latif --- MAINTAINERS| 10 ++ drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + 3 files changed, 12 insertions(+) diff --git

[PATCH V1 01/16] i40e: Add support for client interface for IWARP driver

2015-12-21 Thread Faisal Latif
From: Anjali Singhai Jain This patch adds a Client interface for i40iw driver support. Also expands the Virtchannel to support messages from i40evf driver on behalf of i40iwvf driver. This client API is used by the i40iw and i40iwvf driver to access the core driver

[PATCH V1 00/16] add Intel(R) X722 iWARP driver

2015-12-21 Thread Faisal Latif
This (V1) series contains the addition of the i40iw.ko driver after incorporating the feedback from Christoph Hellwig and Joe Perches for initial series. This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet controller for PCI Physical Functions. It also has support for

[PATCH V1 02/16] i40iw: add main, hdr, status

2015-12-21 Thread Faisal Latif
i40iw_main.c contains routines for i40e <=> i40iw interface and setup. i40iw.h is header file for main device data structures. i40iw_status.h is for return status codes. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by:

[PATCH V1 08/16] i40iw: add files for iwarp interface

2015-12-21 Thread Faisal Latif
i40iw_verbs.[ch] are to handle iwarp interface. Added feedback provided by Christoph Hellwig Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH V1 05/16] i40iw: add pble resource files

2015-12-21 Thread Faisal Latif
i40iw_pble.[ch] to manage pble resource for iwarp clients. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_pble.c | 618

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Brent Taylor
On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder wrote: > Hi Brent, > > On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >> Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to >> be pointing to memory allocated by vmalloc.

Re: [PATCH] Octeon: Fix logic for waking octoen ethernet tx queue.

2015-12-21 Thread Luuk Paulussen
I see that this patch has been marked as "Not applicable" in patchworx. Is this because I have sent it to the wrong place? I also noticed that I forgot to add a signoff line or CC a maintainer, so I'm happy to resend if those are the issues. The patch is a bugfix for an ethernet driver in the

Re: 4.4-rc5 crash (af_unix)

2015-12-21 Thread Cong Wang
(Cc'ing netdev and Rainer) On Thu, Dec 17, 2015 at 9:12 PM, Mika Penttilä wrote: > Still something with af_unix and/or wake code on rc5 : > > > [34971.300210] Unable to handle kernel paging request at virtual address > 56ac56ac > > [34971.307455] pgd = a8c3 > >

[PATCH v2] net-next: Add tcindex to conntrack and add netfilter target/matches

2015-12-21 Thread Luuk Paulussen
This patch implements support for setting/matching the skb->tc_index field from Xtables, as well as allowing it to be saved/restored using connection tracking. This provides 16 extra bits of mark space that can be saved/restored from the connection (for performance benefits) when the marking is

Re: [PATCH 3/8] cgroup: implement cgroup_get_from_path() and expose cgroup_put()

2015-12-21 Thread Serge E. Hallyn
On Mon, Dec 07, 2015 at 05:38:50PM -0500, Tejun Heo wrote: > Implement cgroup_get_from_path() using kernfs_walk_and_get() which > obtains a default hierarchy cgroup from its path. This will be used > to allow cgroup path based matching from outside cgroup proper - > e.g. networking and perf. Hi

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Dan Kephart
Hi Brent and Souptick, On 12/21/15, 2:23 PM, "ath6kl on behalf of Souptick Joarder" wrote: >Hi Brent, > >On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >> Since commit

[PATCH V1 13/16] i40iw: virtual channel handling files

2015-12-21 Thread Faisal Latif
i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual channel support for iWARP VF module. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH V1 03/16] i40iw: add connection management code

2015-12-21 Thread Faisal Latif
i40iw_cm.c i40iw_cm.h are used for connection management. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_cm.c |

[PATCH V1 06/16] i40iw: add hmc resource files

2015-12-21 Thread Faisal Latif
i40iw_hmc.[ch] are to manage hmc for the device. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_hmc.c | 821

[PATCH V1 04/16] i40iw: add puda code

2015-12-21 Thread Faisal Latif
i40iw_puda.[ch] are files to handle iwarp connection packets as well as exception packets over multiple privilege mode uda queues. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH V1 07/16] i40iw: add hw and utils files

2015-12-21 Thread Faisal Latif
i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle interrupts and processing. Added feeback from Cristoph Hellwig. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH V1 12/16] i40iw: user kernel shared files

2015-12-21 Thread Faisal Latif
i40iw_user.h and i40iw_uk.c are used by both user library as well as kernel requests. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_uk.c |

[PATCH V1 09/16] i40iw: add file to handle cqp calls

2015-12-21 Thread Faisal Latif
i40iw_ctrl.c provides for hardware wqe supporti and cqp. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 4740

[PATCH V1 10/16] i40iw: add hardware related header files

2015-12-21 Thread Faisal Latif
header files for hardware accesses Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++ drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++ drivers/infiniband/hw/i40iw/i40iw_type.h | 1307 +++

[PATCH V1 14/16] i40iw: Kconfig and Kbuild for iwarp module

2015-12-21 Thread Faisal Latif
Kconfig and Kbuild needed to build iwarp module. Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/Kbuild | 43 + drivers/infiniband/hw/i40iw/Kconfig | 7 ++ 2 files changed, 50 insertions(+) create mode 100644

[PATCH V1 11/16] i40iw: add X722 register file

2015-12-21 Thread Faisal Latif
X722 Hardware registers defines for iWARP component. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_register.h | 1027

Re: [PATCH V1 16/16] i40iw: changes for build of i40iw module

2015-12-21 Thread kbuild test robot
Hi Faisal, [auto build test ERROR on net/master] [also build test ERROR on v4.4-rc6 next-20151221] [cannot apply to net-next/master] url: https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151222-071852 config: x86_64-allmodconfig (attached as .config

Re: [PATCH net-next V2 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

2015-12-21 Thread Richard Cochran
On Sun, Dec 20, 2015 at 11:46:31PM +0200, Saeed Mahameed wrote: > From: Eran Ben Elisha > > Add a PHC support to the mlx5_en driver. Use reader/writer spinlocks to > protect the timecounter since every packet received needs to call > timecounter_cycle2time() when

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-21 Thread Richard Cochran
On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote: > +/* Should run once every mlx5e_tstamp->overflow_period */ > +static void mlx5e_timestamp_overflow(struct work_struct *work) > +{ > + struct delayed_work *dwork = to_delayed_work(work); > + struct mlx5e_tstamp *tstamp =

TUN works when SRC != own IP

2015-12-21 Thread Karl Krach
Hello, I have to forward IP-packets from an FPGA via network. For this I use packet_mmap / PACKET_TX_RING for destinations within the ARP cache and the TUN interface for all others (incl. packets to my own device). When I send these foreign packets (ip4h->saddr != device address) via TUN

Re: [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-21 Thread Saeed Mahameed
On Mon, Dec 21, 2015 at 11:15 AM, Richard Cochran wrote: > On Sun, Dec 20, 2015 at 11:46:30PM +0200, Saeed Mahameed wrote: >> +/* Should run once every mlx5e_tstamp->overflow_period */ >> +static void mlx5e_timestamp_overflow(struct work_struct *work) >> +{ >> +

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-21 Thread Marcelo Ricardo Leitner
Em 21-12-2015 07:56, Xin Long escreveu: On Sat, Dec 19, 2015 at 12:23 AM, Marcelo Ricardo Leitner wrote: On Fri, Dec 18, 2015 at 09:08:46AM -0500, Vlad Yasevich wrote: On 12/17/2015 02:33 PM, Vlad Yasevich wrote: On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner

Re: [PATCH iproute2] ip/iproute: allow routes to be configured with expire values

2015-12-21 Thread Stephen Hemminger
OK, applied to net-next branch (not master). Also, please update man pages as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Yuchung Cheng
On Mon, Dec 21, 2015 at 12:25 PM, Oleksandr Natalenko wrote: > Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by > default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c > tcp_cwnd_reduction() that, possibly, cause division

Re: [iproute PATCH] iptunnel: Fix compile error in ip/tunnel.c

2015-12-21 Thread Stephen Hemminger
On Mon, 21 Dec 2015 20:42:56 +0100 Phil Sutter wrote: > I repeatedly failed to get this right, so now I have to clean up my mess > afterwards. > > Fixes: 7d6aadcd0a1dc ("ip{,6}tunnel: have a shared stats parser/printer") > Signed-off-by: Phil Sutter > --- >

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-21 Thread Stephen Hemminger
On Sat, 19 Dec 2015 00:45:40 +0300 Dmitrii Shcherbakov wrote: > Phil, > > 18.12.2015, 19:55, "Phil Sutter" : > > On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > >>  > Dmitrii, did iproute2 without your change even print the overhead as

Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2015-12-21 Thread Stephen Hemminger
On Thu, 17 Dec 2015 22:22:18 +0900 Lorenzo Colitti wrote: > diff --git a/misc/ss.c b/misc/ss.c > index 0dab32c..be70c41 100644 > --- a/misc/ss.c > +++ b/misc/ss.c > @@ -160,6 +160,9 @@ struct filter > int states; > int families; > struct ssfilter *f; > +

Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field

2015-12-21 Thread Stephen Hemminger
On Sat, 19 Dec 2015 18:25:52 +0300 Dmitrii Shcherbakov wrote: > Remove printing according to the previously used encoding of mpu and overhead > values within the tc_ratespec's mpu field. This encoding is no longer being > used as a separate 'overhead' field in the

[PATCH iproute2] ip/iproute: allow routes to be configured with expire values

2015-12-21 Thread Hangbin Liu
Signed-off-by: Hangbin Liu --- include/linux/rtnetlink.h | 1 + ip/iproute.c | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h index 3244947..ff2fe31 100644 ---

Re: [iproute PATCH v2] ip{,6}tunnel: have a shared stats parser/printer

2015-12-21 Thread Daniel Borkmann
On 12/18/2015 11:58 AM, Phil Sutter wrote: This has a slight side-effect of not aborting when /proc/net/dev is malformed, but OTOH stats are not parsed for uninteresting interfaces. Signed-off-by: Phil Sutter --- Changes since v1: - Fix conflict resolution (sscan from 'buf'

[patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies

2015-12-21 Thread Jiri Pirko
From: Ido Schimmel The bridge's ageing time is offloaded to hardware when: 1) A port joins a bridge 2) The ageing time of the bridge is changed In the first case the ageing time is offloaded as jiffies, but in the second case it's offloaded as clock_t, which

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-21 Thread Xin Long
On Sat, Dec 19, 2015 at 12:23 AM, Marcelo Ricardo Leitner wrote: > On Fri, Dec 18, 2015 at 09:08:46AM -0500, Vlad Yasevich wrote: >> On 12/17/2015 02:33 PM, Vlad Yasevich wrote: >> > On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: > ... >> >> There is a check on

[PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-21 Thread Andrey Ryabinin
ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. Fix this by inverting ip6addrlbl_hold() check. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF:

Re: net, ipv6: out of bounds access in secret_stable

2015-12-21 Thread Hannes Frederic Sowa
On 19.12.2015 21:50, Cong Wang wrote: > On Fri, Dec 18, 2015 at 5:13 PM, Sasha Levin wrote: >> Hi Hannes, >> >> I've hit the following out of bounds access while fuzzing on the latest >> -next kernel. >> >> This code was added in 3d1bec9932 ("ipv6: introduce secret_stable

[patch net-next] mlxsw: core: Allow to reset temperature history via hwmon interface

2015-12-21 Thread Jiri Pirko
From: Jiri Pirko Add another sysfs hwmon attribute to expose possibility to reset temperature sensors history. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c | 37 +++- 1 file changed, 36 insertions(+),

Re: [PATCH] Octeon: Fix logic for waking octoen ethernet tx queue.

2015-12-21 Thread David Miller
From: Luuk Paulussen Date: Mon, 21 Dec 2015 22:53:06 + > The patch is a bugfix for an ethernet driver in the staging dir. Changes to things under drivers/staging get submitted to the staging maintainer, not here. -- To unsubscribe from this list: send the

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Souptick Joarder
ipt (relaxed version of > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > Patch is against linux-next (localversion-next is -next-20151221) > > drivers/net/wireless/ti/w

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Julian Calaby
t; scripts/coccinelle/api/alloc/kzalloc-simple.cocci) >> > >> > Patch was compile tested with: x86_64_defconfig + >> > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) >> > >> > Patch is against linux-next (localversion-next is -next-20151221) >> > >>

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Nicholas Mc Guire
mplies CONFIG_WLCORE=m) > > > > Patch is against linux-next (localversion-next is -next-20151221) > > > > drivers/net/wireless/ti/wlcore/main.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/wireless/ti/wlco

[v10, 0/6] Freescale DPAA FMan

2015-12-21 Thread igal.liberman
From: Igal Liberman The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators

[v10, 1/6] fsl/fman: Add FMan MURAM support

2015-12-21 Thread igal.liberman
From: Igal Liberman Add Frame Manager Multi-User RAM support. This internal FMan memory block is used by the FMan hardware modules, the management being made through the generic allocator. The FMan Internal memory, for example, is used for allocating transmit and

[v10, 2/6] fsl/fman: Add FMan support

2015-12-21 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger Driver. The FMan embeds a series of hardware blocks that implement a group of Ethernet interfaces. This patch adds The FMan configuration, initialization and runtime control routines. The

Re: [PATCH] BugFix in XHCI controller driver for scatter gather DMA

2015-12-21 Thread Oliver Neukum
On Mon, 2015-12-21 at 17:34 +0530, Vikas Bansal wrote: > Pre-Condition > At the time of reset resume of a USB device, both self and bus powered > devices might go to a low power state or power off state depending on the > acceptable suspend time power of the system. > In case the device

[PATCH] Adding Reset resume support for CDC-EEM driver.

2015-12-21 Thread Vikas Bansal
Pre-Condition At the time of reset resume of a USB device, both self and bus powered devices might go to a low power state or power off state depending on the acceptable suspend time power of the system. In case the device experiences a power glitch or completely powers off during

Re: net, ipv6: out of bounds access in secret_stable

2015-12-21 Thread Sasha Levin
On 12/21/2015 03:58 AM, Hannes Frederic Sowa wrote: > On 19.12.2015 21:50, Cong Wang wrote: >> On Fri, Dec 18, 2015 at 5:13 PM, Sasha Levin wrote: >>> Hi Hannes, >>> >>> I've hit the following out of bounds access while fuzzing on the latest >>> -next kernel. >>> >>> This

[v10, 4/6] fsl/fman: Add FMan SP support

2015-12-21 Thread igal.liberman
From: Igal Liberman The Storage Profiles contain parameters that are used by the FMan for frame reception and transmission. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |2 +-

[v10, 3/6] fsl/fman: Add FMan MAC support

2015-12-21 Thread igal.liberman
From: Igal Liberman Add the Data Path Acceleration Architecture Frame Manger MAC support. This patch adds The FMan MAC configuration, initialization and runtime control routines. This patch contains support for these types of MACs: - dTSEC: Three speed

[v10, 6/6] fsl/fman: Add FMan MAC driver

2015-12-21 Thread igal.liberman
From: Igal Liberman This patch adds the Ethernet MAC driver supporting the three different types of MACs: dTSEC, tGEC and mEMAC. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |3 +-

[PATCH] Adding Reset resume support for CDC-EEM driver.

2015-12-21 Thread Vikas Bansal
Pre-Condition At the time of reset resume of a USB device, both self and bus powered devices might go to a low power state or power off state depending on the acceptable suspend time power of the system. In case the device experiences a power glitch or completely powers off during

RE: [PATCH] net: phy: adds backplane driver for Freescale's PCS PHY

2015-12-21 Thread Shaohui Xie
> On Fri, Dec 18, 2015 at 05:30:54PM +0800, shh@gmail.com wrote: > > +static int fsl_backplane_probe(struct phy_device *phydev) { > > + struct fsl_xgkr_inst *xgkr_inst; > > + struct device_node *child, *parent, *lane_node; > > + const char *lane_name; > > + int len; > > + int ret; >

[PATCH 1/1] use buf, not (non-existent) ptr

2015-12-21 Thread Christian Hesse
From: Christian Hesse Shared code was moved to a function, but variable name has not been updated. Use buf (passed to the function) instead of ptr. This fixes regressen from upstream commit 7d6aadcd0a1dc795d72e1ab311aee333c763fe71. Signed-off-by: Christian Hesse

Re: [PATCH] net: tcp: deal with listen sockets properly in tcp_abort.

2015-12-21 Thread Eric Dumazet
On Tue, 2015-12-22 at 00:03 +0900, Lorenzo Colitti wrote: > When closing a listen socket, tcp_abort currently calls > tcp_done without clearing the request queue. If the socket has a > child socket that is established but not yet accepted, the child > socket is then left without a parent, causing

[PATCH -next] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-21 Thread Florian Westphal
Hannes points out that when we generate tcp reset for timewait sockets we pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). Make it cope with inet tw sockets and then provide tw sk so RST appears on correct interface. Packetdrill test case: // want default route to be used, we

RE: [RFC 5/5] i40e/ethtool: support coalesce setting by queue

2015-12-21 Thread Nelson, Shannon
> From: Liang, Kan > Sent: Friday, December 18, 2015 1:06 PM > > Hi sln, > > Thanks for the comments. I will fix it in V2. > > Could you please check if the following code can find and set/get vector > correctly? > > Get rx_usecs and tx_usecs per queue > > + if (queue > 0) { > +

[PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Nicholas Mc Guire
config + CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) Patch is against linux-next (localversion-next is -next-20151221) drivers/net/wireless/ti/wlcore/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/

Re: [PATCH 1/2] can: sja1000: add documentation for Technologic Systems version

2015-12-21 Thread Damien Riegel
On Sat, Dec 19, 2015 at 09:37:42PM -0600, Rob Herring wrote: > On Fri, Dec 18, 2015 at 03:17:24PM -0500, Damien Riegel wrote: > > This commit adds documentation for the Technologic Systems version of > > SJA1000. The difference with the NXP version is in the way the registers > > are accessed. > >

Re: [PATCH] Adding Reset resume support for CDC-EEM driver.

2015-12-21 Thread Alan Stern
On Mon, 21 Dec 2015, Vikas Bansal wrote: > Pre-Condition > At the time of reset resume of a USB device, both self and bus powered > devices might go to a low power state or power off state depending on the > acceptable suspend time power of the system. > In case the device experiences a

[PATCH] net: tcp: deal with listen sockets properly in tcp_abort.

2015-12-21 Thread Lorenzo Colitti
When closing a listen socket, tcp_abort currently calls tcp_done without clearing the request queue. If the socket has a child socket that is established but not yet accepted, the child socket is then left without a parent, causing a leak. Fix this by setting the socket state to TCP_CLOSE and

Re: [PATCH 07/14] batman-adv: use list_for_each_entry_safe

2015-12-21 Thread Antonio Quartulli
Hi Geliang, > static int batadv_socket_release(struct inode *inode, struct file *file) > { > - struct batadv_socket_client *socket_client = file->private_data; > - struct batadv_socket_packet *socket_packet; > - struct list_head *list_pos, *list_pos_tmp; > + struct

[patch net-next] mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

2015-12-21 Thread Jiri Pirko
From: Jiri Pirko KASan reported use-after-free for the hwmon structure. So fix this by using devm_kzalloc and let the core take care about freeing the memory during device dettach. Reported-by: Ido Schimmel Fixes: 89309da39 ("mlxsw: core: Implement

Re: [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies

2015-12-21 Thread David Ahern
On 12/21/15 3:56 AM, Jiri Pirko wrote: diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index 5396ff08..12045de 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -39,7 +39,7 @@ void br_init_port(struct net_bridge_port *p) struct switchdev_attr attr = {

Re: [PATCH -next] tcp: honour SO_BINDTODEVICE for TW_RST case too

2015-12-21 Thread Eric Dumazet
On Mon, 2015-12-21 at 17:20 +0100, Florian Westphal wrote: > Hannes points out that when we generate tcp reset for timewait sockets we > pretend we found no socket and pass NULL sk to tcp_vX_send_reset(). > > Make it cope with inet tw sockets and then provide tw sk so RST appears on > correct

Re: [patch net] switchdev: bridge: Pass ageing time as clock_t instead of jiffies

2015-12-21 Thread Ido Schimmel
Mon, Dec 21, 2015 at 05:53:19PM IST, dsah...@gmail.com wrote: >On 12/21/15 3:56 AM, Jiri Pirko wrote: >> diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c >> index 5396ff08..12045de 100644 >> --- a/net/bridge/br_stp_if.c >> +++ b/net/bridge/br_stp_if.c >> @@ -39,7 +39,7 @@ void

[PATCH net-next v3] Driver for IBM System i/p VNIC protocol

2015-12-21 Thread Thomas Falcon
This is a new device driver for a high performance SR-IOV assisted virtual network for IBM System p and IBM System i systems. The SR-IOV VF will be attached to the VIOS partition and mapped to the Linux client via the hypervisor's VNIC protocol that this driver implements. This driver is able to