[PATCH] [NET] Add constant for FCS/CRC length (frame check sequence)

2007-05-15 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] About a dozen drivers that have some form of crc checksumming or offloading use this constant, warranting a global define for it. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/if_ether.h |1 + 1 files changed, 1 insertions(+), 0 deletions

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
a lot better. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
a lot better. All #ifdef CONFIG_PCI_MSI's have been removed. Compile tested with both CONFIG_PCI_MSI enabled and disabled. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |4 +--- drivers/net/e1000/e1000_main.c | 39

[PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Auke Kok
Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Wen Xiong [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 10 ++ 1 files changed, 10

[PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup minor leak

2007-05-17 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] pci_enable_msi calls can fail for normal operational reasons. Driver should not print an error message in that case. Fix a leak that leaves msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI ifdefs alltogether Signed-off-by: Auke Kok [EMAIL

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 Tested by Doug Chapman [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Acked-by: Herbert Xu

[PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Auke Kok
it to be. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] Cc: Doug Chapman [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-08 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-08 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c| 121 +++-- drivers/net/e1000/e1000.h | 15

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-11 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c| 135 - drivers/net/e1000/e1000.h | 15

[PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h | 54 + net/core/dev.c|5 net/core/ethtool.c| 14 ++-- 3 files changed, 66 insertions(+), 7 deletions(-) diff --git a/include/linux

Re: [PATCH 08/26] e1000: Deprecate mii-tool SIOCMIIREG ioctl

2006-08-31 Thread Auke Kok
Brandeburg, Jesse wrote: Jeff Garzik wrote: Kok, Auke wrote: Deprecate mii-tool SIOCMIIREG ioctl. This ioctl is broken in e1000 and ethtool has this functionality in working order. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] This doesn't deprecated

Re: [PATCH 00/26] e100, e1000, ixgb updates

2006-08-31 Thread Auke Kok
699a71238856b19091503c671bac8abb1e3f9a3a) Cheers, Auke Kok, Auke wrote: Vasily Averin [EMAIL PROTECTED] e1000: IRQ resources cleanup e1000: e1000_probe resources cleanup e1000: ring buffers resources cleanup Jesse Brandeburg [EMAIL PROTECTED] e1000: unify WoL capability

[PATCH]: ethtool: typo fix for e1000

2006-09-01 Thread Auke Kok
e1000: Typo fix. Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/e1000.c b/e1000.c index 6de27ca..6741323 100644 --- a/e1000.c +++ b/e1000.c @@ -372,7 +372,7 @@ e1000_dump_regs(struct ethtool_drvinfo * Descriptor minimum threshold size: %s\n Broadcast accept mode

Re: e1000 Detected Tx Unit Hang

2006-09-01 Thread Auke Kok
Paul Aviles wrote: I am getting e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang using stock 2.6.17.11, 2.6.17.5 or 2.6.17.4 kernels on centos 4.3. The server is a Tyan GS10 and is connected to a Netgear GS724T Gig switch. I can easily reproduce the problem by trying to do a large ftp

Re: e100 fails, eepro100 works

2006-09-08 Thread Auke Kok
Jan Kiszka wrote: Hi, we have a couple of industrial PCs here with Intel PRO/100 controllers on board. Most of them work fine with the e100, but today I stumbled over one box that doesn't: Reception works (RX counter increases, ARP cache gets filled up), but transmission fails (TX counter is

Re: e1000_xmit_frame and e1000_down racing with next_to_use?

2006-09-08 Thread Auke Kok
Shaw Vrana wrote: On Wed, 6 Sep 2006 10:58:15 -0700 (PDT) [EMAIL PROTECTED] wrote: Hello All, I have a question about the use of the tx_ring-next_to_use variable in the e1000. Specifically, I'm wondering about a race between the use of next_to_use in e1000_xmit_frame and the clearing of

[PATCH] ethtool: e1000: fix a typo

2006-09-08 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/e1000.c b/e1000.c index 6de27ca..6741323 100644 --- a/e1000.c +++ b/e1000.c @@ -372,7 +372,7 @@ e1000_dump_regs(struct ethtool_drvinfo

[PATCH] e1000: fix TX timout hang regression for 82542rev3

2006-09-11 Thread Auke Kok
registers for read and write descriptor rings. Ths fix was tested on an 82542 rev3 NIC and newer NICs. Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 726f43d..98ef9f8 100644 --- a/drivers/net/e1000/e1000_main.c +++ b

Re: examples to model ethernet driver off of?

2006-09-13 Thread Auke Kok
Francois Romieu wrote: Kumar Gala [EMAIL PROTECTED] : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) Cheers, Auke - To unsubscribe from this list: send the line unsubscribe

Re: examples to model ethernet driver off of?

2006-09-13 Thread Auke Kok
Kumar Gala wrote: On Sep 13, 2006, at 3:11 PM, Auke Kok wrote: Francois Romieu wrote: Kumar Gala [EMAIL PROTECTED] : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) What

Re: [PATCH] please include in 2.6.18: e100 disable device on PCI error

2006-09-18 Thread Auke Kok
is no longer enabled. This is a trivial fix for this problem. Tested. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] drivers/net/e100.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.18-rc7-git1

[PATCH] ethtool: e1000: fix a typo

2006-09-19 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/e1000.c b/e1000.c index 6de27ca..6741323 100644 --- a/e1000.c +++ b/e1000.c @@ -372,7 +372,7 @@ e1000_dump_regs(struct ethtool_drvinfo

[PATCH] [PATCH] ethtool: add ixgb register dump support

2006-09-19 Thread Auke Kok
From: Nicholas Nunley [EMAIL PROTECTED] This adds support for dumping ixgb registers in readable format. Signed-off-by: Nicholas Nunley [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- Makefile.am|4 +- ethtool-util.h |3 + ethtool.c |2 + ixgb.c

Re: [PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Auke Kok
is not set, which was previously broken. Signed-off-by: Auke Kok [EMAIL PROTECTED] Why does e100_suspend() need to exist even when CONFIG_PM is disabled? WoL is fundamentally power management. same as e1000_suspend: we're consolidating shutdown code making 2 different codepaths exactly

Re: [PATCH 18/23] e1000: revert 'e1000: Remove 0x1000 as supported device'

2006-09-19 Thread Auke Kok
6a9516989f94df10d9a27ba543c6b53b3e69c84a). This commit reverts commit 673a052fde79ab5e9dce569b0336358812ddba2d and re-enables 82542rev3 chips completely. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- 0 files changed, 0 insertions(+), 0 deletions(-) null patch hmm, it should look like this: --- e1000: revert 'e1000

Re: [PATCH 00/23] e100, e1000, ixgb updates

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: FYI, note that I killed some OS wrappers from osdep.h in e1000 and ixgb excellent, I am ashamed I didn't get to that myself yet :) Thanks! Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Auke Kok
is not set, which was previously broken. Signed-off-by: Auke Kok [EMAIL PROTECTED] Why does e100_suspend() need to exist even when CONFIG_PM is disabled? WoL is fundamentally power management. okay, I'll fix this for e1000 as well, where we have the same code flow. Thanks. Auke

Re: [PATCH 05/23] e1000: rename flow control symbols

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: --- a/drivers/net/e1000/e1000_hw.h +++ b/drivers/net/e1000/e1000_hw.h @@ -90,15 +90,6 @@ typedef enum { e1000_100_full = 3 } e1000_speed_duplex_type; -/* Flow Control Settings */ -typedef enum { -e1000_fc_none = 0, -e1000_fc_rx_pause = 1, -

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Auke Kok
Dave Jones wrote: On Tue, Sep 19, 2006 at 05:40:34PM -0400, Jeff Garzik wrote: Dave Jones wrote: On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: + add_taint(TAINT_MACHINE_CHECK); I object to this flag being abused this way. A corrupt EEPROM on

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ACK patch, NAK

Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-19 Thread Auke Kok
Stephen Hemminger wrote: On Tue, 19 Sep 2006 16:45:06 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: looks OK except for the tasklet, which may starve if the lock is being held upon entry Why would the tasklet starve anymore than NAPI? Worst case, the transmitters fill the ring completely and

Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-20 Thread Auke Kok
Jeff Garzik wrote: Actually, I rescind the ACK. The code should be inside a spinlock, and therefore not need this additional check. If this check were truly needed, then SMP code all over the kernel would be broken. I will drop the patch for now. Once Jesse is back next week he gets to

Re: [PATCH 11/23] e1000: Jumbo frames fixes for 82573

2006-09-20 Thread Auke Kok
Allan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index e81aa03..2ecec51 100644 --- a/drivers/net

Re: 2.6.1[78] page allocation failure. order:3, mode:0x20

2006-09-22 Thread Auke Kok
: account for NET_IP_ALIGN when calculating bufsiz Account for NET_IP_ALIGN when requesting buffer sizes from netdev_alloc_skb to reduce slab allocation by half. Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index bb0d129

Re: 2.6.1[78] page allocation failure. order:3, mode:0x20

2006-09-23 Thread Auke Kok
Andrew Morton wrote: On Fri, 22 Sep 2006 22:25:07 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Fri, 22 Sep 2006 21:50:00 -0700 On Fri, 22 Sep 2006 10:10:36 -0700 Auke Kok [EMAIL PROTECTED] wrote: e1000: account for NET_IP_ALIGN when

Re: 2.6.1[78] page allocation failure. order:3, mode:0x20

2006-09-24 Thread Auke Kok
Evgeniy Polyakov wrote: On Fri, Sep 22, 2006 at 10:33:48PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: The NET_IP_ALIGN existed not just for fun :) There are ramifications for removing it. It's still there, isn't it? For the 9k MTU case, for example, we end up allocating 16384 byte skbs

Re: [PATCH] ioremap balance with iounmap for drivers/net]

2006-09-24 Thread Auke Kok
Amol Lad wrote: ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Tested (compilation only) with: - allmodconfig - Modifying drivers/net/Kconfig to make sure that the changed file is compiling without warning Signed-off-by: Amol Lad [EMAIL PROTECTED] ---

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-09-25 Thread Auke Kok
Linas Vepstas wrote: Resending a minor janitorial patch from long ago that seems to have fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1. Please apply and forward upstream. --linas [PATCH]: e1000: Janitor: Use #defined values for literals Minor janitorial patch: use

Re: [patch 01/11] e1000: memory leak in e1000_set_ringparam()

2006-09-25 Thread Auke Kok
and rx_new) and uses kzalloc instead kmalloc+memset(0) Signed-off-by: Vasily Averin [EMAIL PROTECTED] Cc: Jeb Cramer [EMAIL PROTECTED] Cc: John Ronciak [EMAIL PROTECTED] Cc: Jesse Brandeburg [EMAIL PROTECTED] Cc: Jeff Kirsher [EMAIL PROTECTED] Cc: Auke Kok [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL

Re: mii-tool gigabit support.

2006-09-27 Thread Auke Kok
David Acker wrote: Stephen Hemminger wrote: On Tue, 26 Sep 2006 17:55:34 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: The mii-tool utility seems to be abandoned and unmaintained? Here is a version that does standard 1000baseT support.

Re: mii-tool gigabit support.

2006-09-27 Thread Auke Kok
Rick Jones wrote: With mii-tool we can do the command below and work with a half duplex hub and a full duplex switch. mii-tool -A 10baseT-FD,10baseT-HD eth0 Why, and how often, is that really necessary? This is a bit of a hypothetical discussion of course, but I can imagine a lot of users

Re: mii-tool gigabit support.

2006-09-27 Thread Auke Kok
Maciej W. Rozycki wrote: On Wed, 27 Sep 2006, Rick Jones wrote: Another scenario: forcing the NIC to negotiate only full-duplex speeds. Not only fun if you try it against a hub, but possibly useful. [...] I'm just worried (as in Fear Uncertainty and Doubt) that having people set the allowed

Re: mii-tool gigabit support.

2006-09-27 Thread Auke Kok
dean gaudet wrote: On Tue, 26 Sep 2006, Jeff Garzik wrote: Stephen Hemminger wrote: The mii-tool utility seems to be abandoned and unmaintained? Here is a version that does standard 1000baseT support. http://developer.osdl.org/shemminger/prototypes/mii-tool.tar.bz2 Not really. I

Re: [PATCH 13/23] e1000: gather hardware bit tweaks.

2006-09-27 Thread Auke Kok
: Jeff Kirsher [EMAIL PROTECTED] Several hardware bits were set all over the driver and have been consolidated into a single function. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_hw.c | 155

Re: [PATCH 08/23] e1000: add multicast stats counters

2006-09-27 Thread Auke Kok
-by: Mitch Williams [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c | 32 ++-- drivers/net/e1000/e1000_hw.h |4 +++- drivers/net/e1000/e1000_main.c|9 - 3 files changed, 25 insertions(+), 20 deletions

[GIT PATCH] e100, e1000, ixgb updates for #upstream

2006-09-27 Thread Auke Kok
files changed, 1108 insertions(+), 1488 deletions(-) --- Summary: --- Auke Kok [EMAIL PROTECTED]: e100, e1000, ixgb: update copyright header and remove LICENSE e100, e1000, ixgb: Fix an impossible memory overwrite bug e1000: keep .suspend and .resume driver methods in CONFIG_PM

Re: Network problem with 2.6.18-mm1 ?

2006-09-27 Thread Auke Kok
Sukadev Bhattiprolu wrote: I am unable to get networking to work with 2.6.18-mm1 on my system. But 2.6.18 kernel on same system works fine. Here is some info about the system/debug attempts. Attached are the lspci output and config. Appreciate any help. Please let me know if you need more

Re: e100 changes in git-netdev-all break reboot with netconsole

2006-09-28 Thread Auke Kok
Andrew Morton wrote: Enable netconsole-over-e100, and `reboot -f' hangs. Disabling netconsole prevents that from happening. I assume what's happening is that the driver gets shut down and then something tries to do a printk through it, and things hang. For some reason sysrq-B still reboots

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Auke Kok
Stephen Hemminger wrote: There is no reason to not allow non-admin users to query network statistics and settings. --- linux-2.6.orig/net/core/ethtool.c +++ linux-2.6/net/core/ethtool.c @@ -806,13 +806,6 @@ int dev_ethtool(struct ifreq *ifr) int rc; unsigned long old_features;

Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

2006-10-10 Thread Auke Kok
Robert P. J. Day wrote: On Tue, 10 Oct 2006, Auke Kok wrote: Robert P. J. Day wrote: Delete the minimally-useful IXGB_DBG() macro and call pr_debug() directly from the main routine. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb

Re: [PATCH] ixgb: Delete IXGB_DBG() macro and call pr_debug() directly.

2006-10-10 Thread Auke Kok
Robert P. J. Day wrote: On Tue, 10 Oct 2006, Auke Kok wrote: Robert P. J. Day wrote: ... snip ... if someone wants to tell me what, in the context of ixgb_main.c, i would use as that dev argument [for dev_dbg], i'm all for that. (CC netdev since it's a network driver topic). all our

Re: user of the jiffies rounding code: Networking

2006-10-12 Thread Auke Kok
://vger.kernel.org/majordomo-info.html For the e1000 parts, but in general too: Acked-by: Auke Kok [EMAIL PROTECTED] Cheers - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[PATHC] e100: fix reboot -f with netconsole enabled

2006-10-14 Thread Auke Kok
e100: FIX: fix netconsole fast reboot attached to e100 When rebooting with netconsole over e100, the driver shutdown code would deadlock with netpoll. Reduce shutdown code to a bare minimum while retaining WoL and suspend functionality. Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread Auke Kok
jamal wrote: On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control capability. Auke, can you also check this as well? Just found

Re: [e1000]: flow control on by default - good idea really?

2006-10-17 Thread Auke Kok
jamal wrote: On Mon, 2006-16-10 at 11:55 -0700, Auke Kok wrote: jamal wrote: I think when the e1000 says via ethtool rx is on - it means that it is _advertising_ flow control as opposed to detecting partner has flow control capability. Auke, can you also check this as well? Just found

Re: [e1000]: flow control on by default - good idea really?

2006-10-18 Thread Auke Kok
jamal wrote: On Tue, 2006-17-10 at 14:02 -0700, Auke Kok wrote: For now, we should really report the FC status in e1000 at link up time. Jamal: this should help you out for now, I'll send something like this upstream later on. Thanks - this puts you at par with the tg3 at least. On Tue

Re: [PATCH 2.6.19] e100: replace kmalloc with kcalloc

2006-12-12 Thread Auke Kok
Yan Burman wrote: Replace kmalloc+memset with kcalloc ACK, fine with me. Signed-off-by: Yan Burman [EMAIL PROTECTED] diff -rubp linux-2.6.19-rc5_orig/drivers/net/e100.c linux-2.6.19-rc5_kzalloc/drivers/net/e100.c --- linux-2.6.19-rc5_orig/drivers/net/e100.c2006-11-09 12:16:21.0

[PATCH RESEND] 3 ixgb fixes, please pull

2007-01-06 Thread Auke Kok
insertions(+), 7 deletions(-) --- Auke Kok [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line unsubscribe netdev

[PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
quad port adapter (device 0x10a5). MTU changes on a downed interface require a phy commit to enact the new size immediately. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/Makefile

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Stephen Hemminger wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: Andrew, All, This patch contains a major rewrite to the e1000 driver that groups and separates e1000 hardware by chipset family. It abstracts the hardware specific code into an API that will allow

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Randy Dunlap wrote: On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote: Auke Kok [EMAIL PROTECTED] writes: drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 95 drivers/net/e1000/e1000_80003es2lan.c | 1330 + drivers/net/e1000

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

Re: watchdog timeout panic in e1000 driver

2007-01-15 Thread Auke Kok
know if this also fixes the problem for you. I will most likely push this patch to the netdev tree in any case. Cheers, Auke --- From: Auke Kok [EMAIL PROTECTED] e1000: Don't do PHY reads in watchdog unless link status is down The watchdog runs code that every 2 seconds performs several PHY

Re: Two Dual Core processors and NICS (not handling interrupts on one CPU/assigning a Two Dual Core processors and NICS (not handling interrupts on one CPU / assigning a CPU to a NIC)

2007-01-15 Thread Auke Kok
Mark Ryden wrote: Hello, I have a machine with 2 dual core CPUs. This machine runs Fedora Core 6. I have two Intel e1000 GigaBit network cards on this machine; I use bonding so that the machine assigns the same IP address to both NICs ; It seems to me that bonding is configured OK, bacuse

Re: e100.c patch to 2.6.18 fixing Wake on Lan (WOL)

2007-01-15 Thread Auke Kok
Harry Coin wrote: Hello from Iowa. Below please find a fix to the Wake On Lan function in the e100.c (intel 10/100) driver. With the original driver distributed in kernel 2.6.18 in debian etch, wake on lan did not work. This was tested on 14 dell optiplexes with built-in ethernet chips

Re: e100.c patch to 2.6.18 fixing Wake on Lan (WOL)

2007-01-15 Thread Auke Kok
Harry Coin wrote: At 10:19 AM 1/15/2007 -0800, Auke Kok wrote: Have you tried the version in 2.6.19? I even tried copying and pasting the e100_down and the latest PM stuff from the newest e100.c version on sourceforge. I admit to being defeated as to how to join a sourceforge group. Too

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Auke Kok
Allen Parker wrote: Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but thought I should get the word out in case someone else is testing this

[PATCH -MM] e1000: update new hardware init layer code with bugfixes

2007-01-16 Thread Auke Kok
-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_80003es2lan.c | 90 - drivers/net/e1000/e1000_82540.c | 86

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-17 Thread Auke Kok
Adam Kropelin wrote: Allen Parker wrote: Allen Parker wrote: From what I've been able to gather, other Intel Pro/1000 chipsets work fine in 2.6.20-rc5. If the e1000 guys need any assistance testing, I'll be more than happy to volunteer myself as a guinea pig for patches. I wasn't aware that

Re: [PATCH 0/8] partial resend: e1000 fixes and updates

2007-01-18 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Hi, This patch series contains exclusively fixes for e1000. Some of these patches were already sent in december, but didn't make it into any usptream tree yet. Most importantly, it addresses two issues in the recently merged msi interrupt handler and

Re: [BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()

2007-01-18 Thread Auke Kok
Sukadev Bhattiprolu wrote: I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. Same basic config file seems to work with 2.6.20-rc2-mm1 on this same system. Have not tried -rc3-mm1 yet. Attached are config file and lspci -vv output. Let me know if you need more info. Suka

e1000: update device ID table for register dumps

2007-01-19 Thread Auke Kok
e1000: update device ID table for register dumps with new devices From: Auke Kok [EMAIL PROTECTED] The register dump routine of e1000 was missing several newer chipsets. I reimported the mac detection code from the linux e1000 driver. This fixes newer NIC's reporting that their bus type is PCI

Re: e1000: update device ID table for register dumps [Is an *ethtool* patch]

2007-01-19 Thread Auke Kok
Auke Kok wrote: e1000: update device ID table for register dumps with new devices From: Auke Kok [EMAIL PROTECTED] The register dump routine of e1000 was missing several newer chipsets. I reimported the mac detection code from the linux e1000 driver. This fixes newer NIC's reporting

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-19 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I am experiencing the no-link issue on a 82572EI single port copper PCI-E card. I've only tried 2.6.20-rc5, so I cannot tell if this is a regression or not yet. Will test older kernel soon. Can provide details/logs if you want 'em

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-19 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I haven't been able to test rc5-mm yet because it won't boot on this box. Applying git-e1000 directly to -rc4 or -rc5 results in a number of rejects that I'm not sure how to fix. Some are obvious, but the others I'm unsure

Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume

2007-01-21 Thread Auke Kok
Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: It's the 10th resume and in /proc/interrupts eth0 appers 10 times. The e100_resume() function should be calling netif_device_detach and free_irq. Could you try the following (compile tested) patch? I just

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days ago, WITH the changes that you

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Auke Kok wrote: Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days

Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume

2007-01-22 Thread Auke Kok
Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 01:45:27PM -0800, Auke Kok wrote: Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: It's the 10th resume and in /proc/interrupts eth0 appers 10 times. The e100_resume() function should be calling

Re: Nvidia MCP55 Machine reboots on ixgb driver load

2007-01-24 Thread Auke Kok
[added netdev to CC] Roger Heflin wrote: I have a machine (actually 2 machines) that upon loading the intel 10GBe driver (ixgb) the machine reboots, I am using a RHAS4.4 based distribution with Vanilla 2.6.19.2 (the RHAS 4.4.03 kernel also reboots with the ixgb load), I don't see any messages

[PATCH -MM]: updated e1000 - new hardware initialization code (replacement patch)

2007-01-27 Thread Auke Kok
-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 97 drivers/net/e1000/e1000_80003es2lan.c | 1377 + drivers/net/e1000/e1000_80003es2lan.h | 89 drivers/net/e1000/e1000_82540.c | 670 ++ drivers/net/e1000

[PATCH -FIX] e100: fix irq leak on suspend/resume

2007-01-29 Thread Auke Kok
e100: fix irq leak on suspend/resume From: Frederik Deweerdt [EMAIL PROTECTED] The e100_resume() function should be calling netif_device_detach and free_irq. This fixes multiple irq's being allocated after resume. Signed-off-by: Frederik Deweerdt [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-02 Thread Auke Kok
: Allen Parker [EMAIL PROTECTED] Adam Kropelin [EMAIL PROTECTED] Handled-By : Auke Kok [EMAIL PROTECTED] Status : problem is being debugged I probably can't fix this bug. Not only do I doubt that the e1000 driver is at fault here, I don't have a system with this particular

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-03 Thread Auke Kok
Adam Kropelin wrote: Eric W. Biederman wrote: Auke Kok [EMAIL PROTECTED] writes: None of the MSI code in e1000 has changed significantly either. as far as I can see, the msi code in e1000 has not changed since 2.6.18. Nonetheless there's no way I can debug any of this without a system

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-03 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I've never had this device work 100% with MSI on any kernel version I've tested so far. But I'm not the original reporter of the problem, and I believe for him it was a true regression where a previous kernel wored correctly. maybe

Re: [PATCH 00/10] e1000: Driver fixes and update to 7.0.38-k2

2006-04-23 Thread Auke Kok
David S. Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 22 Apr 2006 15:22:54 +1000 Jeff Garzik [EMAIL PROTECTED] wrote: 05/10: [PATCH] Update truesize with the length of the packet for packet split These 10 patches look OK, but since the current kernel

Re: Van Jacobson's net channels and real-time

2006-04-24 Thread Auke Kok
Ingo Oeser wrote: On Saturday, 22. April 2006 15:49, Jörn Engel wrote: That was another main point, yes. And the endpoints should be as little burden on the bottlenecks as possible. One bottleneck is the receive interrupt, which shouldn't wait for cachelines from other cpus too much. Thats

Re: Van Jacobson's net channels and real-time

2006-04-24 Thread Auke Kok
linux-os (Dick Johnson) wrote: On Mon, 24 Apr 2006, Auke Kok wrote: Ingo Oeser wrote: On Saturday, 22. April 2006 15:49, Jörn Engel wrote: That was another main point, yes. And the endpoints should be as little burden on the bottlenecks as possible. One bottleneck is the receive interrupt

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-26 Thread Auke Kok
Shaw wrote: On 4/21/06, Andy Gospodarek [EMAIL PROTECTED] wrote: On 4/21/06, Michael Chan [EMAIL PROTECTED] wrote: On Fri, 2006-04-21 at 16:01 -0400, Andy Gospodarek wrote: I just hate to see extra resources used to solve problems that good coding can solve (not that my suggestion is

Re: E1000 stopped transmitting in rc3.

2006-04-27 Thread Auke Kok
Dave Jones wrote: With 2.6.17-rc3, my E1000 won't get a dhcp lease. Looking at tcpdump and ifconfig output, it's easy to see why. It's recieving packets, but the packets transmitted field of ifconfig never increases. The last version I have built that worked ok was 2.6.17rc2-git3 *puzzled*

Re: 2.6.16.13 e1000 reports incorrect PCI-X bus speed?

2006-05-12 Thread Auke Kok
Ben Greear wrote: I'm running a slightly modified 2.6.16.13 kernel on FC5-amd64. The motherboard is SuperMicro H8SSL dual-core AMD system. According to super-micro web site, the PCI-X slot is 133Mhz. I'm using a 4-port pro/1000 NIC. dmesg shows a listing of 120Mhz: Intel(R) PRO/1000

Re: [PATCH 02/11] ixgb: Fix the use of dprintk rather than printk

2006-05-19 Thread Auke Kok
Francois Romieu wrote: Jeff Kirsher [EMAIL PROTECTED] : @@ -486,8 +495,7 @@ ixgb_probe(struct pci_dev *pdev, netif_carrier_off(netdev); netif_stop_queue(netdev); - printk(KERN_INFO %s: Intel(R) PRO/10GbE Network Connection\n, - netdev-name); +

e1000: add WoL fix for 2.6.17rc

2006-05-25 Thread Auke Kok
PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index fb8cef6..b224e40 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -221,6 +221,7 @@ static void e1000_restore_vlan(struct e1 static

Re: TCP connection hang problem with 2.6.16.16, e1000.

2006-05-31 Thread Auke Kok
Ben Greear wrote: Kernel is 2.6.16.16 with my patches, including a patch to the e1000. what patch? I don't see it anywhere. Cheers, Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: DPRINTKs in e1000 code (2.6.x kernels)

2006-05-31 Thread Auke Kok
On Wed, 31 May 2006 14:31:05 +0530, Amit K Arora [EMAIL PROTECTED] wrote: Hello, I am wondering why this patch e1000: Remove PM warning DPRINTKs breaking 2.4.x kernels (http://www.mail-archive.com/netdev@vger.kernel.org/msg10803.html) was meant only for 2.4 kernels, and _not_ for 2.6

Re: DPRINTKs in e1000 code (2.6.x kernels)

2006-06-01 Thread Auke Kok
Amit Arora wrote: On Wed, 2006-05-31 at 16:30, Auke Kok wrote: On Wed, 31 May 2006 14:31:05 +0530, Amit K Arora [EMAIL PROTECTED] wrote: Should these DPRINTKs be removed from the 2.6.x e1000 code as well ? they already are. the patch was merged in 7.0.38-k2 or so which is over a month ago

  1   2   3   4   >