Re: select(0, ..) is valid ?

Badari Pulavarty napsal(a): Hi, Is select(0, ..) is a valid operation ? Yes, it was (is) sometimes used for measuring (sleeping for) short time slices. regards, -- http://www.fi.muni.cz/~xslaby/Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby

Re: [PATCH] wrong firmware location in IPW2100 Kconfig entry (Was: IPW2100 Kconfig)

Alejandro Bonilla napsal(a): Thanks. I also had a question. To whom is this patch sent to? Netdev or LK? How does one determine? Read, read, read. Documentation/SubmittingPatches, point 4. -- Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [EMAIL PROTECTED

[PATCH 0/3 #2] avoid pci_find_device

Hello, there are some patches to avoid pci_find_device in drivers, next will come in future. Take #2. It's against 2.6.17-rc4-mm3 tree. 01-i2c-scx200-acb-avoid-pci-find-device.patch 02-bcm43xx-avoid-pci-find-device.patch 03-gt96100eth-avoid-pci-find-device.patch i2c/busses/scx200_acb.c

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

/source/drivers/pci/search.c#L270 They traverse the table in similar way as I do. pci_match_one_device() just checks (one to one) values without any looping. regards, - -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ [EMAIL PROTECTED] _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop over the table, pci_match_one_device() does that for you. The problem

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

/bcm43xx in the tree at git://kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git Ok, thanks. - -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ [EMAIL PROTECTED] _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.3 (GNU/Linux

BUG: warning at ... (netlink) [Was: 2.6.17-rc5-mm1]

+0x12b/0x2f1 [c0101005] kernel_thread_helper+0x5/0xb If more info needed, feel free to ask. regards, - -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ [EMAIL PROTECTED] _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.3 (GNU/Linux) Comment

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

John W. Linville napsal(a): On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop

[PATCH 0/3 #3] avoid pci_find_device

Hello, there are some patches to avoid pci_find_device in drivers. I will make a bcm43xx patch against wireless git too. Take #3. It's against 2.6.17-rc5-mm3 tree. 01-i2c-scx200-acb-avoid-pci-find-device.patch 02-bcm43xx-avoid-pci-find-device.patch 03-gt96100eth-avoid-pci-find-device.patch

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

Michael Buesch napsal(a): On Monday 05 June 2006 22:18, Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. I am wondering about the reference count. From docbook: 256 * pci_get_device - begin or continue

Re: [PATCH 3/3] pci: gt96100eth avoid pci_find_device

Jiri Slaby napsal(a): gt96100eth avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more bridges. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit fd863b81ac491faf783ff7f2dcf6032177c5ab7f tree d7eb59f897505230023754f19ad7227eec39e676 parent

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

Greg KH napsal(a): On Mon, Jun 05, 2006 at 10:20:07PM +0200, Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 4b73c16f5411d97360d5f26f292ffddeb670ff75 tree

[PATCH] happy-meal-pci-probing

against 2.6.15-mm2 happy-meal-pci-probing Pci probing functions added, some functions were rewritten. Use PCI_DEVICE macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit eb724d05644c4a6fa80fc7f4beaeabfcd7a19905 tree a75be76af0e6a59f2f1526c7cce188403cff63cf parent

[PATCH 1/1] net: correct-Traffic-shaper-Kconfig

kconfig, correct traffic shaper CBQ is no longer experimental and is located in other subtree. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 5ee1f6ff7e1f03ed8edb2461612346e9964b745d tree debfe70d8c8338adb5ef1d860b07e4a00e760081 parent a3d771ef92954ce81363af9e0252490e2741fc21 author

Re: ipw3945?

a reason not to merge it. has Intel submitted it for inclusion? No. It seems to be still in a devel phase -- it doesn't work for me (and other people): http://bughost.org/bugzilla/show_bug.cgi?id=1152 regards, -- http://www.fi.muni.cz/~xslaby/Jiri Slaby faculty of informatics

Re: Kernel oops in rt_check_expire()

--- You would rather post it to lkml and netdev. Please post a kernel version and some other basic info if there is any. regards, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby - To unsubscribe from this list: send

[PATCH 1/1] Net: kconfig, correct traffic shaper

Shaper is now obsolete and alternative to it is no longer CBQ, since its problems with virtual devices, alter Kconfig text to reflect this -- put a link to the traffic schedulers as a whole. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Cc: Patrick McHardy [EMAIL

Re: [patch 08/18] happymeal: add pci probing

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] napsal(a): From: Jiri Slaby [EMAIL PROTECTED] Pci probing functions added, some functions were rewritten. Use PCI_DEVICE macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED

3c59x regression (transmission stop)

, -- http://www.fi.muni.cz/~xslaby/Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: 3c59x regression (transmission stop)

Jiri Slaby napsal(a): There is nothing significant in dmesg, 2.6.17-rc5 was fine, so this is definitely a regression. No, it's probably not, it allegedly happened sometimes in 2.6.17-rc5 too, I've changed the card. regards, -- http://www.fi.muni.cz/~xslaby/Jiri Slaby faculty

Re: [PATCH] use dev_printk() in some net drivers

(KERN_ERR, #dev_err(# macro? regards, -- Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [EMAIL PROTECTED] ~\-/~ B67499670407CE62ACC8 22A032CC55C339D47A7E - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: 2.6.23-rc2-mm2 -- conntrack divide error

/~xslaby/sklad/panics/nf_oops.config -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

All against mac80211 tree -- mac80211, remove bitfields from struct ieee80211_tx_packet_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 10e9252a35d42fb92e65dfaaef136d81dbb71c4f tree f8579cff30dc8053b770b78582a30961b7320046 parent a050b807aede7f9c6bee0bef1c07cd9c5fc4 author Jiri

[PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

mac80211, remove bitfields from struct ieee80211_txrx_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 37d65bd9e26732c7ec33a58eab6bda750b3be113 tree ac8e2b83c426b03007ea0bd7c5092e351598053c parent 10e9252a35d42fb92e65dfaaef136d81dbb71c4f author Jiri Slaby [EMAIL PROTECTED] Sun, 12 Aug

[PATCH 3/4] Net: mac80211, remove bitfields from struct ieee80211_if_sta

mac80211, remove bitfields from struct ieee80211_if_sta Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 3fe2e620fcc758be03b87e3ca5265b10fbd60e1a tree 2f3e78c8f801af86ac42b8de1ab4495cdcd24bc3 parent 37d65bd9e26732c7ec33a58eab6bda750b3be113 author Jiri Slaby [EMAIL PROTECTED] Sun, 12 Aug

[PATCH 4/4] Net: mac80211, remove bitfields from struct ieee80211_sub_if_data

mac80211, remove bitfields from struct ieee80211_sub_if_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 086d27164f6a040ea24efe6baab3e6b9075942a5 tree 61fb84b9bb528c8321a86a6afbf980eafb28ee3f parent 3fe2e620fcc758be03b87e3ca5265b10fbd60e1a author Jiri Slaby [EMAIL PROTECTED] Sun, 12

Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

Johannes Berg napsal(a): On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: +if (control-flags IEEE80211_TXCTL_REQ_TX_STATUS) +pkt_data-flags |= IEEE80211_TXPD_REQ_TX_STATUS; +if (control-flags IEEE80211_TXCTL_DO_NOT_ENCRYPT) +pkt_data-flags

Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

Johannes Berg napsal(a): On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: -unsigned int fragmented:1; /* whether the MSDU was fragmented */ +/* whether the MSDU was fragmented */ +#define IEEE80211_TXRXD_FRAGMENTED BIT(0) +#define IEEE80211_TXRXD_TXUNICAST BIT

[PATCH 1/4 #2] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

mac80211, remove bitfields from struct ieee80211_tx_packet_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit b7844000ba006531bd2133e8097fa27724efe3c2 tree ba74c93d4c8f1ef7d7c4a3f45af9a24cf3a6d329 parent a050b807aede7f9c6bee0bef1c07cd9c5fc4 author Jiri Slaby [EMAIL PROTECTED] Sat

[PATCH 2/4 #2] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

mac80211, remove bitfields from struct ieee80211_txrx_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit bb1e8d28c269abe10378d39c2050ad2653c4f1a9 tree a44c0c27ffaeb917f9e4753019d4cbc17e4c341a parent b7844000ba006531bd2133e8097fa27724efe3c2 author Jiri Slaby [EMAIL PROTECTED] Sat, 18 Aug

[PATCH 3/4 #2] Net: mac80211, remove bitfields from struct ieee80211_if_sta

mac80211, remove bitfields from struct ieee80211_if_sta Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 5d3b17704c1cb1d8c8ff45f72282918f89e1d5c0 tree 41c8b637c79728517d647edc8f0e41f544ccefbc parent bb1e8d28c269abe10378d39c2050ad2653c4f1a9 author Jiri Slaby [EMAIL PROTECTED] Sat, 18 Aug

[PATCH 4/4 #2] Net: mac80211, remove bitfields from struct ieee80211_sub_if_data

mac80211, remove bitfields from struct ieee80211_sub_if_data Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 44b3d1f3d0bd6a9a02d2a1383a4d9c91ce897c68 tree f5566b0211375a426080487d32eeab228b264b0e parent 5d3b17704c1cb1d8c8ff45f72282918f89e1d5c0 author Jiri Slaby [EMAIL PROTECTED] Sat, 18

[PATCH 4/9] s2io, rename BIT macro

s2io, rename BIT macro BIT macro will be global definiton of (1x) Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 0d66c4337fec02f0b9bd1c1fd783b60fbab5438b tree c2027e1c366255dbec6ae061aed2c5cf809232b0 parent 6aec5d2e526e319488e6cdd627ca370086d458df author Jiri Slaby [EMAIL PROTECTED] Wed

[PATCH 8/9] define global BIT macro

define global BIT macro move all local BIT defines to the new globally define macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 19b14b967521eda7011bd70891bbe5044882d739 tree cd49de4f9f8d991ee7af22037a86978ea227abb8 parent fef5bcc8e5a7bfd66920df6d02c3448314dfe4b2 author Jiri Slaby

Re: [PATCH 8/9] define global BIT macro

Randy Dunlap napsal(a): On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: define global BIT macro move all local BIT defines to the new globally define macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- include/linux/bitops.h |1 + include/video

[PATCH 2/2] Net: ath5k, remove sysctls

ath5k, remove sysctls Syscalls were buggy and defunct in later kernels (due to sysctl check). Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 069bfbe93facb3468f579568434d18f1268a487c tree 87c19ebf2c91d9fb07f1847adcb6098f2235eaaa parent b01c0e9a02b248c3e2f2923da9728ba2c3961dee author Jiri

Re: [PATCH -mm] ath5k: remove sysctl(2) support

! -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] Net: ath5k, use short preamble for some rates

ath5k, use short preamble for some rates 2, 5.5 and 11 in b/g are now in short preamble mode Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- commit 0a11d301ccb5caf1c9738a7307002a5295aecd58 tree f812c3fb91651437c7b434afbd4f8dc8435611f0 parent

[PATCH 4/4] Net: ath5k, remove some ieee80211 re-defines

ath5k, remove some ieee80211 re-defines use mac80211 defines directly instead. this means MODULATION_* to IEEE80211_RATE_* switch. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- commit c858c1b27bfb4c58c9ebfa24de0d6442e364db97 tree 1add137b1e95ca1b4905441b5e30c779f8801c36

[PATCH 1/1] MAINTAINERS, order NETERION alphabetically

MAINTAINERS, order NETERION alphabetically Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit f5f10b061961546a77300f3ebe92abd9cb5b9b48 tree 90ad6e22504aeaadb17309d01996eb6cd7eb5a93 parent c858c1b27bfb4c58c9ebfa24de0d6442e364db97 author Jiri Slaby [EMAIL PROTECTED] Sat, 25 Aug 2007 09:39:05

Re: [PATCH 3/4] Net: ath5k, use short preamble for some rates

Johannes Berg napsal(a): On Sat, 2007-08-25 at 03:58 -0400, Jiri Slaby wrote: ath5k, use short preamble for some rates 2, 5.5 and 11 in b/g are now in short preamble mode umm, mac80211 needs to be able to choose depending on the network. Hmm, misleading log comment. It should be 'can now

[PATCH 2/5] Net: ath5k, switch to ioread/iowrite

ath5k, switch to ioread/iowrite Do not use readl/writel, since iomap retval is platform dependent and needn't be virtual address awaited by readl/writel. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 64b9d0578668fe8c7a43eadace673bc3e57fc22b tree 4990ed95e4112d79830d306ab6ae7afb2235f190

[PATCH 3/5] Net: ath5k, use int as retval

ath5k, use int as retval Convert some functions to return int and proper negative return value on error as we are used to. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470 tree 44cd0736147325e35c32274eb53bd543fb1510a9 parent

[PATCH 4/5] Net: ath5k, license is GPLv2

ath5k, license is GPLv2 The files are available only under GPLv2 since now. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 330c2ab9a53ddce27003218bd546034e8eeeff17 tree b24cecd991fbe3046d5c5269c61e0090427e4fd3 parent ceeaf6b9aac9daaa41ec38fbba3d2c1972af4470 author Jiri Slaby [EMAIL

[PATCH 5/5] Net: ath5k, kconfig changes

ath5k, kconfig changes - build 5120, 5111 and 5112 optionally - alter Kconfig text Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit 0902114e92b19bc080780f21f98807688244fc8f tree d7b4a039e4d14ae73faf1b33907c38825d198461 parent 330c2ab9a53ddce27003218bd546034e8eeeff17 author Jiri Slaby

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

On 8/29/07, Johannes Berg [EMAIL PROTECTED] wrote: On Tue, 2007-08-28 at 12:00 -0400, Jiri Slaby wrote: The files are available only under GPLv2 since now. Since the BSD people are already getting upset about (for various reasons among which seem to be a clear non-understanding) I'd suggest

2.6.23-rc4-mm1: e1000e napi lockup

Hi, I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver. napi_disable(adapter-napi) in e1000_probe freezes the kernel on boot. regards, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe

[PATCH 1/2] remove asm/bitops.h includes

remove asm/bitops.h includes including asm/bitops directly may cause compile errors. don't include it and include linux/bitops instead. next patch will deny including asm header directly. Cc: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit

Re: 2.6.23-rc4-mm1: e1000e napi lockup

On 09/07/2007 09:19 AM, Jiri Slaby wrote: Hi, I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver. napi_disable(adapter-napi) in e1000_probe freezes the kernel on boot. Ok, after these changes: diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index

Re: 2.6.23-rc4-mm1: e1000e napi lockup

Kok, Auke napsal(a): Jiri Slaby wrote: I still have problems with the driver. When I do `ip link set eth0 up', ksoftirq runs with 100 % cpu time, so I think you endlessly re-schedule some timer (or the new napi layer?) something changed in the logic and e1000e apparently does something

Re: [PATCH] [-MM, FIX V4] e1000e: incorporate napi_struct changes from net-2.6.24.git

] kthread+0x4d/0x80 [8020caf8] child_rip+0xa/0x12 [8024db70] kthread+0x0/0x80 [8020caee] child_rip+0x0/0x12 regards, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [-MM, FIX V4] e1000e: incorporate napi_struct changes from net-2.6.24.git

On 09/17/2007 06:29 PM, Kok, Auke wrote: Jiri Slaby wrote: On 12/23/-28158 08:59 PM, Auke Kok wrote: This incorporates the new napi_struct changes into e1000e. Included bugfix for ifdown hang from Krishna Kumar for e1000. Disabling polling is no longer needed at init time, so remove

/proc/net/ bad hard links count [Was: 2.6.23-rc8-mm2]

-xr-xr-x) Uid: (0/root) Gid: (0/root) Access: 2007-09-28 18:26:48.813048220 +0200 Modify: 2007-09-28 18:26:48.813048220 +0200 Change: 2007-09-28 18:26:48.813048220 +0200 hmm, this is some kind of weirdness :) regards, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics

[PATCH 1/5] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

ibm_newemac, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- commit aefcf0f6b6ab925184e7cebff8b609e4da1f5c0d tree 9e1e6240f26c759826959e8812885726c520019d parent

[PATCH 5/5] Net: sunrpc, remove SPIN_LOCK_UNLOCKED

sunrpc, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit d5e782e62a4fe2663a012571c345d9887b02 tree b993038b020d8c619f6ffdad412fbb992c073513 parent 828042d12cc0aa515e049889aa76d4066df100c0 author

sock_valbool_flag is required by VMware

(). Is this their business (and they should use sock_set_flag/sock_reset_flag) or should this be reverted? thanks, -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: namespace support requires network modules to say GPL

On 12/02/2007 12:13 AM, Eric W. Biederman wrote: Mark Lord [EMAIL PROTECTED] writes: Fine. But all of them want to call sk_alloc(), network drivers should be calling sk_alloc less then they should call dev_get_by_. Only protocols call sk_alloc. and many want to do register_netdev().

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150 [ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp bf87a690 error 4 in wpa_supplicant[8048000+4c000] [ 406.277199] wpa_supplicant[4384]: segfault at 30 ip 080697ca sp

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

On 02/04/2008 10:52 PM, Dan Williams wrote: On Mon, 2008-02-04 at 22:34 +0100, Oliver Pinter wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: ioctl[SIOCSIWAUTH]: Operation not supported WEXT auth param 4 value 0x0 - bind

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

On 02/04/2008 10:40 PM, Oliver Pinter wrote: On 2/4/08, Oliver Pinter [EMAIL PROTECTED] wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: [ 413.118874] wpa_supplicant[4388]: segfault at 30 ip 080697ca sp bfc9cab0 error 4

Re: [BUG] bad address in twothirdsMD4Transform

On 02/11/2008 08:42 PM, Matt Mackall wrote: BUG: unable to handle kernel paging request at 8102366213f8 IP: [803558f4] twothirdsMD4Transform+0xc4/0x3b0 You should mention what kernel you're using. Kernel version is in the bug below modules and above registers. This bug is only

[BUG] bad address in twothirdsMD4Transform

Hi, I get this with 32 bit Firefox 3b2 and java 1.6.0_03 on 64 bit: BUG: unable to handle kernel paging request at 8102366213f8 IP: [803558f4] twothirdsMD4Transform+0xc4/0x3b0 PGD 8063 PUD 0 Oops: [1] SMP last sysfs file: /sys/devices/virtual/net/tun0/statistics/collisions CPU

[patch added to the 3.12 stable tree] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3, 5}

...@davemloft.net Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/net/ethernet/amd/pcnet32.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 2d8e28819779..048743573230

Re: v3.12-stable-queue build errors

On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of function 'dev_consume_skb_any'

[PATCH 3.12 04/83] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3, 5}

-by: Jiri Slaby jsl...@suse.cz --- drivers/net/ethernet/amd/pcnet32.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 2d8e28819779..048743573230 100644 --- a/drivers/net

Re: v3.12-stable-queue build errors

On 04/27/2015, 06:25 PM, David Miller wrote: From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 27 Apr 2015 10:35:51 -0500 Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c

[PATCH 1/1] bna: remove obsolete use of EXTRA_CFLAGS

EXTRA_CFLAGS should be used on the command line only. Since EXTRA_CFLAGS here add only a non-existant path to compiler include paths (by -I), remove EXTRA_CFLAGS completely. Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/net/ethernet/brocade/bna/Makefile | 2 -- 1 file changed, 2

Re: please queue commit ac37e2515c1a for stable 3.12 - 3.18

On 06/04/2015, 10:54 PM, Michal Kubecek wrote: Hello, please queue mainline commit ac37e2515c1a (xfrm: release dst_orig in case of error in xfrm_lookup()) for stable branches 3.12, 3.14 and 3.18. It fixes a dst_entry reference leak introduced by commit f92ee61982d6 (xfrm:

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

On 10/21/2015, 04:55 PM, Punit Vara wrote: > This patch is to the ath10k/pci.h file that fixes following warning > reported by coccicheck: > > WARNING: sum of probable bitmasks, consider | > > I have replaced + with OR operator | for summing bitmasks > > Signed-off-by: Punit Vara

Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

On 10/21/2015, 04:55 PM, Punit Vara wrote: > @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void) > static int at76_remap(struct usb_device *udev) > { > int ret; > - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, > + return usb_control_msg(udev,

Re: [PATCH 3.19 and earlier] fib_rules: Fix dump_rules() not to exit early

On 10/05/2015, 07:29 PM, Roland Dreier wrote: > From: Roland Dreier > > Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across > multiple skbs") introduced a regression in "ip rule show" - it ends up > dumping the first rule over and over and never exiting,

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/05/2016, 05:40 PM, Ben Hutchings wrote: > On Tue, 2016-01-05 at 17:36 +0100, Jiri Slaby wrote: >> On 12/28/2015, 03:01 PM, Michal Kubecek wrote: >>> Recent fix "net: add length argument to >>> skb_copy_and_cs

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

On 12/28/2015, 03:01 PM, Michal Kubecek wrote: > Recent fix "net: add length argument to > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > branches, namely > > stable-3.2.y: commit 127500d724f8 > stable-3.12.y: commit 3e1ac3aafbd0 Applied this fix to 3.12. Thanks! >

[PATCH] kcm: fix /proc memory leak

is caused by a missing free in the ->release path. So fix it by providing seq_release_net as the ->release method. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Fixes: cd6e111bf5 (kcm: Add statistics and proc interfaces) Cc: "David S. Miller" <da...@davemloft.net> Cc: Tom Her

Re: [PATCH 00/33] Compile-time stack metadata validation

On 01/21/2016, 11:49 PM, Josh Poimboeuf wrote: > This is v16 of the compile-time stack metadata validation patch set, > along with proposed fixes for most of the warnings it found. It's based > on the tip/master branch. Hi, with this config:

Re: [PATCH 00/33] Compile-time stack metadata validation

On 02/12/2016, 11:36 AM, Jiri Slaby wrote: > It there some compilation flag missing? -f flags when compiling that file are: > -falign-jumps=1 > -falign-loops=1 > -fconserve-stack > -fno-asynchronous-unwind-tables > -fno-common > -fno-delete-null-pointer-checks > -fno-inli

[PATCH 3.12 28/64] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

ong Wang <cw...@twopensource.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jiri Slaby <jsl...@suse.cz> --- drivers/net/veth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 61c4044f644e..917abeae77ad 100644 ---

[patch added to 3.12-stable] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

Acked-by: Cong Wang <cw...@twopensource.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jiri Slaby <jsl...@suse.cz> --- drivers/net/veth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 61c4044f644e..9

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Cc Tejun (workqueues), Takashi (debug patch) On 01/26/2016, 12:53 PM, Dmitry Vyukov wrote: > Hello, > > I've hit the following warning while running syzkaller fuzzer: Hi, I am hitting it over and over again using syzkaller. > WARNING: CPU: 2 PID: 17409 at kernel/workqueue.c:3968 >

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

On 02/18/2016, 06:44 PM, Tejun Heo wrote: > Hello, > > Can you please do the followings? > > 1. Remove WQ_MEM_RECLAIM from the affected workqueue and see whether >the problem is reproducible. WQ_MEM_RECLAIM on anything bluetooth >doesn't make sense btw. Why is it there? > > 2. If

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

On 02/19/2016, 11:20 AM, Jiri Slaby wrote: > On 02/18/2016, 06:44 PM, Tejun Heo wrote: >> Hello, >> >> Can you please do the followings? >> >> 1. Remove WQ_MEM_RECLAIM from the affected workqueue and see whether >>the problem is reproducible. WQ_MEM_RECL

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Hello, On 03/11/2016, 06:12 PM, Tejun Heo wrote: > On Thu, Mar 03, 2016 at 10:12:01AM +0100, Jiri Slaby wrote: >> On 03/02/2016, 04:45 PM, Tejun Heo wrote: >>> On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote: >>>>> 1. didn't help, the problem persist

Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter

On 03/31/2016, 02:13 AM, Daniel Borkmann wrote: > Sasha Levin reported a suspicious rcu_dereference_protected() warning > found while fuzzing with trinity that is similar to this one: > > [ 52.765684] net/core/filter.c:2262 suspicious > rcu_dereference_protected() usage! > [ 52.765688]

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

On 03/21/2016, 04:58 PM, Jiri Slaby wrote: > Hello, > > On 03/18/2016, 09:52 PM, Tejun Heo wrote: >> On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: >>>>> I have not done that yet, but today, I see: >>>>> destroy_workqueue: name='req

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Hello, On 03/18/2016, 09:52 PM, Tejun Heo wrote: > On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: >>>> I have not done that yet, but today, I see: >>>> destroy_workqueue: name='req_hci0' pwq=88002f590300 >>>> wq->dfl_pwq=8

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

Hi, On 03/02/2016, 04:45 PM, Tejun Heo wrote: > On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote: >>> 1. didn't help, the problem persists. So I haven't applied the patch from 2. >> >> FWIW I dumped more info about the wq: >> wq->name='hci0'

[PATCH 3.12 70/76] VSOCK: do not disconnect socket when peer has shutdown SEND only

...@linux.vnet.ibm.com> Cc: Andy King <ack...@vmware.com> Cc: Dmitry Torokhov <d...@vmware.com> Cc: Jorgen Hansen <jhan...@vmware.com> Cc: Adit Ranadive <ad...@vmware.com> Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller <da...@davemloft.net> Signed-

[PATCH 3.12 30/76] cpuset: Fix potential deadlock w/ set_mems_allowed

> Cc: "David S. Miller" <da...@davemloft.net> Cc: netdev@vger.kernel.org Link: http://lkml.kernel.org/r/1381186321-4906-4-git-send-email-john.stu...@linaro.org Signed-off-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Jiri Slaby <jsl...@suse.cz> --- include/li

[patch added to 3.12-stable] VSOCK: do not disconnect socket when peer has shutdown SEND only

om> Cc: Claudio Imbrenda <imbre...@linux.vnet.ibm.com> Cc: Andy King <ack...@vmware.com> Cc: Dmitry Torokhov <d...@vmware.com> Cc: Jorgen Hansen <jhan...@vmware.com> Cc: Adit Ranadive <ad...@vmware.com> Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller <da...@davemloft

[patch added to 3.12-stable] cpuset: Fix potential deadlock w/ set_mems_allowed

;rost...@goodmis.org> Cc: "David S. Miller" <da...@davemloft.net> Cc: netdev@vger.kernel.org Link: http://lkml.kernel.org/r/1381186321-4906-4-git-send-email-john.stu...@linaro.org Signed-off-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Jiri Slaby <jsl...@suse.cz&

[PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL

In ircomm_tty_get_serial_info, struct serial_struct is memset to 0 and then some members set to 0 explicitly. Remove the latter as it is obviously superfluous. And remove the retinfo check against NULL. copy_to_user will take care of that. Part of hub6 cleanup series. Signed-off-by: Jiri Slaby

[PATCH] atm: idt77252, use setup_timer and mod_timer

jan.konia...@trustica.cz> Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Chas Williams <3ch...@gmail.com> Cc: <linux-atm-gene...@lists.sourceforge.net> Cc: <netdev@vger.kernel.org> --- drivers/atm/idt77252.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) d

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

On 09/13/2016, 05:35 PM, Tejun Heo wrote: > Hello, > > On Sat, Sep 10, 2016 at 11:33:48AM +0200, Dmitry Vyukov wrote: >> Hit the WARNING with the patch. It showed "Showing busy workqueues and >> worker pools:" after the WARNING, but then no queue info. Was it >> already destroyed and removed from

[PATCH] p54: memset(0) whole array

to memset. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Christian Lamparter <chunk...@googlemail.com> Cc: Kalle Valo <kv...@codeaurora.org> Cc: linux-wirel...@vger.kernel.org Cc: netdev@vger.kernel.org --- drivers/net/wireless/intersil/p54/fwio.c | 2 +- 1 file changed, 1 insert

UDP does not autobind on recv

knowledge is very limited in that area, so I have no idea whether that is correct at all. thanks, -- js suse labs >From 57c320998feb2e1e705a4ab6d3bbcb74c6ae65f0 Mon Sep 17 00:00:00 2001 From: Jiri Slaby <jsl...@suse.cz> Date: Sat, 22 Oct 2016 12:10:53 +0200 Subject: [PATCH] net: autobind

Re: UDP does not autobind on recv

On 10/24/2016, 03:03 PM, Eric Dumazet wrote: > On Mon, 2016-10-24 at 14:54 +0200, Jiri Slaby wrote: >> Hello, >> >> as per man 7 udp: >> In order to receive packets, the socket can be bound to >> a local address first by using bind(2). Otherwise, >>

[PATCH] net: sctp, forbid negative length

Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Vlad Yasevich <vyasev...@gmail.com> Cc: Neil Horman <nhor...@tuxdriver.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: linux-s...@vger.kernel.org Cc: netdev@vger.kernel.org --- net/sctp/socket.c | 5 - 1 file chang

[patch added to 3.12-stable] net: sctp, forbid negative length

+0x330/0x540 [] ? sctp_getsockopt_local_addrs+0x174/0xca0 [sctp] [] ? sctp_getsockopt+0x10d/0x1b0 [sctp] [] ? sock_common_getsockopt+0xb9/0x150 [] ? SyS_getsockopt+0x1a5/0x270 Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Vlad Yasevich <vyasev...@gmail.com> Cc: Neil Horman <nhor...@

  1   2   >