Re: [patch 4/8] Use menuconfig objects: SCTP

2007-05-11 Thread Vlad Yasevich
Brian Haley wrote: [EMAIL PROTECTED] wrote: diff -puN net/sctp/Kconfig~use-menuconfig-objects-sctp net/sctp/Kconfig --- a/net/sctp/Kconfig~use-menuconfig-objects-sctp +++ a/net/sctp/Kconfig @@ -2,11 +2,9 @@ # SCTP configuration # -menu SCTP Configuration (EXPERIMENTAL) -depends

Re: [PATCH net-2.6] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread Vlad Yasevich
Hi Yoshifuji-san YOSHIFUJI Hideaki / 吉藤英明 wrote: The fix for emerging security threats was overkill and it broke basic semantic of IPv6 routing header processing. We should assume RT0 (or even RT2, depends on configuration) as unknown RH type so that we - silently ignore the routing header

Re: Sending ipv6 packets from a kernel module

2007-05-21 Thread Vlad Yasevich
Neil Horman wrote: On Mon, May 21, 2007 at 02:04:33PM +0930, Anton wrote: Hi all, Please excuse me if the following question has already been asked on the mailing list, I am a little new to this. I am trying to send IPv6 packets from a kernel module. As far as I understand, I would have

Re: What test suite exists for SCTP

2007-06-05 Thread Vlad Yasevich
Paolo Galtieri wrote: Vlad, what test suite exists for SCTP? The lksctp-tools code hasn't been updated since Feb of 2006, and I was wondering whether this version is still the most useful. Thanks Hi Paolo I have a lksctp-tools tree on git.kernel.org that's up to date. We'll need to

Re: What test suite exists for SCTP

2007-06-05 Thread Vlad Yasevich
Paolo Galtieri wrote: Vlad, I'm looking for something that exercises the SCTP stack. Something that can be run against different kernel versions for comparing features and regression testing. lksctp-tools git repo is a good start. There 2 different sets of test: 1. Frame tests in

[GIT PATCHES] SCTP bugfixes

2007-06-13 Thread Vlad Yasevich
and BIC. are found in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git Vlad Yasevich (6): [SCTP]: Correctly set daddr for IPv6 sockets during peeloff [SCTP]: Allow unspecified port in sctp_bindx() [SCTP] Fix leak in sctp_getsockopt_local_addrs

Re: [IPV6] addrconf: Fix IPv6 on tuntap tunnels

2007-06-15 Thread Vlad Yasevich
Oliver Hartkopp wrote: Hallo David, hello Herbert, indeed i have some concerns about reverting the patch as i do not see that the MTU is the right thing to distinguish whether a netdevice is capable to have IPv4/IPv6. E.g. is decnet able to run IPv6? IMHO the autoconf (in any case) should

Re: [IPV6] addrconf: Fix IPv6 on tuntap tunnels

2007-06-18 Thread Vlad Yasevich
Herbert Xu wrote: On Fri, Jun 15, 2007 at 03:14:57PM -0700, David Miller wrote: No, the questions should really be: 1. Is IPV6 supported over this media type. yes: got to 2 no: stop 2. Is the device MTU = IPV6_MIN_MTU yes: continue no: stop Autoconfiguration is a

Re: [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing.

2007-06-18 Thread Vlad Yasevich
YOSHIFUJI Hideaki / 吉藤英明 wrote: IPSTATS_MIB_INHDRERRORS); @@ -465,6 +440,8 @@ looped_back: break; #ifdef CONFIG_IPV6_MIP6 case IPV6_SRCRT_TYPE_2: + if (accept_source_route 0) + goto unknown_rh;

Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate

2007-06-25 Thread Vlad Yasevich
Zach Brown wrote: I'm not sure that I've gotten either the sctp or lockdep details right, but with this patch I don't get lockdep yelling at me any more :) -- sctp: lock_sock_nested in sctp_sock_migrate sctp_sock_migrate() grabs the socket lock on a newly allocated socket while

Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate

2007-06-25 Thread Vlad Yasevich
Arjan van de Ven wrote: Vlad Yasevich wrote: Hm... This is another case of of two different sockets taking the same lock... Arjan, did this every get fixed, or is the nested locking the right solution to this? for this specific case it's ok and the nested solution is right

[GIT PATCHES] SCTP fixes

2007-06-28 Thread Vlad Yasevich
Hi David Please pull the following changes: The following changes since commit 19e6454ca778e11e81497bd87c930dc0defd03d7: David Howells (1): [AF_RXRPC]: Return the number of bytes buffered in rxrpc_send_data() are found in the git repository at:

[PATCH] IPV6: Call inet6addr_chain notifiers on link down

2007-07-03 Thread Vlad Yasevich
Currently if the link is brought down via ip link or ifconfig down, the inet6addr_chain notifiers are not called even though all the addresses are removed from the interface. This caused SCTP to add duplicate addresses to it's list. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/ipv6

Re: -ENOCOMPILE

2007-07-06 Thread Vlad Yasevich
David Miller wrote: diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index f96ed76..6496e03 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2472,6 +2472,7 @@ static int addrconf_ifdown(struct net_device *dev, int how) write_unlock_bh(idev-lock);

[PATCH updated] IPV6: Call inet6addr_chain notifiers on link down

2007-07-06 Thread Vlad Yasevich
for it. -vlad -- Currently if the link is brought down via ip link or ifconfig down, the inet6addr_chain notifiers are not called even though all the addresses are removed from the interface. This caused SCTP to add duplicate addresses to it's list. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED

Re: [PATCH] Export ip_tos2prio for module use

2005-08-31 Thread Vlad Yasevich
Ok. I'll hold off on this till the full patch is complete. Thanks -vlad Patrick McHardy wrote: Vlad Yasevich wrote: I am trying to teach SCTP about the TOS settings on a per-association basis. While trying to do that, I was using rt_tos2priority call. Everything worked great while sctp

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-14 Thread Vlad Yasevich
On Thu, 2006-09-14 at 08:39 -0700, David Stevens wrote: Alexey Kuznetsov [EMAIL PROTECTED] wrote on 09/14/2006 03:30:37 AM: Hello! No, it returns 1 (allow) if there are no filters to explicitly filter it. I wrote that code. :-) I see. It did not behave this way old

rewriting skb-truesize... good or bad idea

2006-09-29 Thread Vlad Yasevich
Hi Folks I was looking at SCTP performance problem that is a result of receive buffer exhaustion and found the we severely overcharge the receive buffer when multiple data chunks are bundled together. This bundling usually happens at retransmit time which penalizes us even more. Here is what

Re: [PATCH] Customizable TCP backoff patch

2006-10-11 Thread Vlad Yasevich
Ben Woodard wrote: diff -ru linux-2.6.18/include/net/tcp.h linux-2.6.18.new/include/net/tcp.h --- linux-2.6.18/include/net/tcp.h2006-09-19 20:42:06.0 -0700 +++ linux-2.6.18.new/include/net/tcp.h

Re: Fw: Intermittent SCTP multihoming breakage

2007-01-10 Thread Vlad Yasevich
Steve Hill wrote: On Wed, 3 Jan 2007, Sridhar Samudrala wrote: Sorry for the delay in replying. No. lksctp-developers mailing list is still the best place for SCTP related discussions. You can subscribe and look in the archives at

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Vlad Yasevich
Hi Neil I don't this is still right... @@ -746,6 +772,7 @@ static void ndisc_recv_ns(struct sk_buff *skb) int dad = ipv6_addr_any(saddr); int inc; int is_router; + int type; if (ipv6_addr_is_multicast(msg-target)) { ND_PRINTK2(KERN_WARNING @@

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Vlad Yasevich
Hi Neil Neil Horman wrote: + /* + * This is not a dad solicitation, meaning we may + * need to respond to it, if we are + * an optimistic node, go ahead, otherwise +

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-01-25 Thread Vlad Yasevich
chunk to be retransmitted as well. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/outqueue.c | 27 ++- 1 files changed, 22 insertions(+), 5 deletions(-) diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index fba567a..54d1b7f 100644 --- a/net/sctp

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-01-25 Thread Vlad Yasevich
BTW, if anyone needs a reproducer, I can provide one. -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Neil Horman wrote: On Wed, Jan 24, 2007 at 05:54:47PM -0800, Sridhar Samudrala wrote: Sec 2.1 of RFC 4429 says Unless noted otherwise, components of the IPv6 protocol stack should treat addresses in the Optimistic state equivalently to those in the Deprecated state, indicating that

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Hi Neil @@ -1027,15 +1029,17 @@ int ipv6_dev_get_saddr(struct net_device *daddr_dev, } } - /* Rule 3: Avoid deprecated address */ + /* Rule 3: Avoid deprecated and optimistic address */

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread Vlad Yasevich
Hi Neil I went through the RFC again it seems like the following is missing: Section 3.3: * (modifies section 5.4.2) The host MUST join the all-nodes multicast address and the solicited-node multicast address of the Tentative address. The host SHOULD NOT delay before sending

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Vlad Yasevich
YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman [EMAIL PROTECTED] says: diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2a7e461..46f91ee 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -830,7 +830,8

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread Vlad Yasevich
Hi Neil Neil Horman wrote: On Fri, Jan 26, 2007 at 09:13:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman [EMAIL PROTECTED] says: New patch attached with most of your suggestions incorporated. I've a few comments

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-02 Thread Vlad Yasevich
Neil Horman wrote: Ok, I'm still testing it, but heres a new patch for review. Significant changes include the addition of a CONFIG_IPV6_OPTIMISTIC_DAD option that is dependent on the inclusion of both IPPV6 and EXPERIMENTAL options, as well as a new method for redirecting packets from

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-02 Thread Vlad Yasevich
Brian Haley wrote: Hi Neil, @@ -830,7 +836,8 @@ retry: ift = !max_addresses || ipv6_count_addresses(idev) max_addresses ? ipv6_add_addr(idev, addr, tmp_plen, - ipv6_addr_type(addr)IPV6_ADDR_SCOPE_MASK, IFA_F_TEMPORARY) : NULL; +

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-02 Thread Vlad Yasevich
Neil Horman wrote: On Fri, Feb 02, 2007 at 11:46:08AM -0800, David Miller wrote: From: Neil Horman [EMAIL PROTECTED] Date: Fri, 2 Feb 2007 14:06:34 -0500 Ok, I'm still testing it, but heres a new patch for review. Significant changes include the addition of a CONFIG_IPV6_OPTIMISTIC_DAD

Re: Was change to ip_push_pending_frames intended to break udp (more specifically, WCCP?)

2006-05-22 Thread Vlad Yasevich
On Sat, 2006-05-20 at 14:04 -0700, Andrew Morton wrote: Paul P Komkoff Jr [EMAIL PROTECTED] wrote: Hello! I have a userspace application, which talks WCCP2 with cisco routers. It sends and receives UDP packets on port 2048. After I've updated my server to 2.6.16, it stopped working.

Re: Was change to ip_push_pending_frames intended to break udp (more specifically, WCCP?)

2006-05-22 Thread Vlad Yasevich
On Mon, 2006-05-22 at 11:48 -0700, Rick Jones wrote: IP id is set to 0 on unconnected sockets when the DF bit is set (path mtu discovery is enabled). Try issuing a connect() in your application and see if the ids are increasing again. ID of zero again? I thought that went away years

Re: Was change to ip_push_pending_frames intended to break udp (more specifically, WCCP?)

2006-05-22 Thread Vlad Yasevich
On Tue, 2006-05-23 at 00:21 +0400, Paul P Komkoff Jr wrote: Replying to Vlad Yasevich: /* This is only to work around buggy Windows95/2000 * VJ compression implementations. If the ID field * does not change, they drop every other packet in * a TCP stream using header

Re: [SCTP]: Always linearise packet on input

2006-10-31 Thread Vlad Yasevich
Herbert Xu wrote: Hi Sridhar: On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: I think we currently assume atleast the SCTP header and the data chunk header to be in the skb head. But we do handle skbs with data in the frag_list. Not sure about skb's with paged fragments.

Re: [SCTP]: Always linearise packet on input

2006-10-31 Thread Vlad Yasevich
Sridhar Samudrala wrote: On Tue, 2006-10-31 at 09:36 -0500, Vlad Yasevich wrote: Herbert Xu wrote: Hi Sridhar: On Mon, Oct 30, 2006 at 05:31:24PM -0800, Sridhar Samudrala wrote: I think we currently assume atleast the SCTP header and the data chunk header to be in the skb head. But we do

Re: [PATCH] warning in SCTP

2006-11-02 Thread Vlad Yasevich
in it (digest being embedded in the struct, not a pointer). Make digest a pointer to fix this warning. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index c6d93bb..5596f5d 100644 --- a/include/net/sctp/structs.h +++ b/include/net

Re: IPv6 and rt6_lookup()

2006-11-02 Thread Vlad Yasevich
Nicolas DICHTEL wrote: Hello, Suppose that a host has autoconfiguration enabled. It will take RA to autoconfigure an IPv6 address. For example, 2001:0db8:3008:c1ca:2d0:b7ff:febb:4aee/64. This host will create a route entry for this onlink prefix (dst: 2001:0db8:3008:c1ca::/64) in the MAIN

Re: [Devel] Re: Network virtualization/isolation

2006-11-30 Thread Vlad Yasevich
Daniel Lezcano wrote: Brian Haley wrote: Eric W. Biederman wrote: I think for cases across network socket namespaces it should be a matter for the rules, to decide if the connection should happen and what error code to return if the connection does not happen. There is a potential in this

Re: [SCTP] Initialization collision problem

2007-04-04 Thread Vlad Yasevich
[For SCTP questions, please use netdev or lksctp-developers list] Hi Oscar Isaula Oscar-QOI000 wrote: I ran into a problem where LKSCTP is reporting a SCTM_COMM_UP indication to the User application but is giving back a value of zero for the assoc_id. Attached are the SCTP debugs for the

Re: Bug in SCTP with SCTP_BINDX_REM_ADDR

2007-04-05 Thread Vlad Yasevich
Hi Paolo Paolo Galtieri wrote: What is happening is that the check for IPV6_ADDR_MAPPED that occurs during the add is missing when you do the remove and hence the IPv6 address is never mapped to the IPv4 address causing the lookup to fail. Below is the patch to add the necessary checks to do

[PATCH 0/2] [SCTP] a few bugfixes

2007-04-10 Thread Vlad Yasevich
Hi Dave Please consider applying the following two patches. They resolve some interesting bugs. Thanks -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] [SCTP] a few bugfixes (now with patches)

2007-04-10 Thread Vlad Yasevich
Sorry, now with the patches that follow... -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] [SCTP] Unmap v4mapped addresses during SCTP_BINDX_REM_ADDR operation.

2007-04-10 Thread Vlad Yasevich
fails. This patch unmaps the addresses on during the remove operation as well. Signed-off-by: Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net/sctp/socket.c b/net

[PATCH 1/2] [SCTP] Fix assertion (!atomic_read(sk-sk_rmem_alloc)) failed message

2007-04-10 Thread Vlad Yasevich
and lobby queue in structure sctp_ulpq. When there are date in these queue, assertion failed message is printed in inet_sock_destruct because sk_rmem_alloc of oldsk does not become 0 when socket is destroyed. Signed-off-by: Tsutomu Fujii [EMAIL PROTECTED] Signed-off-by: Vlad Yasevich [EMAIL PROTECTED

Re: [SCTP] Initialization collision problem

2007-04-11 Thread Vlad Yasevich
Hi Oscar Isaula Oscar-QOI000 wrote: I ran into a problem where LKSCTP is reporting a SCTM_COMM_UP indication to the User application but is giving back a value of zero for the assoc_id. Attached are the SCTP debugs for the period in question. A couple of things that I would like to note

[PATCH] [SCTP] Do not interleave non-fragments when in partial delivery

2007-04-18 Thread Vlad Yasevich
check the stream-id and flags which it may not be doing. 2. this clears partial delivery state from the association and results in app communication hanging. This patch is a band-aid over a much bigger problem in that we don't do stream interleave. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED

Re: [PATCH] [SCTP] Do not interleave non-fragments when in partial delivery

2007-04-18 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Wed, 18 Apr 2007 14:38:15 -0400 This is a bug fix, but done on top of 2.6.22 tree. I am trying to minimize the amount of conflict this would cause during merge by doing it this way. However, if you would rather keep all

Re: [Bugme-new] [Bug 8342] New: sctp_getsockopt_local_addrs_old() calls copy_to_user() while a spinlock is held

2007-04-23 Thread Vlad Yasevich
holding the lock is also problematic as it calls copy_to_user() Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c | 96 + 1 files changed, 60 insertions(+), 36 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index

[PATCH] [SCTP] Verify all destination ports in sctp_connectx.

2007-04-23 Thread Vlad Yasevich
to multiple different ports at once. This was reported on the sctp-impl list. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 536298c..6bfae12 100644

very strange inet_sock corruption with rpc

2007-04-25 Thread Vlad Yasevich
Hi All To support a piece of custom functionality, we needed to add 2 member to the struct inet_sock. During testing, we started seeing an interesting corruption. Following a hunch, we've completely ripped out all of our code with the exception of 5 lines that do this: diff --git

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Vlad Yasevich
Sridhar Samudrala wrote: The corruption is triggered after about 10 minutes of running the following script: nfspath = $1 localpath = $2 while true; do mount $nfspath $localpath sleep 5 cp /boot/vmlinuz $localpath sleep 5 rm $localpath/vmlinuz sleep 5

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Vlad Yasevich
Olaf Kirch wrote: On Wednesday 25 April 2007 23:03, Vlad Yasevich wrote: It looks like someone is stepping all over the inet_sock. We'll continue looking, but if anyone has any ideas of what might be going on, I'd appreciate it. This could be a socket in TIME_WAIT. A socket entering

Re: [Bugme-new] [Bug 8342] New: sctp_getsockopt_local_addrs_old() calls copy_to_user() while a spinlock is held

2007-04-26 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Mon, 23 Apr 2007 13:43:35 -0400 [PATCH] [SCTP] Fix sctp_getsockopt_local_addrs_old() to use local storage sctp_getsockopt_local_addrs_old() in net/sctp/socket.c calls copy_to_user() while the spinlock addr_lock is held

Re: [SCTP] Initialization collision problem

2007-05-01 Thread Vlad Yasevich
Of Vlad Yasevich Sent: Wednesday, April 11, 2007 9:45 AM To: Isaula Oscar-QOI000 Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [SCTP] Initialization collision problem Hi Oscar Isaula Oscar-QOI000 wrote: I ran into a problem where LKSCTP is reporting a SCTM_COMM_UP indication

Re: ARP Spoofing

2007-05-02 Thread Vlad Yasevich
Topher Fischer wrote: Does the kernel have any protection against ARP spoofing? If not, does anybody know why not? (As in, nobody has done anything, or because of A, B, and C). Thanks, If by arp spoofing you mean receiving arp replies from multiple sources and trusting all of them, then

Re: ARP Spoofing

2007-05-02 Thread Vlad Yasevich
Chris Friesen wrote: Vlad Yasevich wrote: If by arp spoofing you mean receiving arp replies from multiple sources and trusting all of them, then I haven't seen anything. I don't know the history as to why nothing has has been done. This concept is a valuable tool to allow for fast

[PATCH 0/4]: SCTP: bugfixes

2007-05-04 Thread Vlad Yasevich
Hi David This is a set of recent bufixes to SCTP. Please apply. Thanks -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] [SCTP]: Re-order SCTP initializations to avoid race with sctp_rcv()

2007-05-04 Thread Vlad Yasevich
From: Sridhar Samudrala [EMAIL PROTECTED] Signed-off-by: Sridhar Samudrala [EMAIL PROTECTED] Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/sctp.h |4 ++ net/sctp/ipv6.c | 49 net/sctp/protocol.c | 79

[PATCH 1/4] [SCTP] Verify all destination ports in sctp_connectx.

2007-05-04 Thread Vlad Yasevich
We need to make sure that all destination ports are the same, since the association really must not connect to multiple different ports at once. This was reported on the sctp-impl list. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c |8 1 files changed, 8

[PATCH 0/4]: SCTP bug fixes

2007-05-04 Thread Vlad Yasevich
[ sory for possible duplicates, mail server problems ] Hi David This a set of 4 bug fixes for SCTP. Please apply. Thanks -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 3/4] [SCTP] Set assoc_id correctly during INIT collision.

2007-05-04 Thread Vlad Yasevich
During the INIT/COOKIE-ACK collision cases, it's possible to get into a situation where the association id is not yet set at the time of the user event generation. As a result, user events have an association id set to 0 which will confuse applications. This happens if we hit case B of duplicate

[PATCH 2/4] [SCTP] Fix the SO_REUSEADDR handling to be similar to TCP

2007-05-04 Thread Vlad Yasevich
Update the SO_REUSEADDR handling to also check for listen state. This was muliple listening server sockets can't be created and they will not steal packets from each other. Reported by Paolo Galtieri [EMAIL PROTECTED] Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c | 32

[PATCH 3/4] [SCTP] Set assoc_id correctly during INIT collision.

2007-05-04 Thread Vlad Yasevich
end up trying to update the association that was created on A as a result of the (lost) INIT, but that association doesn't have the ID set yet. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/command.h |2 ++ include/net/sctp/structs.h |1 + net/sctp/associola.c

[PATCH 3/3] [SCTP] Do not include ABORT chunk header in the notification.

2007-05-09 Thread Vlad Yasevich
The socket API draft is unclear about whether to include the chunk header or not. Recent discussion on the sctp implementors mailing list clarified that the chunk header shouldn't be included, but the error parameter header still needs to be there. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED

[PATCH 2/3] [SCTP] Correctly copy addresses in sctp_copy_laddrs

2007-05-09 Thread Vlad Yasevich
I broke the non-wildcard case recently. This is to fixes it. Now, explictitly bound addresses can ge retrieved using the API. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net/sctp

[PATCH] [SCTP]: More bugfixes

2007-05-09 Thread Vlad Yasevich
Hi David This is yet more bugfixes for SCTP: [SCTP] Prevent OOPS if hmac modules didn't load [SCTP] Correctly copy addresses in sctp_copy_laddrs [SCTP] Do not include ABORT chunk header in the notification. Please apply. Thanks -vlad - To unsubscribe from this list: send

[PATCH 1/3] [SCTP] Prevent OOPS if hmac modules didn't load

2007-05-09 Thread Vlad Yasevich
SCTP was checking for NULL when trying to detect hmac allocation failure where it should have been using IS_ERR. Also, print a rate limited warning to the log telling the user what happend. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/socket.c |7 ++- 1 files changed, 6

Re: [RFC] New driver API to speed up small packets xmits

2007-05-10 Thread Vlad Yasevich
Rick Jones wrote: It is the reverse - GSO will segment one super-packet just before calling the driver so that the stack is traversed only once. In my case, I am trying to send out multiple skbs, possibly small packets, in one shot. GSO will not help for small packets. If there are small

Re: [RFC] New driver API to speed up small packets xmits

2007-05-10 Thread Vlad Yasevich
Rick Jones wrote: Vlad Yasevich wrote: Rick Jones wrote: It is the reverse - GSO will segment one super-packet just before calling the driver so that the stack is traversed only once. In my case, I am trying to send out multiple skbs, possibly small packets, in one shot. GSO will not help

Re: [RFC] New driver API to speed up small packets xmits

2007-05-10 Thread Vlad Yasevich
Ian McDonald wrote: On 5/11/07, Vlad Yasevich [EMAIL PROTECTED] wrote: May be for TCP? What about other protocols? There are other protocols?-) True, UDP, and I suppose certain modes of SCTP might be sending streams of small packets, as might TCP with TCP_NODELAY set. Do

Re: magical 552 mtu

2006-04-05 Thread Vlad Yasevich
On Tue, 2006-04-04 at 17:40 -0600, Mark Butler wrote: Rick Jones wrote: Again from RFC 791: snip Every internet destination must be able to receive a datagram of 576 octets either in one piece or in fragments to be reassembled. Hence the minimum IPv4 MTU of 68 bytes.

Question about skb clones and frag_list

2006-04-05 Thread Vlad Yasevich
Hi All I am trying to understand if it is a good idea to have cloned skbs reside on a frag_list? I've ran into a situation with SCTP, where it is possible to create infinite recursion loops by having cloned skbs reside on a frag_list. We end up in a situation where have two clones skb1 and skb2

Re: Question about skb clones and frag_list

2006-04-05 Thread Vlad Yasevich
On Wed, 2006-04-05 at 10:38 -0600, Mark Butler wrote: Vlad Yasevich wrote: Hi All I am trying to understand if it is a good idea to have cloned skbs reside on a frag_list? I've ran into a situation with SCTP, where it is possible to create infinite recursion loops by having cloned skbs

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
Steve Hill wrote: Vlad Yasevich wrote on 25 January 2007 16:33: Can you try the attached patch and let me know if the problem is fixed. You can try reducing rto_max or path_max_retrans to get the failover to happen a little faster. Sorry for the delay - I've been on vacation for the past

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
Hi Steve Steve Hill wrote: Vlad Yasevich wrote on 05 February 2007 16:39: Once you start simulating the network failure, how long do you wait? If you have not changed rto_max and path_max_retrans, you can end up waiting quite a while for the full path switchover. This will also severely

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-05 Thread Vlad Yasevich
not 100% sure. In my case, the sender if running 2.6.10-rc7 and receiver is running Ubuntu 2.6.17-10. I'll try running against a different receiver as well. -vlad Steve Hill wrote: Vlad Yasevich wrote on 05 February 2007 17:08: 1. What did you set the sinfo_timetolive to? I presume you

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-06 Thread Vlad Yasevich
Steve Hill wrote: Vlad Yasevich wrote on 05 February 2007 20:35: would you mind terribly, changing the -d $net to the -i $net, and run the script with the interface name instead? I seem to get the same failure when dropping traffic based on interface as I do when dropping based on address

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-06 Thread Vlad Yasevich
Hi Neil a few comments. sorry, just can't resist... :) @@ -2627,6 +2673,9 @@ static void addrconf_dad_completed(struct inet6_ifaddr *ifp) * Configure the address for reception. Now it is valid. */ + if (ifp-flags IFA_F_OPTIMISTIC) +

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-07 Thread Vlad Yasevich
:00 2001 From: Vlad Yasevich [EMAIL PROTECTED] Date: Wed, 7 Feb 2007 14:58:25 -0500 Subject: [PATCH] [SCTP] Strike the transport before updating rto Once we reach a poing where we exceed the max.path.retrans strike the trasport before updating the rto. This will force transport switch at the right

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-07 Thread Vlad Yasevich
Darn... and it was looking so good... diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 7b7bd44..8a1ea96 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -859,6 +859,34 @@ static int ip6_dst_lookup_tail(struct sock *sk, err =

Re: [Lksctp-developers] Fw: Intermittent SCTP multihoming breakage

2007-02-08 Thread Vlad Yasevich
Steve Hill wrote: On Wed, 7 Feb 2007, Vlad Yasevich wrote: I think I've tracked this down. Can you apply the attached patch on top of the one I posted before and re-run your test. Using the 2.6.20 kernel on the sending side with both patches applied, the problem seems to be fixed

Re: /proc/sys/net/ipv[46]/conf/ issue unsolved

2007-02-13 Thread Vlad Yasevich
Stephen Hemminger wrote: On Tue, 13 Feb 2007 15:29:04 +0200 Hasso Tepper [EMAIL PROTECTED] wrote: There is long standing issue in kernel which makes using /etc/sysctl.conf useless for boottime configuration of specific interface properties and breaks probably any software relying on

Re: /proc/sys/net/ipv[46]/conf/ issue unsolved

2007-02-13 Thread Vlad Yasevich
Neil Horman wrote: On Tue, Feb 13, 2007 at 03:29:04PM +0200, Hasso Tepper wrote: There is long standing issue in kernel which makes using /etc/sysctl.conf useless for boottime configuration of specific interface properties and breaks probably any software relying on unconditional existence of

Re: [GIT PULL] IPv6 Updates

2007-02-14 Thread Vlad Yasevich
Hi Yoshifuji-san I have a question: YOSHIFUJI Hideaki / 吉藤英明 wrote: commit bd292ad1ccbf15c72351f79d4a130dd50da81613 Author: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Thu Feb 15 02:07:27 2007 +0900 [IPV6] ADDRCONF: Register inet6_dev earlier. Allocate inet6_dev earlier to allow

Re: Fix bugs in Whether sock accept queue is full checking

2007-02-22 Thread Vlad Yasevich
David Miller wrote: From: weidong [EMAIL PROTECTED] Date: Wed, 14 Feb 2007 11:30:57 -0500 when I use linux TCP socket, and find there is a bug in function sk_acceptq_is_full(). ... Consider an example: After listen(sockfd, 1) system call, sk-sk_max_ack_backlog is set to 1. As we

Re: [NET]: Please revert disallowing zero listen queues

2007-03-09 Thread Vlad Yasevich
David Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 10:54:00 -0800 So we're not disallowing a backlog argument of zero to listen(). We'll accept that just fine, the only thing that happens is that you'll get what you ask for, that being no connections :-) I'm

[PATCH] [SCTP] Correctly reset ssthresh when restarting association

2007-03-22 Thread Vlad Yasevich
Reset ssthresh to the correct value (peer's a_rwnd) when restarting association. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/transport.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index c4699f5..4d8c2ab

[PATH 0/6] New SCTP functionality for 2.6.22

2007-03-23 Thread Vlad Yasevich
This patch series implements additional SCTP socket options. This was originally submitted too late for 2.6.21, so I am re-submitting for 2.6.22. Please consider applying. Thanks -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH 2/6] [SCTP] Implement SCTP_PARTIAL_DELIVERY_POINT option.

2007-03-23 Thread Vlad Yasevich
This option induces partial delivery to run as soon as the specified amount of data has been accumulated on the association. However, we give preference to fully reassembled messages over PD messages. In any case, window and buffer is freed up. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED

[PATCH 5/6] [SCTP] Implement sac_info field in SCTP_ASSOC_CHANGE notification.

2007-03-23 Thread Vlad Yasevich
ABORT chunks into the sac_info field and pass that to the user. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/ulpevent.h |1 + include/net/sctp/user.h |1 + net/sctp/sm_sideeffect.c| 11 +++-- net/sctp/sm_statefuns.c | 14 ++-- net/sctp

[PATCH 4/6] [SCTP] Honor flags when setting peer address parameters

2007-03-23 Thread Vlad Yasevich
Parameters only take effect when a corresponding flag bit is set and a value is specified. This means we need to check the flags in addition to checking for non-zero value. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/user.h | 15 +++-- net/sctp/socket.c

[PATCH 3/6] [SCTP]: Implement SCTP_ADDR_CONFIRMED state for ADDR_CHNAGE event

2007-03-23 Thread Vlad Yasevich
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/user.h |1 + net/sctp/associola.c| 10 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h index 9a83527..4ed7521 100644 --- a/include/net/sctp

[PATCH 6/6] [SCTP] Implement SCTP_MAX_BURST socket option.

2007-03-23 Thread Vlad Yasevich
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/constants.h |2 +- include/net/sctp/structs.h |1 + include/net/sctp/user.h |2 + net/sctp/associola.c |2 +- net/sctp/protocol.c |2 +- net/sctp/socket.c| 61

[PATCH 1/6] [SCTP] Implement SCTP_FRAGMENT_INTERLEAVE socket option

2007-03-23 Thread Vlad Yasevich
Jørgensen. Additionally, this functionality now permits multiple associations on the same endpoint to enter Partial Delivery. Applications should be extra careful, when using this functionality, to track EOR indicators. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/structs.h

Re: [Lksctp-developers] [PATCH 3/5][SCTP]: Remove multiple levels of msecs to jiffies conversions.

2006-08-22 Thread Vlad Yasevich
On Tue August 22 2006 03:22, David Miller wrote: From: Sridhar Samudrala [EMAIL PROTECTED] Date: Fri, 18 Aug 2006 11:22:37 -0700 [SCTP]: Remove multiple levels of msecs to jiffies conversions. The SCTP sysctl entries are displayed in milliseconds, but stored internally in jiffies. This

Re: [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing.

2007-07-09 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Mon, 18 Jun 2007 14:16:29 -0400 YOSHIFUJI Hideaki / wrote: IPSTATS_MIB_INHDRERRORS); @@ -465,6 +440,8 @@ looped_back: break; #ifdef CONFIG_IPV6_MIP6

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Vlad Yasevich
Rémi Denis-Courmont wrote: On Wednesday 11 July 2007 15:29:16 YOSHIFUJI Hideaki / 吉藤英明 wrote: In article [EMAIL PROTECTED] (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont [EMAIL PROTECTED] says: ICMPv6 Router Advertisements may now contain informations that is mostly of interest to

Re: [**RFC**] [IPV6]: Support RFC3542 IPV6_PKTINFO socket option.

2007-07-16 Thread Vlad Yasevich
YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. This patch is just a tentative implementation of RFC3542 IPV6_PKTINFO sticky option, and is NOT intended to be applied so far. We need to check if this is okay in RFC POV, anyway. ok. comments from just the RFC pov. diff --git

  1   2   3   4   >