[PATCH net] bnx2x: Align RX buffers

2017-04-28 Thread Scott Wood
d295378 993f0086 e93e00d0 f93f00d0 813e00d8 913f00d8 3921 913f00dc 813e00c0 e95e00c8 7d2a4a14 39490020 <7d005028> 31080001 7d00512d 40c2fff4 ---[ end trace b40fe13265ac423d ]--- Fixes: d46d132cc021 ("bnx2x: use netdev_alloc_frag()") Signed-off-by: Scott Wood <sw...@re

Re: [upstream-release] [PATCH net v3 2/4] powerpc: fsl/fman: remove fsl, fman from of_device_ids[]

2016-12-19 Thread Scott Wood
e_ids[] = { >   { >   .compatible = "fsl,qe", >   }, > - { > - .compatible= "fsl,fman", > - }, >   /* The following two are for the Freescale hypervisor */ >   { >   .name = "hypervisor&quo

Re: [upstream-release] [PATCH net 2/4] fsl/fman: arm: call of_platform_populate() for arm64 platfrom

2016-12-15 Thread Scott Wood
On 12/15/2016 07:11 AM, Madalin Bucur wrote: > From: Igal Liberman > > Signed-off-by: Igal Liberman > --- > drivers/net/ethernet/freescale/fman/fman.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-09 Thread Scott Wood
On Thu, 2016-11-10 at 04:11 +, Y.B. Lu wrote: > > > > -Original Message- > > From: Y.B. Lu > > Sent: Thursday, November 10, 2016 12:06 PM > > To: 'Scott Wood'; Ulf Hansson > > Cc: linux-mmc; Arnd Bergmann; linuxppc-...@lists.ozlabs.org; > >

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-09 Thread Scott Wood
On Wed, 2016-11-09 at 19:27 +0100, Ulf Hansson wrote: > - i2c-list > > On 9 November 2016 at 04:14, Yangbo Lu wrote: > > > > This patchset is used to fix a host version register bug in the T4240- > > R1.0-R2.0 > > eSDHC controller. To match the SoC version and revision, 15

Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-10-27 Thread Scott Wood
On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > + guts->regs = of_iomap(np, 0); > + if (!guts->regs) > + return -ENOMEM; > + > + /* Register soc device */ > + machine = of_flat_dt_get_machine_name(); > + if (machine) > + soc_dev_attr.machine =

Re: [v12, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-10-26 Thread Scott Wood
On Wed, 2016-09-21 at 14:57 +0800, Yangbo Lu wrote: > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig > new file mode 100644 > index 000..b99764c > --- /dev/null > +++ b/drivers/soc/fsl/Kconfig > @@ -0,0 +1,19 @@ > +# > +# Freescale SOC drivers > +# > + > +source

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-09-13 Thread Scott Wood
On Tue, 2016-09-13 at 07:23 +, Y.B. Lu wrote: > > > > > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > > ow...@vger.kernel.org] On Behalf Of Scott Wood > > Sent: Tuesday, September 13, 2016 7:25 AM > &

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-09-12 Thread Scott Wood
On Mon, 2016-09-12 at 06:39 +, Y.B. Lu wrote: > Hi Scott, > > Thanks for your review :) > See my comment inline. > > > > > -Original Message- > > From: Scott Wood [mailto:o...@buserror.net] > > Sent: Friday, September 09, 2016 11:47 AM >

Re: [v11, 5/8] soc: fsl: add GUTS driver for QorIQ platforms

2016-09-08 Thread Scott Wood
river to manage and access global utilities block. > Initially only reading SVR and registering soc device are supported. > Other guts accesses, such as reading RCW, should eventually be moved > into this driver as well. > > Signed-off-by: Yangbo Lu <yangbo...@nxp.com> > Signe

Re: [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems.

2016-08-02 Thread Scott Wood
On 08/02/2016 10:34 AM, arvind Yadav wrote: > > > On Tuesday 02 August 2016 01:15 PM, Arnd Bergmann wrote: >> On Monday, August 1, 2016 4:55:43 PM CEST Scott Wood wrote: >>> On 08/01/2016 02:02 AM, Arnd Bergmann wrote: >>>>> diff --git a/include/linux/

Re: [v4] Fix to avoid IS_ERR_VALUE and IS_ERR abuses on 64bit systems.

2016-08-01 Thread Scott Wood
On 08/01/2016 02:02 AM, Arnd Bergmann wrote: > On Sunday, July 31, 2016 4:48:44 PM CEST Arvind Yadav wrote: >> IS_ERR_VALUE() assumes that parameter is an unsigned long. >> It can not be used to check if 'unsigned int' is passed insted. >> Which tends to reflect an error. >> >> In 64bit

Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

2016-07-15 Thread Scott Wood
nate > > function selection for multiplexed signals,and clock control. > > > > This patch adds GUTS driver to manage and access global utilities > > block. > > > > Signed-off-by: Yangbo Lu <yangbo...@nxp.com> > > Acked-by: Scott Wood <o...@buserr

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

2016-07-07 Thread Scott Wood
On Thu, 2016-07-07 at 10:30 +0200, Arnd Bergmann wrote: > On Thursday, July 7, 2016 2:35:33 AM CEST Yangbo Lu wrote: > > > > Hi Arnd, > > > > Could you reply when you see the email? > > If your method doesn’t resolve the problem, we still want to use our old > > patchset. > > > > This guts

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

2016-06-10 Thread Scott Wood
On Thu, 2016-06-02 at 11:01 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:24:20 PM CEST Scott Wood wrote: > > On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > > > All users of this driver are PowerPC specific and the header file > > > has no bus

Re: [PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-06-10 Thread Scott Wood
On Thu, 2016-06-02 at 10:52 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:11:14 PM CEST Scott Wood wrote: > > > +#define T4240_HOST_VER ((VENDOR_V_23 << SDHCI_VENDOR_VER_SHIFT) | > > > SDHCI_SPEC_200) > > > +static const struct so

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

2016-06-10 Thread Scott Wood
On Thu, 2016-06-02 at 10:43 +0200, Arnd Bergmann wrote: > On Wednesday, June 1, 2016 8:47:22 PM CEST Scott Wood wrote: > > On Mon, 2016-05-30 at 15:15 +0200, Arnd Bergmann wrote: > > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > > > new file mode 1006

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:15 +0200, Arnd Bergmann wrote: > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > new file mode 100644 > index ..2f30698f5bcf > --- /dev/null > +++ b/drivers/soc/fsl/guts.c > @@ -0,0 +1,130 @@ > +/* > + * Freescale QorIQ Platforms GUTS Driver > +

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote: > All users of this driver are PowerPC specific and the header file > has no business in the global include/linux/ hierarchy, so move > it back before anyone starts using it on ARM. > > This reverts commit

Re: [PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-06-01 Thread Scott Wood
On Mon, 2016-05-30 at 15:16 +0200, Arnd Bergmann wrote: > This is a rewrite of an earlier patch from Yangbo Lu, adding a quirk > for the NXP QorIQ T4240 in the detection of the host device version. > > Unfortunately, this device cannot be detected using the compatible > string, as we have to

Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-05-10 Thread Scott Wood
ion.org; netdev@vger.kernel.org; Mark Rutland; > > > ulf.hans...@linaro.org; Russell King; Bhupesh Sharma; Joerg Roedel; > > > Santosh Shilimkar; Yang-Leo Li; Scott Wood; Rob Herring; Claudiu Manoil; > > > Kumar Gala; Xiaobo Xie; Qiang Zhao > > > Subject: Re: [v10, 7/7]

Re: [v9, 6/7] MAINTAINERS: add entry for Freescale SoC driver

2016-05-04 Thread Scott Wood
0644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4622,9 +4622,18 @@ F: drivers/net/ethernet/freescale/fec_ptp.c > F: drivers/net/ethernet/freescale/fec.h > F: Documentation/devicetree/bindings/net/fsl-fec.txt > > +FREESCALE SOC DRIVER > +M: Scott Woo

Re: [v7, 0/5] Fix eSDHC host version register bug

2016-04-01 Thread Scott Wood
TS driver for QorIQ platforms > dt: move guts devicetree doc out of powerpc directory > powerpc/fsl: move mpc85xx.h to include/linux/fsl > mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 Acked-by: Scott Wood <o...@buserror.net> -Scott

Re: [v6, 2/5] soc: fsl: add GUTS driver for QorIQ platforms

2016-03-19 Thread Scott Wood
On 03/09/2016 04:18 AM, Yangbo Lu wrote: > +#ifdef CONFIG_FSL_GUTS > +u32 fsl_guts_get_svr(void); > +int fsl_guts_init(void); > +#endif Don't ifdef prototypes (when not providing a stub alternative). -Scott

Re: [v6, 3/5] dt: move guts devicetree doc out of powerpc directory

2016-03-19 Thread Scott Wood
On 03/17/2016 12:06 PM, Rob Herring wrote: > On Wed, Mar 09, 2016 at 06:08:49PM +0800, Yangbo Lu wrote: >> Move guts devicetree doc to Documentation/devicetree/bindings/soc/fsl/ >> since it's used by not only PowerPC but also ARM. And add a specification >> for 'little-endian' property. >> >>

Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-03-19 Thread Scott Wood
On 03/17/2016 12:06 PM, Arnd Bergmann wrote: > On Thursday 17 March 2016 12:01:01 Rob Herring wrote: >> On Mon, Mar 14, 2016 at 05:45:43PM +0000, Scott Wood wrote: > >>>>> This makes the driver non-portable. Better identify the specific >>>>>

Re: [v6, 5/5] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-03-14 Thread Scott Wood
er...@lists.infradead.org; linux-ker...@vger.kernel.org; linux- >> c...@vger.kernel.org; linux-...@vger.kernel.org; iommu@lists.linux- >> foundation.org; netdev@vger.kernel.org; linux-...@vger.kernel.org; >> ulf.hans...@linaro.org; Zhao Qiang; Russell King; Bhupesh Sharma; Joerg >>

Re: [9/9] powerpc: optimise csum_partial() call when len is constant

2016-03-04 Thread Scott Wood
On Tue, Sep 22, 2015 at 04:34:36PM +0200, Christophe Leroy wrote: > +/* > + * computes the checksum of a memory block at buff, length len, > + * and adds in "sum" (32-bit) > + * > + * returns a 32-bit number suitable for feeding into itself > + * or csum_tcpudp_magic > + * > + * this function must

Re: [4/9] powerpc: inline ip_fast_csum()

2016-03-04 Thread Scott Wood
On Tue, Sep 22, 2015 at 04:34:25PM +0200, Christophe Leroy wrote: > @@ -137,6 +130,45 @@ static inline __wsum csum_add(__wsum csum, __wsum addend) > #endif > } > > +/* > + * This is a version of ip_compute_csum() optimized for IP headers, > + * which always checksum on 4 octet boundaries. ihl

Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround

2016-03-03 Thread Scott Wood
On 03/02/2016 10:15 AM, Igal Liberman wrote: >> -Original Message- >> From: Scott Wood [mailto:scott.w...@nxp.com] >> Sent: Tuesday, March 01, 2016 1:31 AM >> To: igal.liber...@freescale.com; netdev@vger.kernel.org >> Cc: scottw...@freescale.com; madalin.bu..

Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround

2016-02-29 Thread Scott Wood
On 02/29/2016 09:17 AM, igal.liber...@freescale.com wrote: > From: Igal Liberman > > Errata dTSEC-A003 was fixed in P4080 rev 3.0. > Prior revisions are not supported, so the workaround can be removed. > > Signed-off-by: Igal Liberman

Re: [v9, 6/6] fsl/fman: Add FMan MAC driver

2015-12-09 Thread Scott Wood
On Wed, 2015-12-09 at 04:10 -0600, Bucur Madalin-Cristian-B32716 wrote: > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > > > From: Scott Wood <scottw...@freescale.com> > > Date: Tue, 8 Dec 2015 16:44:38 -0600 > > >

Re: [v9, 6/6] fsl/fman: Add FMan MAC driver

2015-12-08 Thread Scott Wood
On Tue, 2015-12-08 at 14:18 -0600, Andy Fleming wrote: > On Thu, Dec 3, 2015 at 1:19 AM, wrote: > > From: Igal Liberman > > > > This patch adds the Ethernet MAC driver supporting the three > > different types of MACs: dTSEC, tGEC and

Re: [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection

2015-12-03 Thread Scott Wood
On Thu, 2015-12-03 at 04:02 -0600, Bucur Madalin-Cristian-B32716 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, December 02, 2015 11:41 PM > > > > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > > > Allow the selection of the transmission queue

Re: [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection

2015-12-02 Thread Scott Wood
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Allow the selection of the transmission queue based on the CPU id. Explain why. > > Signed-off-by: Madalin Bucur > --- > drivers/net/ethernet/freescale/dpaa/Kconfig | 10 ++ >

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

2015-11-10 Thread Scott Wood
On Mon, Nov 02, 2015 at 07:31:34PM +0200, Madalin Bucur wrote: > diff --git a/drivers/net/ethernet/freescale/dpaa/Makefile > b/drivers/net/ethernet/freescale/dpaa/Makefile > new file mode 100644 > index 000..3847ec7 > --- /dev/null > +++ b/drivers/net/ethernet/freescale/dpaa/Makefile > @@

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Scott Wood
On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote: > Regards, > Igal Liberman > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, October 28, 2015 11:31 PM > > To: Liberman Igal-B31950 > > Cc: netdev@vger.kernel.org;

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-28 Thread Scott Wood
On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > + > > > +struct device *fman_get_device(struct fman *fman) { > > > + return fman->dev; > > > +} > > > > Is this really necessary? > > > > Fman port needs fman->dev, fman structure is opaque, so yes, it's needed. Why is

Re: [PATCH 9/9] powerpc: optimise csum_partial() call when len is constant

2015-10-22 Thread Scott Wood
On Tue, 2015-09-22 at 16:34 +0200, Christophe Leroy wrote: > csum_partial is often called for small fixed length packets > for which it is suboptimal to use the generic csum_partial() > function. > > For instance, in my configuration, I got: > * One place calling it with constant len 4 > * Seven

Re: [PATCH 6/9] powerpc32: optimise a few instructions in csum_partial()

2015-10-22 Thread Scott Wood
On Tue, 2015-09-22 at 16:34 +0200, Christophe Leroy wrote: > r5 does contain the value to be updated, so lets use r5 all way long > for that. It makes the code more readable. > > To avoid confusion, it is better to use adde instead of addc > > The first addition is useless. Its only purpose is

Re: [PATCH 3/9] powerpc32: checksum_wrappers_64 becomes checksum_wrappers

2015-10-22 Thread Scott Wood
On Tue, 2015-09-22 at 16:34 +0200, Christophe Leroy wrote: > The powerpc64 checksum wrapper functions adds csum_and_copy_to_user() > which otherwise is implemented in include/net/checksum.h by using > csum_partial() then copy_to_user() > > Those two wrapper fonctions are also applicable to

Re: [PATCH 8/9] powerpc: simplify csum_add(a, b) in case a or b is constant 0

2015-10-22 Thread Scott Wood
On Tue, 2015-09-22 at 16:34 +0200, Christophe Leroy wrote: > Simplify csum_add(a, b) in case a or b is constant 0 > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/checksum.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [v3 1/8] devres: add devm_alloc_percpu()

2015-10-01 Thread Scott Wood
On Thu, Sep 24, 2015 at 06:00:12PM +0300, Madalin Bucur wrote: > Introduce managed counterparts for alloc_percpu() and free_percpu(). > Add devm_alloc_percpu() and devm_free_percpu() into the managed > interfaces list. > > Signed-off-by: Madalin Bucur > Tested-by:

Re: [v5, 2/6] fsl/fman: Add FMan support

2015-10-01 Thread Scott Wood
On Thu, Sep 24, 2015 at 12:10:34PM +0300, igal.liber...@freescale.com wrote: > +int fman_get_rx_extra_headroom(void) > +{ > + static bool fm_check_rx_extra_headroom; > + > + if (!fm_check_rx_extra_headroom) { > + if (fsl_fm_rx_extra_headroom > FSL_FM_RX_EXTRA_HEADROOM_MAX || >

Re: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan

2015-09-11 Thread Scott Wood
On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote: > +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is about > + * inter-processor locking only. Note, FQLOCK() is always called either > under a > + * local_irq_save() or from interrupt context - hence there's no need for

Re: [v2 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-08-24 Thread Scott Wood
On Wed, 2015-08-12 at 16:14 -0400, Roy Pledge wrote: From: Geoff Thorpe geoff.tho...@freescale.com This driver enables the Freescale DPAA 1.0 Buffer Manager block. BMan is a hardware buffer pool manager that allows accelerators connected to the SoC datapath to acquire and release buffers

Re: [v2 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-08-24 Thread Scott Wood
On Wed, Aug 12, 2015 at 04:14:49PM -0400, Roy Pledge wrote: diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index 9a500ce..d6e2204 100644 --- a/drivers/soc/fsl/qbman/bman.c +++ b/drivers/soc/fsl/qbman/bman.c @@ -165,11 +165,11 @@ static struct bman *bm_create(void

Re: [v2 00/11] Freescale DPAA QBMan Drivers

2015-08-24 Thread Scott Wood
On Wed, 2015-08-12 at 16:14 -0400, Roy Pledge wrote: The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and

Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 16:13 +0300, Claudiu Manoil wrote: From: Scott Wood scottw...@freescale.com As part of defconfig consolidation using fragments, we'd like to be able to have the same drivers enabled on 32-bit and 64-bit. Gianfar happens to only exist on 32-bit systems, and when

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: +#ifdef CONFIG_PM static void lock_tx_qs(struct gfar_private *priv) { int i; @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) for (i = 0; i

Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet

2015-07-27 Thread Scott Wood
On Fri, 2015-07-24 at 10:45 -0500, Bucur Madalin-Cristian-B32716 wrote: -Original Message- From: Joe Perches [mailto:j...@perches.com] On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: +static int __init dpa_load(void) +{ [] + err =

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote: return in_be32((void *)bm + offset); ^ [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration of function ‘out_be32’

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote: On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: --- /dev/null +++ b/drivers/soc/fsl/qbman/Kconfig @@ -0,0 +1,33 @@ +menuconfig FSL_DPA + bool Freescale DPAA support + depends on FSL_SOC || COMPILE_TEST Are you sure about

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: +#ifdef CONFIG_FSL_DPA_CHECKING +#define DPA_ASSERT(x) \ + do { \ + if (!(x)) { \ + pr_crit(ASSERT: (%s:%d) %s\n, __FILE__, __LINE__, \ +

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 15:57 -0500, Pledge Roy-R01356 wrote: On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: +#ifdef CONFIG_FSL_DPA_CHECKING +#define DPA_ASSERT(x) \ + do { \ + if (!(x)) { \ +

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-07-02 Thread Scott Wood
On Thu, 2015-07-02 at 10:32 -0500, Liberman Igal-B31950 wrote: Hi Scott, Thank you for your feedback, please take a look at my comments/questions. Regards, Igal Liberman. -Original Message- From: Wood Scott-B07421 Sent: Friday, June 26, 2015 6:55 AM To: Liberman Igal-B31950

Re: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-28 Thread Scott Wood
Why are these two parts being submitted separately? Worse, the CC list seems to be different for each part as I'm not seeing the DPAA ETH driver. -Scott On Sun, 2015-06-28 at 03:06 -0500, Liberman Igal-B31950 wrote: Hi Paul, All those exported functions are used by DPAA ETH driver, which was

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: From: Igal Liberman igal.liber...@freescale.com Add Frame Manger Driver support. This patch adds The FMan configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman

Re: [v2,1/9] fsl/fman: Add the FMan FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:33 +0300, igal.liber...@freescale.com wrote: From: Igal Liberman igal.liber...@freescale.com The FMan FLib provides the basic API used by the FMan drivers to configure and control the FMan hardware. Signed-off-by: Igal Liberman igal.liber...@freescale.com Again,

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. -Scott -- To unsubscribe from this list:

Re: [v2,3/9] fsl/fman: Add the FMan MAC FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: From: Igal Liberman igal.liber...@freescale.com The FMan MAC FLib provides basic API used by the drivers to configure and control the FMan MAC hardware. Signed-off-by: Igal Liberman igal.liber...@freescale.com ... +int

Re: [v2,4/9] fsl/fman: Add FMan MURAM support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: + struct muram_info *p_muram; No Hungarian notation. +void fm_muram_free(struct muram_info *p_muram) +{ + /* Destroy pool */ + gen_pool_destroy(p_muram-pool); + /* Unmap memory */ +

Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers

2015-06-17 Thread Scott Wood
On Wed, 2015-06-17 at 09:59 -0500, Liberman Igal-B31950 wrote: Regards, Igal Liberman. -Original Message- From: Wood Scott-B07421 Sent: Wednesday, June 10, 2015 9:54 PM To: Bucur Madalin-Cristian-B32716 Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; linuxppc-

Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers

2015-06-10 Thread Scott Wood
On Wed, 2015-06-10 at 18:21 +0300, Madalin Bucur wrote: From: Igal Liberman igal.liber...@freescale.com This patch presents the FMan Foundation Libraries (FLIB) headers. The FMan FLib provides the basic API used by the FMan drivers to configure and control the FMan hardware.

Re: [v4] QE: Move QE from arch/powerpc to drivers/soc

2015-06-01 Thread Scott Wood
On Sun, 2015-05-31 at 23:09 -0500, Zhao Qiang-B45475 wrote: On Fri, Jan 30, 2015 at 1:22PM +0800, Wood Scott wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, January 30, 2015 1:22 PM To: Zhao Qiang-B45475 Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org;

Re: [PATCH v5] QE: Move QE from arch/powerpc to drivers/soc

2015-06-01 Thread Scott Wood
On Tue, 2015-06-02 at 10:37 +0800, Zhao Qiang wrote: ls1 has qe and ls1 has arm cpu. move qe from arch/powerpc to drivers/soc/fsl to adapt to powerpc and arm Signed-off-by: Zhao Qiang b45...@freescale.com --- Changes for v2: - move code to driver/soc Changes for v3: - change

Re: [RFC,1/8] soc/fman: Add FMan MURAM support

2015-04-20 Thread Scott Wood
On Mon, 2015-04-20 at 03:58 -0500, Liberman Igal-B31950 wrote: Regards, Igal Liberman. -Original Message- From: Kumar Gala [mailto:ga...@kernel.crashing.org] Sent: Thursday, March 12, 2015 5:57 PM To: Liberman Igal-B31950 Cc: linuxppc-...@lists.ozlabs.org;

[PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-15 Thread Scott Wood
The lock acquisition in fs_ioctl() does not appear to actually be necessary, and thus is simply removed. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- This fixes the following bug: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html drivers/net/fs_enet/fs_enet-main.c |7

Re: WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Scott Wood
Rune Torgersen wrote: Scott Wood wrote: Rune Torgersen wrote: I hit the following WARN_ON when using mii-tools agains a ethernet interface using a bit-banged mii interface It looks like the kernel thinks it's in an interrupt, even though it clearly isn't from the backtrace. Presumably

Re: WARN_ON() hit in fsl bitbanged phy driver

2008-02-11 Thread Scott Wood
Rune Torgersen wrote: I hit the following WARN_ON when using mii-tools agains a ethernet interface using a bit-banged mii interface It is only diplayed once, and does not seem to impact usage at all Does somebody know what is wrong, and how to fix it? It looks like the kernel thinks it's in

Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-04 Thread Scott Wood
Doug Maxey wrote: On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote: On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote: /* input param R5 */ -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11) ... +#define H_ALL_RES_QP_EQPOEHEA_BMASK_IBM(9, 11) ... This was better

Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-01 Thread Scott Wood
On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote: /* input param R5 */ -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11) -#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12) -#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15) -#define H_ALL_RES_QP_EQEG

Re: [PATCH UCC TDM 3/3 ] Modified Documentation to explain dtsentries for TDM driver

2008-01-25 Thread Scott Wood
Aggrwal Poonam wrote: The device tree already has a brg-frequency property in qe node which is the value of BRGCLK. Yes, I'm saying it belongs as brg/clock-frequency. :-) CPM1/2 already do this. -Scott -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH UCC TDM 3/3 ] Modified Documentation to explain dts entries for TDM driver

2008-01-24 Thread Scott Wood
On Thu, Jan 24, 2008 at 10:24:13AM +0530, Poonam_Aggrwal-b10812 wrote: + ix) Baud Rate Generator (BRG) + + Required properties: + - compatible : shpuld be fsl,cpm-brg + - fsl,brg-sources : define the input clock for all 16 BRGs. The input +clock source could be 1 to 24 for CLK1 to

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Scott Wood
On Thu, Jan 24, 2008 at 10:33:47AM -0600, Timur Tabi wrote: Yes, but deciding what the UCC does might not be static. At what point do we declare, UCC5 is for eth0 and eth0 only? When the board designer decides to hook eth0 up to UCC5. If the board designer decides to hook multiple devices up

[PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-12 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Jeff, can you ack this to go through Paul's tree (assuming nothing wrong with it)? drivers/net/gianfar.c | 137 - drivers/net/gianfar.h | 13 +++- drivers/net/gianfar_ethtool.c | 41

Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file

2007-11-09 Thread Scott Wood
Sergej Stepanov wrote: We also need to change the reference to port C in fsl,mdio-pin and fsl,mdc-pin. Do you mean this: Currently defined compatibles: fsl,pq1-fec-mdio (reg is same as first resource of FEC device) - fsl,cpm2-mdio-bitbang (reg is port C registers) Properties for

Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file

2007-11-08 Thread Scott Wood
Sergej Stepanov wrote: If both mdio and mdc controlling pins are on the same processor port, one resource should be used. Otherwise, two resources are used: the 1-st - mdio, the 2-nd - mdc. How about: The first reg resource is the I/O port register block on which MDIO resides. The second reg

Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file

2007-11-06 Thread Scott Wood
On Tue, Nov 06, 2007 at 09:51:57AM +0100, Sergej Stepanov wrote: The patch updates the booting-without-of.txt-file. There is a description for the case if mdio data and clock pins are on different processor ports. It is a extending for e-mail [PATCH v3] using mii-bitbang on different

Re: [PATCH] [POWERPC] Fix fs_enet module build

2007-11-05 Thread Scott Wood
Jochen Friedrich wrote: diff --git a/drivers/net/fs_enet/Makefile b/drivers/net/fs_enet/Makefile index 02d4dc1..2f7563a 100644 --- a/drivers/net/fs_enet/Makefile +++ b/drivers/net/fs_enet/Makefile @@ -4,7 +4,15 @@ obj-$(CONFIG_FS_ENET) += fs_enet.o -obj-$(CONFIG_8xx) += mac-fec.o mac-scc.o

Re: [PATCH v2] using mii-bitbang on different processor ports

2007-10-30 Thread Scott Wood
Sergej Stepanov wrote: + if( !of_address_to_resource(np, 1, res[1])) { The spacing is still wrong. - iounmap(bitbang-dir); + if ( bitbang-mdio.dir != bitbang-mdc.dir) + iounmap(bitbang-mdio.dir); + iounmap(bitbang-mdc.dir); And here. -Scott - To

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-23 Thread Scott Wood
On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote: Are you suggesting we leave those warnings there until somebody decides to fix all the portability issues of this driver? My patch is a small and insignificant improvement and not the revolution you're asking for, but is

[PATCH] fs_enet: Update for API changes

2007-10-17 Thread Scott Wood
-- the device struct embedded in the net_device struct is not the same as the of_platform device in the private struct. 5. napi_disable/napi_enable was being called even when napi was not being used. These changes have been fixed, and napi is now on by default. Signed-off-by: Scott Wood [EMAIL

[PATCH v2 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-10-02 Thread Scott Wood
), and existing arch/powerpc boards that I wasn't able to test on for this patchset get converted (which should be even sooner). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Resent with an erroneous if (phynode) changed to if (mdionode). drivers/net/fs_enet/Kconfig|1 + drivers/net/fs_enet

[PATCH 1/9] fs_enet: Whitespace cleanup.

2007-10-01 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- This patch series applies to the net-2.6.24 branch. drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii

[PATCH 5/9] fs_enet: Align receive buffers.

2007-10-01 Thread Scott Wood
At least some hardware driven by this driver needs receive buffers to be aligned on a 16-byte boundary. This usually happens by chance, but it breaks if slab debugging is enabled. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 21

[PATCH 4/9] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-10-01 Thread Scott Wood
These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/mac-fcc.c | 25

[PATCH 3/9] fs_enet: Include linux/string.h from linux/fs_enet_pd.h

2007-10-01 Thread Scott Wood
It is needed for strstr(). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- include/linux/fs_enet_pd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h index 543cd3c..815c6f9 100644 --- a/include/linux/fs_enet_pd.h

[PATCH 8/9] fs_enet: Convert mii-bitbang to use the generic bitbang MDIO code.

2007-10-01 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/mii-bitbang.c | 270 - 1 files changed, 54 insertions(+), 216 deletions(-) diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c index 7cf132f..b8e4a73 100644

[PATCH 9/9] fs_enet: sparse fixes

2007-10-01 Thread Scott Wood
Mostly a bunch of __iomem annotations. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 18 +- drivers/net/fs_enet/fs_enet.h | 30 drivers/net/fs_enet/mac-fcc.c | 71 drivers/net

[PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-10-01 Thread Scott Wood
), and existing arch/powerpc boards that I wasn't able to test on for this patchset get converted (which should be even sooner). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/Kconfig|1 + drivers/net/fs_enet/fs_enet-main.c | 258 --- drivers

[PATCH 2/9] fs_enet: Fix build breakage.

2007-10-01 Thread Scott Wood
Commit 4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960 (Make NAPI polling independent of struct net_device objects.) introduced some build breakage in the napi rx function. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c |4 ++-- 1 files changed, 2 insertions

[PATCH 7/9] Generic bitbanged MDIO library

2007-10-01 Thread Scott Wood
Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers

[PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-09-24 Thread Scott Wood
), and existing arch/powerpc boards that I wasn't able to test on for this patchset get converted (which should be even sooner). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- Resent, with linux/of_platform.h instead of asm/of_platform.h drivers/net/fs_enet/Kconfig|1 + drivers/net/fs_enet

[PATCH 0/9] fs enet and mdio bitbang patches

2007-09-20 Thread Scott Wood
Changes since previous patchset: - Changed mdio_bitbang_ to mdiobb_, as requested. - Separated mii bitbang conversion to generic MDIO bitbang library from the of_platform conversion. - Added register read-backs to flush the writes in mdio bitbang clients. - Fixed a couple minor issues. Jeff,

[PATCH 2/9] fs_enet: Include linux/string.h from linux/fs_enet_pd.h

2007-09-20 Thread Scott Wood
It is needed for strstr(). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- include/linux/fs_enet_pd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h index 543cd3c..815c6f9 100644 --- a/include/linux/fs_enet_pd.h

[PATCH 1/9] fs_enet: Whitespace cleanup.

2007-09-20 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-bitbang.c |3 - drivers/net/fs_enet/mii-fec.c

[PATCH 8/9] fs_enet: Convert mii-bitbang to use the generic bitbang MDIO code.

2007-09-20 Thread Scott Wood
Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/mii-bitbang.c | 270 - 1 files changed, 54 insertions(+), 216 deletions(-) diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c index 2b9c44c..5732890 100644

[PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-09-20 Thread Scott Wood
), and existing arch/powerpc boards that I wasn't able to test on for this patchset get converted (which should be even sooner). Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/Kconfig|1 + drivers/net/fs_enet/fs_enet-main.c | 259 --- drivers

  1   2   >