Re: [PATCH] eeprom_93cx6: Add write support

2006-12-21 Thread Ivo van Doorn
Hi,

  This patch addes support for writing to the eeprom,
  this also moves some duplicate code into seperate functions.
 
 John: Do you want me to merge this path with the eeprom merge patch,
 and move the patch that moves rt2x00 to use this eeprom module into a
 separate patch or all these 2 patches good enough?

I shouldn't write mails while tired. Let met explain myself. ;)
eeprom_93cx6 has now 2 patches pending:
 1 - move eeprom_93cx6 out of rt2x00 and into /lib
 2 - add write support for eeprom_93cx6

Should patch 1 be split into a patch to add eeprom_93cx6
to the /lib folder and a seperate patch to remove the module
from rt2x00?

And while redoing the patch, merge patch 2 with the patch to add
eeprom_93cx6 to /lib?

Ivo
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] eeprom_93cx6: Add write support

2006-12-20 Thread Ivo Van Doorn

Hi,


This patch addes support for writing to the eeprom,
this also moves some duplicate code into seperate functions.


John: Do you want me to merge this path with the eeprom merge patch,
and move the patch that moves rt2x00 to use this eeprom module into a
separate patch or all these 2 patches good enough?

Ivo
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


EEPROM infrastructure (was: [PATCH] eeprom_93cx6: Add write support)

2006-12-15 Thread Ingo Oeser
Lennart Sorensen schrieb:
 On Wed, Dec 13, 2006 at 07:56:50PM +0100, Ivo van Doorn wrote:
  This patch addes support for writing to the eeprom,
  this also moves some duplicate code into seperate functions.
  
  Signed-off-by Ivo van Doorn [EMAIL PROTECTED]
 
 Thank you.  I will have a try with that to see if I can get that to work
 with the jsm driver.  Too bad the serial drivers don't have any
 geteeprom/seteeprom standard ioctl's the way ethtool does for network
 devices.

It might be even better to have eeprom writing infrastructure.

Many device types come with eeproms today and they implement
it per driver or subsystem. On embedded platforms these EEPROMs
might even be shared among different devices.

So it might be time to generalize this like we did with LEDs.

Any comments?

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] eeprom_93cx6: Add write support

2006-12-13 Thread Lennart Sorensen
On Wed, Dec 13, 2006 at 07:56:50PM +0100, Ivo van Doorn wrote:
 This patch addes support for writing to the eeprom,
 this also moves some duplicate code into seperate functions.
 
 Signed-off-by Ivo van Doorn [EMAIL PROTECTED]

Thank you.  I will have a try with that to see if I can get that to work
with the jsm driver.  Too bad the serial drivers don't have any
geteeprom/seteeprom standard ioctl's the way ethtool does for network
devices.

--
Len Sorensen
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html