Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-25 Thread Keiichi KII
Well.. before you can finish this work we need to decide upon what the interface to userspace will be. - The miscdev isn't appropriate Why isn't miscdev appropriate? We just shouldn't use miscdev for networking conventionally? Yes it's rather odd, especially for networking. What does the

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-25 Thread David Miller
From: Keiichi KII [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 13:02:04 +0900 Stephen Hemminger said The configuration of netconsole's looks like the configuration of routes. I think so too. So I think ioctl commands for adding/removing port and the following userland application like route(8)

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Keiichi KII
On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch: I'm going to fix my patches by following your reviews and send new patches on

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Keiichi KII
We don't really have anything that corresponds to netpoll's connections at higher levels. I'm tempted to say we should make this work more like the dummy network device. ie: modprobe netconsole -o netcon1 [params] modprobe netconsole -o netcon2 [params] The configuration of netconsole's looks

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Andrew Morton
On Tue, 24 Apr 2007 17:14:28 +0900 Keiichi KII [EMAIL PROTECTED] wrote: On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2007 01:29:02 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007 17:14:28 +0900 Keiichi KII [EMAIL PROTECTED] wrote: On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch: I'm going to fix my patches by following your reviews and send new patches on the LKML and the netdev ML in a few days. Thank you for your comments

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Keiichi KII
Please include an update to Documentation/networking/netconsole.txt OK, I update the documnet for the added functions in next patches. Thank you for your comments. -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Andrew Morton
On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch: I'm going to fix my patches by following your reviews and send new

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Matt Mackall
On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it was all getting a bit large. Here are some fixes against this patch:

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-20 Thread Stephen Hemminger
On Fri, 20 Apr 2007 13:21:10 -0500 Matt Mackall [EMAIL PROTECTED] wrote: On Fri, Apr 20, 2007 at 11:15:26AM -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 18:51:13 +0900 Keiichi KII [EMAIL PROTECTED] wrote: I started to do some cleanups and fixups here, but abandoned it when it

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-19 Thread Andrew Morton
On Wed, 18 Apr 2007 21:06:41 +0900 Keiichi KII [EMAIL PROTECTED] wrote: From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents,

[RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-18 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents, extend netcosnole to be able to use multiple netpolls. Each netpoll sends

Re: [RFC][PATCH -mm take4 2/6] support multiple logging

2007-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2007 21:06:41 +0900 Keiichi KII [EMAIL PROTECTED] wrote: From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents,