Re: Poor TCP performance with XPS enabled after scrubbing skb

2018-05-25 Thread David Miller
From: Flavio Leitner Date: Thu, 24 May 2018 16:17:29 -0300 > veth originally called skb_orphan() on veth_xmit() most probably > because there was no TX completion. Then the code got generalized to > dev_forward_skb() and later on moved to skb_scrub_packet(). > > The issue is

Re: Poor TCP performance with XPS enabled after scrubbing skb

2018-05-24 Thread Flavio Leitner
On Tue, May 15, 2018 at 02:08:09PM -0700, Eric Dumazet wrote: > > > On 05/15/2018 12:31 PM, Flavio Leitner wrote: > > Hi, > > > > There is a significant throughput issue (~50% drop) for a single TCP > > stream when the skb is scrubbed and XPS is enabled. > > > > If I turn CONFIG_XPS off, then

Re: Poor TCP performance with XPS enabled after scrubbing skb

2018-05-15 Thread Eric Dumazet
On 05/15/2018 12:31 PM, Flavio Leitner wrote: > Hi, > > There is a significant throughput issue (~50% drop) for a single TCP > stream when the skb is scrubbed and XPS is enabled. > > If I turn CONFIG_XPS off, then the issue never happens and the test > reaches line rate. The same happens if I

Poor TCP performance with XPS enabled after scrubbing skb

2018-05-15 Thread Flavio Leitner
Hi, There is a significant throughput issue (~50% drop) for a single TCP stream when the skb is scrubbed and XPS is enabled. If I turn CONFIG_XPS off, then the issue never happens and the test reaches line rate. The same happens if I echo 0 to tx-*/xps_cpus. It looks like that when the skb is