Re: bnx2 dirver's firmware images

2007-09-20 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:43, Michael Chan wrote: On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote: Are you saying that you successfully run-tested it? I've only reviewed the code. Let's resolve these issues first before testing the code. Please test these two patches. I

Re: bnx2 dirver's firmware images

2007-09-20 Thread Michael Chan
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote: Please test these two patches. I updated them according to your comments. I've only tested patch #1. It worked after some minor modifications below. plain text document attachment (linux-2.6.23- rc6.bnx2-1.patch)

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
On Tuesday 18 September 2007 21:05, Michael Chan wrote: The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. sounds reasonable. I see that bnx2 has support for unpacking gzipped

Re: bnx2 dirver's firmware images

2007-09-19 Thread Bill Davidsen
David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. The firmware in tg3 is a lot

Re: bnx2 dirver's firmware images

2007-09-19 Thread David Miller
From: Bill Davidsen [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:40:14 -0400 Is that a suggestion that the driver work differently when built as a module or built in? Absolutely. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Tue, 18 Sep 2007, Michael Chan wrote: The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. sorry didn't check, what's the license of the firmware? The firmware in tg3 is a

Re: bnx2 dirver's firmware images

2007-09-19 Thread David Miller
From: maximilian attems [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 18:33:18 +0200 we have to strip the firmware for Debian for the upcoming Lenny release. Why do you have to? The vendor has given you explicit rights to distribute it: * Firmware is: * Derived from proprietary unpublished

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
hello dave, i appreciate a lot your opinon, but please cool down. this is not a four spin on your beloved pipe. :) On Wed, Sep 19, 2007 at 09:38:32AM -0700, David Miller wrote: From: maximilian attems [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 18:33:18 +0200 we have to strip the firmware for

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Tue, 18 Sep 2007, Sam Ravnborg wrote: Anyway - if we again consider klibc I will do my best to make the build stuff as smooth as possible. Sam nitpicking mode on currently klibc has tendency to rebuild a bit too much if you touch some part of it, seen in usr/utils for the main

Re: bnx2 dirver's firmware images

2007-09-19 Thread H. Peter Anvin
maximilian attems wrote: On Tue, 18 Sep 2007, Sam Ravnborg wrote: Anyway - if we again consider klibc I will do my best to make the build stuff as smooth as possible. Sam nitpicking mode on currently klibc has tendency to rebuild a bit too much if you touch some part of it, seen

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote: Could you give a concrete example? -hpa [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c [EMAIL PROTECTED]:~/src/klibc$ make KLIBCCC usr/utils/mount_main.o KLIBCLD usr/utils/static/halt LN

Re: bnx2 dirver's firmware images

2007-09-19 Thread Sam Ravnborg
Hi Maks. On Wed, Sep 19, 2007 at 07:18:41PM +0200, maximilian attems wrote: On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote: Could you give a concrete example? -hpa [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c [EMAIL PROTECTED]:~/src/klibc$ make

Re: bnx2 dirver's firmware images

2007-09-19 Thread Michael Chan
On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) +* is stripped, 32-bit unpacked size (LE) is prepended instead */ + sz = *zbuf++; + sz = (sz 8) + *zbuf++; + sz = (sz 8) + *zbuf++; +

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:00, Michael Chan wrote: On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) +* is stripped, 32-bit unpacked size (LE) is prepended instead */ + sz = *zbuf++; +

Re: bnx2 dirver's firmware images

2007-09-19 Thread Michael Chan
On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote: Are you saying that you successfully run-tested it? I've only reviewed the code. Let's resolve these issues first before testing the code. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote: Hi Michael, In bnx2_fw.h I see the following: static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 }; static struct fw_info bnx2_rxp_fw_06 = { ... .bss= bnx2_RXP_b06FwBss, ... }; I grepped

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote: On Tuesday 18 September 2007 19:45, Michael Chan wrote: We can compress all the different sections of the firmware. Currently, we only compress the biggest chunks and the rest are uncompressed. These zeros should compress to almost

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 11:45:14 -0700 On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote: Do you have any plans to switch to request_firmware() interface, which will allow you to avoid keeping firmware in unswappable kernel memory and thus free

Re: bnx2 dirver's firmware images

2007-09-18 Thread Denys Vlasenko
On Tuesday 18 September 2007 19:45, Michael Chan wrote: We can compress all the different sections of the firmware. Currently, we only compress the biggest chunks and the rest are uncompressed. These zeros should compress to almost nothing. But I agree that the firmware is still big. You

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: H. Peter Anvin [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 11:41:34 -0700 David Miller wrote: I don't like it because it means people have to setup full initrd's in order to do network booting with such network cards. klibc could help with that, if there is interest in exploring

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. The firmware in tg3 is a lot more mature and I

Re: bnx2 dirver's firmware images

2007-09-18 Thread H. Peter Anvin
David Miller wrote: From: H. Peter Anvin [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 11:41:34 -0700 David Miller wrote: I don't like it because it means people have to setup full initrd's in order to do network booting with such network cards. klibc could help with that, if there is interest

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: H. Peter Anvin [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 12:27:04 -0700 Well, what I was referring to here, of course, was the initramfs integrated in the kernel image, so it all comes out of the kernel build tree and produces a single bootable image. The fact that part of it contains

Re: bnx2 dirver's firmware images

2007-09-18 Thread Sam Ravnborg
On Tue, Sep 18, 2007 at 01:08:10PM -0700, David Miller wrote: From: H. Peter Anvin [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 12:27:04 -0700 Well, what I was referring to here, of course, was the initramfs integrated in the kernel image, so it all comes out of the kernel build tree and

Re: bnx2 dirver's firmware images

2007-09-18 Thread H. Peter Anvin
Sam Ravnborg wrote: Except there seems to be great resistance to include userland code in the kernel as demonstrated at last KS. Or this is maybe just a single vocal person and the topic were brought up late? Anyway - if we again consider klibc I will do my best to make the build stuff as

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things

Re: bnx2 dirver's firmware images

2007-09-18 Thread Willy Tarreau
On Tue, Sep 18, 2007 at 02:31:34PM -0700, David Miller wrote: From: Willy Tarreau [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 23:30:25 +0200 On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The

Re: bnx2 dirver's firmware images

2007-09-18 Thread David Miller
From: Willy Tarreau [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 23:30:25 +0200 On Tue, Sep 18, 2007 at 12:21:50PM -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often

Re: bnx2 dirver's firmware images

2007-09-18 Thread Michael Chan
On Tue, 2007-09-18 at 23:37 +0200, Willy Tarreau wrote: Michael, doesn't a functional-yet-suboptimal firmware exist ? I mean, just the same principle as we all have kernels, boot CDs, statically built tools, etc... which run everywhere. If you have such a beast, maybe it would be a