[PATCH] [NET]: fix multicast list when cloning sockets

sets mc_list of cloned socket to NULL. Signed-off-by: Flavio Leitner [EMAIL PROTECTED] diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index fbe7714..8ee0f54 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -506,6 +506,8 @@ struct

Re: [PATCH] [NET]: fix multicast list when cloning sockets

-by: Flavio Leitner [EMAIL PROTECTED] diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index 4d54457..6b420ae 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ipv4/ip_sockglue.c @@ -625,6 +625,10 @@ static int do_ip_setsockopt(struct sock *sk, int level, { struct ip_mreqn

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

It seems patch 01 didn't make it to ovs dev mailing list, but it is available on netdev mailing list. fbl -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: OVS interface for generic networking device operation looks odd. have you considered adding new device ioctl to do this? New ioctls for networking configuration are generally

Re: [PATCH net v2] openvswitch: disable LRO

space, do the same as bridging does and call dev_disable_lro in the kernel. Signed-off-by: Jiri Benc jb...@redhat.com --- LGTM Acked-by: Flavio Leitner f...@redhat.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net-next 1/2] inet_hashinfo: remove bsocket counter

this counter and double inet_csk_get_port() calls under pressure. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Marcelo Ricardo Leitner mleit...@redhat.com Cc: Flavio Leitner f...@redhat.com --- The patch looks good to me. Acked-by: Flavio Leitner f...@redhat.com -- To unsubscribe

Re: [PATCH net-next 2/2] tcp: improve REUSEADDR/NOREUSEADDR cohabitation

(not using SO_REUSEADDR) Note this patch does not add a new sysctl, and only changes the way we try to pick port number. Signed-off-by: Eric Dumazet eduma...@google.com Cc: Marcelo Ricardo Leitner mleit...@redhat.com Cc: Flavio Leitner f...@redhat.com --- The only downside I can see

[PATCH net-next] netfilter: remove dead code

Remove __nf_conntrack_find() from headers. Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code" Signed-off-by: Flavio Leitner <f...@redhat.com> --- include/net/netfilter/nf_conntrack.h | 4 1 file changed, 4 deletions(-) diff --git a/include/net/netfilter/n

Re: [PATCH net-next] netfilter: remove dead code

On Tue, Sep 29, 2015 at 09:54:35PM -0700, David Miller wrote: > From: Florian Westphal <f...@strlen.de> > Date: Wed, 30 Sep 2015 02:45:07 +0200 > > > Flavio Leitner <f...@redhat.com> wrote: > >> Remove __nf_conntrack_find() from headers. > >> Fixes:

Re: [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

vice device") > Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of > vport") > Fixes: 6b001e682e90 ("openvswitch: Use Geneve device.") > Signed-off-by: Paolo Abeni <pab...@redhat.com> > --- LGTM and fixes the issue in my env. Acke

Cannot set ageing to zero

Hi, After the commit[1] below, we can't set ageing on a Linux bridge device to zero. It seems rocker needs the minimum value, but we can't break an old and valid Linux bridge behavior. [1] commit c62987bbd8a1a1664f99e89e3959339350a6131e Author: Scott Feldman Date: Thu

Re: Cannot set ageing to zero

On Tue, 26 Jan 2016 18:30:41 +0100 Jiri Pirko wrote: > Tue, Jan 26, 2016 at 06:26:30PM CET, f...@sysclose.org wrote: > > > >Hi, > > > >After the commit[1] below, we can't set ageing on a Linux bridge > >device to zero. It seems rocker needs the minimum value, but we > >can't

[PATCH net-next] netlink: include netnsid only when netns differs.

Don't include netns id for notifications broadcasts when the socket and the skb are in the same netns because it will be an error which can't be distinguished from a peer netns failing to allocate an id. Signed-off-by: Flavio Leitner <f...@sysclose.org> --- net/netlink/af_netlink.c | 6 +++

Re: [PATCH net] netlink: don't send unknown nsid

On Thu, Jun 01, 2017 at 10:42:13PM +0200, Nicolas Dichtel wrote: > Le 01/06/2017 à 19:02, Flavio Leitner a écrit : > > On Thu, Jun 01, 2017 at 10:00:07AM +0200, Nicolas Dichtel wrote: > >> The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a > >> n

Re: [PATCH net] netlink: don't send unknown nsid

On Mon, Jun 05, 2017 at 10:40:24AM +0200, Nicolas Dichtel wrote: > > Let me ask this instead: How do you think userspace should behave when > > netnsid allocation fails? > > > There is two ways to assign a nsid: > - manually with netlink ('ip netns set'). In this case, the error is reported >

Re: [PATCH net] netlink: don't send unknown nsid

> checked only for netns that are different from the socket netns. Thus, if > no nsid is assigned to the socket netns, NETNSA_NSID_NOT_ASSIGNED is > reported to the userland. This value is confusing and useless. > After this patch, only valid nsid are sent to userland. > > Rep

Re: [PATCH net-next] netlink: include netnsid only when netns differs.

On Wed, May 31, 2017 at 03:48:06PM +0200, Nicolas Dichtel wrote: > Le 31/05/2017 à 14:28, Flavio Leitner a écrit : > > On Wed, May 31, 2017 at 10:38:21AM +0200, Nicolas Dichtel wrote: > >> Le 30/05/2017 à 23:33, Flavio Leitner a écrit : > >>> Don't include netns i

Re: [PATCH net-next] netlink: include netnsid only when netns differs.

On Wed, May 31, 2017 at 10:38:21AM +0200, Nicolas Dichtel wrote: > Le 30/05/2017 à 23:33, Flavio Leitner a écrit : > > Don't include netns id for notifications broadcasts when the > > socket and the skb are in the same netns because it will be > > an error which can't be dist

Re: [PATCH net] netlink: don't send unknown nsid

On Thu, Jun 08, 2017 at 10:31:53AM +0200, Nicolas Dichtel wrote: > Le 07/06/2017 à 21:14, Flavio Leitner a écrit : > > Let's say the app is restarted, or another monitoring app is executed > > with enough perms. How will it identify the error condition? > Your app wants t

Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID

On Mon, 6 Nov 2017 16:16:20 +0100 Jiri Benc wrote: > On Mon, 6 Nov 2017 15:04:54 +, Colin King wrote: > > The size for IFLA_IF_NETNSID is missing from the size calculation > > because the proceeding semicolon was not removed. Fix this by removing > > the semicolon. > >

[PATCH net-next 1/3] net: export peernet2id_alloc

From: Jiri Benc It will be used by openvswitch. Signed-off-by: Jiri Benc --- net/core/net_namespace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 6cfdc7c84c48..b797832565d3 100644 ---

[PATCH net-next 0/3] Allow openvswitch to query ports in another netns.

Today Open vSwitch users are moving internal ports to other namespaces and although packets are flowing OK, the userspace daemon can't find out basic information like if the port is UP or DOWN, for instance. This patchset extends openvswitch API to retrieve the current netnsid of a port. It will

[PATCH net-next 2/3] openvswitch: reliable interface indentification in port dumps

From: Jiri Benc This patch allows reliable identification of netdevice interfaces connected to openvswitch bridges. In particular, user space queries the netdev interfaces belonging to the ports for statistics, up/down state, etc. Datapath dump needs to provide enough

[PATCH net-next 3/3] rtnetlink: use netnsid to query interface

From: Jiri Benc Currently, when an application gets netnsid from the kernel (for example as the result of RTM_GETLINK call on one end of the veth pair), it's not much useful. There's no reliable way to get to the netns fd from the netnsid, nor does any kernel API accept

Poor TCP performance with XPS enabled after scrubbing skb

Hi, There is a significant throughput issue (~50% drop) for a single TCP stream when the skb is scrubbed and XPS is enabled. If I turn CONFIG_XPS off, then the issue never happens and the test reaches line rate. The same happens if I echo 0 to tx-*/xps_cpus. It looks like that when the skb is

Re: Poor TCP performance with XPS enabled after scrubbing skb

On Tue, May 15, 2018 at 02:08:09PM -0700, Eric Dumazet wrote: > > > On 05/15/2018 12:31 PM, Flavio Leitner wrote: > > Hi, > > > > There is a significant throughput issue (~50% drop) for a single TCP > > stream when the skb is scrubbed and XPS is enabled.

Re: [PATCH] netfilter: check if the socket netns is correct.

On Thu, Sep 27, 2018 at 01:46:29PM -0700, Guenter Roeck wrote: > Hi Flavio, > > On Wed, Jun 27, 2018 at 10:34:25AM -0300, Flavio Leitner wrote: > > Netfilter assumes that if the socket is present in the skb, then > > it can be used because that reference is cle

[PATCH] Revert "openvswitch: Fix template leak in error cases."

e original problem is removed. Then 44d6e2f27328 ("net: Replace NF_CT_ASSERT() with WARN_ON().") replaced a debug assert with a WARN_ON() which is trigged now. Signed-off-by: Flavio Leitner --- net/openvswitch/conntrack.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --g