Re: [PATCH] fix integer overflow in H-TCP congestion control

[David Miller]

From: Gavin McCullagh [EMAIL PROTECTED]
Date: Wed, 25 Oct 2006 09:47:26 +0100

 When using H-TCP with a single flow on a 500Mbit connection (or less
 actually), alpha can exceed 65000, so alpha needs to be a u32.
 
 Signed-off-by: Gavin McCullagh [EMAIL PROTECTED]
 Signed-off-by: Doug Leith [EMAIL PROTECTED]

Applied, thank you.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fix integer overflow in H-TCP congestion control

[Gavin McCullagh]

When using H-TCP with a single flow on a 500Mbit connection (or less
actually), alpha can exceed 65000, so alpha needs to be a u32.

Signed-off-by: Gavin McCullagh [EMAIL PROTECTED]
Signed-off-by: Doug Leith [EMAIL PROTECTED]


diff --git a/net/ipv4/tcp_htcp.c b/net/ipv4/tcp_htcp.c
index 6edfe5e..8072b6d 100644
--- a/net/ipv4/tcp_htcp.c
+++ b/net/ipv4/tcp_htcp.c
@@ -23,7 +23,7 @@ module_param(use_bandwidth_switch, int, 
 MODULE_PARM_DESC(use_bandwidth_switch, turn on/off bandwidth switcher);
 
 struct htcp {
-   u16 alpha;  /* Fixed point arith,  7 */
+   u32 alpha;  /* Fixed point arith,  7 */
u8  beta;   /* Fixed point arith,  7 */
u8  modeswitch; /* Delay modeswitch until we had at least one 
congestion event */
u32 last_cong;  /* Time since last congestion event end */

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fix integer overflow in H-TCP congestion control

[David Miller]

Your patch doesn't apply, your email client turned the tab
characters in the patch into spaces.

Please fix and resubmit, thank you.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html