[netsniff-ng] Re: [PATCH v2 6/7] trafgen: parser: Allow to set function at field offset

2016-12-20 Thread Vadim Kochan
On Tue, Dec 20, 2016 at 12:33:47PM +0100, Tobias Klauser wrote: > On 2016-12-18 at 10:52:49 +0100, Vadim Kochan wrote: > > Extend proto field expression to: > > > > proto_field[{index}:{len}] = {func} > > I like the idea behind this very much, but I'm not particularly

[netsniff-ng] Re: [PATCH v2 6/7] trafgen: parser: Allow to set function at field offset

2016-12-20 Thread Tobias Klauser
On 2016-12-18 at 10:52:49 +0100, Vadim Kochan wrote: > Extend proto field expression to: > > proto_field[{index}:{len}] = {func} I like the idea behind this very much, but I'm not particularly happy with the syntax of this. First, I find it a bit confusing that the

[netsniff-ng] Re: [PATCH v2 5/7] trafgen: parser: Parse IPv6 address by strict match pattern

2016-12-20 Thread Tobias Klauser
On 2016-12-18 at 10:52:48 +0100, Vadim Kochan wrote: > Used IPv6 pattern from nftables project to match valid only IPv6 > address to do not mess with MAC or other syntax patterns with ':' symbol. Please mention the nftables source where you took this from in a comment in the