Re: [netsniff-ng] [PATCH] netsniff-ng: increment the pkts_seen after packet type check

On 2016-07-21 at 16:42:22 +0200, Paolo Abeni wrote: > Currently in receive_to_xmit() pkts_seen is incremented before > after the packet type check, but failing the latter will cause > the packet to be ignored, pretty much as if it failed to pass > the filter. > This change move

Re: [netsniff-ng] packet accounting in netsniff-ng

On 2016-07-21 at 16:01:30 +0200, Paolo Abeni wrote: > Hi all, > > I have a couple of doubts about packet accounting in netsniff-ng: > currently in receive_to_xmit() pkts_seen is incremented before the > packet type check, but failing the latter will cause the packet to be >

Re: [netsniff-ng] [PATCH] netsniff-ng: skip duplicated packets on loopback device

On 2016-07-21 at 15:25:27 +0200, Paolo Abeni wrote: > When sniffing on the loopback device, each packet will be seen > twice, once per direction. To avoid duplicates, explicitly > skip OUTGOING packets received from loopback, if no packet_type > filter is explicitly set. > >

[netsniff-ng] Re: [PATCH 0/2] trafgen: Avoid to use user defined fields for csum

On 2016-07-16 at 11:39:42 +0200, Vadim Kochan wrote: > It is dangerous to use such fields like 'ihl' and 'len' when calculate csum > for IPv4 & UDP headers because these fields are set from user. Instead - > use program calculated values. > > Vadim Kochan (2): > trafgen:

[netsniff-ng] Re: [PATCH] trafgen: ipv4: Set default proto as ipv6-in-ipv4 for ipv6()

On 2016-07-15 at 22:21:05 +0200, Vadim Kochan wrote: > Set default ip proto field to IPPROTO_IPV6(41) if the higher protocol > was specified as ipv6(). > > Signed-off-by: Vadim Kochan Applied, thanks Vadim. -- You received this message because you are

[netsniff-ng] Re: [PATCH v2 0/3] trafgen: Implement ICMPv4 packet creation - part #2

On 2016-07-13 at 00:01:52 +0200, Vadim Kochan wrote: > Add ICMPv4 protocol header creating. > > Changed echorequest to echo-request, and echoreply to echo-reply > which looks more readable. > > The following ICMPv4 parameters are supported: > > type > code > csum

[netsniff-ng] Re: [PATCH 0/6] trafgen: Implement ICMPv4 packet creation

On 2016-06-29 at 11:21:24 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > Hi Tobias, > > On Sat, Apr 30, 2016 at 6:01 PM, Tobias Klauser <tklau...@distanz.ch> wrote: > > Hi Vadim > > > > Thanks for the series. I'll be travelling for a while starting tomorro

[netsniff-ng] Re: [PATCH 3/6] trafgen: parser: Split echorequest & echoreply with "-"

On 2016-04-30 at 16:39:17 +0200, Vadim Kochan wrote: > Change echorequest to echo-request, and echoreply to echo-reply > which looks more readable. > > Signed-off-by: Vadim Kochan NAK, I think it's OK the way it currently is. All other "2-word" keywords

[netsniff-ng] Re: [PATCH 1/6] trafgen: parser: Split [e]type to separate keywords

On 2016-04-30 at 16:39:15 +0200, Vadim Kochan wrote: > Split [e]etype to separate 'type' & 'etype' keywords, > the reason is that 'type' might be used in other protocol > headers (e.g. ICMP). > > Signed-off-by: Vadim Kochan Applied, thanks. -- You

[netsniff-ng] Re: [PATCH 2/6] trafgen: parser: Replace 'mtype' by 'type'

On 2016-04-30 at 16:39:16 +0200, Vadim Kochan wrote: > After splitting etype & type to different tokens it is possible > to use 'type' for ICMP type field which is used by RFC. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message

[netsniff-ng] Re: [PATCH] netsniff-ng: Create out pcap only if first packet passed

On 2016-05-16 at 18:58:21 +0200, Vadim Kochan wrote: > If all packets did not pass the filter then output pcap > file will be created with pcap header, which might be not what user > expect - to see only interested pcap files. IMO, an output file should always be created, even

Re: [netsniff-ng] [PATCH] man: netsniff-ng: Fix usage example description

On 2016-06-21 at 18:20:35 +0200, Hisao Tanabe wrote: > Fix the input device name that is used in the description of the usage > example. > > Signed-off-by: Hisao Tanabe Applied, thanks a lot. -- You received this message because you are subscribed to the

[netsniff-ng] Re: [PATCH] netsniff-ng: pcap_io: Print unsupported magic number

On 2016-05-16 at 19:32:46 +0200, Vadim Kochan wrote: > It might be more understandable to print unsupported > pcap magic number in hexadecimal format. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are

[netsniff-ng] Re: flowtop: How should be src info printed in stdout dump mode

On 2016-04-26 at 12:24:45 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > On Tue, Apr 26, 2016 at 12:00 PM, Tobias Klauser <tklau...@distanz.ch> wrote: > > On 2016-04-26 at 10:47:18 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > >> On Tue, Apr 26, 2016 at 10

[netsniff-ng] Re: [PATCH 5/8] flowtop: Remove unused args in draw_flow_entry(...)

On 2016-04-26 at 09:47:19 +0200, Vadim Kochan wrote: > Remove unused "screen" & "line" arguments in draw_flow_entry(...) > function. > > Signed-off-by: Vadim Kochan This does not really influence the rest of the series, so I already applied this, thanks.

[netsniff-ng] Re: flowtop: How should be src info printed in stdout dump mode

On 2016-04-25 at 16:55:53 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > On Mon, Apr 25, 2016 at 11:21:57AM +0200, Tobias Klauser wrote: > > On 2016-04-22 at 23:53:01 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > > > Hi, > > > > > > I

[netsniff-ng] Re: flowtop: How should be src info printed in stdout dump mode

On 2016-04-22 at 23:53:01 +0200, Vadim Kochan wrote: > Hi, > > I am thinking about to add dump of flows to stdout. It seems OK if > to use similar table format like in curses mode by default, but in case > of src peer info (2 lines per flow) the output processing by external

[netsniff-ng] Re: [PATCH v3 0/6] flowtop: Layout change to 1-row view (part #2)

On 2016-04-21 at 20:47:37 +0200, Vadim Kochan wrote: > This is a 2nd part of series about changing flowtop layout to 1-row > view. This version is mostly a refactoring of flows refreshing to > make it more generic by using UI table API. > > v3: > 1) Fixed headers including

[netsniff-ng] Re: [PATCH] flowtop: Fix compilation error when build without geoip

On 2016-04-22 at 06:05:47 +0200, Vadim Kochan wrote: > Commit (f61f39d geoip: Allow to get country 3-code) added > new helpers without considering HAVE_GEOIP definition. > > Fixed by adding dummy functions for get 3-code country name > in case if HAVE_GEOIP is not defined. >

[netsniff-ng] Re: [PATCH v2 07/11] ui: Implement UI table for flows printing

On 2016-04-17 at 19:31:30 +0200, Vadim Kochan wrote: > Add new module ui.c which is responsible to render > different kinds of UI widgets - tables, etc. > > Implemented generic API for print table-like list of elements. > This table API might be used for print flows in curses

[netsniff-ng] Re: [PATCH v2 00/11] flowtop: Layout change to 1-row view

On 2016-04-17 at 19:31:23 +0200, Vadim Kochan wrote: > Changed flows list layout to look more a top-like output > with header and in 1 line. When -s option is specified > then layout changes to 2 lines view including with src peer > info and dst under it on next line. > > v2:

[netsniff-ng] Re: [PATCH 2/5] flowtop: Change flows layout to 1-row view

On 2016-03-29 at 15:32:43 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > On Tue, Mar 29, 2016 at 4:23 PM, Tobias Klauser <tklau...@distanz.ch> wrote: > > On 2016-03-23 at 22:00:44 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > >> Changed flows list l

[netsniff-ng] Re: [PATCH 2/5] flowtop: Change flows layout to 1-row view

On 2016-03-23 at 22:00:44 +0100, Vadim Kochan wrote: > Changed flows list layout to look more a top-like output > with header and in 1 line. When -s option is specified > then layout changes to 2 lines view including with src peer > info and dst under it on next line. > > Also

[netsniff-ng] [ANNOUNCE] netsniff-ng 0.6.1

) Fix download of GeoIP databases so the files don't get corrupted. From Tobias Klauser. Contributions since last release: 64 Vadim Kochan 49 Tobias Klauser 1 Thomas Fleischmann 1 Reiner Herrmann 1 Erik Bengtsson 1 Daniel Borkmann Git changelog since last

[netsniff-ng] Re: flowtop: Flows visual separating

On 2016-02-25 at 17:35:56 +0100, Vadim Kochan wrote: > On Sat, Feb 20, 2016 at 8:47 PM, Vadim Kochan wrote: > > On Sat, Feb 20, 2016 at 7:49 PM, Daniel Borkmann > > wrote: > >> Hi Vadim, > >> > >> thanks for looking into this,

[netsniff-ng] Re: [PATCH v2 0/4] trafgen: Add MPLS header creating

On 2016-02-23 at 13:38:42 +0100, Vadim Kochan wrote: > Thanks! > > So icmpv4 will appear in next version, I have patches but need to rebase them. That'd be great if you could send them once the tree is open again, thanks. -- You received this message because you are

[netsniff-ng] [ANNOUNCE] Tree closed for new features until v0.6.1 release

As previously announced in the last release message [1], we slightly changed our development model to do releases a bit more often and to ditch the -rc releases. [1] http://thread.gmane.org/gmane.linux.network.netsniff-ng/1258 In that vein, we'd like to close the tree for new features as of

[netsniff-ng] Re: [PATCH 0/7] trafgen: Add VLAN header creating

On 2016-02-02 at 17:27:26 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Tue, Feb 2, 2016 at 6:20 PM, Vadim Kochan <vadi...@gmail.com> wrote: > > On Tue, Feb 2, 2016 at 5:54 PM, Tobias Klauser <tklau...@distanz.ch> wrote: > >> On 2016-02-01 at 18:01:34 +0

Re: [netsniff-ng] Replay pcap file on Xenomai kernel in real time

On 2016-02-01 at 15:38:28 +0100, Umair Ali wrote: > Thanks a lot for the help offer. I can understand what you want to say. > > I need your feedback on the code which I have written. The flow of the code > is as follows > - Reader the pcap file. the pcap file contained the

Re: [netsniff-ng] Synchronize file creation between netsniff-ng processes possible?

On 2016-01-28 at 22:04:45 +0100, e.bengts...@gmail.com wrote: > Sounds good. Thanks! Patch now applied, thanks a lot Erik! Tobias -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop

[netsniff-ng] Re: [PATCH v3 00/16] trafgen: Add proto header generation

On 2016-01-26 at 21:24:56 +0100, Vadim Kochan wrote: > Add new trafgen proto generation framework which allows to describe > proto header fields and easy build the proto header by set/get proto > header fields value. > > Meanwhile implemented Ethernet, ARP, IPv4 & UDP proto

Re: [netsniff-ng] Synchronize file creation between netsniff-ng processes possible?

On 2016-01-28 at 13:17:30 +0100, e.bengts...@gmail.com <e.bengts...@gmail.com> wrote: > > > Den onsdag 27 januari 2016 kl. 18:02:23 UTC+1 skrev e.ben...@gmail.com: > > > > > > > > Den onsdag 27 januari 2016 kl. 16:17:46 UTC+1 skrev Tobias Klauser: >

[netsniff-ng] Re: [PATCH 0/4] trafgen: Add IPv4 and UDP protocol generation

On 2016-01-28 at 23:06:23 +0100, Vadim Kochan wrote: > Reworded commit message of 12-14 patches from series: > > "[PATCH v3 00/16] trafgen: Add proto header generation" > > 1) Added parameters & default values description. > 2) Functionality was not changed. Perfect,

Re: [netsniff-ng] Replay pcap file on Xenomai kernel in real time

Hi Ali On 2016-01-27 at 13:01:55 +0100, Umair Ali wrote: > Hello there, > > I am working on the project of replaying the pcap files in the real time over > the network. For this purpose I am using the real time Linux kernel 'Xenomai > v 3.0.1'. My idea is to write a code in

Re: [netsniff-ng] Replay pcap file on Xenomai kernel in real time

On 2016-01-27 at 15:15:01 +0100, Umair Ali wrote: > Hi Tobias, > > Thanks for the quick reply. I have read pcap_mm.c file but cannot understand > the flow of the code. Can you explain me the flow that once the pcap file is > open using mmap then how it is further processed to

Re: [netsniff-ng] Synchronize file creation between netsniff-ng processes possible?

Hi again On 2016-01-27 at 16:10:30 +0100, Tobias Klauser <tklau...@distanz.ch> wrote: > On 2016-01-27 at 14:40:55 +0100, Erik Bengtsson <e.bengts...@gmail.com> wrote: > > By "start time" I mean file creation time. It is totally possible to post > > process all

[netsniff-ng] Re: [PATCH v2 11/16] trafgen: parser: Add syntax to generate ARP header fields

On 2016-01-26 at 09:47:32 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Tue, Jan 26, 2016 at 10:25 AM, Tobias Klauser <tklau...@distanz.ch> wrote: > > On 2016-01-26 at 00:11:53 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > >> Add syntax to generate AR

[netsniff-ng] Re: [PATCH v2 15/16] trafgen: parser: Add syntax to build UDP header

On 2016-01-26 at 00:11:57 +0100, Vadim Kochan wrote: > Added trafgen syntax to set UDP header fields: > > { udp(sport=111, dport=222) } > > Signed-off-by: Vadim Kochan > --- > trafgen_lexer.l | 4 > trafgen_parser.y | 29

[netsniff-ng] Re: [PATCH v2 03/16] trafgen: Add basic proto generation logic

On 2016-01-26 at 00:11:45 +0100, Vadim Kochan wrote: [...] > +void proto_header_init(enum proto_id pid) > +{ > + struct proto_hdr *hdr = proto_header_by_id(pid); > + struct proto_hdr *new; > + > + if (headers_count >= PROTO_MAX_LAYERS) > + panic("Too

[netsniff-ng] Re: [PATCH 00/13] trafgen: Add proto header generation

On 2016-01-25 at 10:06:04 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Mon, Jan 25, 2016 at 09:56:37AM +0100, Tobias Klauser wrote: > > On 2016-01-21 at 00:19:48 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > Add new trafgen proto generation fram

[netsniff-ng] Re: [PATCH 10/13] trafgen: l2: Add ARP header generation logic

On 2016-01-21 at 00:19:58 +0100, Vadim Kochan wrote: > Add ARP proto header fields generation via src mac, src ip, > dst mac, dst ip & operaion. > > By default Ethernet proto will be initialized, and ARP probe > request is filled. > > Signed-off-by: Vadim Kochan

[netsniff-ng] Re: [PATCH 13/13] trafgen: parser: Add syntax for IPv4 proto

On 2016-01-21 at 00:20:01 +0100, Vadim Kochan wrote: > Add syntax to specify IPv4 header fields: > > { ip(df, mf, frag=100, prot=0x1, ecn=2, dscp=20) } > > Signed-off-by: Vadim Kochan > --- > trafgen_lexer.l | 15 +++ > trafgen_parser.y |

[netsniff-ng] Re: [PATCH 0/2] trafgen: Small changes for unit parsing (gap, ring size)

On 2016-01-14 at 00:22:39 +0100, Vadim Kochan wrote: > Small simplification of unit parsing for gap & ring size option by using > strtoul for setting start of unit name instead of checking it char by char. > > Vadim Kochan (2): > trafgen: Simplify 'gap' option unit parsing >

[netsniff-ng] Re: [PATCH] trafgen: Move gap feature into shaper logic

On 2016-01-07 at 07:34:46 +0100, Vadim Kochan wrote: > Move gap feature into rate shaper, as these features > means the same - delay the packet sending. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are

[netsniff-ng] Re: [PATCH 1/2] flowtop: Use one func to update flow entry

On 2016-01-05 at 20:42:39 +0100, Vadim Kochan wrote: > Seems there is no need to have 2 separate handlers > for the flow updating, so use one which was used > for flow refreshing. Significant change is that new entry > will be not added if it was not found in the list, but such

[netsniff-ng] Re: [PATCH 2/2] flowtop: Use one nfct handle for dump & refresh flows

On 2016-01-05 at 20:42:40 +0100, Vadim Kochan wrote: > Simplify dump & flows refreshing via one nfct handle, which is enough. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribed to the Google Groups

[netsniff-ng] Re: [PATCH v2] trafgen: Add option to specify packets sending rate

On 2015-12-28 at 10:19:12 +0100, Vadim Kochan wrote: > On Fri, Dec 25, 2015 at 03:19:59AM +0200, Vadim Kochan wrote: > > On Wed, Dec 23, 2015 at 10:58:32PM +0200, Vadim Kochan wrote: > > > On Wed, Dec 23, 2015 at 10:31:23PM +0200, Vadim Kochan wrote: > > > > Added -b,--rate

[netsniff-ng] Re: [PATCH 0/3] flowtop: Misc updates: filter state, refresh flag reset

On 2015-12-16 at 21:12:06 +0100, Vadim Kochan wrote: > There are just few different changes like: > 1) Show family in filter status bar > 2) Show if 'Active' flows mode is selected in filter status bar > 3) Reset do_refresh flag immideately if it is enabled to make

[netsniff-ng] Re: [PATCH v4 1/6] proc: Add function to execute process with argv list

On 2015-12-15 at 22:09:10 +0100, Vadim Kochan wrote: > Add proc_exec function which executes given process with > argv list via fork + execvp. > > It allows to replace 'system' call approach which is used > for invoking cpp and securely extend it with additional options > like

[netsniff-ng] Re: [PATCH v4 1/6] proc: Add function to execute process with argv list

On 2015-12-16 at 10:05:33 +0100, vkochan <vadi...@gmail.com> wrote: > Hi, > > On Wed, Dec 16, 2015 at 09:34:28AM +0100, Tobias Klauser wrote: > > On 2015-12-15 at 22:09:10 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > Add proc_exec function which execute

[netsniff-ng] Re: [PATCH 1/4] netsniff-ng: nlmsg: Resolve genl family name

On 2015-11-30 at 01:05:04 +0100, Vadim Kochan wrote: > Print name of resolved genl family name by type This patch does quite a bit more than the description says (i.e. the init/uninit hooks). Please be a bit more verbose in your patch descriptions. > Signed-off-by: Vadim

[netsniff-ng] Re: [PATCH v2] bpfc, trafgen: Allow to pass C preprocessor macro/define

On 2015-12-01 at 23:04:18 +0100, Vadim Kochan wrote: > Add -D option for bpfc & trafgen to make possible pass -Dkey=value > to C preprocessor. Characters like .?*()[]-^|`!#$&<>;\ are quoted > to do not trick with shell's special symbols (e.g. process spawning), > \ is ignored

[netsniff-ng] Re: [PATCH 2/5] cpp: Allow to pass cpp arguments

On 2015-11-29 at 13:42:43 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Wed, Nov 25, 2015 at 10:31:28AM +0100, Tobias Klauser wrote: > > On 2015-11-25 at 00:51:48 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > Extend cpp_exec func to pass cpp arguments >

[netsniff-ng] Re: [PATCH] netsniff-ng: nlmsg: Print genl ops & mcast groups attributes

On 2015-11-27 at 08:58:39 +0100, Vadim Kochan wrote: > Dump Generic netlink ops & mcast groups nested attributes. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribed to the Google Groups "netsniff-ng"

[netsniff-ng] Re: [PATCH v2] flowtop: Add runtime commands to filter flows by proto

On 2015-11-22 at 10:39:06 +0100, Vadim Kochan wrote: > Add U/T/I/D/S runtime commands (same like for command line) > to filter flows by UDP/TCP/ICMP/DCCP/SCTP proto. > > Signed-off-by: Vadim Kochan Applied now, thanks. -- You received this message

[netsniff-ng] Re: [PATCH 4/4] cpp: Use /tmp folder for output files

On 2015-11-19 at 05:07:49 +0100, Vadim Kochan wrote: > There might be a case when input file is located > in read-only directory and cpp fails when it tries to > create output file there, so use /tmp folder for that > as usually it should be writeable for any user. > >

[netsniff-ng] Re: [PATCH 2/4] bpfc: Invoke C preprocessor from cpp.c module

On 2015-11-19 at 05:07:47 +0100, Vadim Kochan wrote: > Use cpp_process func from cpp.c module to invoke > C preprocessor. > > Signed-off-by: Vadim Kochan LGTM, please resend along with adjustments v2 of patch 1/4. -- You received this message because you

[netsniff-ng] Re: [PATCH 2/2] flowtop: Add runtime commands to show TCP/UDP/DCCP/ICMP/SCTP

On 2015-11-12 at 07:54:19 +0100, Vadim Kochan wrote: > Now it is possible toggle display TCP/UDP/DCCP/ICMP/SCTP protos > by the same char keys as short command line options - T/U/D/I/S. > > Signed-off-by: Vadim Kochan > --- > flowtop.c | 69 >

[netsniff-ng] Re: [PATCH] bpfc: Do not panic if bpf file is not valid

On 2015-11-15 at 22:16:37 +0100, Vadim Kochan wrote: > If bpf file is not valid then cpp generated file is not > deleted because panic() func is invoked. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are

[netsniff-ng] Re: [PATCH] netsniff-ng: Allow to specify compiled BPF from stdin

On 2015-11-10 at 09:18:18 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Tue, Nov 10, 2015 at 09:06:17AM +0100, Tobias Klauser wrote: > > On 2015-11-10 at 07:29:12 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > Allow read compiled BPF instructions f

[netsniff-ng] Re: [PATCH v2] netsniff-ng: Allow to specify compiled BPF from stdin

On 2015-11-10 at 09:28:08 +0100, Vadim Kochan wrote: > Allow read compiled BPF instructions from stdin by via '-f -' option. > > Signed-off-by: Vadim Kochan Applied, thanks! -- You received this message because you are subscribed to the Google Groups

[netsniff-ng] Re: [PATCH] bpfc, trafgen: Do not close stdin when "-" is specified

On 2015-11-10 at 09:53:33 +0100, Vadim Kochan wrote: > Do not perform fclose for stdin fd. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe

[netsniff-ng] Re: [PATCH 2/2] trafgen: Allow to build packet from command line

On 2015-11-07 at 15:55:16 +0100, Vadim Kochan wrote: > Craft packet direct from command line with same syntax as for conf file. > It might be as first step to extend current syntax with specific proto fields. > > Signed-off-by: Vadim Kochan Nice work,

[netsniff-ng] Re: [PATCH 1/2] str: Add converting cmdline args vector to str

On 2015-11-07 at 15:55:15 +0100, Vadim Kochan wrote: > Move piece of code which converts cmdline args vector to string > from netsniff-ng.c to str.c as function. > > Signed-off-by: Vadim Kochan Applied with slightly changed function/argument names. Thanks!

[netsniff-ng] Re: [PATCH 2/3] flowtop: Add runtime command to change rate units

On 2015-11-06 at 23:23:25 +0100, Vadim Kochan wrote: > Add interactive command 'b' to change rate units to show. > > Signed-off-by: Vadim Kochan Applied, thanks Vadim! -- You received this message because you are subscribed to the Google Groups

[netsniff-ng] Re: [PATCH 1/3] flowtop: Add runtime command to show help window

On 2015-11-06 at 23:23:24 +0100, Vadim Kochan wrote: [...] > +static void draw_help(WINDOW *screen) > +{ > + int col = 0; > + int row = 0; > + int i; > + > + mvaddch(row, col, ACS_ULCORNER); > + mvaddch(rows - row - 2, col, ACS_LLCORNER); > + > +

[netsniff-ng] Re: [PATCH] flowtop: Redraw screen in 1s if no key was pressed

On 2015-11-05 at 23:07:45 +0100, Vadim Kochan wrote: > Seems like screen is updating too frequently which > may block some terminals, so lets do it once in 1s > but only if no key was pressed. > > Signed-off-by: Vadim Kochan Applied, thanks Vadim. -- You

[netsniff-ng] Re: [PATCH] curvetun: Move copyright text to separate variable

On 2015-11-05 at 16:38:51 +0100, Vadim Kochan wrote: > Use copyright text from one place when print it in version or help output. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribed to the Google

[netsniff-ng] Re: [PATCH] lookup: Do not panic if conf file does not exist

On 2015-11-05 at 16:49:29 +0100, Vadim Kochan wrote: > It is not necessary to do not allow run application if > there is no conf file for port resolving, but instead print > message to stderr. Applied, thanks. -- You received this message because you are subscribed to the

Re: [netsniff-ng] Re: [PATCH] build: Check for libnl-route

On 2015-11-06 at 16:53:02 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Fri, Nov 06, 2015 at 04:36:08PM +0100, Tobias Klauser wrote: > > On 2015-11-06 at 15:46:16 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > libnl-route is used in netsnif

Re: [netsniff-ng] Re: [PATCH] build: Check for libnl-route

On 2015-11-06 at 17:06:55 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Fri, Nov 06, 2015 at 05:05:38PM +0100, Tobias Klauser wrote: > > On 2015-11-06 at 16:53:02 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > On Fri, Nov 06, 2015 at 04:36:08

[netsniff-ng] Re: [PATCH] flowtop: Calc flow rate more carefully

On 2015-11-04 at 20:42:15 +0100, Vadim Kochan wrote: > Make rate calculation more carefully by checking previous & current > bytes/pkts counter. > > Do calculation only if update time passed >= 1s. > > Signed-off-by: Vadim Kochan Applied, thank you Vadim!

[netsniff-ng] Re: netsniff-ng: pcap to json

On 2015-11-05 at 12:28:29 +0100, Vadim Kochan wrote: > What do you think if it is a good idea to convert pcap to json by netsniff-ng > ? > I mean to add such feature ... What would be the use case for this? Is there a kind of standardized representation for packets in JSON?

[netsniff-ng] Re: About next release date

Hi Vadim On 2015-10-30 at 09:59:46 +0100, Vadim Kochan wrote: > I'd like to know when you plan to do the next release, actually > I have some plans regarding flowtop which I think might be good to have in > the next release like sorting by rate & probably by received/sent

[netsniff-ng] Re: [PATCH] flowtop: Add command-line option for show rate in bits

On 2015-10-28 at 06:39:26 +0100, Vadim Kochan wrote: > Add -b,--bits command line option for show rate in bits. > > Signed-off-by: Vadim Kochan Applied, thanks Vadim. -- You received this message because you are subscribed to the Google Groups

[netsniff-ng] Re: [PATCH] all: Change reporting bugs email

On 2015-10-28 at 08:38:15 +0100, Vadim Kochan wrote: > Replace b...@netsniff-ng.com to netsniff-ng@googlegroups.com > which is used in REPORTING-BUGS file. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are

[netsniff-ng] Re: [PATCH 2/5] flowtop: Allow disable hostname lookup

On 2015-10-27 at 01:00:48 +0100, Vadim Kochan wrote: > Added option -n,--no-dns which disables hostname lookup. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because you are subscribed to the Google Groups "netsniff-ng"

[netsniff-ng] Re: [PATCH 1/5] flowtop: Fix src hostname showed with garbage

On 2015-10-27 at 10:59:10 +0100, vkochan <vadi...@gmail.com> wrote: > On Tue, Oct 27, 2015 at 10:51:26AM +0100, Tobias Klauser wrote: > > On 2015-10-27 at 01:00:47 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > Use strlcpy for copy resolved src/dst hostname. >

[netsniff-ng] Re: [PATCH 4/5] flowtop: Show rate in bits by default but in bytes optionaly

On 2015-10-27 at 01:00:50 +0100, Vadim Kochan wrote: > Show rate in bits, but allow to show in bytes by -B,--rate-bytes option. I think it should be the other way around, i.e. the default mode shows the rate in bytes and you can switch to bits via command-line option. In my

[netsniff-ng] Re: [PATCH 4/5] flowtop: Lookup process by dst port too

On 2015-10-26 at 14:16:09 +0100, vkochan <vadi...@gmail.com> wrote: > On Mon, Oct 26, 2015 at 01:38:41PM +0100, Tobias Klauser wrote: > > On 2015-10-24 at 16:38:10 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > > > From: Vadim Kochan <vadi...@gmail.com> >

[netsniff-ng] Re: [PATCH 3/5] flowtop: Fix src hostname with garbage

On 2015-10-26 at 15:07:31 +0100, vkochan <vadi...@gmail.com> wrote: > On Mon, Oct 26, 2015 at 01:33:11PM +0100, Tobias Klauser wrote: > > On 2015-10-24 at 16:38:09 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > > > From: Vadim Kochan <vadi...@gmail.com> &g

[netsniff-ng] Re: [PATCH 5/5] flowtop: Add option for flow refresh interval

On 2015-10-24 at 16:38:11 +0200, Vadim Kochan wrote: > From: Vadim Kochan > > Add new -t,--interval option to specify flow refresh time in seconds. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received this message because

[netsniff-ng] Re: [PATCH 3/5] flowtop: Fix src hostname with garbage

On 2015-10-24 at 16:38:09 +0200, Vadim Kochan wrote: > From: Vadim Kochan > > Add missing reset for src hostname buffer. > > Signed-off-by: Vadim Kochan > --- > flowtop.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

[netsniff-ng] Re: [RFC] flowtop: Show flow rate of bytes & pkts

On 2015-10-20 at 19:46:07 +0200, Vadim Kochan wrote: > Calculate & print the rate of src/dst bytes & pkts. > Also changed refresh flows time to 1s so the rate > info will be not disappeared very soon. Looks good to me in general and I like the idea. A few minor comments below.

Re: [netsniff-ng] netlink

On 2015-10-17 at 11:08:22 +0200, Vadim Kochan wrote: > OK you can get changes from: > https://github.com/vkochan/netsniff-ng/tree/netsniff_print_headers > > I added -z,--headers option, you can find it in usage output. > This option allows the following combinations: > >

Re: [netsniff-ng] netlink

On 2015-10-15 at 16:14:09 +0200, Geoff Ladwig wrote: > Vadim, > > Thanks for responding. > > I have never found much use for the ASCII output... but would be happy > either way. > > Possibly a --headers options so you can individually select --header, --hex >

Re: [netsniff-ng] netlink

On 2015-10-19 at 14:09:19 +0200, Geoff Ladwig wrote: > Tobias, > > Either way works for me. > The issue I had was that the only way I could see all the data was with > --hex , but then didn't get the headers- which are pretty handy! Ok, great. Would it be possible

Re: [netsniff-ng] netlink

On 2015-10-19 at 16:24:07 +0200, Geoff Ladwig wrote: > Here is a .pcap generated using > netsniff-ng --dev nlmon0 -o netlink.pcap Perfect, thanks! I just pushed a fix for this issue to the master branch. Could you please check whether this fixes the issue for you?

Re: [netsniff-ng] netlink

On 2015-10-19 at 17:38:03 +0200, Vadim Kochan <vadi...@gmail.com> wrote: > On Mon, Oct 19, 2015 at 05:37:04PM +0200, Tobias Klauser wrote: > > On 2015-10-19 at 12:43:33 +0200, vkochan <vadi...@gmail.com> wrote: > > > On Mon, Oct 19, 2015 at 12:36:42PM +0200, Tobias

[netsniff-ng] Re: [PATCH] netsniff-ng: Fix print stats in silent mode

On 2015-10-17 at 09:55:12 +0200, Vadim Kochan wrote: > RX stats were not printed because of wrong check on PRINT_NONE. > > Signed-off-by: Vadim Kochan > Fixes: 5f94671f31c040f ("netsniff-ng: Show total rx stats for multi pcap > mode") Applied, thanks

Re: [netsniff-ng] Stats differences between ifpps and netsniff-ng.

On 2015-10-13 at 14:47:28 +0200, tmartin...@gmail.com <tmartin...@gmail.com> wrote: > Le mardi 13 octobre 2015 14:02:45 UTC+2, Tobias Klauser a écrit : > > > > ifpps reports the NIC the cummulative stats since start of the system > > (i.e. the info from /proc/net/de

Re: [netsniff-ng] Stats differences between ifpps and netsniff-ng.

On 2015-10-13 at 14:47:28 +0200, tmartin...@gmail.com <tmartin...@gmail.com> wrote: > Le mardi 13 octobre 2015 14:02:45 UTC+2, Tobias Klauser a écrit : > > > > ifpps reports the NIC the cummulative stats since start of the system > > (i.e. the info from /proc/net/de

Re: [netsniff-ng] [PATCH 0/2] mmaped netlink packet

On 2015-09-11 at 09:56:05 +0200, Ken-ichirou MATSUZAWA wrote: > Hi, > > Thanks to Daniel, I can see mmaped netlink packet by netsniff-ng, > but something is a little wrong. It seems that netsniff-ng can not > get actual packet size. The output is like: > > >K ? 16360

[netsniff-ng] Re: [PATCH] flowtop: man: Fix small typo of timestampinf

On 2015-09-03 at 20:48:38 +0200, Vadim Kochan wrote: > From: Vadim Kochan > > Fix typo timestampinf -> timestamping > > Signed-off-by: Vadim Kochan Sorry for introducing this with my "fixes" and thanks for fixing. Now applied. -- You

[netsniff-ng] Re: [PATCH 2/3] flowtop: Enable flow timestamp on start

On 2015-09-02 at 01:31:17 +0200, Vadim Kochan wrote: > From: Vadim Kochan > > Allow set start/stop timestamp for new flows by setting: > > /proc/sys/net/netfilter/nf_conntrack_timestamp > > on start and reset it on exit or panic. > > Signed-off-by:

[netsniff-ng] Re: [PATCH 1/3] flowtop: Show flow time duration

On 2015-09-02 at 01:31:16 +0200, Vadim Kochan wrote: > From: Vadim Kochan > > Show human readable time since flow was created by Linux > > Signed-off-by: Vadim Kochan > --- > flowtop.c | 38 ++ > 1

[netsniff-ng] Re: [PATCH 1/3] flowtop: Show flow time duration

On 2015-09-03 at 16:40:53 +0200, vkochan wrote: [...] > What do you think if it is better to show time duration only by '-t' option ? > Is it possible that time duration counting for each flow might stress someone > ? In my opinion its fine like this, as it doesn't take much

[netsniff-ng] Re: [PATCH] netsniff-ng: Show total rx stats for multi pcap mode

On 2015-08-24 at 20:37:03 +0200, Vadim Kochan vadi...@gmail.com wrote: From: Vadim Kochan vadi...@gmail.com Allow to collect rx stats for multiple pcap mode, by storing them in separated variables before switch to the next pcap file. It allows to have the one approach when dump for single

Re: [netsniff-ng] Can we specify the packet length during capturing the traffic?

Hi Ivan On 2015-08-21 at 05:20:33 +0200, Ivan Cheng ivancheng2...@gmail.com wrote: Hi Experts, Can we specify the packet length during capturing the traffic? This feature allows us to just save the protocol information without user data. It can avoid the save sensitive user data and

[netsniff-ng] [PULL] Pull request for netsniff-ng Debian packaging

://github.com/tklauser/pkg-netsniff-ng.git for-kartik for you to fetch changes up to 36d6176dcea2de4f1752e402eac7b907507534b5: Use verbose build to make compiler flags visible in buildd logs (2015-08-20 09:14:16 +0200) Tobias Klauser

<    1   2   3   >