Re: [netsniff-ng] [PATCH] mausezahn: Fix IPv6 address comparison

2018-05-15 Thread Tobias Klauser
On 2018-05-14 at 23:59:59 +0200, Petr Machata wrote: > CMP_INT evaluates its arguments more than once, and thus passing a > post-incremented pointer as an argument causes double increments and > hence buffer overruns. This can be observed by erratic behavior of IPv6 > address

[netsniff-ng] [PATCH] mausezahn: Fix IPv6 address comparison

2018-05-14 Thread Petr Machata
CMP_INT evaluates its arguments more than once, and thus passing a post-incremented pointer as an argument causes double increments and hence buffer overruns. This can be observed by erratic behavior of IPv6 address ranges. Fix by moving the increment to loop header. Signed-off-by: Petr Machata