[netsniff-ng] Re: [PATCH 02/15] trafgen: proto: Reference to packet from proto_hdr struct

2016-08-02 Thread Tobias Klauser
On 2016-07-26 at 21:35:07 +0200, Vadim Kochan wrote: > Using of current_packet() is not relevant for dynamically updated > fields so lets keep packet index in proto_hdr struct. > > Signed-off-by: Vadim Kochan Applied, thanks! -- You received this message

[netsniff-ng] Re: [PATCH 03/15] trafgen: proto: Move proto headers into packet

2016-08-02 Thread Tobias Klauser
On 2016-07-26 at 21:35:08 +0200, Vadim Kochan wrote: > Till now headers were used only for packet creation at compile time > only, which does not allow to handle dynamic fields update at runtime. > It needs that proto_hdr entries will be not freed after compile is done. > >

[netsniff-ng] Re: [PATCH 04/15] trafgen: proto: Force field id to be index in array

2016-08-02 Thread Vadim Kochan
Yes, bug_on(x) is good point, so I am expecting you will continue review the rest patches ? Thanks, On Tue, Aug 2, 2016 at 6:50 PM, Tobias Klauser wrote: > On 2016-07-26 at 21:35:09 +0200, Vadim Kochan wrote: >> Usually proto fields array is sorted in

[netsniff-ng] Re: [PATCH 1/3] trafgen: Allow to compile without libnl

2016-08-02 Thread Tobias Klauser
On 2016-07-31 at 23:13:16 +0200, Vadim Kochan wrote: > trafgen uses libnl only to inject mac80211 frames but > it might be not needed in some embedded or switch environments, > so lets make possible to disable this feature. > > In case if --rfraw option will be used - user

[netsniff-ng] Re: [PATCH 3/3] configure: Add option to compile tools without libnl dependency

2016-08-02 Thread Tobias Klauser
On 2016-07-31 at 23:13:18 +0200, Vadim Kochan wrote: > Add command line parsing function which allows to compile tools (trafgen, > netsniff-ng) > without libnl-xxx libraries. > > Option --no-libnl sets CONFIG_NO_LIBNL=1. > > Signed-off-by: Vadim Kochan >

[netsniff-ng] Re: [PATCH 04/15] trafgen: proto: Force field id to be index in array

2016-08-02 Thread Tobias Klauser
On 2016-07-26 at 21:35:09 +0200, Vadim Kochan wrote: > Usually proto fields array is sorted in the same order as related enum, > so id may be used as index for faster lookup, it will make > csum field calculation little faster at runtime. > > Signed-off-by: Vadim Kochan