[netsniff-ng] Re: [RFC 1/7] trafgen: parser: Rename bytes -> mac

2017-02-09 Thread Tobias Klauser
On 2017-01-30 at 09:33:24 +0100, Vadim Kochan wrote: > Rename token member to as it is used only for MAC > address parsing, for dynamic sized bytes array we have an . > Signed-off-by: Vadim Kochan Applied, as this is not directly related to the rest of

[netsniff-ng] Re: [RFC 2/7] trafgen: proto: Add 'len' parameter to *_set_bytes(...) functions

2017-02-09 Thread Tobias Klauser
On 2017-01-30 at 09:33:25 +0100, Vadim Kochan wrote: > Add 'len' parameter to *_set_bytes(...) functoins to have better > control over it. While this is certainly a good idea (and you are also going to use it in the following patch), the current patch doesn't use the passed

[netsniff-ng] Re: [RFC 2/7] trafgen: proto: Add 'len' parameter to *_set_bytes(...) functions

2017-02-09 Thread Vadim Kochan
On Thu, Feb 9, 2017 at 1:02 PM, Tobias Klauser wrote: > On 2017-01-30 at 09:33:25 +0100, Vadim Kochan wrote: >> Add 'len' parameter to *_set_bytes(...) functoins to have better >> control over it. > > While this is certainly a good idea (and you are also