[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/39
  

[![Coverage 
Status](https://:/builds/12090041/badge)](https://:/builds/12090041)

Coverage remained the same at 84.728% when pulling 
**95974fc671661244c83fdead2231f8367a67d2ba on sesuncedu:COMPRESS-413** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/39

COMPRESS-413:  Performance improvements for Travis builds 

Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using 
-Ptravis-jacoco profile if one exists.
  - clean
  - apache-rat:check
  - test
  - jacoco:report
  - coveralls:report

  - This will fail the build if any of the above goals fail. The goals that 
are most likely to fail are: apache-rat:check and test. coveralls configuration 
is changed in pom to not fail the build if the service is not available (e.g. 
for forks that do not have repository registered with coveralls).

 -  Note that the apache-rat: check could be added to the pom (executing by 
default in the validate phase)
 -  Also note that the jacoco:check goal can  be added to the pom 
(executing by default in the verify phase).
 -  the script could then be changed to execute the verify goal.
 - coveralls stuff could be run in an after_success script. That script 
could restrict coveralls notification to a single point in the jdk matrix


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero 
Date:   2017-06-19T20:15:16Z

add mvnw

(cherry picked from commit 91a08f4)
Signed-off-by: Simon Spero 

commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero 
Date:   2017-06-22T16:13:45Z

COMPRESS-413
Alter pom.xml:
- Add Simon Spero as contributor.
- change javadoc configuration to use  (lowercase e) instead 
of  (uppercase E).
  - see 
https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
- exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they 
already have APL header).
- add plugin configuration for coveralls to pluginManagement. Set 
failOnServiceError to false to avoid breaking the build
if coveralls is not available

Signed-off-by: Simon Spero 

commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero 
Date:   2017-06-22T17:00:13Z

COMPRESS-413
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using 
-Ptravis-jacoco profile if one exists.
  - clean
  - apache-rat:check
  - test
  - jacoco:report
  - coveralls:report

  - This will fail the build if any of the above goals fail. The goals that 
are most likely to fail are: apache-rat:check and test. coveralls configuration 
is changed in pom to not fail the build if the service is not available (e.g. 
for forks that do not have repository registered with coveralls).

 -  Note that the apache-rat: check could be added to the pom (executing by 
default in the validate phase)
 -  Also note that the jacoco:check goal can  be added to the pom 
(executing by default in the verify phase).
 -  the script could then be changed to execute the verify goal.
 - coveralls stuff could run in a after_success script that checked and 
only ran for a selected jdk

Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/39
  

[![Coverage 
Status](https://:/builds/12090926/badge)](https://:/builds/12090926)

Coverage decreased (-0.008%) to 84.72% when pulling 
**7b4ecc9e7c9d2fb32ddfe4f92791aacf9f17d901 on sesuncedu:COMPRESS-413** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Commons-Compress PullRequest Builder #60

[Apache Jenkins Server]

See 

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/39
  
Randomly adding  coverage tests  for coveralls


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

[sesuncedu]

Github user sesuncedu closed the pull request at:

https://github.com/apache/commons-compress/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

[sesuncedu]

GitHub user sesuncedu reopened a pull request:

https://github.com/apache/commons-compress/pull/39

COMPRESS-413:  Performance improvements for Travis builds 

Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using 
-Ptravis-jacoco profile if one exists.
  - clean
  - apache-rat:check
  - test
  - jacoco:report
  - coveralls:report

  - This will fail the build if any of the above goals fail. The goals that 
are most likely to fail are: apache-rat:check and test. coveralls configuration 
is changed in pom to not fail the build if the service is not available (e.g. 
for forks that do not have repository registered with coveralls).

 -  Note that the apache-rat: check could be added to the pom (executing by 
default in the validate phase)
 -  Also note that the jacoco:check goal can  be added to the pom 
(executing by default in the verify phase).
 -  the script could then be changed to execute the verify goal.
 - coveralls stuff could be run in an after_success script. That script 
could restrict coveralls notification to a single point in the jdk matrix


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero 
Date:   2017-06-19T20:15:16Z

add mvnw

(cherry picked from commit 91a08f4)
Signed-off-by: Simon Spero 

commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero 
Date:   2017-06-22T16:13:45Z

COMPRESS-413
Alter pom.xml:
- Add Simon Spero as contributor.
- change javadoc configuration to use  (lowercase e) instead 
of  (uppercase E).
  - see 
https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
- exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they 
already have APL header).
- add plugin configuration for coveralls to pluginManagement. Set 
failOnServiceError to false to avoid breaking the build
if coveralls is not available

Signed-off-by: Simon Spero 

commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero 
Date:   2017-06-22T17:00:13Z

COMPRESS-413
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using 
-Ptravis-jacoco profile if one exists.
  - clean
  - apache-rat:check
  - test
  - jacoco:report
  - coveralls:report

  - This will fail the build if any of the above goals fail. The goals that 
are most likely to fail are: apache-rat:check and test. coveralls configuration 
is changed in pom to not fail the build if the service is not available (e.g. 
for forks that do not have repository registered with coveralls).

 -  Note that the apache-rat: check could be added to the pom (executing by 
default in the validate phase)
 -  Also note that the jacoco:check goal can  be added to the pom 
(executing by default in the verify phase).
 -  the script could then be changed to execute the verify goal.
 - coveralls stuff could run in a after_success script that checked and 
only ran for a selected jdk

Signed-off-by: Simon Spero 

commit 7b4ecc9e7c9d2fb32ddfe4f92791aacf9f17d901
Author: Simon Spero 
Date:   2017-06-22T18:32:48Z

Switch to trusty container.
Use only openjdk7 and openjdk8 as jdks

Signed-off-by: Simon Spero 

commit 0a61bfde39bb3e8122101622bb96ca918f85ebc7
Author: Simon Spero 
Date:   2017-06-22T18:42:00Z

Add comment to .travis.yml

Signed-off-by: Simon Spero 

commit a632a7f090ab8dc673fb57f22709bdaddf3ee802
Author: Simon Spero 
Date:   2017-06-22T20:12:56Z

Cover last two extra lines in ExplodingInputStream

Signed-off-by: Simon Spero 

commit 05b849faf0b1fee3d462b71d9e2c350ba791b06c
Author: Simon Spero 
Date:   2017-06-22T20:32:16Z

Cover last three lines in BinaryTree

Signed-off-by: Simon Spero 

commit 5d82b0d7ff4f2664e35602ad5bfe1353e764fa79
Author: Simon Spero 

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/39
  

[![Coverage 
Status](https://:/builds/12093695/badge)](https://:/builds/12093695)

Coverage increased (+0.09%) to 84.815% when pulling 
**a434e5866df38e4b1f089c280f0b1a784e41a86d on sesuncedu:COMPRESS-413** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/39
  

[![Coverage 
Status](https://:/builds/12093740/badge)](https://:/builds/12093740)

Coverage increased (+0.1%) to 84.828% when pulling 
**a434e5866df38e4b1f089c280f0b1a784e41a86d on sesuncedu:COMPRESS-413** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #42: COMPRESS-407: Allow use of invalid record sizes ...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/42
  

[![Coverage 
Status](https://:/builds/12096355/badge)](https://:/builds/12096355)

Coverage increased (+0.04%) to 84.767% when pulling 
**368cb1b7520f78803772b5eff4b28622432479d8 on 
sesuncedu:COMPRESS-407-SYSTEM-PROPERTY** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #42: COMPRESS-407: Allow use of invalid record sizes ...

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/42
  
The system property is can be discovered by reading the source code. This 
information could be added to the exception message. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #42: COMPRESS-407: Allow use of invalid record...

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/42

COMPRESS-407:  Allow use of invalid record sizes if a system property is 
set.

I do not recommend using this approach.  #40 is the preferred solution. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress 
COMPRESS-407-SYSTEM-PROPERTY

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero 
Date:   2017-06-11T22:48:42Z

COMPRESS-407 Validate Block and Record Sizes

Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize 
as parameter

Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length  for
different block sizes including PAX default, USTAR default, and unspecified.

Signed-off-by: Simon Spero 

(cherry picked from commit d754d89)
Signed-off-by: Simon Spero 

commit 368cb1b7520f78803772b5eff4b28622432479d8
Author: Simon Spero 
Date:   2017-06-23T00:50:13Z

COMPRESS-407 Validate Block sizes. Detect invalid record sizes. Allow them 
through if a
system property is set.

Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #41: COMPRESS-407 - Just Warn

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/41
  

[![Coverage 
Status](https://:/builds/12096330/badge)](https://:/builds/12096330)

Coverage decreased (-0.02%) to 84.704% when pulling 
**abab94288a8b8de05ecfade6517456a2c8dc6fb2 on sesuncedu:COMPRESS-407-WARN** 
into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #40: COMPRESS-407 Validate Block and Record Sizes

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/40
  

[![Coverage 
Status](https://:/builds/12096032/badge)](https://:/builds/12096032)

Coverage increased (+0.05%) to 84.777% when pulling 
**f0c21325faf6f613821a8b542c73ac380f0feb6a on sesuncedu:COMPRESS-407-REDUX** 
into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #41: COMPRESS-407 - Just Warn

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/41

COMPRESS-407 - Just Warn

Warn if an invalid record size is set. 

I would not recommend using this approach.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-407-WARN

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero 
Date:   2017-06-11T22:48:42Z

COMPRESS-407 Validate Block and Record Sizes

Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize 
as parameter

Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length  for
different block sizes including PAX default, USTAR default, and unspecified.

Signed-off-by: Simon Spero 

(cherry picked from commit d754d89)
Signed-off-by: Simon Spero 

commit abab94288a8b8de05ecfade6517456a2c8dc6fb2
Author: Simon Spero 
Date:   2017-06-23T00:35:13Z

COMPRESS-407 Validate Block sizes. Detect invalid record sizes, but just 
log a  warning.

Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #30: COMPRESS-407 - Validate Block and Record ...

[sesuncedu]

Github user sesuncedu closed the pull request at:

https://github.com/apache/commons-compress/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #30: COMPRESS-407 - Validate Block and Record Sizes a...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/30
  

[![Coverage 
Status](https://:/builds/12095979/badge)](https://:/builds/12095979)

Changes Unknown when pulling **ace4d5da8bd8504e884d139abf6f34ab4b5dd99d on 
sesuncedu:COMPRESS-407** into ** on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #40: COMPRESS-407 Validate Block and Record Si...

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/40

COMPRESS-407 Validate Block and Record Sizes

Original (require correct record size) 

Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize 
as parameter

Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length  for
different block sizes including PAX default, USTAR default, and unspecified.

Signed-off-by: Simon Spero 

(cherry picked from commit d754d89)
Signed-off-by: Simon Spero 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-407-REDUX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit f0c21325faf6f613821a8b542c73ac380f0feb6a
Author: Simon Spero 
Date:   2017-06-11T22:48:42Z

COMPRESS-407 Validate Block and Record Sizes

Require block size >=0 that is multiple of 512 bytes.
Use block size of 512 if one is not given.
Require record size of 512 bytes. Deprecate constructors taking recordSize 
as parameter

Modify tests to check for enforcement of record size == 512
Modify tests to check for correct overall length  for
different block sizes including PAX default, USTAR default, and unspecified.

Signed-off-by: Simon Spero 

(cherry picked from commit d754d89)
Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---